linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Josh Poimboeuf <jpoimboe@kernel.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	linux-mm@kvack.org, mm-commits@vger.kernel.org,
	linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [GIT PULL] non-MM updates for 6.6-rc1
Date: Wed, 30 Aug 2023 15:53:35 -0700	[thread overview]
Message-ID: <20230830225335.kmdj5er253fr7rk4@treble> (raw)
In-Reply-To: <CAHk-=wgsKp2ZPxQ_WvRGLJXtZG6Z2TrqC_jNppukfniCZB9doQ@mail.gmail.com>

On Tue, Aug 29, 2023 at 03:20:37PM -0700, Linus Torvalds wrote:
> On Mon, 28 Aug 2023 at 22:54, Andrew Morton <akpm@linux-foundation.org> wrote:
> >
> > Linus, please pull mm.git's non-MM updates for this cycle.
> 
> Hmm. For some non-obvious (to me) reason this triggers
> 
>   vmlinux.o: warning: objtool: ibt_selftest+0x18: sibling call from
> callable instruction with modified stack frame
> 
> which didn't happen before, even though the pull doesn't actually
> change that file at all.
> 
> I see that Josh has a patch to fix this by making it be real assembly
> code rather than a hacky inline asm in a C file, but it's a bit
> surprising, and I don't see why it's triggered now when it wasn't
> before.
> 
> At a guess it's related to the Kconfig changes, but I have nothing to
> back that guess up with.
> 
> Slightly annoying, but I guess I'll live with the warning for now.

As far as I can tell this warning only shows up with the rare
combination of CONFIG_X86_KERNEL_IBT and CONFIG_UNWINDER_FRAME_POINTER
(the latter being pretty much deprecated at this point).

Did you manage to enable frame pointers somehow?

The fix (to rewrite the IBT selftest) was merged into tip/x86/shstk.
Presumably it'll be in a pull request soon-ish.

-- 
Josh


  reply	other threads:[~2023-08-30 22:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-29  5:54 Andrew Morton
2023-08-29 22:20 ` Linus Torvalds
2023-08-30 22:53   ` Josh Poimboeuf [this message]
2023-08-31 18:46     ` Sohil Mehta
2023-08-29 22:22 ` pr-tracker-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230830225335.kmdj5er253fr7rk4@treble \
    --to=jpoimboe@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mm-commits@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox