From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF77DC71153 for ; Wed, 30 Aug 2023 01:36:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1810F8E0040; Tue, 29 Aug 2023 21:36:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10ACD8E000B; Tue, 29 Aug 2023 21:36:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F14558E0040; Tue, 29 Aug 2023 21:36:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DF27D8E000B for ; Tue, 29 Aug 2023 21:36:26 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B1D5C1A03A2 for ; Wed, 30 Aug 2023 01:36:26 +0000 (UTC) X-FDA: 81179055972.10.833511D Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 181EE20008 for ; Wed, 30 Aug 2023 01:36:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lBU3UyED; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693359385; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Wi5eLZPKAQoaN9JYgXPAP3u1gv5ZGszVZUbIW7nRLtU=; b=QenfVdAgwiKnsH6kZfLxM2EnlpxRQL7wB8ZXbT0X8Ao5t95x7lwhcmGryRPK8QKRmXzabE llnDLxrGD794Mc7kjN5xBZLyhEjSnghWxE15uXfcG80U2gIG0VTilbruamWt/m5i/23aRN ZQzdAHxRJaPDC2ao1+bUABYOXENrgVk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=lBU3UyED; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693359385; a=rsa-sha256; cv=none; b=gLukzhJlzsn/eLHQvX0nb5oqAm0kcN+aFjM9+uxcWbmsrCEySgJDGEiZvWNXBaHYr5gSOf 86H4OhwpP3kg8/38VGWDlTqeXRg+bS4maBMYsIChkymZlix0vg6M7Rp7MMar/fYYZEZuQU YggILHiedis02Goz+WLio4cnneDKh7M= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 55BFF60916; Wed, 30 Aug 2023 01:36:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 38016C433C8; Wed, 30 Aug 2023 01:36:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693359383; bh=0T61JhZvBgtGqTFCxU7ee9dwkyQB1gfq2ay5n+uX9HM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lBU3UyEDn9KBvrJspSdcvxZ/i/yQRLuIi/gAfUUsMXID2Az4PxAo4rK04tzWzyp+u Se7JZy/rdzOxMjePY1C0mZ8gLkZxYrMNEtmCNpU9cI6TVtk3eu7M7rdnetGzvuExJW llTxt0gPw/5049P/a7+dtBma2qaEMPSXXVSa/KuugzrUzj1wiZGrLsSAsyGj6ZbPCR tzsnvvp1wIr2KYpsf0w6Rv0LGAEmGksaKp2U+D5gjWhSAFwU3PKh+PlRc5VLSAMAc/ pcWlX4mM4kcnr/zdvtUh8b974pDRnmQbtvDfDrhhuRiLqs7m7oB/BjmnthV8Kl+Gew lnEKj6Hmd59zA== From: SeongJae Park To: Steven Rostedt Cc: SeongJae Park , damon@lists.linux.dev, Andrew Morton , linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm/damon/core: add a tracepoint for damos apply target regions Date: Wed, 30 Aug 2023 01:36:21 +0000 Message-Id: <20230830013621.46216-1-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230829191629.25c5f0e2@rorschach.local.home> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 181EE20008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 4hadnyxdadacq68ji1wpu7zyej6ohm4w X-HE-Tag: 1693359384-906534 X-HE-Meta: U2FsdGVkX1+sF6I2nY++DlHyP6aVj+PXFCKpSA9NvJ/srsNdWk8Di1ZGwr49OjZiU4NgaWW6UFU0YevyojjW3Oiu3YK9WnDq3bNrmgsX/3LTUW9tPSIVfAG25WPV51Mk/ds6LFiT+/oN+Y3lI38Cg5sKP/2L8zYLQH6WyW2BlaoFA6omIGmJapU6AlH5MZnxwOzPnEfracQHXVpICLf7Sgbl9K8F0pQXYDAuAUSu1Msem70jdu0qv1p+xAHHFq454qB0EJy077eTlQwA825pqGuun2r/QiAZIdjO+6UAlPHBhjXbX3z2maQNgk2SjpVV1CMuhj1lrGgGNj8EFtx3iBPKccrVrCA0Gqbu4anSrX+OS+QRx6z5btOAF2EWCJIXNQ+0UyTfpYBpPZcrCqhIYEgLZjBZ7pfR+sKtDcfzhIq8hNEOO+lb8/DZlLtkOVUSuh9CtTr438tNTbnRn3GbmwN2InXemrnl8IZaMeMFgKYVpQByCN8q5vp/B9uHUExhqTrbsinX7mxkbXdqIwB4udE45O3jC1b52tdlokIWYw4USAlG8Pdz9epbbu7VsIaywhoGyP8DALuqyx52dWFp3yGij0GrbAPZ6zCGvVMyN1IzlucI5n0MyuZyJac7uW9ah2H3gWjyASlNEvvZPXpmCxPc3vrhv4z1jsTRbnvj9Y0OKrO+nilaODtlBICf7lvQ4FNctHlq/1LdpLR/s9PU7kfIlRe2e1NLTbNC9WOoWseHRXlkfrH6vlaGoNMo4e8PIOBhkePQemst/DxdxRsDEkchGspnPUjWPyMrgElVerqQsC3jxOAkTdN1e5Z4VGv4AOzxajV3HJEI1m7NhIiwj6RLSqJ3cF0X8/nbx1ebKfjcpYmC0u1OBOzoilMNCuoF1bapyHgArr4ClhQGvtgGeLv8SNZWsNkHHYmgj8GhMHhgAB0xzhprtQtTs07zxGWXf/oUOFfgVXvGgIar3Bj EkBbAnsj bwwm2tz/UanG9RqtOg4fb4P109MilyDoRVtrQvDcrvUBBsZR2fIcXZcoynoBWu3i5nZ2i27Wz2E+pUs0d3fSkfEo2YBNyxm6jtdY4pgb1uffLCQeSRjV1WW1DG9FYRv5KvlckB3nHFqWQgPNQwHdhsR8SStMYLm8CRF9GKURm1RfPU9s8sfdtBaC6vqPrbBWHg6ugCo8VtABuGqPELy5YgwjTAX1Cz0UyIMoeb/xjU6W/qK4CnftJOzCPVXZi06JXMukhKIa4ZmIT4qHTRdKIKa4wSMS4XIAl32EaTKFcqRgI3DrR0cjhNPMplvSzFIdpR/6taaT+5iu7YC9UDkD3BqYb2OdugoHrtaggs54ErJ70UuO+Iugdcnthz3NDrYuu2UfR0vucEtMj2mE3/qEkTH5p/o+95exydYvCL9tp13kxHVo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Steven, On Tue, 29 Aug 2023 19:16:29 -0400 Steven Rostedt wrote: > On Sun, 27 Aug 2023 00:40:45 +0000 > SeongJae Park wrote: > > > + TP_STRUCT__entry( > > + __field(unsigned int, context_idx) > > 4 bytes > > > + __field(unsigned int, scheme_idx) > > 4 bytes > > > + __field(unsigned long, target_idx) > > 8 bytes > > > + __field(unsigned int, nr_regions) > > 4 bytes > > > + __field(unsigned long, start) > > This is going to cause a 4 byte hole. I would move nr_regions after end > so that it stays properly aligned. That makes sense, thank you for letting me know this! I will do so in the next spin. Thanks, SJ > > -- Steve > > > > > + __field(unsigned long, end) > > + __field(unsigned int, nr_accesses) > > + __field(unsigned int, age) > > + ), > > + >