From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06B3AC83F01 for ; Wed, 30 Aug 2023 08:24:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 890038E0048; Wed, 30 Aug 2023 04:24:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 83FB98E0009; Wed, 30 Aug 2023 04:24:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 731B88E0048; Wed, 30 Aug 2023 04:24:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 63F798E0009 for ; Wed, 30 Aug 2023 04:24:50 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 33A47A02F8 for ; Wed, 30 Aug 2023 08:24:50 +0000 (UTC) X-FDA: 81180085140.10.E5FF402 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id 7CFD78000E for ; Wed, 30 Aug 2023 08:24:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EgcU5iYq; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693383888; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BouTYDcyoH5oFGvSHQfz59A4rip/gsu1Rh2DT5TR+A8=; b=ePDDPQ/xJyVc34nGYSrGZo7WkDu3lg2XRPk7WxfJK0k3Z90mGqBgc4e0j3gzqfbCKKW3aA Ff4/20g2qkgImI3Ny0bD9YZ6T4ir4XZKotnIz1ZtomELsle2hukp5PdxD0dvTAQ5OhszG6 tij7cE1Q8HM1cBd8FifsM2wvFnSd70c= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693383888; a=rsa-sha256; cv=none; b=AUnD+PC/jGEHDREgNg9RIfq1C0ngc3s20TyRvdJ8jXSjV5jeE1mvLalzaYEFPQGCHqPecf Hws3FhiRgsb0kLhZS3RLD3iL6H7BUtjrv2F3JusVkH05bTRAIL/gK+LpzDuVgF5z/4BFRz mbRomBY8J+DpKEubT/7h8v/DTvfs19Q= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EgcU5iYq; spf=pass (imf30.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 54DA06010E; Wed, 30 Aug 2023 08:24:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5DEA8C433C9; Wed, 30 Aug 2023 08:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693383886; bh=Dw9c1DXIAY68a849K5SUG04VmXYyYAHrBl2h6ksyWj0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EgcU5iYqRWDPKRDTvyVru5KDSlEMnfMA8mWLaUmd2wIwP6+zw8w2QohrkfX1vXqoJ /yhlUchRWhs0wTyJVPhBhvQGvKHArvTZB5wAMqrLMIo1vHGrqd8o20yJOOPvR1aAWH 7WerVmEH/eTW51KaLQ1ux5PmgxQHcilj057bIvf55ni/vE6ICzvY5RZhH8IFbKJlEX vHIpV+Upt0c5eVepzLMP/gOgUd7ZOeeDGwy0XNcpUAxGMMs1FtWJYyAKzfTy1Kzf8k Y4AneGPbl4ou0hxMgXmfa7C20ndTWPSK/feYw42w+VNMHQalV0dKvuupJNl5920Uv8 Rou9OMXKWQqPQ== Date: Wed, 30 Aug 2023 10:24:42 +0200 From: Christian Brauner To: Randy Dunlap Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, Andrew Morton , Linux Memory Management List Subject: Re: kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key' Message-ID: <20230830-koiteich-ehrerbietung-8191852e752b@brauner> References: <202308172003.O1QB7TgB-lkp@intel.com> <9a05d92f-60c5-6ede-2105-829f09c737b7@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9a05d92f-60c5-6ede-2105-829f09c737b7@infradead.org> X-Rspamd-Queue-Id: 7CFD78000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: kjcpfb6pecnf6yweycywttdyjbxe6npx X-HE-Tag: 1693383888-590498 X-HE-Meta: U2FsdGVkX1+xE/gxJW4YDZi9LualjsnVhRVhTp0I+dGSR4+hFXhaWd9q0fiRnE0V89TRbY5z7skwEHENwsimxygVRL3atsbaW6vUxFzt9H5WM3mcaCTF+4jZVqwz+de+8/DZTpsZsfOtpdV5kKcNCi4qRjKBDQhgFrOsOYwSZWAS0u/VD31gGu30Ne1rkg9BV36hR8jUtWNycOiefBh4FMfsLynvWuCGuKwv0r6HK/0kW+dL2FsazYetNHuv1dY1jKz+OawQQ6TSWiNEPt1AMDYjpBHsZ+OE1h2tiGP/arMVbIIkRWgikyKjDLV0BBourJb242sxbyZZIbOO5eU3e2CO4WzvU/cgMeFnzaJO9Dn2NE0+V66Ch5fBrRRFhGlwgYW0XxL69Vf4B57Le5A+lkp+Dqymo7/g0qY/6P8RpF1sj3c65TeXs7p4YefNgU61rX1AvDJ4EbTthtbHUTETZLBwZssnbtwJQwbTWT11/V4vpEvUEfeVEJLAFhXBN654vlaeFx7up2ps4gKrZav/Gike6K2+VMbVQnr3dkV6WQ2eLflvcCOoVYUo9/I/Tw4sRdhFu9i9/75lVrp0cmcS75u/qV3yRXG1h2Ql1/26jS0OPjlNM8b2R5+8+x4lG+kuUrEfojETNiUEGpRHJQ6EAwXIe4pw5pv8mSSGBACP7XmK48k4eQL3hNBSQaNmx5exCCtKHbijVHXoIOHJR9iRRg8W3O2UpyJrtAa6EUdypVN1UvNJw7CLsVL933sh8FbIT5KfYuU1zUAtTsjpFjBBv/1FpjKxnHArfNBT/kLggG0BjCBTpVRgzOn5CSKbofHqWjCATub1G7hlEzeqO3+FZY/t0YINLgiCfz0HfxPcd8PF4RBPwNnEcnx0B49tQDWelklwEUxEjFx65r5GohBGXHrqZ86qr9Gb7p1zdkH/gbyywiwdflzbMS+W+b/9czQAlYhB2YcdEEvled2fgQF dEWmxWe0 +CSgg7jESo33ZcTfqzBWOJLSYskq3luau2d5VNjoRRirCMKD7x8H6Fuyycffiwce+Wy0xx4SR5FhgITPnCVNK0nSgcmTebtNMlNHm78Ztt1dohloBT7ZTZHuK+aPHx0qibGOEo0L9k4YFGni7e/laMVZkycwyNLUsy0MKg3Nm2OImQbLHGV3UEybVYvl8ih+JqbjAxVdYhLA8yCSdkylNRJmf80Kvh7nNxvkHi5q4s19IoRFvMkwITMbpPZLS+gFLc5cYtJ+S2Q7IwlOUfk76wzKXhmjJje15Vb5niIICVb7ukB1C1PPq/lt38S0XvXBZLNXaPFzlvWsdqGEGEFqKiujuAMAZUEb+bpfPJa+lw/xqjXeRHFNWi8ks2my9oZkJfVHRGHWBbOLkRj11p2SWtBxzuXnFev6lUmoTQRxtTW93Fx7REijikeaKkLX+pan+aeN+4EIgMYT87fPNBqirsMEvgGTtWP32gy6G X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 28, 2023 at 10:13:06PM -0700, Randy Dunlap wrote: > Hi Christian, > > On 8/17/23 05:56, kernel test robot wrote: > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master > > head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6 > > commit: e227db4d4f125efb1cae2f1337da85bc10b3185e userns: fix a struct's kernel-doc notation > > date: 7 months ago > > config: parisc64-defconfig (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/config) > > compiler: hppa64-linux-gcc (GCC) 12.3.0 > > reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/reproduce) > > > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: https://lore.kernel.org/oe-kbuild-all/202308172003.O1QB7TgB-lkp@intel.com/ > > > > All warnings (new ones prefixed by >>): > > > >>> kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key' > >>> kernel/user_namespace.c:239: warning: Function parameter or member 'id' not described in 'idmap_key' > >>> kernel/user_namespace.c:239: warning: Function parameter or member 'count' not described in 'idmap_key' > > kernel/user_namespace.c:246: warning: Function parameter or member 'k' not described in 'cmp_map_id' > > kernel/user_namespace.c:246: warning: Function parameter or member 'e' not described in 'cmp_map_id' > > kernel/user_namespace.c:277: warning: Function parameter or member 'extents' not described in 'map_id_range_down_max' > > kernel/user_namespace.c:277: warning: Function parameter or member 'map' not described in 'map_id_range_down_max' > > kernel/user_namespace.c:277: warning: Function parameter or member 'id' not described in 'map_id_range_down_max' > > kernel/user_namespace.c:277: warning: Function parameter or member 'count' not described in 'map_id_range_down_max' > > kernel/user_namespace.c:295: warning: Function parameter or member 'extents' not described in 'map_id_range_down_base' > > kernel/user_namespace.c:295: warning: Function parameter or member 'map' not described in 'map_id_range_down_base' > > kernel/user_namespace.c:295: warning: Function parameter or member 'id' not described in 'map_id_range_down_base' > > kernel/user_namespace.c:295: warning: Function parameter or member 'count' not described in 'map_id_range_down_base' > > kernel/user_namespace.c:344: warning: Function parameter or member 'extents' not described in 'map_id_up_base' > > kernel/user_namespace.c:344: warning: Function parameter or member 'map' not described in 'map_id_up_base' > > kernel/user_namespace.c:344: warning: Function parameter or member 'id' not described in 'map_id_up_base' > > kernel/user_namespace.c:364: warning: Function parameter or member 'extents' not described in 'map_id_up_max' > > kernel/user_namespace.c:364: warning: Function parameter or member 'map' not described in 'map_id_up_max' > > kernel/user_namespace.c:364: warning: Function parameter or member 'id' not described in 'map_id_up_max' > > kernel/user_namespace.c:776: warning: Function parameter or member 'map' not described in 'insert_extent' > > kernel/user_namespace.c:776: warning: Function parameter or member 'extent' not described in 'insert_extent' > > kernel/user_namespace.c:844: warning: Function parameter or member 'map' not described in 'sort_idmaps' > > > > According to 'git blame', all of these come from additions that you made. > > What do you think about a patch that converts all of these into non-kernel-doc comments? > I.e., change "/**" to "/*" for the functions and struct? Yeah, sure.