From: Christian Brauner <brauner@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: kernel test robot <lkp@intel.com>,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Linux Memory Management List <linux-mm@kvack.org>
Subject: Re: kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
Date: Wed, 30 Aug 2023 10:24:42 +0200 [thread overview]
Message-ID: <20230830-koiteich-ehrerbietung-8191852e752b@brauner> (raw)
In-Reply-To: <9a05d92f-60c5-6ede-2105-829f09c737b7@infradead.org>
On Mon, Aug 28, 2023 at 10:13:06PM -0700, Randy Dunlap wrote:
> Hi Christian,
>
> On 8/17/23 05:56, kernel test robot wrote:
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> > head: 4853c74bd7ab7fdb83f319bd9ace8a08c031e9b6
> > commit: e227db4d4f125efb1cae2f1337da85bc10b3185e userns: fix a struct's kernel-doc notation
> > date: 7 months ago
> > config: parisc64-defconfig (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/config)
> > compiler: hppa64-linux-gcc (GCC) 12.3.0
> > reproduce: (https://download.01.org/0day-ci/archive/20230817/202308172003.O1QB7TgB-lkp@intel.com/reproduce)
> >
> > If you fix the issue in a separate patch/commit (i.e. not just a new version of
> > the same patch/commit), kindly add following tags
> > | Reported-by: kernel test robot <lkp@intel.com>
> > | Closes: https://lore.kernel.org/oe-kbuild-all/202308172003.O1QB7TgB-lkp@intel.com/
> >
> > All warnings (new ones prefixed by >>):
> >
> >>> kernel/user_namespace.c:239: warning: Function parameter or member 'map_up' not described in 'idmap_key'
> >>> kernel/user_namespace.c:239: warning: Function parameter or member 'id' not described in 'idmap_key'
> >>> kernel/user_namespace.c:239: warning: Function parameter or member 'count' not described in 'idmap_key'
> > kernel/user_namespace.c:246: warning: Function parameter or member 'k' not described in 'cmp_map_id'
> > kernel/user_namespace.c:246: warning: Function parameter or member 'e' not described in 'cmp_map_id'
> > kernel/user_namespace.c:277: warning: Function parameter or member 'extents' not described in 'map_id_range_down_max'
> > kernel/user_namespace.c:277: warning: Function parameter or member 'map' not described in 'map_id_range_down_max'
> > kernel/user_namespace.c:277: warning: Function parameter or member 'id' not described in 'map_id_range_down_max'
> > kernel/user_namespace.c:277: warning: Function parameter or member 'count' not described in 'map_id_range_down_max'
> > kernel/user_namespace.c:295: warning: Function parameter or member 'extents' not described in 'map_id_range_down_base'
> > kernel/user_namespace.c:295: warning: Function parameter or member 'map' not described in 'map_id_range_down_base'
> > kernel/user_namespace.c:295: warning: Function parameter or member 'id' not described in 'map_id_range_down_base'
> > kernel/user_namespace.c:295: warning: Function parameter or member 'count' not described in 'map_id_range_down_base'
> > kernel/user_namespace.c:344: warning: Function parameter or member 'extents' not described in 'map_id_up_base'
> > kernel/user_namespace.c:344: warning: Function parameter or member 'map' not described in 'map_id_up_base'
> > kernel/user_namespace.c:344: warning: Function parameter or member 'id' not described in 'map_id_up_base'
> > kernel/user_namespace.c:364: warning: Function parameter or member 'extents' not described in 'map_id_up_max'
> > kernel/user_namespace.c:364: warning: Function parameter or member 'map' not described in 'map_id_up_max'
> > kernel/user_namespace.c:364: warning: Function parameter or member 'id' not described in 'map_id_up_max'
> > kernel/user_namespace.c:776: warning: Function parameter or member 'map' not described in 'insert_extent'
> > kernel/user_namespace.c:776: warning: Function parameter or member 'extent' not described in 'insert_extent'
> > kernel/user_namespace.c:844: warning: Function parameter or member 'map' not described in 'sort_idmaps'
> >
>
> According to 'git blame', all of these come from additions that you made.
>
> What do you think about a patch that converts all of these into non-kernel-doc comments?
> I.e., change "/**" to "/*" for the functions and struct?
Yeah, sure.
next prev parent reply other threads:[~2023-08-30 8:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 12:56 kernel test robot
2023-08-29 5:13 ` Randy Dunlap
2023-08-30 8:24 ` Christian Brauner [this message]
2023-10-26 5:25 ` Randy Dunlap
2023-10-17 12:25 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230830-koiteich-ehrerbietung-8191852e752b@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox