From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA01EC83F1C for ; Tue, 29 Aug 2023 23:16:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2AC748E002E; Tue, 29 Aug 2023 19:16:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 25C5B8E000B; Tue, 29 Aug 2023 19:16:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 14AC68E002E; Tue, 29 Aug 2023 19:16:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 05E148E000B for ; Tue, 29 Aug 2023 19:16:36 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C5916140226 for ; Tue, 29 Aug 2023 23:16:35 +0000 (UTC) X-FDA: 81178703550.03.1975F01 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 3192940012 for ; Tue, 29 Aug 2023 23:16:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of "SRS0=p05Q=EO=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=p05Q=EO=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693350994; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=chcgiFw5tsvJf8aTEHZFGNCczBYPHRHmJY5H4qGryOY=; b=P6MgVC5ascM1pg7GuxHsFh68JAWlegLy/pPtKZkqlCAyyg/A4/NSv7R6Q7JeQ7jHWbDlFN UI7wK5EQZCJQSQOjVGE7BRWcC91Anlt5M7C5W05LAR7wRUnSFH9eaJHrSadd4Arac3WLxj g/jsZvkn/M59hadfw9sRkpIlTu+TGwc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf11.hostedemail.com: domain of "SRS0=p05Q=EO=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=p05Q=EO=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693350994; a=rsa-sha256; cv=none; b=Idj3DIP41HLEZG4H8qXLlBzG12LclAaLzBX8rebdAIYW/A67Zl94kRCT4RKuisuEsq7Gdg WkJI+OzhvvwGinHGri9w8sUMYVztqhgezx3ldVfUwhC+sfTo6ACMz85i0KXqRzqz9sPhLp YsbJ0XfReGyVqIZ0VAP0I+/gV4daiUo= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 338B660A66; Tue, 29 Aug 2023 23:16:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB135C433C8; Tue, 29 Aug 2023 23:16:31 +0000 (UTC) Date: Tue, 29 Aug 2023 19:16:29 -0400 From: Steven Rostedt To: SeongJae Park Cc: damon@lists.linux.dev, Andrew Morton , linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] mm/damon/core: add a tracepoint for damos apply target regions Message-ID: <20230829191629.25c5f0e2@rorschach.local.home> In-Reply-To: <20230827004045.49516-1-sj@kernel.org> References: <20230827004045.49516-1-sj@kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3192940012 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 88317w4bnncts8rp4p1jsfw1hgncfofn X-HE-Tag: 1693350993-766996 X-HE-Meta: U2FsdGVkX1/qminhcf9LhdvnsQa6jpPdjDMQSULIarO8YDn7gs6l/5xMPg3vTh10zUIQA0JXyq7uYST76uPStDpqz03+SL51j+WKyoF775DxiBAudS1WI5TNFie9dOzdCx0cpqfsI8BZcy+S9ZGwJBVL2fs7zSD1d/2h7gwl+4odRV+otxx4G346AsUpnF4pXu1hfVclsXwRKL+7w5uP8BAfA1q7Yr37qx/PnCUFWQA9+r641JwZ246cI+3uVl9HFt/18aecABFxZsPBJ4SraySAXxBmwj+Z7Lu4psZcqfaq3d9emeA8nEloyTveWQyc+La8rl32Arz1bCH3DzsnotHuButWZ/cp6cLFd4/ticwYZmvzCzGzayQrj4Y7K49aShrHQc9dkk9RJ59CqgSnRKWdXi9qu/70XNsJ9UYpqqyTVMH4pKOY9qD0ESpLFTdbGSGCVT6R30ICv6sVOcFrxQwjNBzc4ymIvb2wvdV9dNeHlNUJXV6H62mUFlqmjournf88Ac90kO0+SJdoEacowYE9CkXsaYn2+TSGUQdOM3ul1WYKgNk058UZbG3IQBQUBcFRT/cR+qHl96chcjRZ+FFJk0zmpA+mVL7FuCjfuDjKXdShS8lD7ASOnIDr+DzZ/91/4QyJxT3Y+PX2UvKFZ+/bZO3N+3f0/LQvw9QxDOd9zvRIRSE5QZq07D01VAU6/mPGGpTpQF9cbTRYlfOwdK+nkFT6D/O6pLJMOjgyfRrtOu0OxeW0eYsu+rC0C7mCcJXmr0nU23hLIwP+8yHgCUm7+5SdpgYfj+DkRUfH+1fd/STFRSjJXciCsoH8aaxnTVj+OjEycDoUsQ9nIe9rxxmsYQrbm01mDAHKYwjuRW64DcxwKgNXSIp3CkIco86MqhbPeXabFd0ynU2IUi+Sh0XYaHe0a4TlIk2y7v4PlkaLvWQzQbT10eX/doUKmf4SXmnkdg6vLybthA5rpyT tlDvLIeG zjxz/pV9SGprGIGblvQ8XsKE5Dnmqgnfax46dAUtYfkyCa/aG7PjcdROhBAQ3+73hFRm1Z5Vio9GrNfLN12vFYcJyEJmWx3bO7fOMwMf9PnXVywQA/WIrx/4DprwrG53EtMF7ACPk0GPpcgBljb0WfK4R9YUliaBUxKs8g8s3n4LPdFzWTJMwxuX3pgCLqfmctn/SII9heNT6aoPYsakYSzyxtI1Da0XwdQodLfw/HHYRcTuuprbcxJFSuFM0U9bX8g15h7bjvdvCfgfbbSNe6WlW5jzRO2DObQu/5rEG/i95roBIN3NTMPOD+jcZPV5UerWZqoGrtw7X/RJBfkrK+vTXYc/XLkUrUHfLtYuXY3YD4hNN1IUnzBylgGRLEit6/GVcQP/93qpjFQazbCW0JxQooQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 27 Aug 2023 00:40:45 +0000 SeongJae Park wrote: > + TP_STRUCT__entry( > + __field(unsigned int, context_idx) 4 bytes > + __field(unsigned int, scheme_idx) 4 bytes > + __field(unsigned long, target_idx) 8 bytes > + __field(unsigned int, nr_regions) 4 bytes > + __field(unsigned long, start) This is going to cause a 4 byte hole. I would move nr_regions after end so that it stays properly aligned. -- Steve > + __field(unsigned long, end) > + __field(unsigned int, nr_accesses) > + __field(unsigned int, age) > + ), > +