From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90F2EC83F12 for ; Tue, 29 Aug 2023 15:06:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 040A58E002D; Tue, 29 Aug 2023 11:06:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id F33508E001A; Tue, 29 Aug 2023 11:06:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E22D28E002D; Tue, 29 Aug 2023 11:06:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id CF31D8E001A for ; Tue, 29 Aug 2023 11:06:13 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 91322120182 for ; Tue, 29 Aug 2023 15:06:13 +0000 (UTC) X-FDA: 81177467826.01.DC047AB Received: from outbound-smtp11.blacknight.com (outbound-smtp11.blacknight.com [46.22.139.106]) by imf24.hostedemail.com (Postfix) with ESMTP id 73DF618002D for ; Tue, 29 Aug 2023 15:06:11 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.106 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693321571; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D6lbZ5EY1B6HKU357oK07CIHfD+KpnFLfZHleBsYkNg=; b=ZsTHWeOi2CO84t0dW/NnbLj/lEX1UwHaU/T+L2HrHaikHA6OvbFDaVvHPbFtrEeFL49NHX FqhDUmkfjBW1eD++OEr/O/nqj+gShC/B8jWQwarOvpSoaeIX5zm7gb6wFamHSzuz3ImnlE Qy6Upe0rjGSJNoMoAUrNhRBkVy2yLbE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693321571; a=rsa-sha256; cv=none; b=Nm1Dlnj53hK8lPm3w5xVF6c98vx23BCy80Jz8mmfw8U+cT9FowBHtN9z8ju+UXf8bAdIgZ tDz21iLrxJuj3W7SbIipLaPtyd6BS3cBZ2uRPLG0qAi6kpEy6+Ej/wgWzHgBbdPgmL4fJx wUj6v08pEYb6SscAzO952RzCpIKQ4mg= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.106 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp11.blacknight.com (Postfix) with ESMTPS id 044A71C3909 for ; Tue, 29 Aug 2023 16:06:10 +0100 (IST) Received: (qmail 8158 invoked from network); 29 Aug 2023 15:06:09 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Aug 2023 15:06:09 -0000 Date: Tue, 29 Aug 2023 16:06:07 +0100 From: Mel Gorman To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org Subject: Re: [PATCH v2 6/7] mm/compaction: improve comment of is_via_compact_memory Message-ID: <20230829150607.p4qyjsvrovdhhnh6@techsingularity.net> References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-7-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230826153617.4019189-7-shikemeng@huaweicloud.com> X-Stat-Signature: drk9ycpmuj8z91tcorrr1cu9ttf437yy X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 73DF618002D X-Rspam-User: X-HE-Tag: 1693321571-442084 X-HE-Meta: U2FsdGVkX18VFVXxpfHyKuNpzWXuVjNsOCaAuPjlPA22c/1tbahlK6e+G1h/4CYbw8GkFbCtmr9Ht4aOAXkTBnQXVB876njoaKS51/OgYpPutYacB44Hz8BNynDifK8ky7+ZbK7w4WgO+axHLxA4b8HU9NCMDIPcnPfkkkjaW3qiw6Kf1naxvQyN6gd4pRu45QxftzaMXNUm4tY3u28h/Y1g8vbU6UKP7Dd0j7lxS1rHRi/imxmXpH+a7gPpsFmyurnCX6X4k5N6D79ahbuVsnhukbCSh06hkfPU89We+uP4WuCQqDaCxNih9HfU7EXr1tZ3pwwEw1WcAbJ48rRB81cGdy4nZLtMJodBmr+eh4b/S3k3JS6C22uTX/Q7/LyLRF3iELj+Vg/rI7Wr5SlvqmPLvks1iuSUV7+7EN4wfVs+PvMwaaHgdNx4TNfZNbjL5MBq1TPWdmK2QBxx2gOE/qy2gmnDUQtDUAueyZAXFUJO1BV1JkExWnHB2p1XA7evpdZXiGfjGHmhnIAKmc6f6nlyHIUhPMBecU6tBMppcRhBAMcYV0WxKy8oqCkE7EfZsoxswyLRpmKvteO4ypXgDSDUpD6uH3+75eko7huXVgP1/Lo0Q+w6goHDP9TWQdUYWpUWgnnVAiQ+QrEA5eiMFEiBYNl3kmCroN5vAmMXowTq8ZcVenASFA+7gkpswLWw6iD3wZYLwIyiKfOEpDwEjbQCMl32MbNpUmx1KSPG8Y8tauaiRbloHk+JbnidtVe3u5ecP/X2x154AInn+TmOSghquc2xGD8qk0Xzw6ZvaZ+k23Ggk8VkKtSn1XQkhNrjIbyiiKQqUT8Wio8ZS5xbTYzK7JUfP0FIcvsLXiE5jt1Un1N8N28ghgwFJI68ka+iru14+9/XbQQYPfVye8lTiBnI7pgcd6bW9gAnVqfICRkD0fkxxbOVaQFQ17c47GPrBwBVD0bSRQ4ZlOKwed/ CM0J4Rno AHsfqvhUCh0dhYgGDaWrkLnYrDMxb9Am7yFJilN8GEos8wGJVc3SiYcJLWuwFLchMMC0jbp0CWhzH27far90KLvpWqm8UE36rqIeTSp+JTs+QMEZy8WFLpyfi9nEC5M5DbZZg0gGLVxR5oIV05akvCbfeIoEi8VmB79+fwHO2N2kYJorQXg/6xfFxh7lm+rR3KCt2YPk7edQ+4iG8+Ere+WwYYbJTRT4GZSGdq5nSWZ88CAag0EPVap20cQVERr0NhPdFuIbPAEi2pIW2lXmKe1j3UJ65y9A+5kCIKAlS0ASwwa7FVIL0AoZtViWeIz/0VhsWKi3gflTyOgA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 26, 2023 at 11:36:16PM +0800, Kemeng Shi wrote: > We do proactive compaction with order == -1 via > 1. /proc/sys/vm/compact_memory > 2. /sys/devices/system/node/nodex/compact > 3. /proc/sys/vm/compaction_proactiveness > Add missed situation in which order == -1. > > Signed-off-by: Kemeng Shi Acked-by: Mel Gorman -- Mel Gorman SUSE Labs