From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8655AC71153 for ; Tue, 29 Aug 2023 15:05:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EE5A48E0029; Tue, 29 Aug 2023 11:05:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E94D68E001A; Tue, 29 Aug 2023 11:05:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D856A8E0029; Tue, 29 Aug 2023 11:05:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C91E68E001A for ; Tue, 29 Aug 2023 11:05:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9B0E71601A1 for ; Tue, 29 Aug 2023 15:05:31 +0000 (UTC) X-FDA: 81177466062.15.9588CE2 Received: from outbound-smtp07.blacknight.com (outbound-smtp07.blacknight.com [46.22.139.12]) by imf28.hostedemail.com (Postfix) with ESMTP id 65A75C0038 for ; Tue, 29 Aug 2023 15:05:29 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.12 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693321529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TDlFwmRUm3pKfms8nGyPx8seoI1nc/x+J1AeURjMBHA=; b=BGMdfZRGdQYnPTyq5W0ICp35rw8Im+CNSA8lnqIgUGxeKr3ncH7k+cIEK8VzGY02js1D5N oQcH6KZQulwEmiN5gwVcvRC7CkhwdGWOLCCFPsu2LvwtEJzGp1fa9A3seet6f5NuvxjVau ZM8ik5a+KRfKmeypI06CZvFqgY40rw0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf28.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.12 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693321529; a=rsa-sha256; cv=none; b=XCIGXsPUoaA2hwuhdqQv5EjsnND9uM4zqD2aIL0LzIU45C/ObpDLqsFiCV748UFbPdupCy QaXrAiqY1A+ZDwk5KfTUD0lskZfDaMbgHEed/NCKcxiPqU8ZkwDglwBt7Cwu6O0qePLJC+ iTVfKfa8fd2Rh7Swy1Hd3UNVTQGn0cw= Received: from mail.blacknight.com (pemlinmail04.blacknight.ie [81.17.254.17]) by outbound-smtp07.blacknight.com (Postfix) with ESMTPS id 96FEA1C37AC for ; Tue, 29 Aug 2023 16:05:26 +0100 (IST) Received: (qmail 20754 invoked from network); 29 Aug 2023 15:05:26 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Aug 2023 15:05:26 -0000 Date: Tue, 29 Aug 2023 16:05:23 +0100 From: Mel Gorman To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org Subject: Re: [PATCH v2 5/7] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable Message-ID: <20230829150523.ktn6ktdtl7n22akp@techsingularity.net> References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-6-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230826153617.4019189-6-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: 65A75C0038 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: s8f9na33pdq3s6u18pdrqyyq6a78jhgp X-HE-Tag: 1693321529-981500 X-HE-Meta: U2FsdGVkX1+SYu1qTOJsov9jECuHgUY+dU07hwhXeaWf/EAaY4BlhVovYhhaY4K6WY2RZlP9S609qMINAKeCaLropsgmlpd98en2jclAH85ln+gdNYUVUKDYEGC/G/iCtMGFzS/wrimZdDb6APtJuyfyvs67NUiGRVHGQmsvWur+LFmDAt+rLDTwLGiEQAu0Tm2+QY9YM4r2Dv7qyzrsEHC10OdGn+eU0dlTRk7wDA/39Tqo6jxrco2QYd3c5mox0bcdEEqRPTN/q/705ql249/m5m9orZgJFhnB0og1aeJlda6bg/yxH7rY6IjaQ5cmpeBgFToDjyY8TvInAYZQ+4qIYYaFut/OdUjbcth4LYpOMN/eLyVAhikr1ytUYBi91iBuzNPMvQGP0a+ipBcZg9NbHBb37/H3CVcA/VDIDrGrRxY+wi/xpavguaqhhpMVodCZAG89oBEWXxa/lAoUK2eTuj+Jk9kWbdZAee929DVkvG0PLOC6eFCfIbG28e30Dz7mDE8erAz+0OcET0dpRP6z+Ft+JCZIJx3axIwIyLaqbxxJJfDJ+FrzjVgwC7sz5ekJWPiUAZpc6vo/3sLrOIVnHkSzKfrzCMtHsaNQApogbG4BAkn5AV8P6dZlyrJEki8Ta8Aw2eVK5YczSMoZmjIf8R0c2uMi+7IzGMpYKWfmkjj77+uxpJ9LDYW0FptTZLYQVOWj116XlmIJjWA9tMRkrTeUN/gdPYu4FhHNqnIq0AIXBljC3eS5NbG9aeFOjVI8zXYdFe9VaIGcKg2febdzJsVWMX6PQnXV749mJG7Ipj+p15DJZA44V+NC+BnEcHK563IqRnSfaOs3lXqMD6b/+IJzy8R7PIlEbYQL1IIDkfRegsBKRuGR8ECXZYCC9qNCMUP81bMLXv3Dy5iX7DQ0WVNBjQ+sE/AQ+pE/Fdfz+wCy3xYPe8LsUIkEKc6g3sE+1psm6eLYc3zB3+u UJKq6pTP XhjmZKKrMhCAkEG3s8UX1VaahOjJeeu5LVI8zUicipq+qsi228pL8L0RZZ/Lh+XlZRv3PVEmUU0lGlWrDaZgBJbF9Q7mMYPJr4hTO5UZROGUnASweSte/KYPlweAX2enNYCYHCkqUV/PY98QUDOU6hfh8HEvU+owZqYj8AYfQ5IBhMojC9IVBb9DD9ITnACGC04SiXKW1ZBHxgnAXEgTCbbV/l56a+F7IzTQRA9E1NxxdysN5F0UKXxaYsoI3k/ioaoPzgjU80cdzBFuwOJGDEi5c1h4ORDef1Ri8LFbNTgTQ1dXuFNIkiTcEsRMZiKVrCxyiuN2o1jauQ+JgFEK+VTbFsqzQsCfd9fsy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000143, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 26, 2023 at 11:36:15PM +0800, Kemeng Shi wrote: > We have compact_blockskip_flush check in __reset_isolation_suitable, just > remove repeat check before __reset_isolation_suitable in > compact_blockskip_flush. > > Signed-off-by: Kemeng Shi > Reviewed-by: Baolin Wang The comment should move to __reset_isolation_suitable but otherwise Acked-by: Mel Gorman As a complete aside, the reset_isolation_suitable and __reset_isolation_suitable were badly named because locking is not involved but it's meaningless churn to fix it. -- Mel Gorman SUSE Labs