From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04851C83F14 for ; Tue, 29 Aug 2023 09:39:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3CDF78E001A; Tue, 29 Aug 2023 05:39:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 37E898E001E; Tue, 29 Aug 2023 05:39:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 29FE98E001A; Tue, 29 Aug 2023 05:39:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 17E288E001A for ; Tue, 29 Aug 2023 05:39:16 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id D64CEC0681 for ; Tue, 29 Aug 2023 09:39:15 +0000 (UTC) X-FDA: 81176643870.01.169C586 Received: from outbound-smtp07.blacknight.com (outbound-smtp07.blacknight.com [46.22.139.12]) by imf02.hostedemail.com (Postfix) with ESMTP id E2BA080019 for ; Tue, 29 Aug 2023 09:39:13 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.12 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693301954; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fH4dICvIaXTXRAioJPpblu/vi71jDQWZVy1YvjJnS/0=; b=Pbc4xiVrTWBcwPa5bGrW7aKmRLk5TfONVjSmHM2RSbWFcg6Q+fuBgllZC8Incp3KFS4xPm Jt+RLTigc0MEvDVLt4KrYQcJ5+Pf8SB/q2pIIMEDQhMHOQTsCdZDVlgyuoJ1utwC6vNZxW aWqh0J8V1Gywll2N0bVc2Y1StfiXEcI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693301954; a=rsa-sha256; cv=none; b=d7C6fl4hkxwsbrleOAGoaa2mxNaOr35FM57NxvG9NnQXFgyY+AcqnRIN9rcOVGlQrlyQOo lEn+NvkgWHa7OT9ej4IN3Oboz3cTY2AIn0zliGgERjdrISeHpbIbR1qwN1Gt/d0Pgf9+Gg qXrhg84pGQzMqPnaIfoy8GE9JQOfMSc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.139.12 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp07.blacknight.com (Postfix) with ESMTPS id 3BB941C3E3E for ; Tue, 29 Aug 2023 10:39:12 +0100 (IST) Received: (qmail 20350 invoked from network); 29 Aug 2023 09:39:12 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Aug 2023 09:39:11 -0000 Date: Tue, 29 Aug 2023 10:39:09 +0100 From: Mel Gorman To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org Subject: Re: [PATCH v2 3/7] mm/compaction: correctly return failure with bogus compound_order in strict mode Message-ID: <20230829093909.4hpria3qtouvdv6a@techsingularity.net> References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-4-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230826153617.4019189-4-shikemeng@huaweicloud.com> X-Stat-Signature: 1p8gt9x6a35fugi1g9ubgah6n4uzmmck X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E2BA080019 X-Rspam-User: X-HE-Tag: 1693301953-30988 X-HE-Meta: U2FsdGVkX18iWg2ib7egTzH3XCWgTLu2oboAE7hWtqc2VOBmbPkbuNu2hKqEUY8XSGVvLk6WsSeqRl2dcCrrAc+lxqhWLRXPNZEOzTYlUeTR64EiYR45lUs9WYG+RgU6XByypASdqMEfOoxlXuTynJA1kms58xN8aaBgu0S6I81PNduW2IFo0Za4cWPd7qg91PlDuQM3hSzm0Z+ENQKvKg76Xvp9jwY1L/C2QjX2AnxNo0r+TrvBtf2IOWUZJXi+XGrDXRXOpSdNvjiOSYjwZ+O9iG4lQeekH0BQrAjlxnOYkYmGfIIYd3yf3SYZiRmVo/phLTatRPFfCH/MDQbC1pQ3o+Y2SOkURA4X8n6JWruY7h9ud7NccwXNInOtGsYbYJiDVgqo2WE89FzJTAXlIPnFcAKZ3radqHLin7InrdwP7O7eb9F2x5rlfqlHjf6Id8ZnI3H3+vu1+aTdNlYbNaPpn5Wl06Nx+tYVmMTfNc201j6cyls4jnEMfsk0H9CzbGd2iDfvLJQPkPKe31U6BO++V8Cn03PCas8j/VSiTh6iaaGvE+TdvjxNPMZKmAhPsGG/i58dI44XA8ae8J42zgo9vkocDf6qyF7HaxsUYDYWAlCHS25NuWScd91e80qnoLTCJoEGfMy+EredsTaw8SBPSurehfegwB1RXcbIeSigptu7ZTpGylgjTbUWYvA9UXxhNdD93R+xrPNtXlN4lXSujuOSbMI79QYcuyw8+PSdCe6vwAZXALRxYFddOHATcxLTXlxt1ExQv+GRH7ljfhdxwcMbZOq1x2WJONMWya+00oKknuJhvCyXqdpE+0y1aJAaf+A5G43KVh0jTV35OktehPBHyUfTe4kJRN6wOlOGA2eHmZXYsFKUAoWgQAZVGQ1APca2aL7ObJX1Rkv98P4kmwx+jBSeVDFHLXgYojqyLJZY3DEp2c8ho+HlDok46GFwu+WyaY+9/NwJp8b eJRLB4Ok xtqMgt/aogcO6Z28Mg3DHa1I5+Z5V8yYdNWqzsarVZ7N9nSXwpgxytj7RpYWvq385Qk8LJVIrQAvaT/pqIx6SyRlxxuy9q1RhqC4hFZIyYh62VpHn7ulqI3xKoJCUcy17I7pPWh3y8WuCFpnxc8P6U+IluPoEIRQQQT32Jh/vo1vw3mJgoxZwp95QnzncHrAJvNMLBiCHtTc3NGG5rv4KBLtUjdYXAOMZgEPdZHz2jjNJKe+flM/AuCIiZNa86u+/0R755bJR+XlUS1PVEGEhd9vv+a4c1RZfMsTohONmf5eVdGA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 26, 2023 at 11:36:13PM +0800, Kemeng Shi wrote: > In strict mode, we should return 0 if there is any hole in pageblock. If > we successfully isolated pages at beginning at pageblock and then have a > bogus compound_order outside pageblock in next page. We will abort search > loop with blockpfn > end_pfn. Although we will limit blockpfn to end_pfn, > we will treat it as a successful isolation in strict mode as blockpfn is > not < end_pfn and return partial isolated pages. Then > isolate_freepages_range may success unexpectly with hole in isolated > range. > > Fixes: 9fcd6d2e052ee ("mm, compaction: skip compound pages by order in free scanner") > Signed-off-by: Kemeng Shi Modify the (likely(order <= MAX_ORDER)) block to avoid ever updating blockpfn past the end of the pageblock. Then remove the second redundant check. -- Mel Gorman SUSE Labs