From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B77C6FA8F for ; Tue, 29 Aug 2023 09:18:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DF8D48E001E; Tue, 29 Aug 2023 05:18:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DA8048E001A; Tue, 29 Aug 2023 05:18:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CBD378E001E; Tue, 29 Aug 2023 05:18:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BF8328E001A for ; Tue, 29 Aug 2023 05:18:14 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 95470B297D for ; Tue, 29 Aug 2023 09:18:14 +0000 (UTC) X-FDA: 81176590908.24.AFCD15F Received: from outbound-smtp59.blacknight.com (outbound-smtp59.blacknight.com [46.22.136.243]) by imf30.hostedemail.com (Postfix) with ESMTP id C1BB080014 for ; Tue, 29 Aug 2023 09:18:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.243 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693300693; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ROhjm2iRCP4sE2dvgSXKqEMarRkhJBNQYnDmXwhSNkc=; b=L0n5OvNsvtHwIE3IcCsk5kw5gJR+89R2IUp8AXI0vozcjZssXq2DeV1dRqbjnAUmugn1Gk C0phYQgQovpzHSU08rUTQpROK//haKyI34bKFX5PIUyb1oNuxbsjueTRElTVxlsf4KABSl mrs6I9qx47n4zhUuhKtDj0M/Acf8ylE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693300693; a=rsa-sha256; cv=none; b=53c0bHGTi/6z9gk6K/B+nhjSnkMK5iIa/1qj4Hs/nqtMy53oVj5aiFo3PVrtLMi2MVi3pq TW10//nxMWyTLBC7hAYqdaZ7uQ5HAKSZifMDAOfIdUaM+JcDolWj6PNdKj30d5rlEP9Ffg 7DazDezzll6L+49T2AjTXDE/Ygd569o= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.243 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp59.blacknight.com (Postfix) with ESMTPS id 1ACE9FA83E for ; Tue, 29 Aug 2023 10:18:11 +0100 (IST) Received: (qmail 21416 invoked from network); 29 Aug 2023 09:18:10 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Aug 2023 09:18:10 -0000 Date: Tue, 29 Aug 2023 10:18:08 +0100 From: Mel Gorman To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org Subject: Re: [PATCH v2 2/7] mm/compaction: call list_is_{first}/{last} more intuitively in move_freelist_{head}/{tail} Message-ID: <20230829091808.gfoyi4nhi7dy4f3a@techsingularity.net> References: <20230826153617.4019189-1-shikemeng@huaweicloud.com> <20230826153617.4019189-3-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230826153617.4019189-3-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: C1BB080014 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: zkci4w1bd5wix9ghwm85fqrz7msudc65 X-HE-Tag: 1693300692-153852 X-HE-Meta: U2FsdGVkX19R+NYVii/OtAdFhElkHhASytj96Uv+IAvvty2GNG25YLAd3VVUAZrx/dedx7Fe870/TxD7swmmII0hjYMaVRc2L8G9iLlqAZewH1zuvH0eOtPEgbZX7/aAlEIrVPxkpM3x60XOW2FWRd9mTaOOW6lUFFF9eSUgn8gPwSgSG6vIomjyW9+Psk66Q6k1yCxFELZgT3fBh3D/XD5u/p25/Tqp6kzGx/LhKHOveAMPwWSWxG4yaevHgMkGStFkvNsFg9bzxMV7u1sukJ8nWErNnwVKYkVsybr2N2vK7QeqMD9QcKfrRZBhm+M7bEgtddcd1xPLd8CyPrCRE1NVqYLBGCKPBatrT6alyh5xMeziuRF4KDAUwIDxHuxT7vOckSaJHBWb1hJ8YHZcFXkG50IMrkp+YFR9cT8bkIFUO8g4L5QKa35/4E9abB3rQ7X7l/gi0u25CcEyPWP5MoDvwCaZdvmdXhOEfTt5UPHk3fguQ0Kk0djlqVK16JboNUEQPgKmyvMhdKYTF5Nk+2FcpXaQpIpdg58D/rpvaswwusKXGii+D/P/n/7kixjrc9ah7XeFhfUz5aJqU8k20lNUonot8y+bex/aTsIrGvJ7p+5y/zIyVQXdbGeLYscTJmU77ISuGkPPAwtKlrZ+8pA2y3Ut1qCJgdxTJkXT4bF5Gu8x49eDVgg+TNUF+gvJvH9kelFdK5EkAeQHi21DesUJ8M0TjaIh2JWKtJq/yQX3iBC5brY+kzCOULbMAzO9ZmOKfbF5ZvHZcHdoSyeEIkCEY1SXNfMKOtAFqWJZRDGtBJGN8QILiPN3AznWyhWPF688fL0Y9WXayvgh5RuJSkhNMNLqDtLtSoiYD12UscLeyLmcnqze25+gn5GhhQI4u7+lgkpq1g90HifknF+nYfJQ3N+tfPyf4Dns2/D6TWFm+KPFsadlTYVsXV3borK7eotjSHUzXRy8+wgBMmY iIFbx3ma VTH/FUz6Za2TxS0TaFNSF1YpCcPJcyzTNFuAjBDPVpa+BCPJhgy66drX5GIS7gAe565gMfwn0PKE9aw5WAJg57GENmjJpUO06k9ML2yH5gfP32Ai9X+FNt6hisPc4u1IpG3iuqQbIRrLFHIYikLwxucwUgQRPc3w/lr4P7GJF8zOxU2Cgd0h4zSn/PfibidHsJ4YSoyti5Jz9ue+RNFGaqPKjKMgmuAm2qYU50gRssFpwHM9QCNxtZev/NhlJky/OB4De0Lf41vyELGUvrIawTIGR+Uvydc5vqA/w3lL5SH/obg+697sfvzxNK4KA408v3bk/qYVe/er/zOaEXF47fqUlSqMHT3WsFtBEx56bdMwmMKI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 26, 2023 at 11:36:12PM +0800, Kemeng Shi wrote: > We use move_freelist_head after list_for_each_entry_reverse to skip > recent pages. And there is no need to do actual move if all freepages > are searched in list_for_each_entry_reverse, e.g. freepage point to > first page in freelist. It's more intuitively to call list_is_first > with list entry as the first argument and list head as the second > argument to check if list entry is the first list entry instead of > call list_is_last with list entry and list head passed in reverse. > > Similarly, call list_is_last in move_freelist_tail is more intuitively. > > Signed-off-by: Kemeng Shi > Reviewed-by: Baolin Wang Acked-by: Mel Gorman -- Mel Gorman SUSE Labs