From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA30BC83F16 for ; Tue, 29 Aug 2023 08:12:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B7DE1280042; Tue, 29 Aug 2023 04:12:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AE0C6280041; Tue, 29 Aug 2023 04:12:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 92FC2280042; Tue, 29 Aug 2023 04:12:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 77A2B280037 for ; Tue, 29 Aug 2023 04:12:05 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 59C45B27C9 for ; Tue, 29 Aug 2023 08:12:05 +0000 (UTC) X-FDA: 81176424210.19.705723C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 0CA27100015; Tue, 29 Aug 2023 08:12:02 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=t7GaHq0+; spf=pass (imf05.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693296723; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jf6gjgPrSFkzDGpnNfJeltCs9REThUQT4FVafZr15Os=; b=1GNyv+m/WUjjztbW3affgnr4jBbF2HDw/smIa35PyHDnWarybwX4WfHVyWFfwayrmxJci0 xiU26buYv2eX5lPctLDMkflpfZ5Z02szYqWbFs5XLtvKjYbVmSXzokHK9TeMJJHdck6Qp1 dfNPwFb2D4zX3MvY9ztGH4JtN/x7z0s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693296723; a=rsa-sha256; cv=none; b=5itFckQx4bNKjfVicS7KOu826Rm/VJH8zR3qebWf8ZG6Z+VPSLNz/VIEBphGRWLwVe2BPl iCD2LJpjZDDU3dCpZ5l13yW6dMHl+CYVb9ASJlrw6mlG4pAfokPxzK3309yvdkZ//5RKcx kLOvUd74rT4dqUIPKZwiymYvqrjyf30= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=t7GaHq0+; spf=pass (imf05.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1D66360ACE; Tue, 29 Aug 2023 08:12:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 08D93C433C9; Tue, 29 Aug 2023 08:11:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693296721; bh=RKsitqruLeakZo1D6/gvmm5Cw17kgJDQ6/wtIhtx3Xc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t7GaHq0+LRKigL5Kn8yCcnQq3fr1wVnM+Jarqi0qWe98pvwdAxhGSivWnnq+xZKEI UoYioIzBdYJ+9J8sggSh8yBFyTVXf5MQ51CO7QgeAQ+/RxnI+UrsaVtSYRGfXf8JKR 68DRbZKiVzOt4dB1gFsrvLhI30EdrbT5P2zAVlpOrU/+1w+X2PUf7YB4YsTJmW7EwJ 7TvXnet70vdkNT+hB1gB+WHulUHBhsOh7Qx/MKpmwtp2oeaQ1eFil8VCk34nFM+Sp1 gXyVQJcB1bB+5LCK/yXhcPcjAvh59Scq1Q1dhm9wHnCXlQ/FdWCSkxADQSAPQPB6vB GkmKqCowkBxLw== From: Christian Brauner To: Xueshi Hu Cc: Christian Brauner , nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org, Jan Kara , Christoph Hellwig , hch@infradead.org, dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, jayalk@intworks.biz, daniel@ffwll.ch, deller@gmx.de, bcrl@kvack.org, viro@zeniv.linux.org.uk, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, djwong@kernel.org, willy@infradead.org, akpm@linux-foundation.org, hughd@google.com Subject: Re: [PATCH v3] fs: clean up usage of noop_dirty_folio Date: Tue, 29 Aug 2023 10:11:50 +0200 Message-Id: <20230829-kappen-meinen-0c51bfa4472a@brauner> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230829040029.473810-1-xueshi.hu@smartx.com> References: <20230829040029.473810-1-xueshi.hu@smartx.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1181; i=brauner@kernel.org; h=from:subject:message-id; bh=RKsitqruLeakZo1D6/gvmm5Cw17kgJDQ6/wtIhtx3Xc=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaS8XeE0X7zC/+a5ToXwkP6tq+ffe+sq23qzeTUrp2C3uJho fe+ajlIWBjEuBlkxRRaHdpNwueU8FZuNMjVg5rAygQxh4OIUgImU9DAyNBh8vvFMVubWufawk0/v5z ds+Kuc8/L2Q+tlArpzys41XWRkuDDXYfo74/2PbWIrF2j+aXK07m/J2JfZXJkcbrtn7zE7ZgA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 0CA27100015 X-Rspam-User: X-Stat-Signature: 8ya9c98f7zz33itdu8t8ei5r54yxcq6k X-Rspamd-Server: rspam03 X-HE-Tag: 1693296722-126584 X-HE-Meta: U2FsdGVkX19y9QUi5vggEhO6GeSLKWT5K6PjNYasC8hfxEpHagmhq7m6fxYu0mtw4C5+z9qkXCQlh7XPRs3FRDav1ljWwLtJDpaJMUMqTpTyZSma0Ip0erZ+M6r33HUvMpJ8c4WCYZhcb0R0peFCNf7AvwLP5byvbJcBO/sHqI3cwbsa0uYPz0Y+JbJL2jOJWM7zLOErWSUAui5n4Yr1ekll29QE69qinaoA66d8Dunc9KiYxGyVIRTEMKRk0MiuDi2XFcwEYgrZzYPLAvdeTGvLhwI5NRTip4IsBVDeWLRLM0Qk++7Gk35WkWBMrVNk4o8zYHrTdXdJUQucHXhWyeSlBntLTWZ9M3gnqklp7j7Lplt07PpvvaEEUse1lSXAdicAPizbh2qmGVZqZsykch+nwDCU92vxxh2L5dMvUXQaVj20MBHfyTF9ghcsyxmJuGKglBQ6D4dgGoadRD7HuovCywvMoQDZ6BYNnbWvGnUsCW1eVs84v55Lgzj3uhBaVLodk1YrGpa6cs9SdSaKuz8H6YXjDeP3qRFBvvWT8pH/1zk4Lkr8hf+Vb6QXoMOB7zLqFVnviSe9aE8brwe3VvBqxPjS6SPN9wufFuTK23exZcRYyy1tkyFE9iQMcJU/cui+hvFuFOHGeDl9Ws7wfHClNzoA70dA1roxCfF+QBetvCgeYk1zIWgP2vGGlM4sokfypzWB1efrYuyUTZMDPTChnmvgZvmHIKvIAoy+K0aEzKS1kttlLybs8XcAZlAX7u3PPLOc4NIKkKLGtHT8dpyjRUhwR/GHkysFnIbcXPT1joK2ARh1Jtdj0Uz3wdJ0+mKCedbSs9+YqGS6s5pgCdTfmLC838diTkftzdxSSk9aUgWK+KoL/W5Aff6tUMdJuDn3MY0Jxm8Resx6lHF2qlkXUdtACTVN036MelM1Z8t0o0rdM06xg9ba9VfA1TlONV0Vct+RqEU8jvDYqjy P9w9UeZu dk9OBrghtUez/BiXQH+oQo1Q0tLEbbMolOuf1aq7BcJRsnVmHUUoleBvu3ZHxu4j63g5m88/XEvsojigqPnpm75cD/IPRZEHChyoIK8wzLBWT3fEb+VYKnSTLEIlEv8kJIWE6y8+4mdUUi2i2eLOfnyDFTU1awtBsg+fSl4hdTiAt724ZVdJiSVLH3Glk0dSKEiz0phCDgorYRXQPPbb0OIL7BZpHS2VP8T/qDvkKfgkMxLE6WC8lqe1Dtr4LJKOJItsvgu0yLhvZMZvQoPXMwEwcYF6ZGkpyJwvomGFOynR8WuLrqQU+6GKJPw3+0kBsl36Hv01NVjbiRoXlmLIjGKiZaytI4rmbjAIdcqHO7nfaLTK+3AjMFbHETi5DkPDqYOONXGmepeCwYHU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 29 Aug 2023 12:00:29 +0800, Xueshi Hu wrote: > In folio_mark_dirty(), it can automatically fallback to > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > In anon_aops, dev_dax_aops and fb_deferred_io_aops, replacing .dirty_folio > with NULL makes them identical to default (empty_aops) and since we never > compare ->a_ops pointer with either of those, we can remove them > completely. > > [...] Applied to the vfs.misc branch of the vfs/vfs.git tree. Patches in the vfs.misc branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.misc [1/1] fs: clean up usage of noop_dirty_folio https://git.kernel.org/vfs/vfs/c/ffb2bc01caae