From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4739C71153 for ; Mon, 28 Aug 2023 18:37:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6256A280024; Mon, 28 Aug 2023 14:37:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D5E98E0029; Mon, 28 Aug 2023 14:37:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49DA3280024; Mon, 28 Aug 2023 14:37:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 3851A8E0029 for ; Mon, 28 Aug 2023 14:37:50 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 129B814050C for ; Mon, 28 Aug 2023 18:37:50 +0000 (UTC) X-FDA: 81174372300.05.D31B351 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf14.hostedemail.com (Postfix) with ESMTP id 4B480100029 for ; Mon, 28 Aug 2023 18:37:48 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=SH8jxYzq; spf=pass (imf14.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.174 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693247868; a=rsa-sha256; cv=none; b=u0f/maFeVXxSju3cBMak4GC3squzg5xLuMh8WwlO5Zt/3Dyr/UEfLsrdXhkmt59rVPL+RU o0lXFaYBOGffUNeqk01WrIlfClO2QoFOaQyXDiw7rYI6CuWwQ3wxn56E6uPd+0/DBDuE/K GWIV2fGGVUORIw3dEfcsVKQJEHaX6nQ= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=joelfernandes.org header.s=google header.b=SH8jxYzq; spf=pass (imf14.hostedemail.com: domain of joel@joelfernandes.org designates 209.85.166.174 as permitted sender) smtp.mailfrom=joel@joelfernandes.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693247868; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4aeA+YemQ9g7XInX/f96izKvTfLcSSJK1SLJJW0jCfI=; b=cwocPiXVmfZWhN7h3L1kbQvGE+XOyVJuNMzUeANMgJvxuEvIaMRTu4YZ788rQR8MYY7NH2 jXGXg18mzEjSa7hoZSZsIxTrzo4TOktOu+52cpCPkWr6R6JJuAIhW0rGDcBliP9AJOnxvn jwahrU4bQwUiz51nn1+1tKSfK9UiS90= Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-34c9f8c9876so10910655ab.3 for ; Mon, 28 Aug 2023 11:37:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=joelfernandes.org; s=google; t=1693247867; x=1693852667; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4aeA+YemQ9g7XInX/f96izKvTfLcSSJK1SLJJW0jCfI=; b=SH8jxYzqPWl2O32h0Ogm94o1PofQqU6DaPrQRD/G0r8ur4Om+FS9pGS8xoQdQe6ZtN jonkZUnZz4vIHKnMvhPOWoiuW+zyMcHvTs26ojfEsa56CVAS5PqJ0jN56h8Qs62ZiNc6 dhQ0/34QhWGk+P2JVk/2dUI1HdZyVA4GTu6Qg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693247867; x=1693852667; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=4aeA+YemQ9g7XInX/f96izKvTfLcSSJK1SLJJW0jCfI=; b=bcd/Q2cAazTOc/WT2ZmqvG7poEg+cizSGoe6a3GG4wvEEsGRYb3JAVWHqi3qT/Wu/P Ab85YrAPjj3xqcr1EoJd4nm858T7p3cmdmnb99rxSpRvX4JiLHtdkUX4ht4f76waAsmA NPmX8+C1DKgw3TxzPfTQ+JfK9KcZu0Vl8ZS3mSmeiM8q9/4OtEVrwjCJtt+IgPn5HBrU 3vf45Xpdt6ktMUM9nS2z1NFvIQyvlqInik/I0m3ZBltxraMWQlrr7qjOo7d2JxDEKYZM zMSqcXFOYX+fr92DOdIxkbXhxqBAmo2SjF6tWHm8gfVtZrLvUZeExmQ6O/SN6Ecfy8e1 Pilw== X-Gm-Message-State: AOJu0YwZbrnXR3yEulDQEfyGObQeSA9TnXig8L/f28miHZRglOeMmeHa 2V7cMX4KoVat5LjG4sZPy1ot0Q== X-Google-Smtp-Source: AGHT+IGuh45u033WSGbdyoxXgEFVHoRQLf8WpOIpwwKNP0a57n7PrCK5IlzOYqyZUn7LNJqiW0FyWQ== X-Received: by 2002:a05:6e02:ec9:b0:348:7d72:86f3 with SMTP id i9-20020a056e020ec900b003487d7286f3mr15799100ilk.17.1693247867430; Mon, 28 Aug 2023 11:37:47 -0700 (PDT) Received: from localhost (156.190.123.34.bc.googleusercontent.com. [34.123.190.156]) by smtp.gmail.com with ESMTPSA id z10-20020a92cd0a000000b00345d10ea524sm2643310iln.65.2023.08.28.11.37.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 11:37:46 -0700 (PDT) Date: Mon, 28 Aug 2023 18:37:46 +0000 From: Joel Fernandes To: Lorenzo Stoakes Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, Shuah Khan , Vlastimil Babka , Michal Hocko , Linus Torvalds , Kirill A Shutemov , "Liam R. Howlett" , "Paul E. McKenney" , Suren Baghdasaryan , Kalesh Singh , Lokesh Gidra Subject: Re: [PATCH v5 6/7] selftests: mm: Add a test for remapping within a range Message-ID: <20230828183746.GC1621761@google.com> References: <20230822015501.791637-1-joel@joelfernandes.org> <20230822015501.791637-7-joel@joelfernandes.org> <08ce8c61-e7a2-417a-a3cc-d20861753ae8@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <08ce8c61-e7a2-417a-a3cc-d20861753ae8@lucifer.local> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4B480100029 X-Stat-Signature: s6ihs7a8byi8sm581e99swe4z4yoxpuc X-Rspam-User: X-HE-Tag: 1693247868-261585 X-HE-Meta: U2FsdGVkX1/NgSJ/4ZFCZpUi3ofXgtm3O8NTD81zBcSqLJz5WhBJ0/gL5W0MG1YgEx/oMFUm+w1Ua7ByVn7kDjiRMfUA2UbGC14CMR+Zu+F7eOd9/jXJdqaDqhdRyaBqOumZOsRsZQMKpEn5D+hdlP7zh01t2eI7xUDuwfd5Wfvjxp8FKpClaVY+q1P4jqI3PKXNnt3WjyLEaZoqoCcgC7ASTzFLoKn51ftQeuX6x14Plr0l0ceup1E+K1fydEwRn/P9wKm8efYBaiZN0vTd3ypjfXdvR+EpCZbqvvqOn62l5kbEmoyPvO9IGj2A2LiwXc8oyR81d8mhSZnAXUZdJCac3oc6i0OX3Zq0VjQ6xfcrbtlti/6mDtU89Cbes7itSSNzYeTMal/iS+/OupVsKKlrkiPjUGPgtI5EC70d0nnF1AbOJlW+9kEFoUHzxcpbvHUrXi1D0THX1D6W8DdN1imXaqHlMCq7E5o8SN9PBrUtMI3E7G9guH3aFsbHG7hEsOLptuR8PQJWtumAqMXpttSvMjo1uZ3rmIFk3xcHbeSjgfTZ2tYAfPbQphUNU4yOOGpu1yuMIvxTaoV1EbnhbOosbJfYStH/jx0Mc7j8VzX4kK1DBXNJluVeyo8sAry2o3v+/ZkR3dl3/YnaRNdXbG0/mu7WaDgS/qwhwIAybJH/Jo6M4zXgI0TfKFVcIHj9U2jRycI0Tb82Ze6WVTZWbUsQf/fc49hfy1WGLaRinzteoGEOOC/b2uLJ+Ea5GOv8W1G4+Ya1iTeaUTnHrFd/5uIpG3TffIzcmX0qZOnOGXoHKQiMUL+jOVyQvik7ul/aW9bSxT53H7KmXbMtJUnrOKB97EzKTfNGL6TSPoZes6vNs/1+guAx1pio1J+snVB9YQTZsx2iLTH4L3+Yh9ftdsJ+eXVagpS1oL97tUSu++Gd3ekC/HzbxZiEZYdvwmppvhZRWhyawY3n8uNAKJN iJJiZWFB YE9ThhW8shLdS8JEXMAOiMZsfRbVusGQqEoNK0W4woLwCjKIaQs3JHpPLzGpzsdeTcDPkq0z5FgZlrILbClfnSaeJlV3+zXoinSwsRmWXHmRUEsv6XjJZpzcgTC6aeGq/Cn8xCX27PB1iCwCgqVmXSF9qGAwcaC0HSdVy/AdKcZmFBwtRFEafIcIlZf1F9PaZdL4by5px0d1n0fJkoJIxhg65kCEXOBvTtUEaeJe8mO2PMQNgojDEyYcPcMZ0kPo6V/qy9VIlMPbCyPSZHDGLHdsxh9YP1rsTUmQatiO2u8hB8ziLlK4pp6TDKCBGIzmv8k1oTqnbLKmMtFJzUV9hcS7zZezAOHAH9fdwn49EmLx4sGSvy6fk+m7LTnvNlZuaqmRD74z0mcx+L+jXlbMpWEq7X06T10r6KqTF2lP+LLGrqo8ksR03A6nxyh6lH8H0H4Q89q9/cCFUALHKhktP2HKsfw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 27, 2023 at 10:57:59AM +0100, Lorenzo Stoakes wrote: > On Tue, Aug 22, 2023 at 01:54:59AM +0000, Joel Fernandes (Google) wrote: > > Move a block of memory within a memory range. Any alignment optimization > > on the source address may cause corruption. Verify using kselftest that > > it works. I have also verified with tracing that such optimization does > > not happen due to this check in can_align_down(): > > > > if (!for_stack && vma->vm_start <= addr_masked) > > return false; > > > > Signed-off-by: Joel Fernandes (Google) > > --- > > tools/testing/selftests/mm/mremap_test.c | 79 +++++++++++++++++++++++- > > 1 file changed, 78 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/mm/mremap_test.c b/tools/testing/selftests/mm/mremap_test.c > > index d7366074e2a8..f45d1abedc9c 100644 > > --- a/tools/testing/selftests/mm/mremap_test.c > > +++ b/tools/testing/selftests/mm/mremap_test.c > > @@ -23,6 +23,7 @@ > > #define VALIDATION_NO_THRESHOLD 0 /* Verify the entire region */ > > > > #define MIN(X, Y) ((X) < (Y) ? (X) : (Y)) > > +#define SIZE_MB(m) ((size_t)m * (1024 * 1024)) > > Nit in this instance since you always just use an integer, but generally > for good practice's sake - shouldn't we place m in parens e.g. (size_t)(m) > to avoid broken macro expansion? Sure, I'll do that. Thanks. > I drew a little diagram for myself and was thereby convinced this was a good test, therefore, > > Reviewed-by: Lorenzo Stoakes Thanks a lot! - Joel