From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00043C71153 for ; Mon, 28 Aug 2023 17:07:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4F5468E001A; Mon, 28 Aug 2023 13:07:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4A5CC28001C; Mon, 28 Aug 2023 13:07:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 36EB88E0029; Mon, 28 Aug 2023 13:07:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 2A5848E001A for ; Mon, 28 Aug 2023 13:07:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F0436A030B for ; Mon, 28 Aug 2023 17:07:49 +0000 (UTC) X-FDA: 81174145458.08.F522F1D Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf26.hostedemail.com (Postfix) with ESMTP id C0D3614000A for ; Mon, 28 Aug 2023 17:07:47 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qVtknFwa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=R3UkEJ5C; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693242468; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gY+yGRa61TK2BR8Nw1XPStAseZID7tr6EzNodmZtwGI=; b=17TgEKSAZfzgwU5kF12eYFjZqz7Y6XggjvyPHljR6sUKjiogrGA840oSXAEay7pZvIXKu3 EmSL8b6eLxnVnBsAYWo5Jc2pXiy3t7G4iQHIKuvw6KP9kQSM1Pddj2iSHnIZkCFSBBMbOM ndbnW57URYr31IKyhBSAGeFd/sj40lA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693242468; a=rsa-sha256; cv=none; b=splXfMWMELjaMxNARriS5Sf1BF/z+oytI/1OdHaZl2DBrM/Oa8ZLrRcX+3Hjom1RsKe/gA YaIfTSMIDTMTqu+hv7xCYiQMI+3JZzXXQWeLoT9kkLK5vtqoxmo/SvKGAoXahNCJBftGSq mpj9sWQX2xg82sHNNdNzCDxlC6fKOko= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=qVtknFwa; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=R3UkEJ5C; spf=pass (imf26.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 873FB1F37E; Mon, 28 Aug 2023 17:07:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1693242465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gY+yGRa61TK2BR8Nw1XPStAseZID7tr6EzNodmZtwGI=; b=qVtknFwaytxobpauxbbKFuuIVi6tPH4Iq6U6De70imbcWuGOxhftHNb/4FbPSlc5GK5oK7 GshsV6S1hXqpxSKPutaEa7H9BjX/0wslT8a/D4qnl6I13zhL54OxmZm3biLLUgjj3B0284 RPao+ZPH1kv8DfDq9EfFHRPOBMpXacI= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1693242465; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gY+yGRa61TK2BR8Nw1XPStAseZID7tr6EzNodmZtwGI=; b=R3UkEJ5CJtN+ADS2q+nxkKoBRTSfFifpdVN9hgBj3Kx2evg21jSoeC6uq7LeWXoMGsRfiN pZDyCc1pRe5jtEDQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6A42A139CC; Mon, 28 Aug 2023 17:07:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id scxcGWHU7GQMNQAAMHmgww (envelope-from ); Mon, 28 Aug 2023 17:07:45 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id CE101A0774; Mon, 28 Aug 2023 19:07:44 +0200 (CEST) Date: Mon, 28 Aug 2023 19:07:44 +0200 From: Jan Kara To: Christian Brauner Cc: Jan Kara , Jens Axboe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle Message-ID: <20230828170744.iifdmaw732cfiauf@quack3> References: <20230818123232.2269-1-jack@suse.cz> <20230825-hubraum-gedreht-8c5c4db9330a@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825-hubraum-gedreht-8c5c4db9330a@brauner> X-Rspamd-Queue-Id: C0D3614000A X-Rspam-User: X-Stat-Signature: ti7bmaad4313okn15ygxagqs9nmg1q6u X-Rspamd-Server: rspam03 X-HE-Tag: 1693242467-875022 X-HE-Meta: U2FsdGVkX19UBLKZeGLhD5WEoYt4Dek9OZh8XCV+jSjibxCnBVxIlp9yRQ9T28LanJS37cpDwIZj2MIKYNv/8eW3BdQa9mz2uq2xEt6FmrX0WjcIH8e8cTrul/P4AT9f44DswLNuwCuBQw9yFoCiTydyQALOLv7JPgB1PyldViI4Kc3sMj4a8Kjvq4ftIEk8UhR33FwIKyBvj0v620W9V8NSso1DvDBlID2+gIOVY0/IdrWWcubwNgXEY8zFF55zE7OduEaabu6aRDrs3eVMAVM1cPOQSYvcRXtsqngLBQuv7omVEiTNjBGm6PHsOqkMzODCAtum2fwzXCA2GafjqDGk50B9L/p+E5l0t6nOv6itx5x2mLQUs81L8YrV9VKMx0Bq8wNr71Bt33/hNzNDEfVmuJdismv2mpIIOJPdKGmejOMgyx0VlfULYlGhJFx72VMJfzJLL6GuwlaynRO9ESF68f0lycpULCXVH5gRqAwlAfTGcbSTwc1x/W5Ka/eyn0/OOdS7jwZOrQi+0q1qEDxb1kH7lFrjXqoi3hsBk8GMrCqXBHEnbVsHBqP+lGrneoqpE0ky/qa7cLaLXh4WfH2uQ0cQiBV3Au1VciEeKgavmgV/hO1yw7L14HiUFI+FFmJ/RRVlNsIPN8E9takCrZoI8mDSWjb9qJWUjesAKNDppYXullwvo6Mh/dam8s+OhvS9OqYCJmf/Amx2POnJiCDf1rLgZy2Vm0SwdJBslFHVTFNIsJoQrryZM5c71NImI8M45uvG9tKwAOX92aGgMKS7g+NxctRpXSt11mKUDHBZMCl2Xg7QYJcPFpGubkv6+ZTHXof6YYzJD9jptuplT69wrhx33LzN5GkMNOQv/4HnRf777ngJidPUDdvO/O8ueY+qjPeyP+egyh9HfAkUKSGMLn8inLt9/2o2R11fKBM+LONtfEKpOYNc0jhWeC+H2fa20IhClhrl5N5ztQa qk54quie mFFE9+RiUa1MFvqIboMRDJh3wF8LAzkUgFvuy2iQGIM/T2BwHXavmjnPIXbp2iK2zsXsMUSj4K3dDUyLnaptglH/583BIPTYsudRAkU6n3xkG+BLSjiB9bFOsK3y3REpvtjNjGn2YxJIe7EmtDn6DJZ77NyxUBgPzryEfsDLR8lVMN4KtgdVrbFTRIB43OCYMloB5kWWiEN05Y/k9h2qkTBS1E1SObDWSyNxzPw/iBnXqJlV8oVzapMDgbZr2YHnzdI2kUPkCpxvSYgMGLDQusAqW+qB7kJHfhJDiiV+0d56l4H1tJ17BiLgf7gBuVxMFXJGKflbMTmu0GULYMpRoq9mMPotPnStCkpghPNYMbpgJv652cIQNvmr+7oFBgHD4GxKV8NPFwu7rTms6uKYQBkjoCyVOaTd4WeyMYqx3B18mb3yDDMLQXikjOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri 25-08-23 15:32:47, Christian Brauner wrote: > On Wed, Aug 23, 2023 at 12:48:11PM +0200, Jan Kara wrote: > > Hello, > > > > this is a v3 of the patch series which implements the idea of blkdev_get_by_*() > > calls returning bdev_handle which is then passed to blkdev_put() [1]. This > > makes the get and put calls for bdevs more obviously matching and allows us to > > propagate context from get to put without having to modify all the users > > (again!). In particular I need to propagate used open flags to blkdev_put() to > > be able count writeable opens and add support for blocking writes to mounted > > block devices. I'll send that series separately. > > > > The series is based on Christian's vfs tree as of today as there is quite > > some overlap. Patches have passed some reasonable testing - I've tested block > > changes, md, dm, bcache, xfs, btrfs, ext4, swap. More testing or review is > > always welcome. Thanks! I've pushed out the full branch to: > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git bdev_handle > > > > to ease review / testing. Since there were not many comments for v2 and > > Christoph has acked the series I think we should start discussing how to merge > > the series. Most collisions with this series seem to happen in the filesystems > > area so VFS tree would seem as the least painful way to merge this. Jens, > > I really do like this series especially struct bdev_handle and moving > the mode bits in there. I'll happily take this. So far there have only > been minor things that can easily be fixed. Thanks. Since Al is fine with just doing a potential conversion to 'struct file' as a handle on top of this series (it will be dumb Coccinelle replacement) I think we can go ahead with the series as is. As you said there will be some conflicts in btrfs and I've learned about f2fs conflicts as well so I can rebase & repost the series on top of rc1 to make life easier for you. Honza -- Jan Kara SUSE Labs, CR