From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A1CC71153 for ; Mon, 28 Aug 2023 14:42:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6CCFB8E0021; Mon, 28 Aug 2023 10:42:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67DEC8E000E; Mon, 28 Aug 2023 10:42:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 545D7280018; Mon, 28 Aug 2023 10:42:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 423718E0020 for ; Mon, 28 Aug 2023 10:42:58 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id F37FDC045B for ; Mon, 28 Aug 2023 14:42:57 +0000 (UTC) X-FDA: 81173780394.27.D007B74 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf12.hostedemail.com (Postfix) with ESMTP id 84ABF4000A; Mon, 28 Aug 2023 14:42:54 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=gUZNSERn; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf12.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693233775; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fitMFjTe7UlzOJPHkx2hghZeQ5bjBzNc1l5zMQdyLCI=; b=wmm98VbdpzQxN+K1+fqunqJizzlHH7d2CC8vbLfT/TT7Jn2mSVpnJ92zC5HxfZuIaMMx2W EBPwdhiLOmFScDzWIzYa4I4lVOU3cdzbc2XWIgYSn9XNYePDg5AL0tayCYhRNMCRhSrgr7 Is5F8/F9dJtUoMLjT7zDq0Kil8gRgLI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=gUZNSERn; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf12.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693233775; a=rsa-sha256; cv=none; b=R+NcgRZurI38CcfypdpuxRy4cDZkAVqXhuum4xsrwsKsK84y+DL2CSUpwsU0evSCjvz6P3 A+Rto7Wt8FSbMOoHm8W+X2zHM0RXAxADks9Ve1u42jYw8xo3bJdJnGHcXLJ5inAIqXq5Xe 6Pz1Jy3gA3phbQEtYDPnUK2qsJ0kX4I= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=fitMFjTe7UlzOJPHkx2hghZeQ5bjBzNc1l5zMQdyLCI=; b=gUZNSERn182ydlMmD/JGiKZEsk OgLplGeOv9vuS9OA35h0aZ/IJvVVfJYA16NlznwAcJA1w9FpMTvQS7V139nKFCrrrZQVPptZW1Qnh NlrtaWY/AJACSI4Kt7OkQtm136BUQbytcXlI1DESQcEcKTQOF5yaAh/drfTjfw19mNNEA5xwfSgHe 0BK4iM+Zmjh56/cqY3a2K7nBtryKUbD911r9z6wCXSRIUyA/UBBwxH86i7PeNcYMilqluP9xV6Zfc W/F3EDXvuA+TnyWLXwrAAsHLhDWLLd7vBqiildb/I0VtP2zlFjxC3ArtVa0CxBf7pI91HwBNsB6yE 2vzIhf5A==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1qadRy-001a4j-36; Mon, 28 Aug 2023 14:42:43 +0000 Date: Mon, 28 Aug 2023 15:42:42 +0100 From: Al Viro To: Xueshi Hu Cc: hch@infradead.org, dan.j.williams@intel.com, vishal.l.verma@intel.com, dave.jiang@intel.com, jayalk@intworks.biz, daniel@ffwll.ch, deller@gmx.de, bcrl@kvack.org, brauner@kernel.org, jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca, miklos@szeredi.hu, mike.kravetz@oracle.com, muchun.song@linux.dev, djwong@kernel.org, willy@infradead.org, akpm@linux-foundation.org, hughd@google.com, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-mm@kvack.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH v2] fs: clean up usage of noop_dirty_folio Message-ID: <20230828144242.GZ3390869@ZenIV> References: <20230828075449.262510-1-xueshi.hu@smartx.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230828075449.262510-1-xueshi.hu@smartx.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 84ABF4000A X-Stat-Signature: 4dcz164xm1667pwke6pr3cpjtigegci9 X-Rspam-User: X-HE-Tag: 1693233774-328435 X-HE-Meta: U2FsdGVkX1/wKb4yFrmClQs1yuJhwyLtKO1W5YnmUAs0cGae57LXD4FUemSPqQwQk1sKiS+gtygg/al3v7PiaFs7fsOO9NnX9y/T/ZRgyv7f/as/NHQgHyDYBuccM4Js3F6EaryazCz6LjSt97BBgs8g1FrIybUtkcP4cSILnOE44y7VqdfbkstyWs75765Mnk/NJZZnpqVF0+C3OFLPetPqUrC4yrenvNK1lBEeo2nJZGYW3qwtm2NMT10xZdhoL1MECzMmxigInvBSndTVwJWb1OcG322vZ2nB1bDJaICGVXlfTGl+t3rE8TxbKxggb6K6x0zdp2rpOkBeqG7/KGS/NvaMP70TAcDQa5kpvad5Ac35/QGYYHSKsAFyFs8kLFmgD6LVyyEywb83lgR57J6K4Rr8j/HavBrnis5tlZxOz889iSwyDkHOGksHSU67qVE8fMgXfXvOap52G0UQMYEullDrJtL0hnryB86Q26FOmbZRdEMaBVpl2flqBY4u8Ond7A5nPJVGsZmV9xdGhgKbge8/jhhNJU/WjCqgFAq3R4RAkg6Eu12sqVKSybSFh8Y9vkHSTtx+tH36RAFmIAiiZa/IJ7fkWM3dFsarIEpgLXzf4k6VA4h9y3EO7YJ9qQH0InA75FdXQOjuwMI05aL+xuHY3qEfgFoCiHCQQryiKb01w0UgHeQj1K/vspfl7ITycEzV2xeMlUKJS0sGHRn95x1pWe2Hz5IVoxoTP4DxSjxR4mJx8qt+jV+wN6YEvRMudPrfUXnZ7vd95m3Hhj+DDgxiN4XoTGkyTskv6/IklPrZDVMm0j1TuXjSkfhuF2pi9W/bD7fG+pZsR4qy3nYV+eG5ywFfbR2G+PfyJ4jVaDqfHvu4cr/PAwPxfkBeZCQDqU0A+C7Y+/n8ipiAOX6G5J5qTFMuzDxLpqHkAh25FiXriyR6Oc3iuPS47GJbdxUw7i8xMldCHtVjM9W 5Mn4THVM GYImGP/S06EB441cr24qE1X5H9QHOuS8qwDTuTewAoQBK1BrQlwF3zBDP8tPPUV1fVkMc6//4EGKvtPO4kqdgCaZdJ/U+oUVIsSIi66+s/LeoxSYhUCFjdj77RfAti6cQ5gu5VXuyKKk8162oCRv0bqKkDBg5XuQDK3BzZRKFkGF9IePX4GjP50x7BVIT3rObSAb9LCDVytdU0k4jMQeGf2FBQa1b4gZluqprBfGHakopmzzLSh01dEZCaFn3Cw5Rydtjddl0pUHWanzcWfT1ZGUlUKt7E6dlNMWUEd6klxbFYeOzJzQ1txP77hSqCVYHIMsnhaaIg5aUv7kuOlZtPYc461wgxYCS6irhc0tFQiZF1yklBnYPaRZ8o2EVzMBwZBwOX19sv6qIiFgYfGygh8vSK3AFCZW8iyiH+OPcjjuxfmcOf03FwRB1RppdmEg5UqRfQ/vWg58ZAvsmQtnfqsNlvM791CtrN08nmYAV/Q5HVTQbiBAzwPVTQ1Hsy+ws7iVaaNZWxhGM6w8pxyC1N2APGF5r+/xZkY71I5LvHz4aDeE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.055482, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 28, 2023 at 03:54:49PM +0800, Xueshi Hu wrote: > In folio_mark_dirty(), it can automatically fallback to > noop_dirty_folio() if a_ops->dirty_folio is not registered. > > As anon_aops, dev_dax_aops and fb_deferred_io_aops becames empty, remove > them too. I'd put the last sentence as 'In dev_dax_aops and fb_deferred_io_aops replacing .dirty_folio with NULL makes them identical to default (empty_aops) and since we never compare ->a_ops pointer with either of those, we can remove them completely'. There could've been places like #define is_fb_deferred(mapping) (mapping)->a_ops == fb_deferred_io_aops and those would've been broken by that. The fact that there's nothing of that sort in the tree ought to be mentioned in commit message. Note that we *do* have places where method table comparisons are used in predicates like that, so it's not a pure theory; sure, missing that would've probably ended up with broken build, but that can easily be dependent upon the config (and that, alas, is also not a pure theory - BTDT). In this case the change is correct, fortunately... Other than that part of commit message - Acked-by: Al Viro