From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56F45C83F11 for ; Mon, 28 Aug 2023 14:15:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3E698E001F; Mon, 28 Aug 2023 10:15:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DEEA78E000E; Mon, 28 Aug 2023 10:15:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CDD238E001F; Mon, 28 Aug 2023 10:15:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id BE8DD8E000E for ; Mon, 28 Aug 2023 10:15:24 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 99B1B1A0257 for ; Mon, 28 Aug 2023 14:15:24 +0000 (UTC) X-FDA: 81173710968.13.478C387 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf23.hostedemail.com (Postfix) with ESMTP id 3B33C140029 for ; Mon, 28 Aug 2023 14:15:20 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693232121; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3JYn7thNlmLQqnkScFAD85nPybgGPBVIx1IoTQc28Jc=; b=oKHqt6YpBJVZIBrFW9O+qM1Q0ZQVvwU3mq/ycUpZHMM5lNZWWGMKOvF1rTD/DzpkVYTkmk XolC7rKsHTSI9qb67YXGM6HxFgdAprlGasoR0EPNccYBCHx3U1A6gikXN1/8AXhMxqjqMp Rj866kL8LwGEC9lEvM+0Y79Ily6Csn4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=none; spf=none (imf23.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693232121; a=rsa-sha256; cv=none; b=4MwiaBjva+XZ3mDDFNKhW50rFOjuIUTiQ0l04/uEP15tUz5N2azN3vysZXLySLG+9NiC30 3IsCllk7u7/by4z4AMrFnp2WEPoXfdPA3oLnbppkg2ErWoVSnqku2cbR+Q71Y3vetT9dKZ iqE9JEefet3jIuu5CjmuvpbALl7wW5s= Received: by verein.lst.de (Postfix, from userid 2407) id 94DCE68C7B; Mon, 28 Aug 2023 16:15:13 +0200 (CEST) Date: Mon, 28 Aug 2023 16:15:12 +0200 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Hannes Reinecke Subject: Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write Message-ID: <20230828141512.GA19883@lst.de> References: <20230601145904.1385409-1-hch@lst.de> <20230601145904.1385409-4-hch@lst.de> <20230827194122.GA325446@ZenIV> <20230827214518.GU3390869@ZenIV> <20230828123259.GB11084@lst.de> <20230828135615.GW3390869@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230828135615.GW3390869@ZenIV> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 3B33C140029 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 51rdoariwbdgx3th7hkyx83qykkx3uwx X-HE-Tag: 1693232120-534107 X-HE-Meta: U2FsdGVkX19eFueEntzA/rtwL/Myq6ekdXNCy9C/r+PJvtfwj1SWOR0shxpqHq70EJCEvKycwR+9Oh7HdLOh4hctqGoAf3cXBN/XmuzZXobL4TSwdlNaIw4QK66cKwtJJ7ej2As3qrTq8urQB0Zuey+76Ke/TxipPSq1Wahbf+EgDW9NZrBS93DokEQ6NZhJH8vWepJpOsr0+u4r7q8F2ythgYRAIKh30NiawbYRyMlVg2LNJXNm2wrE4RZlY2DVbrlx8qTDIO826GZBlAzhZT7aqD+U8YCvdD5gcUBVq/6BztKyTshwyUcWRa/wLClyQVns950WxQuVJItwVuAGQOEXA6+4hSCCY/H9TbOLJVQ9PX5C+g6k2/egbZU6tOhMMg72HSZDz1/cWFPdNnjKgBYQr3NXyI2QjCXxw9DUKlMylLiq+bD8iccmHe1lrAaW8etVxBzZ1dHcQEfJAkCjmjgPxgRMOLR04nZqV7Uz2EDbY5vE3QKooR1RJ4GdqdUe001mB+roe7usDxeGHb+eHIhre2rzfih+JjQZznNOHpuGUxWCDbP7LpoINRTJMZh+/OSCDLMW0TnOD7+1L7yTBQm8AM1KeRE1jJs7eemmXQV5kKTlSyfVOwpiidExNFa+P0lGgupAtW1TPoiAa0VH75oUAOiFaO4Zgs/Og8+T/4DTtbVbF/nGVXYVF6kaLyr6EuQQ7toEuKlJ7H0wn5gTHMXrRXVztYpKc8Yg7nY3lMC5+vmgVeWvolXW1T4hBB0yQ9Z20/VplGKlyG7Vp5gfOyP5SE+z90EyMHz2pR8KtdzHdqztpbCT/rN0wTG6i4i0AbpSge0l4SNMic0ft5Xa6cYFV6uOa2zuMHyLZuF15xCGPfyI9ErKjGo7EFQjsy52OcT/mTiLzPiIsrxYXOOunLniGH2ddLssr1Lbxf/GkqP8M5Kgdyz07bYmx7IZt+fDbefwevjJcESVbF+A0RR KhCg7efD WTSwTW0j+XQ26BrAm5CbKUBdM7mc9yL5wRnqcmfg9SivVie8fylau/ZbLNu3JplS3m6+srZ/mSp1bB1t70cWE7YBduSPJ3y/iANhx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 28, 2023 at 02:56:15PM +0100, Al Viro wrote: > The first failure exit does not need any work - the caller had not bumped > ->ki_pos; the second one (after that 'if (err < 0) {' line) does and that's > where the patch upthread adds iocb->ki_pos -= buffered_written. > > Or am I completely misparsing what you've written? No, I misread the patch. Looks good: Acked-by: Christoph Hellwig