From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1D2EC83F11 for ; Mon, 28 Aug 2023 12:33:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3456C280014; Mon, 28 Aug 2023 08:33:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CE3B280013; Mon, 28 Aug 2023 08:33:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16EEB280014; Mon, 28 Aug 2023 08:33:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 042CD280013 for ; Mon, 28 Aug 2023 08:33:07 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9B56D120216 for ; Mon, 28 Aug 2023 12:33:06 +0000 (UTC) X-FDA: 81173453172.22.E06FEB7 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf29.hostedemail.com (Postfix) with ESMTP id D932412001A for ; Mon, 28 Aug 2023 12:33:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=none; dmarc=none; spf=none (imf29.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693225985; a=rsa-sha256; cv=none; b=394YqifYhvlddybFw39OI2KESVQ9DoHrQQ88nnQa8QiO3w6PJu6M3kTmy18D07o2CSj0ag oZ/oT61ZU+/PnqeGAQjFetKnS7EEyhH73yiGDvwozSy3w/QUIYH9h+3QDZP9MMKk7V7jQ1 CaZOc+pwy4GqgnubB/itBrtvkZSlPZ0= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=none; dmarc=none; spf=none (imf29.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693225985; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AFgAO5uGx+/8pExT6wW8lT/FnP0yLewZIEyGH7Av2K0=; b=XEmnlfoSvY/OV6p1TP6m5ghGiNDBoD1SF4oz7oX9iGinrdqcjBSx5/uNkt8LV2GYLUIzLa YMhyQkn2ktwbFVwz4fyH48k8z65XQ58EEAA7II6KMZXALkSLtYP5NMh8pG1OET8IBEK2G2 uEGVBglODpp2zR9CGHsa3QLpK0Ds7K0= Received: by verein.lst.de (Postfix, from userid 2407) id 580D668AA6; Mon, 28 Aug 2023 14:33:00 +0200 (CEST) Date: Mon, 28 Aug 2023 14:32:59 +0200 From: Christoph Hellwig To: Al Viro Cc: Christoph Hellwig , Matthew Wilcox , Jens Axboe , Xiubo Li , Ilya Dryomov , Christian Brauner , Theodore Ts'o , Jaegeuk Kim , Chao Yu , Miklos Szeredi , Andreas Gruenbacher , "Darrick J. Wong" , Trond Myklebust , Anna Schumaker , Damien Le Moal , Andrew Morton , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-mm@kvack.org, Hannes Reinecke Subject: Re: [PATCH 03/12] filemap: update ki_pos in generic_perform_write Message-ID: <20230828123259.GB11084@lst.de> References: <20230601145904.1385409-1-hch@lst.de> <20230601145904.1385409-4-hch@lst.de> <20230827194122.GA325446@ZenIV> <20230827214518.GU3390869@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230827214518.GU3390869@ZenIV> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D932412001A X-Stat-Signature: oyu6mpohisg8t1azbetmbc9r4mjredga X-Rspam-User: X-HE-Tag: 1693225984-210496 X-HE-Meta: U2FsdGVkX1/bylmSpOvOuGESL+PQ+q0GMW4EDwNZR93ynr83D3P78umHXfqCLrEwL6SPeGgG4tO3nBjBcnlOVDciMkq7KlLLSXXEUtPUG9h6yDK3ifjAn1k1VJrFx+4d6E+G8jz7Yhd7HR1pung0zlNQss45SH+uICejo33aOxNKATSAhGTXWYRTVBYQDVUI7RnvluK4qgYbXJfIEBYYCi1/Pt7TN6CcsikUCQrye92BzFhKqHPu2njLlePSae1PLp8HVeg6Otj8q+1zZSjNJkEBV281+ZZP8RLVhQC9eq7Tyo3Yobf6L6tTOyFlokIR5mFapLhpoX7DyT7gsn+jlT0yUP+uxbHSBuo7KBDUIl4NGwjRFlmn+N01jTuB++edkv+vcuM+r1XxhQzU3jM9fUu9L0Qiv6/BAeFAuNyakdil/cxQapJe3TGjpz7PLLZlF4AIqocKgcwmyt47L8zjezTRvTkoz5YBf8eqFt7MJ5WVAdyKS/ldFE9zxztkpu/z4OYAbqNZh0fqzLPV3PWCzYSe8Vmstm0lx4Safq+asIsR5HasPKr0jPY/T/Lk+8AHDJcRg5Kgwt6DMTjM8suB6FErULhEtFqnv9sxh5DYIWKoPfs7Wi7P/yphTS6U4AvPY1COvT5tRG4uPIwKlG4dFmw4Yf3L1O6Tu7uj40HnBU1Z3ccIDZu/sK0U1HtK8qeazv2IAIfP8ckTErp0PTShdZ3johoaGjoDwDVl4HqB89tum8Es6eKdi4JWQqYyRD3zTLQsW4F/Fm/RSskSAQ0xoakqt2qwRA4CadPtCXtKXFQ8wCk/S/UvTTbKXRlwB4j/BrCJ6atZCiYaeje8+ldVay8Wpf/AX7AOg9zsWu4fYLZpfpwH0m4lGcKviNdtQuMpzQGiflbnKfYSH1PUnOmxol8RJFQc/b0C85Hwb9RttyKsXJD6B9aLYSTy4QNvO7Ozt7E3Q+9ulYMaNsWqbyh JWT7pyEC 92XNe+iRkQVvA4tan9M3vesxNH97vNARkNXKXV6fMkNjdt8dJDgP6Jg8/COs3KFVLOU+flwH5xKEGsyHoREZgs2kJLhMxxcaK+vusMZUuPlL92Kg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 27, 2023 at 10:45:18PM +0100, Al Viro wrote: > IOW, I suspect that the right thing to do would be something along the lines > of The idea looks sensible to me, but we'll also need to do it for the filemap_write_and_wait_range failure case.