From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FBB7C83F11 for ; Mon, 28 Aug 2023 18:45:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 95F1228001C; Mon, 28 Aug 2023 14:45:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 90F368E0029; Mon, 28 Aug 2023 14:45:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7D69928001C; Mon, 28 Aug 2023 14:45:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6C2448E0029 for ; Mon, 28 Aug 2023 14:45:16 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3D19540354 for ; Mon, 28 Aug 2023 18:45:16 +0000 (UTC) X-FDA: 81174391032.16.322CF7F Received: from mail-pf1-f182.google.com (mail-pf1-f182.google.com [209.85.210.182]) by imf07.hostedemail.com (Postfix) with ESMTP id 5D8694000D for ; Mon, 28 Aug 2023 18:45:14 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="RIEOp/wO"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf07.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693248314; a=rsa-sha256; cv=none; b=xYrOnasP/2RDASjMeP32h+WlmUSvt3avQ9g5jdFhSAseQTkY7MrihpcYhdRXenfoHWjMad RHCxWCTOc/Dh0j1zunZB6rVZF2RCPZ/TjAippucLUxl3GlxRd8odo8GkJFKDkMBwhmFzw1 xorO3eQy2yDL0DNExjgRtf5vh+eS4P4= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="RIEOp/wO"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf07.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.182 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693248314; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=a9FmJgU29HqgZJibCVuOZN9LKZYzqMQxeDDjAb+fuvE=; b=OR/Qu1L0FvOgUjjjZniq4MDhulYKI+f5qTHs0r2oTAvoROed3EbVSxpLAVPPUDJi5kZycg JbvWicNJ+0G86otydk5BwtipaH+4uKCTTbrzF/8JpwiWhpwOpNalXq0yj+k5Fsg9c6ZRp7 j/9nLaYSogsRLegSOMOg9yiYAYPeVn4= Received: by mail-pf1-f182.google.com with SMTP id d2e1a72fcca58-68a402c1fcdso2401124b3a.1 for ; Mon, 28 Aug 2023 11:45:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693248313; x=1693853113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=a9FmJgU29HqgZJibCVuOZN9LKZYzqMQxeDDjAb+fuvE=; b=RIEOp/wOdBXAue03fFc5wfbeo3NhauXVPmOHkinrJCWMDd2m8pKPMpw26obXrQyh3O WVGw1FQIwDT+mev4AIuu400qB50T3C1uvVgiNld7OtHf9xdHjLEG5rOczt1HXmETZmGT RRP8NJHKBolMc/M285awaYl7mVl6epN0yDXVM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693248313; x=1693853113; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=a9FmJgU29HqgZJibCVuOZN9LKZYzqMQxeDDjAb+fuvE=; b=XVFoJoYcwqtySOBNCNyLpIli3NbnX5ZMpVuHCBOujYCHGZdFzAMxcmrqd3dmfKcVHm i6wo9QcfoEzZfMp6MA38G9id56LWpFBH0VqS3M6qH1YREJEH7VWqxI0Qy0slx6qdlAem HSS2I477nsxkSNp/jeLBsSvNUMDVVkI4xZKyE4BuV5ecWKgbm4XeydyJBlpAN8SWXCf+ vz/Exjyf3uIDWYdkHtfErUEsV5T4udpy0L2MrlbqHDcgmboXGFOKMVvjPMUzg/RT7ZF7 iPAt+7X2a31nayO64XkJtHObdp3xlzgAHgklKem57IxQ9BYsURRTflAKdNwqMzqlD5UV cu7A== X-Gm-Message-State: AOJu0Yy1IG4DWrUAvxfXl1nt72pYh7gbDA5tYAsKfcCuhGtFxItLc8Hb vNi5lmJZW/7cg6EEJigpESfxXA== X-Google-Smtp-Source: AGHT+IEz5SxwDArL+Cob6j1IF+IMKwlhxa0KqGnQdRBQcSpyhkxXh47si5beEg0McuWEyhnJCrZxHg== X-Received: by 2002:a05:6a21:3290:b0:14c:e8d4:fb3e with SMTP id yt16-20020a056a21329000b0014ce8d4fb3emr5455874pzb.43.1693248313126; Mon, 28 Aug 2023 11:45:13 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j5-20020aa783c5000000b0064d47cd116esm6978854pfn.161.2023.08.28.11.45.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 11:45:12 -0700 (PDT) Date: Mon, 28 Aug 2023 11:45:11 -0700 From: Kees Cook To: Florent Revest Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com, ayush.jain3@amd.com Subject: Re: [PATCH v4 3/6] kselftest: vm: Check errnos in mdwe_test Message-ID: <202308281145.D3C859D@keescook> References: <20230828150858.393570-1-revest@chromium.org> <20230828150858.393570-4-revest@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230828150858.393570-4-revest@chromium.org> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5D8694000D X-Stat-Signature: coonoi3uab59emdwcj5fhayymuwszed4 X-HE-Tag: 1693248314-228215 X-HE-Meta: U2FsdGVkX1/s5p+c6iqLGUzOelf2dPV+xw2vBFwC1c5gi8FmMuaYTXZd9CmSWw0jskGjyY9VKuDdZOmxTs8Gl3YMCONKi8u/fZyNxdxxs4FYF3LaW4c0j9QVK0YOLKiWqjN9ugiFM2aKUGWQmTEFxpnNBZCrJLYtCzQT7+S57YkKwT8BtOReRFS8rnCVApaoNvIkYwRSE54t6jtzcd8ZbrQp/2YTY2FjtCHL58aTpUbFX1xdVpgMlMIMd/mX4w5v9OssgN760SY1HPO2Wl9yYmQ8/UJOZKWnHq2RyuANRxmEIv1v9F0xvsFn5bsFhgAIvAhwMpMhVkCiJe8ltGrebXqUTpeWaGIrHMt0yH3Nv01ZRM/9zajzlKNnXlc9LdZucqcLLXppuZGYK0qvyLtZPTXP8hiFJraXCHCiVzRFVJC3PTxm7Xep266c14w3u3WH2ETed8V+LuBSpWCCt1iESf2rk9PDxqqnvM+Znd1O4vsLzVJyU1NLsxuoJj0jIDUXAHtrWTORRZcMk7DG8/Uiejve75pYk/1ET7Et/D6XlPa7MOQRkS6hXTKDfuENyiRip3a+ru/uvCwKKHmgk0EUd6BI1VQ2INVTKcFcXO8cRMsdEeVJqsoowUssPBF4WHGk4LwpyR6K1C0RSTad2Max3FzrdcblRHv066XFKjhKuXinPm0jBhOksZcxXQMLnkoXFjHgI63u8NL+ORnszyiaMulAIJfoVMFLZ01/MIP3pXZXkUje2xhLsOeFSTTgvz9PrijXj8FbXkxE7vq5SP0OThg4TZcjb4SB5weRFhL9lkxQTBppM6Q//AgEbQQGoun0Ck/Z3nS8QNSik5p2ynM+/MgXRpMV1xlVi5gSHaWVk/vFJQR9QwdDDlXRrhfhP0Yk1ShSKsrrVUHLEOpoGyrcwQIwHO+it0V29mNSlOB0ci5NEOI1mKY6CsGokRBCAkbIYrrPSJ2fQHr/JNoFdYe RsDqOf20 qJBzlR5nW5s2ww19xJPU/mEpQ3adqDCibiIq8UgcusHSIsZSdoFuLzRqrZ864nWZh7zjwMTdrHa/D4VwErPfaYrg8hooLxAFTO/pFwYQDTEWJk7yP0LGQRMUMi6kYhl3FXI9iQqRpHGbBtgsWi7bZd2MiKbPwLdutU3ugD9XfkFYRDLVVTwubJ7Ht+xYVfbSkgUkDTiydyCwizWPumtDP7/acfUcCUR4txRRSS66LjinmIRy+cZ1qUzb6uyLCdrxddMO4OB+sL/2iJeublC1O856ayKg0Cp1b5WJJPGKzjr1et9wJ++bYXPzjKTsBcu8FaBDCIQ+T9wQXmTwD+C7F29MD2cGs/jxiTQtA5C9ndOl+bNWD/7EKPSct7eYhUh4OGSAtAmwtsoUBb4cTwS+ViDLMMgFR71Z8beA3X23RayqbGseMbtObuBbXaHAr+v/CFge1AK5arYiSef8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 28, 2023 at 05:08:55PM +0200, Florent Revest wrote: > Invalid prctls return a negative code and set errno. It's good practice > to check that errno is set as expected. > > Signed-off-by: Florent Revest Thanks! Reviewed-by: Kees Cook -- Kees Cook