From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4305BC83F11 for ; Mon, 28 Aug 2023 18:45:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8EAA2280026; Mon, 28 Aug 2023 14:45:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 89AA98E0029; Mon, 28 Aug 2023 14:45:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76327280026; Mon, 28 Aug 2023 14:45:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 593238E0029 for ; Mon, 28 Aug 2023 14:45:47 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 284AE1C966E for ; Mon, 28 Aug 2023 18:45:47 +0000 (UTC) X-FDA: 81174392334.05.79A79A5 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by imf06.hostedemail.com (Postfix) with ESMTP id 36A0F180014 for ; Mon, 28 Aug 2023 18:45:44 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PtVDUpna; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693248345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=l5qslD60JD6KLOV4CQIfjlboyQ+Y8tlju0WfnPmgJqI=; b=64HDeqDk8Lzy/Wd5R7SYXs7rpQJHv75Do1pD5BmtmuLdQdqaybz/SVnMpT8OFIUWKwDlZb FW06y6tQBbksvjgte4VxJX8cTRr+KDSeuW2ykUU+muEAziXYn5p02dMcUSX1DCi4P+8DxG MEN7DmBKqRQPf3nrHOhIK7NPnO6SuJI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=PtVDUpna; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf06.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693248345; a=rsa-sha256; cv=none; b=sZqNXpGNO0g0NRS1/w7UnyR+QAVv4rHGeEru17ebjyZ6yCfAqhGCTLFWLI2OsbRDOlHf6g dSh5I0MrcdvvnPb9F3v+8H7gwOBcUZdwJIVsCIcbpRgQ7ec2cDjJQ3JD334un4i/ry31Zg lmI2wFDrpNc287RB88txk7LPmjBndQ0= Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-68bec3a1c0fso2484827b3a.1 for ; Mon, 28 Aug 2023 11:45:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693248344; x=1693853144; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=l5qslD60JD6KLOV4CQIfjlboyQ+Y8tlju0WfnPmgJqI=; b=PtVDUpnaFkIsNT/B082DAe0srHqs05yHezYhN4SbovBY9s95E5Lvqy6jKZB75q7+/p FT5wV/0ifBG4UkwZaCRXqGppgqbyOaKn63hkGY4zein/yMJDNeCM88TntuHNV2ns4pFT gKAyj40UiujO2i4v+INYGzXuH12Cpo4p1w/eM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693248344; x=1693853144; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=l5qslD60JD6KLOV4CQIfjlboyQ+Y8tlju0WfnPmgJqI=; b=d2ck7pTZXBBNWAOCUxuY2UNf5w9QRDuzSgut48OOG4FhXRnBU0j8YXrZUzUw2y93HI nEoaRnrL7L9SrRannb/tLZva3uxPJTyqyLQ+838DlfIi36jyY5hKIJLpKjC5go8j8W0K DtCwp8b6NllWTAnEiE30w5hDEvgnECgWYsV/DdQGsHo6kjY0y3Nl/rJ/sXIkKEDnt1St pcNZxd0AMg8dmP+/MdyAOptuEs7bE8FB8B6ee4b3EX33V5xqvlfyeP3wV43wozeIMUA+ 8qchAkQmNdC8BLrA+15K9kAi4RgnSYHLGO2KCuaPXw//9MIkI9O1puW6Rt1MAMfZmQJ3 GjWg== X-Gm-Message-State: AOJu0YxJzf/QY0m+Q2OU7Ku4OsfTi5BTXfr0OVgy/9Ea6Fr9VBhI1HSN iBUGVFwfEggAGnH+QZDP993ykA== X-Google-Smtp-Source: AGHT+IHvRKHA/GEAGdRc0GFMALbV74qompHMrn9Pd4DMWxpSSTAYLhaSNqnHVHthOf+gQ/mKOYR/5Q== X-Received: by 2002:a05:6a20:c901:b0:149:812c:76f with SMTP id gx1-20020a056a20c90100b00149812c076fmr15416452pzb.47.1693248343927; Mon, 28 Aug 2023 11:45:43 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j5-20020aa783c5000000b0066684d8115bsm7219213pfn.178.2023.08.28.11.45.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Aug 2023 11:45:43 -0700 (PDT) Date: Mon, 28 Aug 2023 11:45:42 -0700 From: Kees Cook To: Florent Revest Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com, ayush.jain3@amd.com Subject: Re: [PATCH v4 6/6] kselftest: vm: Add tests for no-inherit memory-deny-write-execute Message-ID: <202308281145.4006BC6@keescook> References: <20230828150858.393570-1-revest@chromium.org> <20230828150858.393570-7-revest@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230828150858.393570-7-revest@chromium.org> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 36A0F180014 X-Stat-Signature: 35mynpdknozdp9fgt7fn46pdckc97m9x X-HE-Tag: 1693248344-539589 X-HE-Meta: U2FsdGVkX1+YkH+d+A4JH8E+B6h4C8qlGkXIvjhV6vwGPEdrW4KerAKuf32vHbJNPJeeQImoZnfEXriclNOtNuf52xlpYLyWy+CLYOPiySomR97MxB+qGmsU8xubTgqVJmaMPOy9lNjG7c0Y0HERAjQgurpuQsGNiELyQXGRTj9/eI2u+Yzje9OejqXTXy7wGA7+A0i6YepC0pGAfjdNzJIGNGzbTM4KrR7YHUP5XD9FVOD9LdPac/uFs1kOos8+WD2sHBGxvG2nxDN+hv4YsQQaiAS/jNjqrLW2okAjmWkBKYxmywG0bLGvfYlD49xGRFryyqj+tSGtCGUmfSM2Hc6UDvc85359p1AuDtMhYxRGujA930GwVysPoSbctMA6qkzVfA/o+NykzTj6Zzet54EWrxvoH9XXRZXbaE7dp062YNjdwntGivf5sGFuboUQ19X3nn3J7SS2a4AnRvZm7ImAkkK+1EFWTFfoVo1S4g+Ak5OdyRACgDbyNZhTrB5wxtg6+L4qrJW5n+aRNtvDLhoTzkYHGDmzc01iSGOkO3Sv0I3xzATJ2xLkfOVh1iZ5/1GeHRzVNWNY+wpbOouO8lvBp3VRL3SVyd/JOOM6mbVu5CnLljldIqDwxhdoF/VtNKwo21K/a97/l+ahNDrTnAR0ggyEM94n02Zxxx+835TQOUkirSQ3218VEAzUZ45WwkDM9Bhh5rJJDkOLNsCLm8YPb2Nf35V2FM524oRjE4InVbatFQ6/07HzYGikKbXFa/A+12q8ZVWk8ISzxCI79jJ4Nw+8Y77BkMOFYytj6DDx3hAjmF60NCcRjuWy3gwtFQ83LY0JqVk4HxYFb9AZ/VmmJuZQENScHoArXrtICqtqE67Bo9bPneuZQ9gZlUqwLyQbqi5zI7KpJa72G4wfYhaBqRwYPHOBCxvJGaqXG9gh159A2ADlxJhRV5OKynw0X9o7xyCvLhKgjxdsp7M eVyBJ7tV 31dd4rkDIM4//3VPLnhFax++vyF7Vmcb7cLRNWgliBcxMlxhMoUJsbhlgs8jhsErgYF0PLdh4+p93bMn4pb82DjdOloY+l0WM2wyiBJdHJL+762ZrndU0P9LyJSvtDIax2tara2jHSSa7fqK4C69/GkujpsAByjp5zF6ju2t0GCLQc8E6WvTM0LuWhvTTucJI9aOuQRHkgR4GII5MIU5GcokS/oHYv/8HIv3WfsyCP+aNTcFTJ1uVBAFsyN+4tBB2X56/XhI0+jgSHbLyuoc2e8SdYmtyLfPA5g7DtB+nbEXQe0kUD86I/y+T1JvTmOL3gE8bwaZ8O2df8Ilnf6gdxEq0FTNwUjsedwwukfWmE7K31susP5MDT1dD6JL3woTkxrk65fEZs1TbqVc8mK2AAjS86xzfzE0YxO9Sw5yuIPvggmcxY+M3De0PIQQcwK8HPaDrphSYJizjfgtdeSrXkjZDpyghJlHA/pnt X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 28, 2023 at 05:08:58PM +0200, Florent Revest wrote: > Add some tests to cover the new PR_MDWE_NO_INHERIT flag of the > PR_SET_MDWE prctl. > > Check that: > - it can't be set without PR_SET_MDWE > - MDWE flags can't be unset > - when set, PR_SET_MDWE doesn't propagate to children > > Acked-by: Catalin Marinas > Signed-off-by: Florent Revest Looks good! Reviewed-by: Kees Cook -- Kees Cook