From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB9ACC83F12 for ; Mon, 28 Aug 2023 07:48:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5180D280016; Mon, 28 Aug 2023 03:48:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4C735280014; Mon, 28 Aug 2023 03:48:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B605280016; Mon, 28 Aug 2023 03:48:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 295A7280014 for ; Mon, 28 Aug 2023 03:48:06 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 0156EC02DD for ; Mon, 28 Aug 2023 07:48:05 +0000 (UTC) X-FDA: 81172734972.17.AE7AC98 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id 5748040012 for ; Mon, 28 Aug 2023 07:48:04 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nkkvo6ka; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693208884; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=j7Y1y36U+iIwHAqj9IBypLxk8ptPyz+oYc/I3WfKNUM=; b=jsg6jbg7Lv7xZAt53KYzSxJOPs+7dX9/j+TDnX+rTMIcEWYWhyDbhak6mzW4169qfMNBF3 WlyAvxM9rWQQ7db0lhBFtgMHQ9itw3fFHm+D3wLxwioV6n+xQVhpph3AGs4gMxTeHEgmQG bzXNSep5w8qiOWn3xm24Txnmp9+bOsU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693208884; a=rsa-sha256; cv=none; b=67uheVTLByBwRd0/o42N71Ee2YZ2xVzOn3D7AzBzLLk+LXGB+ZbUNQ+pB7+g6SDuCQm4Py RapIMt6uxqAgvc9gWqpJwmCvg2LNiByXKC4kHH4ii6Qy3kL0WlZNEdj6afd/V0ZZpZSlsw IgK/14C65/4ZbznYHeeKDLUuNWmsNEQ= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Nkkvo6ka; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 45FA66009F; Mon, 28 Aug 2023 07:48:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8FA7C433C9; Mon, 28 Aug 2023 07:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693208882; bh=CFNiuixnb3UYTeuKjM3Rt3BAiDuLmUsszcQ+qqgsBa4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Nkkvo6kaqwdfZYBHZaowW7k4gkQpMKWajPDj6R8aWMQPxZuFKru2HpZflXqXJ5Hzh P15Z6c8TFZ6KKMlWYbPPvjxbbqDIqXk/m5O16S01HOrCRiCxpv3J2KV+XrDA5CvfcP iJJXnBepDYMe0yGnpwVbJDbafVKwfHybH61cJjUlBozUlkzTgwqrWcM88kMcZu3kOM KpK4bsGCVK5DY2Vn39dUkZ8YAhn1WxZjjKjKcdjkQ0ZmoCndjQpq2MW1Qr+DbyOHmr 36fkCyXJ2KPjOpD3193v/wCZ5HcaJBmMDFXvdlGpBz1BmamrJTlpsrPzvzEeLfwQm9 gv9IXuZwUfZiQ== Date: Mon, 28 Aug 2023 10:47:29 +0300 From: Mike Rapoport To: Usama Arif Cc: linux-mm@kvack.org, muchun.song@linux.dev, mike.kravetz@oracle.com, linux-kernel@vger.kernel.org, songmuchun@bytedance.com, fam.zheng@bytedance.com, liangma@liangbit.com, punit.agrawal@bytedance.com Subject: Re: [v3 3/4] memblock: introduce MEMBLOCK_RSRV_NOINIT_VMEMMAP flag Message-ID: <20230828074729.GC3223@kernel.org> References: <20230825111836.1715308-1-usama.arif@bytedance.com> <20230825111836.1715308-4-usama.arif@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825111836.1715308-4-usama.arif@bytedance.com> X-Rspamd-Queue-Id: 5748040012 X-Rspam-User: X-Stat-Signature: 4cdizdez1t6w7ikjbmiziumdyaype3ew X-Rspamd-Server: rspam03 X-HE-Tag: 1693208884-173514 X-HE-Meta: U2FsdGVkX1/7vcFZ8YC/Fkb5WWMlqwa4am475fJ2ojMzuUJtB8/FDXcpvf7pSMkMsfw7n06igF94GZlEVHSkPqTLZa/0YAUZpNB+OXk8WrJSyXVmu2Dfq0itC7ESv29OJDwA5i/U7lv26ZndWqQY7JFvKuiAjfcZIrFaO+7e+31MjXDeGgY8ODnkLdxm08ifv9Gu0zlcB44POQ/Lcrtwc1rrJTbuhidRnJO7s7EQ/kCH6eCukuXn1+Km0Y0DmuCeuNwnoO0vu9WdlJ9fYrJiIjUK0EFHE6cckgL9YmEzZcOX/Db6cNME5TYtCXI+dSQQ3ZJyvZkxO0M6z0UZ/NaEoLCzb2hXSvQGys3IUuzFztJ1gqTuIdTZmNemQ9cydcHfOraTadMx+4jcE/uNpIgCiIpHbUtiTyuhSqwLUcnXW7u7QxFaQ1h0tysKz2VHVXQatjpo0NSOfsKawG73/CjpNs9rSqMBbGiwE1RRQm1ohABE+4NjcwROhfj6mQ+PS0+CTaiktbBQOQAPVKaSlLV3Glgt6JTgVuNjI/NpiNHzk8CirIxm6vM5PCJiTYRQFlzeEZ9HX+kG8jFaaCKq7h/LK9fkEwpeRwHfDUeRQuHyOA0CNW7s+4PiRDtlXy8m6eQg0hn7TiZOOmzCtbRBUAt96mtRJAJpe8X1uTmyLQv1PZwaye3mYG80b+Vg0Ya1wny2zCLbK2N0WaEEPOzaGScbFHuraW0azDhYqsUE9mCiI/XwmX6HzK8pUMntAh7fMxXF4kQGXVOirFjAQTEco1VoGKVTaxn+t7eKWdts68lfe2qJIz0FMhV5iD6XGOW5LRp220kQErTdlY2qAQ/wX+j3gTlVO4/5KGfyXELRDhqjDPcwBV0ZmDl9HUIZQOhSjgfoD68J6iSr7hFG4C82MxYU87Yq/305mmld6FI5/yBCi49m5ZUCq2ND2VsSLLFAPuRd3VotuXgG4vLhRyIjLIz QLai62Pf vB2moAV4Lh1azCGuwt6pzwm6t36h2hbZYRYo9Tl/Ms+z30DP5vzFlguiQruFDIMRVZ4IMiyCuUWzfHQkwB8tCZm5mgP6Yl8gyogNEGqRmcsupwsqyFnWaZnkfd1/PQ/jFBJXdDxvbGCViTouNez0Pahno9D2BbNgGoKscPd2FnDeHhnN2eoflcpWJEmSjBczF5a1nP6T0oPHbvSWmfJWbLSxU/RhUJ9AoLlBoI5SIR4XOjdMmQm+nVr3kgdr2PWyZMdLPiEC20ODoh46Hod/B3LaxcFvN2TjhxnJzjm6Gr+znrBpTzQSYDl7/vglmrCeCqpXsMyng2ZELOzLKTFsu5uM6gz04bXFQVQ//4zLmfggnw0FIpYZFfocZHkWbXINyi5TG4UYD3whkOds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 25, 2023 at 12:18:35PM +0100, Usama Arif wrote: > For reserved memory regions marked with this flag, > reserve_bootmem_region is not called during memmap_init_reserved_pages. > This can be used to avoid struct page initialization for > regions which won't need them, for e.g. hugepages with > HVO enabled. > > Signed-off-by: Usama Arif > --- > include/linux/memblock.h | 10 ++++++++++ > mm/memblock.c | 32 +++++++++++++++++++++++++++----- > 2 files changed, 37 insertions(+), 5 deletions(-) > > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index f71ff9f0ec81..6d681d053880 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -40,6 +40,8 @@ extern unsigned long long max_possible_pfn; > * via a driver, and never indicated in the firmware-provided memory map as > * system RAM. This corresponds to IORESOURCE_SYSRAM_DRIVER_MANAGED in the > * kernel resource tree. > + * @MEMBLOCK_RSRV_NOINIT_VMEMMAP: memory region for which struct pages are > + * not initialized (only for reserved regions). > */ > enum memblock_flags { > MEMBLOCK_NONE = 0x0, /* No special request */ > @@ -47,6 +49,8 @@ enum memblock_flags { > MEMBLOCK_MIRROR = 0x2, /* mirrored region */ > MEMBLOCK_NOMAP = 0x4, /* don't add to kernel direct mapping */ > MEMBLOCK_DRIVER_MANAGED = 0x8, /* always detected via a driver */ > + /* don't initialize struct pages associated with this reserver memory block */ > + MEMBLOCK_RSRV_NOINIT_VMEMMAP = 0x10, The flag means that struct page shouldn't be initialized, it may be used not only by vmemmap optimizations. Please drop _VMEMMAP. And I agree with Muchun's remarks about the comments. > }; > > /** > @@ -125,6 +129,7 @@ int memblock_clear_hotplug(phys_addr_t base, phys_addr_t size); > int memblock_mark_mirror(phys_addr_t base, phys_addr_t size); > int memblock_mark_nomap(phys_addr_t base, phys_addr_t size); > int memblock_clear_nomap(phys_addr_t base, phys_addr_t size); > +int memblock_reserved_mark_noinit_vmemmap(phys_addr_t base, phys_addr_t size); memblock does not care about vmemmap, please drop _vmemmap here and below as well. > void memblock_free_all(void); > void memblock_free(void *ptr, size_t size); > @@ -259,6 +264,11 @@ static inline bool memblock_is_nomap(struct memblock_region *m) > return m->flags & MEMBLOCK_NOMAP; > } > > +static inline bool memblock_is_noinit_vmemmap(struct memblock_region *m) memblock_is_reserved_noinit please. > +{ > + return m->flags & MEMBLOCK_RSRV_NOINIT_VMEMMAP; > +} > + > static inline bool memblock_is_driver_managed(struct memblock_region *m) > { > return m->flags & MEMBLOCK_DRIVER_MANAGED; > diff --git a/mm/memblock.c b/mm/memblock.c > index 43cb4404d94c..a9782228c840 100644 > --- a/mm/memblock.c > +++ b/mm/memblock.c > @@ -991,6 +991,23 @@ int __init_memblock memblock_clear_nomap(phys_addr_t base, phys_addr_t size) > return memblock_setclr_flag(&memblock.memory, base, size, 0, MEMBLOCK_NOMAP); > } > > +/** > + * memblock_reserved_mark_noinit_vmemmap - Mark a reserved memory region with flag > + * MEMBLOCK_RSRV_NOINIT_VMEMMAP. this should be about what marking RSRV_NOINIT does, not what flag it uses > + * @base: the base phys addr of the region > + * @size: the size of the region > + * > + * struct pages will not be initialized for reserved memory regions marked with > + * %MEMBLOCK_RSRV_NOINIT_VMEMMAP. > + * > + * Return: 0 on success, -errno on failure. > + */ > +int __init_memblock memblock_reserved_mark_noinit_vmemmap(phys_addr_t base, phys_addr_t size) > +{ > + return memblock_setclr_flag(&memblock.reserved, base, size, 1, > + MEMBLOCK_RSRV_NOINIT_VMEMMAP); > +} > + > static bool should_skip_region(struct memblock_type *type, > struct memblock_region *m, > int nid, int flags) > @@ -2107,13 +2124,18 @@ static void __init memmap_init_reserved_pages(void) > memblock_set_node(start, end, &memblock.reserved, nid); > } > > - /* initialize struct pages for the reserved regions */ > + /* > + * initialize struct pages for reserved regions that don't have > + * the MEMBLOCK_RSRV_NOINIT_VMEMMAP flag set > + */ > for_each_reserved_mem_region(region) { > - nid = memblock_get_region_node(region); > - start = region->base; > - end = start + region->size; > + if (!memblock_is_noinit_vmemmap(region)) { > + nid = memblock_get_region_node(region); > + start = region->base; > + end = start + region->size; > > - reserve_bootmem_region(start, end, nid); > + reserve_bootmem_region(start, end, nid); > + } > } > } > > -- > 2.25.1 > -- Sincerely yours, Mike.