From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE679C83F12 for ; Mon, 28 Aug 2023 13:21:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E7568E0018; Mon, 28 Aug 2023 09:21:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0978D8E000E; Mon, 28 Aug 2023 09:21:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EC8968E0018; Mon, 28 Aug 2023 09:21:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id DE5218E000E for ; Mon, 28 Aug 2023 09:21:08 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id ABC7716045C for ; Mon, 28 Aug 2023 13:21:08 +0000 (UTC) X-FDA: 81173574216.13.865A3CB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id 15E961C0019 for ; Mon, 28 Aug 2023 13:21:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dGzUUvJG; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693228866; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QtirhpZ6M4wRBs0PcZuQKaZInNnIQCord7zI9oR3eYc=; b=Tgp3RigfIf550bZJ/Z0jIjqEkAVcZ98miM0Z+RGG9u9/Lir6uikLgS/7vSu55RtClfdmEe GqBV88MaNpF6pWB8NXixinlwVHgXFCTWUpmfkhwPSFbn3UJFUh2f/7XL8ljfN2MsJrMjJ4 jMbrJVru3EaPFY5Z+mxdBvEWWqnX+oM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693228866; a=rsa-sha256; cv=none; b=5jo+iodnPlfVW9hNwgM4858JxqufxMDGph1TJR6wi9QQzSA1mgV3IbKTuVzo5dH/QtXZu2 OhUM+X8GTWfwaAELT0ougqd+j7VjWEsk9CObPVgjYvqL9nqe8QBZD9kjQe54T3ijRWq7Wk EdDF2tyAiAqQ5ipcuW9yBMWv43ig0GM= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dGzUUvJG; spf=pass (imf21.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1E9A96187E; Mon, 28 Aug 2023 13:21:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6569C433C8; Mon, 28 Aug 2023 13:20:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1693228864; bh=QtirhpZ6M4wRBs0PcZuQKaZInNnIQCord7zI9oR3eYc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dGzUUvJG87+eWzsz6xzROYCBNDl7W5LTOJNZSdrdj6kC4UZhu/D9tYCBTY1kzrQPe x7WILXB1VLYusnI7i57xbkDNp7AlezoIITxDEYtPZbpKeaRaDjmpnSpx19pqxTzCO1 eHWv5jG6Kk405k0HzfGlQ5FnGrphH6RQF/qbsChQZpHtUi1E5k/RJY2W8E0veW1Pw4 WmlHIAC8kSpEcFeEGWLjHX2ee4G742ubGUZGwha6A7RHD325wN5SUYbEQ3omUMFDG/ CM1aA/cNlMXqkEYlHa/Phek8pvPKy4SQPmUA3IhuobWAQwG6yFUbEhG6jgGYrQO+H2 J9dq9/E4F2ZeQ== Date: Mon, 28 Aug 2023 15:20:47 +0200 From: Christian Brauner To: Jan Kara Cc: Al Viro , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org, Jens Axboe Subject: Re: [PATCH v2 0/29] block: Make blkdev_get_by_*() return handle Message-ID: <20230828-durften-hauswand-67319ee0c17c@brauner> References: <20230810171429.31759-1-jack@suse.cz> <20230825015843.GB95084@ZenIV> <20230825134756.o3wpq6bogndukn53@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230825134756.o3wpq6bogndukn53@quack3> X-Rspamd-Queue-Id: 15E961C0019 X-Rspam-User: X-Stat-Signature: 8fhr8ztw6g7pxc4zhzu7bstswpx7de7k X-Rspamd-Server: rspam03 X-HE-Tag: 1693228865-501193 X-HE-Meta: U2FsdGVkX18yg3nYlUvG19jvwSiewd9e6sRQBs9BW+CT/NwQXMVcJSMkUeg73jy8NMM/v4GLMWT+KasAi13W6UyPFt4TxUE/hivjkJ/MH6W8Tp3NCxUUGQRdAyJ3qi95l2kwm3pp5V5o4OAHBVmLMni+Fx7Jqxf0GUi78h/kt4CtNbKM2YXRXCcHderxyQl/URFJm4MIG48jbDFBv+SCnMKpBISuZBoZM7+dUagZZgXjW4f/6WJ7iDswdPRYaySlrlXi97Fa7ZT31wDW/24gyqPv9uWZMXwEy2d5tfDlRjIQ64KQV+OVM/yCtb7dBsQsatU7/bxRp85qgDlxHljqtw62+E3sG2g1z96qEmu2ktzJE993GUla/5eTPgScdaiHeIR/8MDJhzAAjFQxyBfDlPxQUXTCIeivZxcTvKv9svcOHmrq25c62Bk5wrPyFYSp4Zg4e9LUY20W+V0gK9/h2G777zBLB5HHhxB97hxQrl/g/LM8npGoYANTLvvnZKXX+w4QqoXDkNjiG1q3oSDVa5ntGWRZrRhWm3/XBRrkO3xj6Ed24EjaeFTCGVfjL+kj4KG6M9DP7lm8q2q8+oWrydUoy/mlRXKubBLX3NOv1nxMEuYm7xK8z2k9HdPT08vPh4+uxunKH3pbx917aVZLiOx0ZFfQrxEdSI9TTSJU1ZdqHJlIuy6tbGsM5iHyJ/Fq1ZCKaXZAWN5XWVXJNProW+OjW4nIH5aVXrX/bk3uuoeuxiFhhjQ2T3869QARxG3w8b/BFoJPFOFZFDJX8jN9xr9H4o5TJDzkHrIEQOPjh3LFlPCMOG8BFFU/ipukDkqvHKMKMyVyP2b6Sso/X4oPuzHqa+WTRfo1U9azzHris9bwnZl5j5bJPEDt7WnDSp4sUJNZ5EaAuq9EgcXLmDh9Ldx79eRhjTzo4GFrf8DZXr2JItxUcXfxWJjalgH32CM7wGQqPu7YpM+wutiKXZX nH1Fvd35 QMLCQjM9codKsPQHZMV+37NLxyzmKKNEIiLCX4nIMShX3cHMvHY84iZkcBgQA5FKlTYcWJDUa9EjIXBXMaF1/gm9r0dgHkt7NX+f3rgMQj0AV8ryEZ9nT9AS8/pHxnQUUMXzFSOi8dmlcW/f4crdntE3ah/MqLCLk6b1vexWOO0cn9nOb7L09+SVVXZGIQRRYfcbYMpPodn9sdpYcqrQLzg60/MeXybD2CwQJIcYmZ8unBDzynqwJWiX6fcg8MPc1est9iRxWRB7WZ0mKEJKgBtw4vuC9Ev28ABOjpDgU+wXY6D1sCgNjE6LdC/IE+ziL3iARyn3qYa545ZWK/EfWxL/ySRqArYR9hRi6RINv21E+ekdLaGmxCHzvCfykzBKqp9BlrOQkXeeSin+i6GzSZbDWng== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > So besides my last fput() worry about I think this could work and would be > probably a bit nicer than what I have. But before going and redoing the whole > series let me gather some more feedback so that we don't go back and forth. > Christoph, Christian, Jens, any opinion? I'll be a bit under water for the next few days, I expect but I'll get back to this. I think not making you redo this whole thing from scratch is what I'd prefer unless there's really clear advantages. But I don't want to offer a haphazard opinion in the middle of the merge window.