From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44F89C83F15 for ; Sat, 26 Aug 2023 17:02:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8992C8E0001; Sat, 26 Aug 2023 13:02:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 821FC8D0001; Sat, 26 Aug 2023 13:02:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C2798E0001; Sat, 26 Aug 2023 13:02:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 5928B8D0001 for ; Sat, 26 Aug 2023 13:02:22 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 25A79160221 for ; Sat, 26 Aug 2023 17:02:18 +0000 (UTC) X-FDA: 81166873956.02.11B55F7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id 6F191A0032 for ; Sat, 26 Aug 2023 17:02:16 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=LWUOrUXo; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693069336; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ODnJlwToZVP3t8xgJ/d4dyjZe1oTLliXb62Z0YoNQvQ=; b=N8IYNIqiCq/ogFeLsFzLCnol9Lwe+MQqn8u1PWW19Wb+IQLVNDZZlb/sGTsKplNEmQqcnq xk3YZST39OKVNyU72l6Cas3n/PiFrYmGVOl2t4Ouf+hguBQ0Spj/i/lI9BzvhpRnQmD/8F W8J+7QN4ovANniCJX36zodvlfykGnQQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693069336; a=rsa-sha256; cv=none; b=GKNi9RQio+gJh+Icu2MrnV79HJfg6AGZVsSXc95HzgRyOV6AM0HTCFb/8onGEedWgbx7Oe MaC8OuuDqzmKHjXdPYP6VN55qi+lM9Vu9RdqyuD0FTv56Lhx47n5lwsCROBXeODzmSlFmL YishmSVqB6g5vDWowJHRLWD4BDPksWA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=LWUOrUXo; spf=pass (imf15.hostedemail.com: domain of gregkh@linuxfoundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2C8E462943; Sat, 26 Aug 2023 17:02:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 72A52C433CC; Sat, 26 Aug 2023 17:02:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1693069335; bh=b27lPrgYOlTBxvB3KFpTfXrDP07o9bRce16U2nOD30A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LWUOrUXoCfZROm3NtCrtJ0kTHSoHNbBTu7HQpspfgTslup16QiChMBByDPRq+8fRk bvfEfM/qPl4KeZnyOXkDZ/lJ8BsMKvbfySDmqb4/53LHdzoXZKrgEBkdB+EobQirB4 ZUbGq132f7bBg6fCfN4ux6VtcOhc2XNNpcvsdHuk= Date: Sat, 26 Aug 2023 19:02:12 +0200 From: Greg Kroah-Hartman To: Stanislav Kinsburskii Cc: Stanislav Kinsburskii , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Wei Liu , "K. Y. Srinivasan" , Madhavan Venkataraman , Anthony Yznaga , "Mike Rapoport (IBM)" , James Gowans , Anirudh Rayabharam , Jinank Jain , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] Introduce persistent memory pool Message-ID: <2023082620-saint-petition-bb89@gregkh> References: <64e7cbf7.050a0220.114c7.b70dSMTPIN_ADDED_BROKEN@mx.google.com> <2023082506-enchanted-tripping-d1d5@gregkh> <64e8f6dd.050a0220.edb3c.c045SMTPIN_ADDED_BROKEN@mx.google.com> <2023082633-magnetize-cupcake-accc@gregkh> <64ea25cd.650a0220.642cc.50e6SMTPIN_ADDED_BROKEN@mx.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <64ea25cd.650a0220.642cc.50e6SMTPIN_ADDED_BROKEN@mx.google.com> X-Rspamd-Queue-Id: 6F191A0032 X-Rspam-User: X-Stat-Signature: 74q7eit6ftb9yqdfiogdip6wyxsx8ys5 X-Rspamd-Server: rspam03 X-HE-Tag: 1693069336-773769 X-HE-Meta: U2FsdGVkX1+Bq/04haGCsXLDWWZE1q7QSN0ECAtzCYvhWD1OKXgyj2YLXrgqWvSoXrTJDtsBkCU+U5fc7SvIP/ardOpHEFaBK7TuAVaH2Ef/WdJNEDUBMDuTqoUDFDjEia8Qi7cRZiCQRLixzwSU1cLARsLH+3/t11QR0p6bQPQ3oHMtgLfoTsMlL3KGGl+95GHeSdYwt0X9Ja2j4ZOnL+W/ooU3YR7G4KeGGU0HYDR6vYmAkHbAf1nnkOMEkpOuvC1sEnhDxJdAvZogr6S1nn8d5P/F8ikv1wIXCYCMBAkYlgoo6+5BADGgsJrWywWHUXFC2nVX4ldwp/rGm1rQlwFL4BjCsUxsjTxKZrjvHrxUlokVYyU2wBio8oF1kFpqvgh9WbHSNgiQVUzrnD4iUT40idSTqBzVTXHNnB/PXYFMQXBE40KvXG2fcj8RF6tcBRhNO9xIcK64iehIrmG+TDMfJldsUyadO7ZpLYA6vsWnR/tFW/rIEPkx2IAV1/JxEsVXjK+DwRBEJb7Qt+0zT03LR+abZYpZNpIrfbD8oSwqL9omEjCIfDoKj/zkwZUtmDo+YUaGEDnZDdIaLQhRoevco1IVHN8YLqQjCBZrvvtqg7ZImkUJh29RZRTYUzdLxbl3n65v739NdvD5WGo+wyKwl/aY+/8TvnXPhpzWuno9V+i/uNZ9+YY6WHPYa1Q0o++KwQOUwHqxBMf7pczhXS57Rk6Exbol1evQO1HhFnQt4hxH8orkm0Xo6L6PlqKO/VBO2QiDRAEmS841VMuz49j+Q1klDjn+UPQBOKO46VQTQM8W4Xc44sAe6hnrsDEsN3T69Yq/JviYQ3COKQ/EKU9gNILUBu/fZEw2RNNQiVuTgpQ+9w3kc8whIzStPT+DUaHExn7PsvhO1WydY8LjFdMEn0YROS+pIz2Rl4+cNBqu/yyLlPuJTYdun/k/AU1i0ekposLAdiIhCkBAskI ALFYWn4S wSITP74RlwRWe9b9ViVd+/sQ0Qrouee6D+ZGvUGOFfnvjbiVrYNNAROAY2w0vpPTlY/hLSJD4MzlH8iSxBAG8As2VCnLEaYwndpvD4wz4d+uP4FkGUTQimEkRjetFqYBpspmyEiSqAsoQcW0Y+gINck2T+0swDO+9iFsCCYN9LwC5O5A3B59azfdK72M/j3W8ikNjC/BVriwMggyMvPwhdx0QfVgf+B//4VS63zUVManZHWbF+CSoSHBJSsH3h+LHJpBV8mtM4YMqeWLNNVCWo9L3PU7LKeEvOk12oy69RLRGDW7wkwhm6tCYPkAFVqLzuqkvlqjC7B7yD0GVZBJpJKCGwg2YwhwGM1F0vMfzqmqQ3GCOHw3/TqLsxwK78OW5TJyl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 22, 2023 at 11:15:08PM -0700, Stanislav Kinsburskii wrote: > On Sat, Aug 26, 2023 at 09:45:39AM +0200, Greg Kroah-Hartman wrote: > > On Tue, Aug 22, 2023 at 06:36:10PM -0700, Stanislav Kinsburskii wrote: > > > > > +#include > > > > > +#include > > > > > +#include > > > > > +#include > > > > > + > > > > > +#include > > > > > + > > > > > +#define VERSION 1 > > > > > > > > In kernel code does not need versions. > > > > > > > > > > Could you elaborate on this? Should kernel version be used as a backward > > > compatitbility marker instead? > > > > kernel versions should never be checked for in-kernel code, so I really > > don't understand the question here sorry. > > > > For code that is in the kernel tree, having "versions" on them (as many > > drivers used to, and now only a few do), makes no sense, especially with > > the stable/lts trees getting fixes for them over time as well. > > > > This version is rather an ABI version. The idea is to make sure, that > any future ABI change is explicit and reflected in the version, so it > can be easily noticed in case of kexec to a kernel with an older > version. > But I guess there are other ways to make sure, that the ABI contract is > the preserved. Which ABI are you referring to here. The user/kernel one? Or the kernel/hypervisor one? Or something else? There is no "numbering" of user/kernel apis, sorry. APIs just don't need that, you can handle things properly automatically without version numbers (as again, that just does not work.) thanks, greg k-h