From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48B5DC83F11 for ; Sat, 26 Aug 2023 08:02:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 753CC2800E5; Sat, 26 Aug 2023 04:02:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7040D2800DF; Sat, 26 Aug 2023 04:02:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5F3D52800E5; Sat, 26 Aug 2023 04:02:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 519C62800DF for ; Sat, 26 Aug 2023 04:02:08 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E5D57B17D5 for ; Sat, 26 Aug 2023 08:02:07 +0000 (UTC) X-FDA: 81165512694.29.889192D Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.93]) by imf15.hostedemail.com (Postfix) with ESMTP id 43C81A0032 for ; Sat, 26 Aug 2023 08:02:05 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Fgllkwb9; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693036926; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JEJpYi7hqnKBeV832HxiXV0V1Jitiv9b40F9F113dGc=; b=TVvKk040rANEieQlsJ/ZTOC1xIBG7+hfmrr8lyEAdBO768LQkzXnpCSMtvHxCPqgwLqRCk V4FC9zX92NOLFB5RviNIKC+Qs34vLZR9Nxe2/7UPNgclOer9o9sTdhcBD35g0S2SZcAUoJ K9Fb9SXAvQYs3um827z7dHo8ib0te9Y= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Fgllkwb9; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf15.hostedemail.com: domain of lkp@intel.com designates 192.55.52.93 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693036926; a=rsa-sha256; cv=none; b=saHdx4/ru41cLyA/lyrA0lFdxyC3Ax3/cX7Y8+yFbWHX32a7awiGX10UfugQXQG4dp0l1A iTBI24PNCeFWheQpf5pTQf3S03K52rQep/mgUCrjkN9QbuElH0sJPNOuYLIl1J2OOxs6rb AW37CesG/ed5Vj7gqnot4VJXXps5kuE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693036925; x=1724572925; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=bVpGnSBGvSJPKPCdKmhHM2u3QgUVXmp2aXiWFiOxQUA=; b=Fgllkwb9NqXqpieUMG34ZZw0847BwnoOxcgbfCd9DmzoLpVVnmaCmJdD uAkstxCFIJejxncr3zvUTO8C7vTeTCFBntVMJHWXkWDyQVG0ytmaqwQGR Xe7m1ol5vjOtek2G1E72Pd0XkNzP0hOxJYN+mAn+UXyBFx8X40H96HUzo ijfWgi/u3mNTfnKGUIES9a+T6br/iFdlYyRusEfziVZ6kOkgpYv6SB3m5 azX8RJzCFPcJF91KzWhmXLpl4IkW746qX+F/+EhjpSz5OjLAQW4Zixf2z qZgwCyvyWYXJK8Xi35QLksrqDrI660Bu1amFmpR4639XipNuZZjxVUjat g==; X-IronPort-AV: E=McAfee;i="6600,9927,10813"; a="372260808" X-IronPort-AV: E=Sophos;i="6.02,203,1688454000"; d="scan'208";a="372260808" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Aug 2023 01:02:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10813"; a="827815883" X-IronPort-AV: E=Sophos;i="6.02,203,1688454000"; d="scan'208";a="827815883" Received: from lkp-server02.sh.intel.com (HELO daf8bb0a381d) ([10.239.97.151]) by FMSMGA003.fm.intel.com with ESMTP; 26 Aug 2023 01:01:58 -0700 Received: from kbuild by daf8bb0a381d with local (Exim 4.96) (envelope-from ) id 1qZoF4-0004U3-0E; Sat, 26 Aug 2023 08:01:58 +0000 Date: Sat, 26 Aug 2023 16:01:45 +0800 From: kernel test robot To: Mike Kravetz , linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Muchun Song , Joao Martins , Oscar Salvador , David Hildenbrand , Miaohe Lin , David Rientjes , Anshuman Khandual , Naoya Horiguchi , Barry Song , Michal Hocko , Matthew Wilcox , Xiongchun Duan , Andrew Morton , Linux Memory Management List , Mike Kravetz Subject: Re: [PATCH 12/12] hugetlb: batch TLB flushes when restoring vmemmap Message-ID: <202308261516.F6FBNktd-lkp@intel.com> References: <20230825190436.55045-13-mike.kravetz@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230825190436.55045-13-mike.kravetz@oracle.com> X-Rspamd-Queue-Id: 43C81A0032 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 5zza69nafpsxuyuoz45d7nir4is7e8gz X-HE-Tag: 1693036925-449619 X-HE-Meta: U2FsdGVkX1/o272oClZhBZSBQis6G6ZfWVfwjhoVc2LA+pI9VcYXSBBhnkM5+7LSEMbVzI1mrE7XA3hwZ9otytIF1TNMig3KrW+TKaXJaUn3FLK3XoeKTspdjSPWP/UAC4L3jg5/vHLgQEKS3ehOgBKdtpSFzXwkuONbx81fW02hR4sSJu1ofjGgn2TvWCIO5HgJr7LirxnCJjiVf/WyDQLNJXbsDYCf3he7DMRxqqIFyp3PoHhKUHBP0ZEIyBQ9jKXeYXw8XJSm1nj+OSa9ckGKp00+iX1TdoJQsXo6sKwjOpTzjD/FNicDuBI6vN+hQX9TzQxbKmjLTcVk1bhJlzutF0MUylFHbzhw976vbkuEf8SoIweO0fWsz8pvBw4zxkSoHbNByFJeKsohNMgLe4tAxiGFb5tx7/XsB3ujRldf0PjqEgVWrHDk2PEbOR5PSTqyeUmZX9jvI9M0JJdSeIAIJAHGmWaTwo5wD1X9SqhBLrld2jNToDGAiEMkWsfuwE2WB4/t9+ymm2gVOK4FiVA8VqG9v1/q2+rEJQrm3vyztOJt4czSnNBROu7GNl7ZgZ0JezqMd/AGkYKMQNnAdJ2QbzLYDERAVDX49eSqf0kUikQzs/GmsmZwYR4Cg0jRYRdyIPkM5wzN9EC0pRuhaHWl1wJQat6wuilG93I3M5tzmIq22Iy4bno0dpV+gS7b9AdyDUUBUJOEuv/qndIeplwG7kz440NpTIjCJXqbM7frL192LaNJ5taeZz0f01veyBYa2kM0i7/fCEtovVTXIMqJIiKsHSAKx7Y/mIwHmmoB9elhTdRsD75LzKcBo5YxXQBcBbuiLydkEYugoNJhq/CbVUGi2Q4IyhpXMIYMVKV7dle6bQqM8Dft4N5qxn+Ut9Y3118sheAojRPibwNIsn2yWMJpWdbilsfCoJuQJwjRyYekRnIRsNPQtG3ypFQVTWqQFRRtMQeduwDYnnh UOOxmrGI Cub9jTol32TGVzowfuGE2DcVCQ+XZiKMP5MsqC09Lk6QPH6bzYTCEinrvYupLcLPmlKvxPxV+dRMDegb0St110Gc+ld+Z2TUAxzVWplu1ie13RdDg2nWlEA+0qKvK/J1YMWFk9emjiKk/ZfocU2Hta8sASaO73BpL0ni3JeumSefBhKoZ45w5B6130hC4o+F9RmTUunEsQx9oNmBCA856GDZtVzSb3TLtvnXIRUp5sGz/N4iSm/wpC+gUQaro6BFY9s6rJXQa4TutpJRPzAdXFB/35L+LMxwDv3JwHiDARrvvOOUnsehWE4HeJjyU7pV/3XVxdT6eY8GOmxJCcffNvWFbwN9ura5xoHb1vHjFKb4CmPqackjrzCPPBx3bXH3uVID+/l5FgNjwT/w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Mike, kernel test robot noticed the following build warnings: [auto build test WARNING on next-20230825] [cannot apply to akpm-mm/mm-everything v6.5-rc7 v6.5-rc6 v6.5-rc5 linus/master v6.5-rc7] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Mike-Kravetz/hugetlb-clear-flags-in-tail-pages-that-will-be-freed-individually/20230826-030805 base: next-20230825 patch link: https://lore.kernel.org/r/20230825190436.55045-13-mike.kravetz%40oracle.com patch subject: [PATCH 12/12] hugetlb: batch TLB flushes when restoring vmemmap config: s390-randconfig-001-20230826 (https://download.01.org/0day-ci/archive/20230826/202308261516.F6FBNktd-lkp@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a) reproduce: (https://download.01.org/0day-ci/archive/20230826/202308261516.F6FBNktd-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308261516.F6FBNktd-lkp@intel.com/ All warnings (new ones prefixed by >>): >> mm/hugetlb_vmemmap.c:516:5: warning: no previous prototype for function '__hugetlb_vmemmap_restore' [-Wmissing-prototypes] 516 | int __hugetlb_vmemmap_restore(const struct hstate *h, struct page *head, bool bulk) | ^ mm/hugetlb_vmemmap.c:516:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 516 | int __hugetlb_vmemmap_restore(const struct hstate *h, struct page *head, bool bulk) | ^ | static mm/hugetlb_vmemmap.c:567:28: error: use of undeclared identifier 'TLB_FLUSH_ALL' 567 | flush_tlb_kernel_range(0, TLB_FLUSH_ALL); | ^ mm/hugetlb_vmemmap.c:673:6: warning: no previous prototype for function 'hugetlb_vmemmap_optimize_bulk' [-Wmissing-prototypes] 673 | void hugetlb_vmemmap_optimize_bulk(const struct hstate *h, struct page *head, | ^ mm/hugetlb_vmemmap.c:673:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 673 | void hugetlb_vmemmap_optimize_bulk(const struct hstate *h, struct page *head, | ^ | static mm/hugetlb_vmemmap.c:679:6: warning: no previous prototype for function 'hugetlb_vmemmap_split' [-Wmissing-prototypes] 679 | void hugetlb_vmemmap_split(const struct hstate *h, struct page *head) | ^ mm/hugetlb_vmemmap.c:679:1: note: declare 'static' if the function is not intended to be used outside of this translation unit 679 | void hugetlb_vmemmap_split(const struct hstate *h, struct page *head) | ^ | static mm/hugetlb_vmemmap.c:710:28: error: use of undeclared identifier 'TLB_FLUSH_ALL' 710 | flush_tlb_kernel_range(0, TLB_FLUSH_ALL); | ^ mm/hugetlb_vmemmap.c:715:28: error: use of undeclared identifier 'TLB_FLUSH_ALL' 715 | flush_tlb_kernel_range(0, TLB_FLUSH_ALL); | ^ 3 warnings and 3 errors generated. vim +/__hugetlb_vmemmap_restore +516 mm/hugetlb_vmemmap.c 515 > 516 int __hugetlb_vmemmap_restore(const struct hstate *h, struct page *head, bool bulk) 517 { 518 int ret; 519 unsigned long vmemmap_start = (unsigned long)head, vmemmap_end; 520 unsigned long vmemmap_reuse; 521 522 if (!HPageVmemmapOptimized(head)) 523 return 0; 524 525 vmemmap_end = vmemmap_start + hugetlb_vmemmap_size(h); 526 vmemmap_reuse = vmemmap_start; 527 vmemmap_start += HUGETLB_VMEMMAP_RESERVE_SIZE; 528 529 /* 530 * The pages which the vmemmap virtual address range [@vmemmap_start, 531 * @vmemmap_end) are mapped to are freed to the buddy allocator, and 532 * the range is mapped to the page which @vmemmap_reuse is mapped to. 533 * When a HugeTLB page is freed to the buddy allocator, previously 534 * discarded vmemmap pages must be allocated and remapping. 535 */ 536 ret = vmemmap_remap_alloc(vmemmap_start, vmemmap_end, vmemmap_reuse, bulk); 537 if (!ret) { 538 ClearHPageVmemmapOptimized(head); 539 static_branch_dec(&hugetlb_optimize_vmemmap_key); 540 } 541 542 return ret; 543 } 544 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki