linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Jinjiang Tu <tujinjiang@huawei.com>
To: <linux-mm@kvack.org>, <akpm@linux-foundation.org>,
	<wangkefeng.wang@huawei.com>
Cc: <tujinjiang@huawei.com>
Subject: [RFC PATCH 1/2] mm/gup: move pinned pages to unevictable list to avoid meaningless scan
Date: Sat, 26 Aug 2023 17:22:39 +0800	[thread overview]
Message-ID: <20230826092240.713105-2-tujinjiang@huawei.com> (raw)
In-Reply-To: <20230826092240.713105-1-tujinjiang@huawei.com>

To avoid meaningless scan during memory reclaim, this patch moves pinned
pages to unevictable list to avoid meaningless scan during memory reclaim.
Update folio_evictable() to check if the folio is pinned. If the folio is
pinned, the function returns false. The vmscan code will put the folio to
inevictable list when scanning the folio, so each pinned page will be
scanned at most once. When the folio is unpinned, check if the folio can
be put back to inactive/active list by calling folio_evictable().

Signed-off-by: Jinjiang Tu <tujinjiang@huawei.com>
---
 mm/gup.c      | 13 +++++++++++++
 mm/internal.h |  2 +-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/mm/gup.c b/mm/gup.c
index 6e2f9e9d6537..ca82e1bc6826 100644
--- a/mm/gup.c
+++ b/mm/gup.c
@@ -200,6 +200,19 @@ static void gup_put_folio(struct folio *folio, int refs, unsigned int flags)
 
 	if (!put_devmap_managed_page_refs(&folio->page, refs))
 		folio_put_refs(folio, refs);
+
+	if (folio_test_unevictable(folio) && folio_evictable(folio)) {
+		struct lruvec *lruvec = folio_lruvec_lock_irq(folio);
+
+		lruvec_del_folio(lruvec, folio);
+		folio_clear_unevictable(folio);
+		lruvec_add_folio(lruvec, folio);
+		folio_set_lru(folio);
+		__count_vm_events(UNEVICTABLE_PGRESCUED,
+			folio_nr_pages(folio));
+
+		unlock_page_lruvec_irq(lruvec);
+	}
 }
 
 /**
diff --git a/mm/internal.h b/mm/internal.h
index 8ed127c1c808..9ce158de40cf 100644
--- a/mm/internal.h
+++ b/mm/internal.h
@@ -154,7 +154,7 @@ static inline bool folio_evictable(struct folio *folio)
 	/* Prevent address_space of inode and swap cache from being freed */
 	rcu_read_lock();
 	ret = !mapping_unevictable(folio_mapping(folio)) &&
-			!folio_test_mlocked(folio);
+			!folio_test_mlocked(folio) && !folio_maybe_dma_pinned(folio);
 	rcu_read_unlock();
 	return ret;
 }
-- 
2.25.1



  reply	other threads:[~2023-08-26  8:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-26  9:22 [RFC PATCH 0/2] " Jinjiang Tu
2023-08-26  9:22 ` Jinjiang Tu [this message]
2023-08-26  9:22 ` [RFC PATCH 2/2] mm/gup: remove folio_maybe_dma_pinned() calls in shrink_page_list() Jinjiang Tu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230826092240.713105-2-tujinjiang@huawei.com \
    --to=tujinjiang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-mm@kvack.org \
    --cc=wangkefeng.wang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox