From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2979EE49A0 for ; Fri, 25 Aug 2023 21:15:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2621B2800E6; Fri, 25 Aug 2023 17:15:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 211F12800E5; Fri, 25 Aug 2023 17:15:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0659E2800E6; Fri, 25 Aug 2023 17:15:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E87342800E5 for ; Fri, 25 Aug 2023 17:15:32 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C2B73B28AF for ; Fri, 25 Aug 2023 21:15:32 +0000 (UTC) X-FDA: 81163883304.11.E9DB089 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) by imf16.hostedemail.com (Postfix) with ESMTP id 7AB78180019 for ; Fri, 25 Aug 2023 21:15:29 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=jCA4xdDM; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Uq1OIqli; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf16.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692998129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VGFf43G4mskRGtZuhJ8G3jHrmBg+U1WlpFB/yCYS4uU=; b=TZmaL5+Tr7r7xLTtFUGjIChx9X8Uz5+8T3Z3f+2bdr8CtrmG409L6yjP54BFs18mn4j7nZ 7vd2jq0+tim8lq5b2WSGxL9vsvmfrTCmQL1fvtyDSbljF3El6nAJUpsXgQZ87jj18170gI l+PqkpEWnck3q61pwMUdJvcTa6/kAbE= ARC-Authentication-Results: i=2; imf16.hostedemail.com; dkim=pass header.d=oracle.com header.s=corp-2023-03-30 header.b=jCA4xdDM; dkim=pass header.d=oracle.onmicrosoft.com header.s=selector2-oracle-onmicrosoft-com header.b=Uq1OIqli; dmarc=pass (policy=none) header.from=oracle.com; arc=pass ("microsoft.com:s=arcselector9901:i=1"); spf=pass (imf16.hostedemail.com: domain of mike.kravetz@oracle.com designates 205.220.165.32 as permitted sender) smtp.mailfrom=mike.kravetz@oracle.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1692998129; a=rsa-sha256; cv=pass; b=uPCuPYpELXYrpUHAO42/+Q+aG/b7zSfFPP4JhmIDyCCx3DBa8H2W/ImWYUNTTp3h80UN4v xZklmzz8QqGPVH7lftuGqKkx8/nU7Md+iBjiiHLLPhsEs0ZuLq60E9X62IZa3bq1gfuR3S zBSciaCbWjnFI6AiMgttgeB2ko5HyjE= Received: from pps.filterd (m0246617.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37PIERtU031110; Fri, 25 Aug 2023 21:15:26 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2023-03-30; bh=VGFf43G4mskRGtZuhJ8G3jHrmBg+U1WlpFB/yCYS4uU=; b=jCA4xdDMgN8JMfy4huVG6oOitMgv6Be28TqMxBaL6aBbfvCJA2W8zPpBiPS9t+Xds6Br bLV4pPS3l3ImsGqqCZpHEzn0p1ozTed/PuRFM9jCBKbmT+TWU41ByyUGw+ZWyk5q7pSF pzYws3S++EW0q7FkG3/7sRgl+SvLekBUVWI0IiSJxQZ7GJ+TccjvCGy7Iz1WszNfVjX5 WkmAiujqJrtS5EAW3sMzeCKkAG0zi3w9PtvuVy2CI7Xli/DhZDQrDFG5WxJlUScQnfI+ LmotmUCrq+KOzgHOClx0+Y3TLi59T7RorUkYIyqTO8Y+mB8D3YnEjdjGamNbr1n6dFD3 Zw== Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta03.appoci.oracle.com [138.1.37.129]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3sn20cq7cw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Aug 2023 21:15:26 +0000 Received: from pps.filterd (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37PJcbb7001230; Fri, 25 Aug 2023 21:15:25 GMT Received: from nam10-bn7-obe.outbound.protection.outlook.com (mail-bn7nam10lp2108.outbound.protection.outlook.com [104.47.70.108]) by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3sn1yvbg80-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 25 Aug 2023 21:15:25 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ak5aRHDpaa5MoZJP3VNjmX3FwOfH6RcsA9+Ce8BTUx73HfKJsv54N9FeoVymM65yNiOjQ/u7e6XR2c3H2clwkdoSNKaoA3OWbyI0JdJVtOrvm3DZZD6aGYwHQuQ2MhxTWYy/rM1BkNNyG5xs1aeZBFtraugXYFRDPNixKkkMoe2t4q2FgaBJ2+e4MfZL9QSjemob5LOv6jFfSeR+6AgnKu781Tc0+pGsireWYuAncHmD1LffYvJSMQKP2xo9yvu35RtiijyKpsEjHom4O28FvuDjgrkeeiIIYi5Nm2A2/CSGk4zJ2PTUeCQ6lzeFXDVRp+F5HNWUR56EYXbeDkVYug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VGFf43G4mskRGtZuhJ8G3jHrmBg+U1WlpFB/yCYS4uU=; b=URswHaFBUNX7GNPYP7e85apkDfThssb4DOASGO0FtPTiKbdeJbL1PA2nSEUhz4hV/qg48npZWSnLM1VwieE1oqjK+ice2i06hjlwnTcB6XSeAtdbdglxFdMDXh09e0g34fj1wnOuExrXEtHG5hQrxI82RUCxO/3wowLg+HQctKTZkZjMzdCdElPIBBAL4X8pkkcIJI8gjUUrUcs8c70Cs0kaAI96PuqUDYpyUh6y/EFttr/KrF3kuEERTrq5sevUBgKwRGJClRydxT/IeTrj3pp95v9Ez/lRUr/TRR9qkQnSlqAKqbHbFsnP9TKej57yn5ggAiMEM3+FgfzWoLrGZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VGFf43G4mskRGtZuhJ8G3jHrmBg+U1WlpFB/yCYS4uU=; b=Uq1OIqli9tDK7SyuZkQ1o1XCrdWbolSe0vm9GWy3L/80xOEdiM4pe+yxyDI7RgGOB3GaxAibZvwufwr7t8C/g5jJ/q5YP9fU/NE5+u9UMUHK+yYI1fEr0wqi5IpZTxIbMIGsv0ViHhoRBJv+Tn0RUrMIV6icfbMHO9VVj3APwbU= Received: from DM6PR10MB4201.namprd10.prod.outlook.com (2603:10b6:5:216::10) by BLAPR10MB4836.namprd10.prod.outlook.com (2603:10b6:208:326::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.30; Fri, 25 Aug 2023 21:15:23 +0000 Received: from DM6PR10MB4201.namprd10.prod.outlook.com ([fe80::8057:a3e9:cbd1:252a]) by DM6PR10MB4201.namprd10.prod.outlook.com ([fe80::8057:a3e9:cbd1:252a%4]) with mapi id 15.20.6699.022; Fri, 25 Aug 2023 21:15:23 +0000 Date: Fri, 25 Aug 2023 14:15:19 -0700 From: Mike Kravetz To: Xueshi Hu Cc: David Hildenbrand , muchun.song@linux.dev, corbet@lwn.net, akpm@linux-foundation.org, n-horiguchi@ah.jp.nec.com, osalvador@suse.de, linux-mm@kvack.org Subject: Re: [PATCH v2 1/4] mm/hugetlb: fix the inconsistency of /proc/sys/vm/nr_huge_pages Message-ID: <20230825211519.GA3730@monkey> References: <20230806074853.317203-1-xueshi.hu@smartx.com> <20230806074853.317203-2-xueshi.hu@smartx.com> <5c9ebf69-cd59-0fb3-bb85-1ab219426530@redhat.com> <79508337-08c1-7926-afd9-af21ee128949@smartx.com> <5b404d86-6b6f-b6c7-6286-f2ce3c4b5424@redhat.com> <42b78b9d-0a2f-c79d-0298-e4a7283a5633@smartx.com> <20230810001755.GC3537@monkey> <396edcf4-2b43-ef2e-baa3-b732134b8f93@redhat.com> <77540220-e1ca-a87f-51ce-905782c5ac91@smartx.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77540220-e1ca-a87f-51ce-905782c5ac91@smartx.com> X-ClientProxiedBy: MW4PR04CA0327.namprd04.prod.outlook.com (2603:10b6:303:82::32) To DM6PR10MB4201.namprd10.prod.outlook.com (2603:10b6:5:216::10) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR10MB4201:EE_|BLAPR10MB4836:EE_ X-MS-Office365-Filtering-Correlation-Id: b0023955-9ec9-40cd-2bb7-08dba5b064b6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KGBnYUmIKF7N27RV8mQCxk3z9hQlejj3cXAcyfrEc0gwtACEZgzM8Xp+MDCW130jse/PFOJgQo91O1kdm+HqBsT6PjXKF0CzrCjJOa6FuOm6YCYQrZCdR0ECpCB9GlV6yC5UszQnCTfUqhtNarQlVKIgfyb98+9Fsww5xlYDQ8B99Drd3VOGr5Z3vTkjrHVVRsUsKO+lsqmbhbek601SgN0lrM57ip13t9Knq8n/N+bWGHx4nsUNzvyI8RBaqRO64MbDj/fPnybjQLpA8gRMGirWyru2UUb3HpNcRDqUeBuA76O3yu3BgnUYZZ1LTRz46Z68xrch7xGoCtanbTco5Z4+xj5fTpHABowxub+kxF/ynZprBqqI5RvAezeShX5629L/mpqOqceyY2qwXgfcSuHyBjLg2QIGE7Ry25AFl66NFWNu+sYis2pif0Bhtdrho+KgPBQHt/xqTLpaqZE7IfES1zuXf+CSNIHUSEtu038obVynI90QBtt0hU6APGRJt2W6NY5o+qiwZJlkYNhwPFrEfmzTmTbLCNWLMYH93EVgF/pTkfhsOxSlH3DP6S0edRwMSmQ5iE2iRX5VsTcOilLo8mjaFLJ+/qPVePuN3JM= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR10MB4201.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(7916004)(396003)(136003)(376002)(39860400002)(366004)(346002)(1800799009)(451199024)(186009)(5660300002)(8936002)(4326008)(8676002)(316002)(26005)(66476007)(41300700001)(66946007)(2906002)(66556008)(6916009)(966005)(44832011)(478600001)(1076003)(6666004)(6486002)(6506007)(53546011)(9686003)(6512007)(83380400001)(38100700002)(86362001)(33656002)(33716001)(14583001);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?92bvVcrAQxEA5Fdzi0V9qsUwbpyR+GVUb/Ut6nA3HGxgAdDrS9ke8u7Ls+65?= =?us-ascii?Q?uSlTfN4J+zRimbS6tUtw5amkDx51PtmZX0kjcGaA1nYohep8MYE0h0oZ+eF0?= =?us-ascii?Q?iCcTJ+e3+dMEgF2QqeWQx22aR6MEXY5qyBO6FQFJIgTiTHgfSHfb0tLiqsbk?= =?us-ascii?Q?6nf00VnlunzAuGw5QAZsiKUEcbDkQ4uhJvQpDdLsmiy2Ts7WcRg+kYUI+njH?= =?us-ascii?Q?ikWro8uSmlqfLgHna/opFJxM1ptOwWe1Cewg+GW3+dzww4BEAejKoa5sOXw1?= =?us-ascii?Q?SDPhkefAvXqOEiVBvlIQT1mmK4+9S50QDDJsE/hGm4oevS2TcghXU6zMHn1F?= =?us-ascii?Q?cUh2F973RYY98kS50tlLiyE7pCeY38SSs6f8k8EE7XfrMASuDSRPtA0guhww?= =?us-ascii?Q?qHN+4fqMGBr2G2DPWibHMHpPN+RWQVAN1x4I00LAQTuC2J25tyJtIBDhAlRH?= =?us-ascii?Q?PPMFC24+iz8asxzyAeyLtmCm055rZ9O15g3KHA3hypCgZkAhyGVquTxF5XcS?= =?us-ascii?Q?HWv9902Gct/eh+4Mft+6rgrsAtcYRerEfaY7CVOBG0N3QuNCvwDvwgdLB3bq?= =?us-ascii?Q?IyUvc/BoGjxlBnQoWMEsykNqwftmCK3GKuHD2gZvX777EAYI1jaqfHJH5g8j?= =?us-ascii?Q?qSeeLYGEKmN8cGLB6Z6Dr+1wJLKKfZjMLQKfwXlUiTioLnlJuPVQtxqUVDXa?= =?us-ascii?Q?gJMfAdy3Bg+56blSdsp468+++1w8VpNRy/hmTxTb50BU9gOoffC4MUhQA6lX?= =?us-ascii?Q?oTCugHJDT3P0dnUWfDOtqQgE3OEbOHulXTz4aeLBFNfVmNXPQ3p1IWoOpG6J?= =?us-ascii?Q?W05qtDmfjXV7TnXDZ/YExUsSI00Ym2OyYEHxhweOEIcIJkho+PSYz0KEqx9B?= =?us-ascii?Q?MZ8xo/PoWZZqLZUxarnF9jtKM2lvcjPZtVaEYecxVOgUQfJBBFfx40y1eUgd?= =?us-ascii?Q?o9TWF/8g39vtwSIFRlTUvsoFTqpGcBT1uCNntT908TLF/MCyJPHECzO34wm5?= =?us-ascii?Q?9My9kxM4fLoIgpL0QKqZhKCXjsRmEsQbI3kFZPlpX8f2f7APju1d8E3eU1xT?= =?us-ascii?Q?GtC6OJFaLyxvv1nfcYcQIeHn+KqDTatHoKRKH4hy3YHO2Uq+2/hcoDS2h+1F?= =?us-ascii?Q?JeA8wUPGRM6EVEfgcBQxI2Kz4h1Xix7iXjOSK/a1+0s9Nrfb6vninmmSQghE?= =?us-ascii?Q?Gr3z1uiIuF+69hRQ/3kN1DWuXOxKocvwKDJOo5dzXj2aqvyNhTqdcd9msqbD?= =?us-ascii?Q?u52oZH96nzEDePm1HWVFDa0xLspwLLmvgiiSHJ7zKBgV2nvghSfi3WaWlYyL?= =?us-ascii?Q?admnpVkh8rTpCcIZWorwE1GZ5jVWzypU7s9GJgrIkWi3IW0mCzCNvIdICkya?= =?us-ascii?Q?LnYV8XSGPeC6nf0c6kJ/BRTjRwGO93HjKuM42mCBa8Dfs+fCh9T3Q7TTb62+?= =?us-ascii?Q?AnwG1qpNgaLH0fw7gaUhXdc+fFdkAzztBq3GRc/0NbjbSeemzO3+HUowK5PX?= =?us-ascii?Q?r1HBYjUSsEETMlErxCZAHtjT1XFqlQmZw28AR7byl6jkbpNxZnn12gkhALlM?= =?us-ascii?Q?fC9stt/mQeUfde2VlsNq0V1Yc36Kn6OyBfNlLvS5hHyuElgr2DE+2SeFAlBk?= =?us-ascii?Q?1g=3D=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: =?us-ascii?Q?GkR22Gq3dzlkkScbgUGE/z12t3w59zWq3pL2/9pM6X9Rk4atowcIUc39JulD?= =?us-ascii?Q?knDRzWAXt4kW291OnNtLaxbXEz7naNlC5JSthLq2Ddhkz369aVbHgLfBkGK1?= =?us-ascii?Q?9iyz8UTGlW7QHAR11Y5wTj2HEiFWwLJNPb8qbJS9AJ6m+TlViQW9Y3sFjG8V?= =?us-ascii?Q?1F76XOKDcHQv2zDPbZhIKK8b4Tl2npy9ZoRcZK02jfYtHEsin/hz5gShJ/wm?= =?us-ascii?Q?6L5voSkC8DthaUalE+taWN7HI7T/8Qnprpmsqa4eWxWOXPbQ+ZKqe+seDcp0?= =?us-ascii?Q?eMOPiRBibQdeeJfLACAPwxlcr5lP0hAIioLf5ylVxmhfPzLOPeP171O1igwS?= =?us-ascii?Q?eLJcNSDfyMwKfjbgTkW+ET+JcRkl67U1sBeXYy0g5TjdP5EqCN0F0JL+AsCA?= =?us-ascii?Q?2+0R01NFxIPpxbBeuJiG/n2P18VTnD/AEKt8Y06Motq5nY9jRf7Q991itPHi?= =?us-ascii?Q?vTbwAVvxcPT+Dxyfre0P1Ho6Y5ULd7HP0zhuAHAdZrZHl3m6jRbiGP1VZNZH?= =?us-ascii?Q?jtM0odsR/Jt9VudmD1hHtDOeYRfwbrZlJsqo/1hiGJGI8LvgG9kO1wymO+Fp?= =?us-ascii?Q?qfibJ91fvOBgQWgmeAsNrrmwEhSfHP85NR13gc7xMHaASoC1/gKi3imuWn1w?= =?us-ascii?Q?pelj2UYuQXbZ4TRfkpYIhm3xBFBrl96G83lWjaLdOyX1jQajNrktffxFj7hB?= =?us-ascii?Q?2NaB3Fw+XnU239XjIVBpelS0X3cN2Stifk5lekuV6PDxQrUxzt4MrUEkxp/h?= =?us-ascii?Q?OV8FmFo5CCAinNDzopoY1ZDbqfyUFMzssCpf3KVCzSAN4TM2DYiE5XwMrO+G?= =?us-ascii?Q?4SdGvTa34h6Q91mdtaAvU/a/fPm/2Vbp0y4AIJlTZtqVcEck0bjF4Tby9ygr?= =?us-ascii?Q?0hjOmmlDJ9z33D6OjRUhpgG1XtgUmeGqnTrTsgx1gwhvj8cLDk/biYF1Y04M?= =?us-ascii?Q?m9geKMFokUCqb+DQSjTGgw=3D=3D?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0023955-9ec9-40cd-2bb7-08dba5b064b6 X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4201.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2023 21:15:23.0457 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: nXBviQFRPHy8mm+/UW8axCcgknRxo6H2UFdsSWqxsQrYzMTHiNmVb1FVvs46Z0hx5Wcu/FMQuJFt7OK4FkkkQw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4836 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-25_19,2023-08-25_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 bulkscore=0 malwarescore=0 phishscore=0 suspectscore=0 adultscore=0 mlxlogscore=751 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2308100000 definitions=main-2308250190 X-Proofpoint-ORIG-GUID: ReMvU2wrZZt8dQ5qvVPn2cJPFNqqJfHO X-Proofpoint-GUID: ReMvU2wrZZt8dQ5qvVPn2cJPFNqqJfHO X-Rspam-User: X-Stat-Signature: cj4fn6r4hw9ncyrzm1npera8rr4kqrzq X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7AB78180019 X-HE-Tag: 1692998129-725938 X-HE-Meta: U2FsdGVkX1/IYS9+8x6TIXSVgDnfnuXRn32dxoSDo1LPBLHclyPS1KgrmdYvPkMeXsVMDnlpFgye/vNgKu6tIs5jaQgs1/s3+UfT0Q2/QmepJG6kgLeHTkyAW7BCmcW3CZ+tLaBXpVMYSpvM0B1i9kZBzXnqEYySFCQrXGhkn+6xwBlEGaWGP4YFDxaKEMhWsxJqXO6fQKN9i7P62O1+CDCYa2OYbHr6mjuw7olNIIsoxk/pyaW/xgtpXKWoNQiCD9B5FVlcdCfCNmzPP5l+UfEyvAVxDwY6axC73wklcS9TD4VhO8ibpKOAiz+W9hc/5f5BPZZGFlsI7wT+B1nRTBBYK3u3pC6EfPhx6WKw50w8BtrSbRUzIdFfVJEzaa94vzrmDGqjXQjIgA17DH9Qpsi+AiC4Aetq5qOlXh8mVjAKV7BNDHoiDFQYolqUq1Xx4IW7ey/FwiH6PFdw00CpebDLlofEf0WmpAt9hEAXGC1O44AMMcjnXJ7F6iKdZcMQNtkjipOwoBXn9VW2uSeEDWL/FIUm5B2B07AbNjR8ytimyqVoBh4gz698hzg31MdSP6X3fKvYrJKlXT9UE58RZ/gVAl3fNV4Zs31VwDqFUVvn3iajFAYKjgLBVtsWzHlDFm795BgTLKZpLzv0OPRyH49Bln/e5UtOnAbLYawR2FUd8eEbUbEAQylnt5+3c9s4SofNupxHcv0o4q3fubhZpZI15G+mDhZdOSf3Wb/JTYoxWcDr/TJfe83GHjHAkJxQLg4RICnRcTB8gbfKm+QMOqor/26JvcUs+zbg6ZDwIV4uk1R7V5Nwa94ZqTdwZlywqwBWND0QyjubKp2TwujqvstVfILvjiqGA8Z0ba8zo6CEw/Jrcm3tTOjo1C/DK04BhosHWwIRHT1TIqWR2VCTTi1rNgSxfzahsnYgBr3QFB6mvrBtKpzVL7xd6iG3PPZ/pnhcqBRQxX5YPKQisSg dNyc3J// EIVaHK5dyAxqQqNpJwkubgiynNn/wEKyi0gE0qDdeKsg+337SZJS3XUK13PC428cd8035SRmD9uf17Na7VsFuTsoyY3aL52MMDXU3lGzrSAMlKoGd5imJryKKvGjZ8eeDxUSoJFZcvnuHXUWsrAy4h8im4ePPTwY3FIq5uekBFdq6SGVKJqpXXcA95/c03i3ImDI2Y0tvv5GIwDoELZ+06ZckOXJak7+gGAEUHe/jeV5dWaPxqyuPd+t4t1aUyMf7WrrOSMexwOoZyRZ2J3DYyTpbElf4ix1reusvHglKHVowHVJbspoQfxTfdQnJYHxOQmjDDURkWNsBt1JYumIdVtsCP1aYJ9b4nres94Opek/QR2zqlPlVIBgg5UFg3NwyEs0jZk03wFmEaDOFAGDBLsqk0l8uf/n63XG7Px2+XpsWaZQ0bTwFJ5FdXeY2t0mRQ3EPBeOk11ABNT4xHE7zxfxpcwcMWxaQAfH83+wms6RHz9dACtSThexQoLBhZRd6EEpw8frPvYlg8m1bz2nr6aw7cbzprXOqqQfYPQSZOuSLH7bAolAlKcxEHg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 08/25/23 12:02, Xueshi Hu wrote: > On 8/10/23 15:34, David Hildenbrand wrote: > > On 10.08.23 02:17, Mike Kravetz wrote: > > > On 08/08/23 17:13, Xueshi Hu wrote: > > > > On 8/8/23 15:58, David Hildenbrand wrote: > > > > > On 08.08.23 04:28, Xueshi Hu wrote: > > > > > > On 8/7/23 23:15, David Hildenbrand wrote: > > > > > > > On 06.08.23 09:48, Xueshi Hu wrote: > > > > > > Sorry for jumping in late, I was away for a while. > > > > > > Hu and myself discussed this previously in, > > > https://lore.kernel.org/linux-mm/20230802182031.GA4762@monkey/T/#r1bdc8eeebafa08699fda5b15f247f3f966ddd090 > > > > > > The documentation around what is displayed with the hugetlb proc/sys > > > interfaces is at best confusing and at worst wrong in places. > > > > > > One source of confusion is use of term 'persistent hugetlb pages'. The > > > documentation does not define this term. However, there is this > > > definition in the code: > > > #define persistent_huge_pages(h) (h->nr_huge_pages - > > > h->surplus_huge_pages) > > > > > > All of the write/update interfaces modify the number of persistent > > > hugetlb > > > pages as defined by the code (#define). Only one read/show interface > > > displays the number of persistent hugetlb pages as defined by the code > > > (#define). That is /proc/sys/vm/nr_hugepages (and sysctl). > > > > Yes. > > > > > > > > When thinking about this more, I am 'guessing' that when the > > > documentation was > > > originally written the term 'persistent hugetlb pages' did not refer > > > to the > > > #define in the code. Rather, it was just the number of allocated > > > hugetlb pages > > > that 'persisted' until modified by the admin/user. > > > > > > There is little doubt the documentation could/should be updated. > > > > Absolutely. > > > > > > > > The question is 'Should we change the /proc/sys/vm/nr_hugepages (and > > > sysctl) > > > interfaces to be consistent with all the other read/show interfaces? > > > > > > The argument for changing is that consistency is good. Why have one > > > interface > > > that is not like the others? > > > > > > The reason for not changing is that this is the oldest interface. The > > > information/interfaces originally available in /proc were created in > > > /sys. > > > And, as mentioned in the documentation the /proc interfaces were kept > > > for backward compatibility. Unfortunately, the meaning of nr_hugepages > > > was changed the /sys interfaces were created. Sigh!!! > > > > Indeed, they were designed to be different and to just leave the /proc > > interface alone. > > > > > > > > In the thread mentioned above, I was in agreement with Hu about changing > > > /proc/sys/vm/nr_hugepages to be consistent with other read/show > > > interfaces. > > > Now, I am not sure. > > > > My take would be to just leave /proc/sys/vm/nr_hugepages alone. Maybe > > pr_warn_once() when the interface is used to guide people away from that > > legacy interface + clarify the docs. > > > > Your call. :) > > > Considering /proc/sys/vm/nr_hugepages may be widely used, and it not total > equivalent to the interfaces under /sys. What about just clarifying the > docs? I believe just updating the docs with clarification may be the best approach. We need to say that /proc/sys/vm/nr_hugepages and sysctl (vm.nr_hugepages) display the number of persistent hugetlb pages in the default pool. And, we should probably define 'persistent' as well. With that, this patch should be dropped. Without patch 1, patch 2 is not necessary. However, some cleanup (possible elimination) of max_huge_pages could be done in the future. Patch 3 is documentation updates which we agree need to be performed. I can assist here if you would like. Patch 4 is most critical as it is a bug fix. Perhaps this can/should be sent separately. -- Mike Kravetz