From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E801CC3DA66 for ; Fri, 25 Aug 2023 13:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FD2F90001A; Fri, 25 Aug 2023 09:33:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2ACFC8E0015; Fri, 25 Aug 2023 09:33:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 176B290001A; Fri, 25 Aug 2023 09:33:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 056208E0015 for ; Fri, 25 Aug 2023 09:33:03 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C910E120681 for ; Fri, 25 Aug 2023 13:33:02 +0000 (UTC) X-FDA: 81162717804.17.C9BDB6F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf13.hostedemail.com (Postfix) with ESMTP id 23AC320007 for ; Fri, 25 Aug 2023 13:33:00 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BOzM2QQ1; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692970381; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X1l9n2w2msxg9FKnzsUG71D//GbSOHzJh48SLsQSHc4=; b=xQnwpNEaVDjxxxrVpBZLPkWPlE2Yh/WhU+jBrX8MDGZ+Mc+i46d8vuRzf1L3Yu4EWloUPH 0Zua2262U4bcHTp5mYGFfH3aCdUJ9XQngWMVyqpeW09gM0r/1MG5ljRAWRjSRKzc+2lh8M 8wdCHX7SG+rSZPTfQGjcMTxJbczucL8= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=BOzM2QQ1; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692970381; a=rsa-sha256; cv=none; b=12hxBzQg/JfZy7DNJv5IDSOqkCcu4HQwhyCQNneBCNq1ZR2Wd/nOQ9N3ISfVHYthYFwt3J q9zr2NHsuam+Qm8OankvM6cZSTrYSGR19MGhF2CXHg+2utyNsZtTqDprIoKfHx9VWZc4Sd wRnp3OWQyQBCpyp6vf0VzCWFGk7Tiig= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 16F38673FF; Fri, 25 Aug 2023 13:33:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E70AEC433C8; Fri, 25 Aug 2023 13:32:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692970379; bh=T3WCgKJR+2I3SNciRzSe5NGE9AO6KZcdR6qXwGAgd9M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BOzM2QQ1MZDAriB3IMOamPdHV+2S3m2FC6tyT1pwI/9DF+WhlbPxDXE6fFDwe1gQn nTHB+ewwdyxJVq1cwfq3lRDi07qJcCHvh+nPPtQwtyRFhMG1ktBk1+a5CxpNbFHlMo Es+8l14bPK+nfmT+9Vs7IvZUfkPWFzk8wOkU0sT7FJdKR3BT4c1FwZN9woHNBuu5tc jHLMCNsuGW/YHncoWpwLVgQ93zfRJ93+ghRIza8tLelTozCObl43Fv+mmuqvzrkB+C SdJZ6/x4IFa4j6NBHHUKQ0uLY4RqtzEgYesuRGMfUi0q6xmwPRpi/3TpKuwt6YF2IT 8BYUF/YAoocgw== Date: Fri, 25 Aug 2023 15:32:47 +0200 From: Christian Brauner To: Jan Kara Cc: Jens Axboe , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, Christoph Hellwig , Alasdair Kergon , Andrew Morton , Anna Schumaker , Chao Yu , Christian Borntraeger , "Darrick J. Wong" , Dave Kleikamp , David Sterba , dm-devel@redhat.com, drbd-dev@lists.linbit.com, Gao Xiang , Jack Wang , Jaegeuk Kim , jfs-discussion@lists.sourceforge.net, Joern Engel , Joseph Qi , Kent Overstreet , linux-bcache@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-erofs@lists.ozlabs.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-mtd@lists.infradead.org, linux-nfs@vger.kernel.org, linux-nilfs@vger.kernel.org, linux-nvme@lists.infradead.org, linux-pm@vger.kernel.org, linux-raid@vger.kernel.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-xfs@vger.kernel.org, "Md. Haris Iqbal" , Mike Snitzer , Minchan Kim , ocfs2-devel@oss.oracle.com, reiserfs-devel@vger.kernel.org, Sergey Senozhatsky , Song Liu , Sven Schnelle , target-devel@vger.kernel.org, Ted Tso , Trond Myklebust , xen-devel@lists.xenproject.org Subject: Re: [PATCH v3 0/29] block: Make blkdev_get_by_*() return handle Message-ID: <20230825-hubraum-gedreht-8c5c4db9330a@brauner> References: <20230818123232.2269-1-jack@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230818123232.2269-1-jack@suse.cz> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 23AC320007 X-Stat-Signature: tpjq5p8bg3ryyg1jnb6jxx9asgs3115m X-Rspam-User: X-HE-Tag: 1692970380-85012 X-HE-Meta: U2FsdGVkX19iZdCR+8Bpv5HCRMGQZY7PpgJQJhUuklBmUxMaDi8UwFUFgLXIsKXdfqO8Xdj1i7XBQBGbOCU5fiTibyt7FltDbfZZfAq2jJBJ6wvsBc7Fq29CTTCx1doo3bfdtcgKb966gtLx+A5uE2xoXw7XEKkkZXmYKvRcu8QXmySkREEgsRdiLQUqfPU8hP1PAO+NuBN+p8FO1E2J+kTvL6FFjfliTDGVp+gCFu1x4Kw3rHm+wKgzcSBtWd9j4FFhfza/fDSgbjOgLWRhlvfQb7bsXa10FCHHmHV+OXKUx/OUYrhPmSuKSfXbnobkRMt9iZLmvsjguo3ZR44y+3qqSbaI9Btsa1si8Pf05gOq9fFyjJlyvsjmTuGUciGQgcLXfCbmBJICNUDSFys/FW2Jl0wA0YIaDvS0246VuJelerhb1YX5//ck/q4ig+blA7o1dBVsS+oxni3AZ2dSNVG85nAWoxVY2PcJXjeIL60sMSR1xmAfzzrhdBR+Qhay23jz5/4jOOZYA1Oau9X+0yaNystGA0Qbqy7Yspu/By0kVvyh7TtcpIretjZqxnEhFMCFX66YfEbmD4wIMPXlQjMOoigwv9WB0DYMPhl2QZpsMXglCK3Uf7Sfh24jrsn/bfkdCR8E5U8olMsrCxY6GAQ3g1LzwHhp85VaM/QqEJbYLd+srMGiiZ2c4TpEQFytUgZlrWyhVloJghXrzLM2UDXbaG92LcfjS1cUMBurA5znJH/O2gE10WXJOAeEPiumYoJZlMR/CqqRaGaXoYKmRDW1olW7O73V4Ewm5cS9Hzt7jG1H1+PD+FGIogwkGzlNp/tBf/qIle+7JFT5w1reuTEf3zlLGlLh8GCVS4CWBUomHZEwN40VGk3wRvRB/u9z/sTeK6UMEgoRkYpqjLL1Z9CUczkS954IgmsuZoLytuLWrykOWhLSImxjhjbqxyIwMc4Cl4wzgKA0BzwYdSg KYI1Mlic Do6ZrNKmJ4f1269/YfNRLjgfQCPf6JculdjzaI7AAxBSxtt+Gm0iHdZVwiC2GpjGNuR3vHvPUvrCGtJhm6J6pZgR3ptJnMB6f5/e7B9p98VMvuV7NWc9iKA8sI1ZrwatyAB5riwWI/cQOHZNqsgZ1u6KmNUOCTekgA+A6IxYKZ3x0duw6ArDiptny3xEz3ifpbYdHslKIvCMNd7QdscSf6jXp7cazJJhRS83Ht58ru4N1wMj6eB2P7tO1h5psI4D5J4qgKdPAFXOycEYIN75R8KACjBlkMAtiIB3auFDrqdw/iLhD2AQUdpbpo235Y1o63PuKse6GkcHxUkeyClWwv5t0vZwdwSKNakewfyYXUTfAQFzsTKQ7he7hXSbwdGMwQWQiJbwFtsfDCranpCTVtOsT6HMVLGeARfuFx36HrMX61C72I7547AJn8VEhrbx6yVImgbYn7RdDCTvJITbKtJO8kg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 23, 2023 at 12:48:11PM +0200, Jan Kara wrote: > Hello, > > this is a v3 of the patch series which implements the idea of blkdev_get_by_*() > calls returning bdev_handle which is then passed to blkdev_put() [1]. This > makes the get and put calls for bdevs more obviously matching and allows us to > propagate context from get to put without having to modify all the users > (again!). In particular I need to propagate used open flags to blkdev_put() to > be able count writeable opens and add support for blocking writes to mounted > block devices. I'll send that series separately. > > The series is based on Christian's vfs tree as of today as there is quite > some overlap. Patches have passed some reasonable testing - I've tested block > changes, md, dm, bcache, xfs, btrfs, ext4, swap. More testing or review is > always welcome. Thanks! I've pushed out the full branch to: > > git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs.git bdev_handle > > to ease review / testing. Since there were not many comments for v2 and > Christoph has acked the series I think we should start discussing how to merge > the series. Most collisions with this series seem to happen in the filesystems > area so VFS tree would seem as the least painful way to merge this. Jens, I really do like this series especially struct bdev_handle and moving the mode bits in there. I'll happily take this. So far there have only been minor things that can easily be fixed.