From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACE81EE49A3 for ; Wed, 23 Aug 2023 13:17:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A19A28006D; Wed, 23 Aug 2023 09:17:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3515128005D; Wed, 23 Aug 2023 09:17:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2424F28006D; Wed, 23 Aug 2023 09:17:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 13DE028005D for ; Wed, 23 Aug 2023 09:17:21 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id EE470B10D9 for ; Wed, 23 Aug 2023 13:17:20 +0000 (UTC) X-FDA: 81155420640.18.CBDF3C6 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf09.hostedemail.com (Postfix) with ESMTP id AF741140013 for ; Wed, 23 Aug 2023 13:17:17 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf09.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692796637; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Kvvr3fnXbq2HHvMhlDHS/wJAJ6ZRdrhcIm2Sezd7beA=; b=Rl6aH8+NNrWRt+ZuZMZgZQiov2omDPxGfCiSgolaPZJWw8fdNq1Tpc6m13ZrqmL9h2ZSyP HR8eSVeJWChtWc1lGk7EUaNgGaGz+TCSf2VxHciE4GYenjQ9HAh0nZn/6u8ePJ/5eBAIYt rzCCltK/UC82NRmV4Kad6s4PmmQ3NDM= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf09.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692796637; a=rsa-sha256; cv=none; b=3+f8c4PHQ1akzZTt/5lfzvP38UHnBm5OlAEIlNgfCh647iONtCkEN6qf1c7CB2sCK/hZdo lVzSwj57n633b2u29i4QCsInauCo1a7tpZCP/CM47iu/g/ukHZJXhZYzLXO7pTr9mUscL9 H61ag0NvPM8ARFuDI7nx8WqaOUQTWYA= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 740FB16F8; Wed, 23 Aug 2023 06:17:57 -0700 (PDT) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1BF5A3F740; Wed, 23 Aug 2023 06:17:10 -0700 (PDT) From: Alexandru Elisei To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC 29/37] mm: arm64: Define the PAGE_METADATA_NONE page protection Date: Wed, 23 Aug 2023 14:13:42 +0100 Message-Id: <20230823131350.114942-30-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230823131350.114942-1-alexandru.elisei@arm.com> References: <20230823131350.114942-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: AF741140013 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: qqhaqu8qredef7dytgfxgnnwd53dd7dd X-HE-Tag: 1692796637-346574 X-HE-Meta: U2FsdGVkX19SHzm8jZksvvo8t54stqYhjgks93pAe3uLz9AnTOZsd7HX4+3SJfrgZdFYo38RcLB3jJvLi26I01CncUuL7YlQMaZBrOJ6TfyC4CKd4UGUasEUZSdjBL++jzJzNzhsoFibEYgDuF+RmZM5zOJEIGoy7Oj1IEBN8XE7OqrBEn7iFjH62UY5mLqQBCNCa/BQmLSUxXN0Zv4s07Sm0tuS+B828htS2JjO0+XqwtzZLtsjG8p8mplorb3G4pgdaKz0+NQrrTJ/h3vvStIYjBxNV1sDVVI/9Jehf8R3iQCalZ0ql32f9YP1k1wEpccwHauFAkcaQ5cUJ3OQtbnD6/jG64pyKQ3lsD5HFeLgp//ZbBrLKv9vP0La/SzgtXR66uxrCAun69kR2T5PzdzgEQwIrmPnGVsgz0NpR9+CVdP8B5tk6jJqmr/kLeIJv1/frbqZ8tcEGmNZaB2Oif/ei/yaYume6QgSIrB01ahoRnBO2j4ZARKwFlDPiZMEGuioFa+z1dtT6jdnkudae9S3jvt7pKvF3cxf/vZohP4GQXfMBpZQuUdk6QIFdyPmsLNwjS+7p0ZAigwkRbs4ruZuVKI/TeX0rf1antw2HkpHPxmEtmblzP1LMMjKy0pdWO+oGUef7TCu2pXc6nEW84vx5ZXLzL0vl2atdRw0V2ERbQGituP88QpB1+rhi6L2J0ZB2Aig1RhAJaEFwnQq83HBe50rMfmK2JVd5p2pmWnSsoHhAXDX3o0BAvJ/CHKKL3BaryXVwFMf2RYahxwSCH8YiSK1v9roozCXn+QW8OO/pad11KHkBrkMZetJMBaPefQG/u5l0043anAyDIWj19MKyJmCqJXzxd3EHuOLs9FfCDEBjn6YNe8pqn21CxCCiHkCKIMwmfEcwtP4psr2e1WZM4GntsZIvg4gEB6nDydyamhSF97rcBI6eNOdMeoY6YFcul/aPhCysGD7vT1 +8ccc8uc AhXzu2SR7TEUjnTCKkM5pT5yeKM62VuSzdfIPXshTn77gAfj/ED43Thux/15+md4ZSgBH4Ej7KAIdOU9UtL+EY3mQVgwzcMnUo2545NhizL7q2nCyRXujxzrV52LioLcLlM35etFDVy8A1EUBRKxwxM29vQIRKELRR5AagMP+N0GRXXwQ/HfSF1tyNKQ49XlH7w11LdAjR+ipBpU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Define the PAGE_METADATA_NONE page protection to be used when a page with metadata doesn't have metadata storage reserved. For arm64, this is accomplished by adding a new page table entry software bit PTE_METADATA_NONE. Linux doesn't set any of the PBHA bits in entries from the last level of the translation table and it doesn't use the TCR_ELx.HWUxx bits. This makes it safe to define PTE_METADATA_NONE as bit 59. Signed-off-by: Alexandru Elisei --- arch/arm64/include/asm/pgtable-prot.h | 2 ++ arch/arm64/include/asm/pgtable.h | 16 ++++++++++++++-- include/linux/pgtable.h | 12 ++++++++++++ 3 files changed, 28 insertions(+), 2 deletions(-) diff --git a/arch/arm64/include/asm/pgtable-prot.h b/arch/arm64/include/asm/pgtable-prot.h index eed814b00a38..ed2a98ec4e95 100644 --- a/arch/arm64/include/asm/pgtable-prot.h +++ b/arch/arm64/include/asm/pgtable-prot.h @@ -19,6 +19,7 @@ #define PTE_SPECIAL (_AT(pteval_t, 1) << 56) #define PTE_DEVMAP (_AT(pteval_t, 1) << 57) #define PTE_PROT_NONE (_AT(pteval_t, 1) << 58) /* only when !PTE_VALID */ +#define PTE_METADATA_NONE (_AT(pteval_t, 1) << 59) /* only when PTE_PROT_NONE */ /* * This bit indicates that the entry is present i.e. pmd_page() @@ -98,6 +99,7 @@ extern bool arm64_use_ng_mappings; }) #define PAGE_NONE __pgprot(((_PAGE_DEFAULT) & ~PTE_VALID) | PTE_PROT_NONE | PTE_RDONLY | PTE_NG | PTE_PXN | PTE_UXN) +#define PAGE_METADATA_NONE __pgprot((_PAGE_DEFAULT & ~PTE_VALID) | PTE_PROT_NONE | PTE_METADATA_NONE | PTE_RDONLY | PTE_NG | PTE_PXN | PTE_UXN) /* shared+writable pages are clean by default, hence PTE_RDONLY|PTE_WRITE */ #define PAGE_SHARED __pgprot(_PAGE_SHARED) #define PAGE_SHARED_EXEC __pgprot(_PAGE_SHARED_EXEC) diff --git a/arch/arm64/include/asm/pgtable.h b/arch/arm64/include/asm/pgtable.h index 944860d7090e..2e42f7713425 100644 --- a/arch/arm64/include/asm/pgtable.h +++ b/arch/arm64/include/asm/pgtable.h @@ -451,6 +451,18 @@ static inline int pmd_protnone(pmd_t pmd) } #endif +#ifdef CONFIG_MEMORY_METADATA +static inline bool pte_metadata_none(pte_t pte) +{ + return (((pte_val(pte) & (PTE_VALID | PTE_PROT_NONE)) == PTE_PROT_NONE) + && (pte_val(pte) & PTE_METADATA_NONE)); +} +static inline bool pmd_metadata_none(pmd_t pmd) +{ + return pte_metadata_none(pmd_pte(pmd)); +} +#endif + #define pmd_present_invalid(pmd) (!!(pmd_val(pmd) & PMD_PRESENT_INVALID)) static inline int pmd_present(pmd_t pmd) @@ -809,8 +821,8 @@ static inline pte_t pte_modify(pte_t pte, pgprot_t newprot) * in MAIR_EL1. The mask below has to include PTE_ATTRINDX_MASK. */ const pteval_t mask = PTE_USER | PTE_PXN | PTE_UXN | PTE_RDONLY | - PTE_PROT_NONE | PTE_VALID | PTE_WRITE | PTE_GP | - PTE_ATTRINDX_MASK; + PTE_PROT_NONE | PTE_METADATA_NONE | PTE_VALID | + PTE_WRITE | PTE_GP | PTE_ATTRINDX_MASK; /* preserve the hardware dirty information */ if (pte_hw_dirty(pte)) pte = pte_mkdirty(pte); diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h index 5063b482e34f..0119ffa2c0ab 100644 --- a/include/linux/pgtable.h +++ b/include/linux/pgtable.h @@ -1340,6 +1340,18 @@ static inline int pmd_protnone(pmd_t pmd) } #endif /* CONFIG_NUMA_BALANCING */ +#ifndef CONFIG_MEMORY_METADATA +static inline bool pte_metadata_none(pte_t pte) +{ + return false; +} + +static inline bool pmd_metadata_none(pmd_t pmd) +{ + return false; +} +#endif /* CONFIG_MEMORY_METADATA */ + #endif /* CONFIG_MMU */ #ifdef CONFIG_HAVE_ARCH_HUGE_VMAP -- 2.41.0