From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59CB7EE4993 for ; Wed, 23 Aug 2023 13:16:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DD9A428003D; Wed, 23 Aug 2023 09:16:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D89C9900035; Wed, 23 Aug 2023 09:16:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C78C928003D; Wed, 23 Aug 2023 09:16:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id B537E900035 for ; Wed, 23 Aug 2023 09:16:23 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 832BB40100 for ; Wed, 23 Aug 2023 13:16:23 +0000 (UTC) X-FDA: 81155418246.20.5F167FF Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf02.hostedemail.com (Postfix) with ESMTP id C65658002C for ; Wed, 23 Aug 2023 13:16:21 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692796581; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=cxIim5XoZri2irZTfRyizJUXpnkJfHUOphqzC+7dZ2g=; b=aB0CU7xpWWvtHLqW2Tnj9tJr8hBCw9R3IW8ExsYz8HSUA3ieArP1N8CMv3qLUUepM80Hew +uFSmE9SSHwHalqqBI98cghN3X9pk03w/WbblAjk3hDZ4RTB0Gkw4iGRZYg8v/PbyixcN4 E7YtFYRUbsRYxYZG8fyp4WpCoXN+2ns= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf02.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692796581; a=rsa-sha256; cv=none; b=jwoYWn0Ml4ux/1FFMZcFMKUCHW/l+oxlW3NI7Bsqyaw8wseK2k8JdJGB+2i0wUmxEZazQP xprrmZTZD0D/9QMzSSAdNtztwfTs7pMbKfkj3knjUcOPuAYtx+b7dkpeuTkeeDePLleeHJ CMSloEoomZbjiVhLGbA1e4rSDhIkM58= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 93C321691; Wed, 23 Aug 2023 06:16:56 -0700 (PDT) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 033CD3F740; Wed, 23 Aug 2023 06:16:09 -0700 (PDT) From: Alexandru Elisei To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC 20/37] mm: compaction: Reserve metadata storage in compaction_alloc() Date: Wed, 23 Aug 2023 14:13:33 +0100 Message-Id: <20230823131350.114942-21-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230823131350.114942-1-alexandru.elisei@arm.com> References: <20230823131350.114942-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: C65658002C X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: j1mx1ga4sbneyapxkmd485hu6qkxo6r4 X-HE-Tag: 1692796581-630870 X-HE-Meta: U2FsdGVkX18kEcQL3lbtMSwshYD1FNHv5kEnlpYbddB3p4qMaUnQPDRrDPWcrA5ktEwBrv6HX07LZjWkeGrt1muA/q+1QcUowD3Y+yrUhlKiyex/XfLZG7imxN07/QxfKdyrC+xbN5qDBZN5Eq1+ENkaiwvyZKxevWdGqQX/0zVcrAaVeYww9975Q3022HC+vnci3S6+WY/lDhS9qIEnPFdZbHx5nNmV5sKO+q19ao9jMG08UHvLg+R+jTJa7ntSB4fFklRZxOTWwetO4JxIo/AMQWmH2mMTMq0840H6crVoEtqvxdpiwgg2WUlhtO1QPxjvf7rwwvN7bVN+RexxJAawXKVstgfrjMWS4wT0XmV9GbLoO9nltKeUzOVxksutmbSTrHyLg1lTQUXgyh86402NcsNM+mDtMcNOPsFE2GUh+CdPmMiMvpayWIMqXhdBJ+xChnUiN+RoItx5+UgNqctuTtPX6LYDRWbcuyVfRAVBTHMvw2Smp4ljfB9E505gU4AR/hWjWJuAkovLxGjW5okXZR9FLQMj1qnE/kDLfyQiO3jqG6XicKVtDG91S/Ge3TQaOyslidoHEohbOeAfNSqJLIWRrLUklR/hgdbDXRTeg3OBoXy6ec8nHK67iPJj4UNRD4gpPIzDffHo9UX9BcNh8kPUGu7sNADsaZwiqDxQrq7WJDqS1imfjM2L/j+OtuIwFdz5pQnMgudv26cpe8/Zx7M5gbkFd5KtBhL/YmcBt7Q74+9GjDEAqUR9IEIj9iiYD2KGa/uwQDdkLAH4ttGIYLt+kQJFMYwYMmxIaxJ8kGLqeMpX8HUaOvzpIop1P6ynYpE+vIrLehAveOUN8BNM/vUkNB4CB5wRhJBw9n3ka7AMrn0Y9ecE5k+l9SsHcXL5c8zkqpMNHPPWLzkzhoKYSeZr+QFJhD7OcnJ8Dgt0dfDCtVoKYfy6lZsD+/lAwx7MWMrA7N7d5qE8C0Q D36M/lAz gcEAyWgBAhMgZfcEn9ly9kEE+4kzbGIc4GouZpiAevYI67dIU9ONzb/7Ue8W87UHd8vQysl0dB9U34fs53tW4bhKprywy2Hw/2J5H7KV6smGYQbQexHvUfM6OLSkx6Cbg6oBU63vLHXPJSzOV/4uDBkiOOHJODHy4Hhf/7C6T76y+WA0ypuVIdRu9wliNJg7duLiwiZKHNPHvLbA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: If the source page being migrated has metadata associated with it, make sure to reserve the metadata storage when choosing a suitable destination page from the free list. Signed-off-by: Alexandru Elisei --- mm/compaction.c | 9 +++++++++ mm/internal.h | 1 + 2 files changed, 10 insertions(+) diff --git a/mm/compaction.c b/mm/compaction.c index cc0139fa0cb0..af2ee3085623 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -570,6 +570,7 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, bool locked = false; unsigned long blockpfn = *start_pfn; unsigned int order; + int ret; /* Strict mode is for isolation, speed is secondary */ if (strict) @@ -626,6 +627,11 @@ static unsigned long isolate_freepages_block(struct compact_control *cc, /* Found a free page, will break it into order-0 pages */ order = buddy_order(page); + if (metadata_storage_enabled() && cc->reserve_metadata) { + ret = reserve_metadata_storage(page, order, cc->gfp_mask); + if (ret) + goto isolate_fail; + } isolated = __isolate_free_page(page, order); if (!isolated) break; @@ -1757,6 +1763,9 @@ static struct folio *compaction_alloc(struct folio *src, unsigned long data) struct compact_control *cc = (struct compact_control *)data; struct folio *dst; + if (metadata_storage_enabled()) + cc->reserve_metadata = folio_has_metadata(src); + if (list_empty(&cc->freepages)) { isolate_freepages(cc); diff --git a/mm/internal.h b/mm/internal.h index d28ac0085f61..046cc264bfbe 100644 --- a/mm/internal.h +++ b/mm/internal.h @@ -492,6 +492,7 @@ struct compact_control { */ bool alloc_contig; /* alloc_contig_range allocation */ bool source_has_metadata; /* source pages have associated metadata */ + bool reserve_metadata; }; /* -- 2.41.0