From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47B4EEE4993 for ; Wed, 23 Aug 2023 13:15:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D15DD90002A; Wed, 23 Aug 2023 09:15:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CC5BA8E0011; Wed, 23 Aug 2023 09:15:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B8DF190002A; Wed, 23 Aug 2023 09:15:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AA3028E0011 for ; Wed, 23 Aug 2023 09:15:07 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 86E398010A for ; Wed, 23 Aug 2023 13:15:07 +0000 (UTC) X-FDA: 81155415054.20.7AF1478 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf19.hostedemail.com (Postfix) with ESMTP id D2AF61A0031 for ; Wed, 23 Aug 2023 13:15:05 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692796505; a=rsa-sha256; cv=none; b=ArmtBWETXxJ3KLz0mNwMz4/anxO9JnspGByFwD27tup9D4fSR/DD1wXcaw6R3VqOAhPfE8 tnVWgWa6QlmrH+kMhxuF8sS61eOzCIYE6Ge33Bva+rZpPbZSFPetfLgcdGN6hy9SELI3/m gcSfzmGzZ2lv6JViNloFoUhiF8TKCdA= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf19.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692796505; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oKha7bxlj9+z1RppzJbqpI8dnCzCeCHgDBljczHqGYk=; b=Fu61jYwgohSXZqGhh5sKbA3aXEEjEYDC/LDpYECGtEnvBbYbT0bnbPDBxlmw7ZjeQkSJC/ TVmd4MfHukrOiUT+lnf352f2/sy1/S2VN78a/B6Sg2BUDEG+4FopISEyv57z38ompB4r0Q tCxAV5Q1e4SJjPhfVScN97J8aEZF2+c= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A7E7415A1; Wed, 23 Aug 2023 06:15:45 -0700 (PDT) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 647253F740; Wed, 23 Aug 2023 06:14:59 -0700 (PDT) From: Alexandru Elisei To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC 09/37] mm: compaction: Handle metadata pages as source for direct compaction Date: Wed, 23 Aug 2023 14:13:22 +0100 Message-Id: <20230823131350.114942-10-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230823131350.114942-1-alexandru.elisei@arm.com> References: <20230823131350.114942-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D2AF61A0031 X-Stat-Signature: f577mznsnyexn979ghyptafxzj6qpifh X-Rspam-User: X-HE-Tag: 1692796505-702072 X-HE-Meta: U2FsdGVkX1+ex82C7fQ6k2Sg9jia7KD528HkIzf2NZ112xU/Aly8cldq96GV17R5kLya06z3rCR8MjZPk6HXTE9dZR1qjrq+h8FEjNduueV0Y9Le51MfRNrLFbUZ8v29p2jlJGMmUBz6FmQgoM6R6nx1sQ90YU3qJSvy0i7wnzbTYXC4DFzgEa6/of7/hX0UR3zcndITvH9MomqwXMozmDh1sZosF5nG8v1bd/n+XOwNY7nZ3eNwWHNMYkFElfrx0YEDKNTG4DNaMQwrwQjmMoKJYwCN9CoDEWdcGIBHh9btqt/auO7pSSrlHMqKRfSvOf4v7tmxaxG4IBVZlxQ92VwegAVpaZP5zf/R7nBGuS3E9KIa5E/87yjYBcKGChlbuywiJm2n10l2qCcnf/HWmmvz/t68Zak40RMynqSZo7Q8Inek3BoSPYI+Cu1AD4py8Q7H/PaIaQXYl0gX7xTNMmawOl9qeqx0G6boPUSAQZEi6j/sloFblmhfazUakjL7mafOJvCoGAn/iJUe96xeQErz8YKRm+vp9DBYxC8P3kWXqEx3kdCq0iSBBZfAZQoHMVdxS4FNMNBxXqUolNxBPvc0lzPwspGosZWiWBsYYYJlYF5JWwCokNX0w1pqLoQ9adzc2SeX7vMdyqMj5x1rYkbyz7VQ4avXdRUEVhg8VXq9e6h/KgAY5Z915+FLzzhvmrhbxAsz5fywvHnDPpNOI0bZtOVwtIQUHBhTN0eq3MbigTnABCyO7/u8GEJRCq1h6qqntTInbRnU9IItyOIeFbFIBtkxnD9MMCvduHOg7T4O287xuQpi5Lhzx1XiH2kupOEQj5t3qu5mEgvtnA5YkAacvqDFbZtcL9Rw6QFZl8GHBEeFLBlvuqrkxUju1wQJOa83emBVu8o23U23easrMMYXnrhrnHXgne/ogii5kqf7sIiCcgyy6JbOxD3DISpIBHFdPxl2J8Tdd4p1aoh 1Zv0aBzv dXRtbdizD6n/UhAK4KzC3wkqKp3VL/9bJ0AEmmmcMg3pSKGXSamWIBvsDhxJEr3MNBnYMFprWOTZn8RglmDvkgYjeUkFtywsGfV9g+8n70SpoZjiJNchId9eSoNU1Q6NAU0j1skMW0GF7m1qykqr2nBzycgIlrCj50yUDfrmCtkYAb85sJFQPW1zq+x3HVfqQbcQx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Metadata pages can have special requirements and can only be allocated if an architecture allows it. In the direct compaction case, the source pages that will be migrated will then be used to satisfy the allocation request that triggered the compaction. Make sure that the allocation allows the use of metadata pages when considering them for migration. When a page is freed during direct compaction, the page allocator will try to use that page to satisfy the allocation request. Don't capture a metadata page in this case, even if the allocation request would allow it, to increase the chances that the page is free when it needs to be taken from the allocator to store metadata. Signed-off-by: Alexandru Elisei --- mm/compaction.c | 10 ++++++++-- mm/page_alloc.c | 1 + 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/mm/compaction.c b/mm/compaction.c index f132c02b0655..a29db409c5cc 100644 --- a/mm/compaction.c +++ b/mm/compaction.c @@ -23,6 +23,7 @@ #include #include #include +#include #include "internal.h" #ifdef CONFIG_COMPACTION @@ -1307,11 +1308,16 @@ static bool suitable_migration_source(struct compact_control *cc, if (pageblock_skip_persistent(page)) return false; + block_mt = get_pageblock_migratetype(page); + + if (metadata_storage_enabled() && cc->direct_compaction && + is_migrate_metadata(block_mt) && + !(cc->alloc_flags & ALLOC_FROM_METADATA)) + return false; + if ((cc->mode != MIGRATE_ASYNC) || !cc->direct_compaction) return true; - block_mt = get_pageblock_migratetype(page); - if (cc->migratetype == MIGRATE_MOVABLE) return is_migrate_movable(block_mt); else diff --git a/mm/page_alloc.c b/mm/page_alloc.c index bbb49b489230..011645d07ce9 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -654,6 +654,7 @@ compaction_capture(struct capture_control *capc, struct page *page, /* Do not accidentally pollute CMA or isolated regions*/ if (is_migrate_cma(migratetype) || + is_migrate_metadata(migratetype) || is_migrate_isolate(migratetype)) return false; -- 2.41.0