From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78CE6C83F11 for ; Sat, 26 Aug 2023 16:18:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 654D88D0002; Sat, 26 Aug 2023 12:18:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 605088D0001; Sat, 26 Aug 2023 12:18:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F4B48D0002; Sat, 26 Aug 2023 12:18:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 412F08D0001 for ; Sat, 26 Aug 2023 12:18:24 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 026BF1C9171 for ; Sat, 26 Aug 2023 16:18:23 +0000 (UTC) X-FDA: 81166763328.20.C62FF01 Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by imf17.hostedemail.com (Postfix) with ESMTP id 37A3040018 for ; Sat, 26 Aug 2023 16:18:21 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=ZhcAit2n; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf17.hostedemail.com: domain of skinsburskii@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=skinsburskii@linux.microsoft.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693066702; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hDY9rLC0VNypXr0ma9cq1keedQjYUitOpBrVLQuM6ug=; b=aRrBWj6EGkgQ2vAAbscGpHlJ8wrtrG/P+FTZg1dQs4D+pXKpDjiungwsaniYWGVF65qQob AUBmKyNmS0lIiw7/BPp9PYVJoRTs6XtqR1egeGN/6GwFmDXQwpL8GG6FYRP2hYsc96cqhN 76WwdKBVRIKnLR211jgiELMUJagfIRM= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=linux.microsoft.com header.s=default header.b=ZhcAit2n; dmarc=pass (policy=none) header.from=linux.microsoft.com; spf=pass (imf17.hostedemail.com: domain of skinsburskii@linux.microsoft.com designates 13.77.154.182 as permitted sender) smtp.mailfrom=skinsburskii@linux.microsoft.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693066702; a=rsa-sha256; cv=none; b=mHXVoSkXU8NW3VTMwQjZC4iHTnInJJrrNQXqXE6RqadND9p726qpsYiD/le5pdgO68fvFv X9apFnDHx6Iwd1AJejtzfUgOozLJMO7VMGLqjkb/XryvlrbTgUGp9ElToK5mp2KoBWi9ms OZzB4oL+LGhRZzidgoFQFruOWkNVLRQ= Received: from skinsburskii. (c-67-170-100-148.hsd1.wa.comcast.net [67.170.100.148]) by linux.microsoft.com (Postfix) with ESMTPSA id 898B62127D30; Sat, 26 Aug 2023 09:18:20 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 898B62127D30 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1693066700; bh=hDY9rLC0VNypXr0ma9cq1keedQjYUitOpBrVLQuM6ug=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ZhcAit2n42RKpWT4YSS5VOZ4DXmxabCpm+dCoj9zE3u4RFor8tUXIJ6JIjFz/KZrn au9Vamxd0XyApnh/65ATf/tuzNJdCf7m1WCTDuwb8nXrBbqLaPJHVECj6/wrPnhCzx 0AZfhz7Ighw52u3dulvtGbky8BpbMjj3RvI732X8= Date: Tue, 22 Aug 2023 23:15:08 -0700 From: Stanislav Kinsburskii To: Greg Kroah-Hartman Cc: Stanislav Kinsburskii , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Wei Liu , "K. Y. Srinivasan" , Madhavan Venkataraman , Anthony Yznaga , "Mike Rapoport (IBM)" , James Gowans , Anirudh Rayabharam , Jinank Jain , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH] Introduce persistent memory pool Message-ID: <20230823061508.GA25702@skinsburskii.> References: <64e7cbf7.050a0220.114c7.b70dSMTPIN_ADDED_BROKEN@mx.google.com> <2023082506-enchanted-tripping-d1d5@gregkh> <64e8f6dd.050a0220.edb3c.c045SMTPIN_ADDED_BROKEN@mx.google.com> <2023082633-magnetize-cupcake-accc@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023082633-magnetize-cupcake-accc@gregkh> X-Rspamd-Queue-Id: 37A3040018 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: r1memtnyugq67n5y3ziwup678jrsc8pm X-HE-Tag: 1693066701-443467 X-HE-Meta: U2FsdGVkX1/tabRJo9J/P62+6ZfOfss1m+cB6WUAGDyZjGLWTvog9oOUqraNolaVED/SzwgjPE6qJ/wQyFa9LCPVtuDAlxDWYxUwH9B+f+N6m/q5DtHaWe9AlkPB7Aju5LBY84au20CdDdPPA18pDqcbKxCysbfFIJ4yhn0JZ6Iq5nqzNh7E0ejcuUdqF/UNxZFQykC6ybnI32iltFWijnLWmmRp6CjFeFJKaNBkHOBDu7ttmlJmUcm+swGnUvWP65u7rZKBRruMtOSaEjfv82snaxPzZV3EmBWJhKDZHfyM6OjPUWnEL18w87WFTfZ8cW6SOyEV/lHgV7eJ35Vst0HQ2q5nN67y1qREjiUNx8jvmy2X1F+VWUKx4Tg1iPkZM1UEgAT3S3uUBM72Cu77H8i4x+02/UBzcF+T0LfbBde/fBnf6Tmu/aVblO9xT/hiW7tpR89WekEu8WkgHtQ0LW7HIpnEFQbe28S0oJU7V9w790YZXdpwdOHF/93etWnEH/RgeRi0ZAebseTxep9e2xeMTJ+o25NFiTAVaVRXPtqH95m3kFgFmxxv1EGpzkQjo8ISNV4mEbTgu7QQsdKn9LsoxuJ8Ab9Z4C2I9rXqOVpKTiHYhsYfSvgGIhntCe2MXO+0rVEHM9MSqXOtYLlPUlBHN1U9djzesgysTvfQ8K06GutwZ5UMNK4PPnmVnawUW4oNlDg6jcOAWdgVrH2Ok9+c0Jbz6W9Sp+OhZWiAO5vqB4a9ZkawmCKSKf6+Lb5t3TlbXP+6kHgbXQSUgjb5KaONpQn0y2xF0ytS+InxpftlRAh2N3ZcKoX7PP3JGxn8v9MHiXGSS39CLnXnWXpyFMW8ic93srnHsJn+vyyZ1I+Otcb5ZqglV1TugAfCbKh/D/kmXGV/f7g1Tk3FK9Cd5xGaXb8ik9fJ1vJ703rdPGAzAVtTqI5+YuYstke1O5VSCAIlh0j6c8cRzuJ7yXW GUVZaU2h 6jpmgIPUr+vf3dJWOVpnM3A+QNbGct70SGObtOLkB5umyU9l2X+LvWYgX9dY/kLq+CY/0kajb8yNVlyQ8f9hBxxbUm/of3rNdsBuKmpavNXU58KKrWwA5E85wiVEkirC4ku8Epu3lzqossELwVsvcuZ94pLIE07dyAcGgMn30AQlsoEy7GqbHtT26ltOAEIBXDEGldZtGh9DNbw4Jjx0xRURSYpmd69oyXq1gguOP8HEuOlkaAodgPKG1wKf1vHMd6cSl6W+bl/3JhAi6GLLKJG65x0tIJzuThCvq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Aug 26, 2023 at 09:45:39AM +0200, Greg Kroah-Hartman wrote: > On Tue, Aug 22, 2023 at 06:36:10PM -0700, Stanislav Kinsburskii wrote: > > > > +#include > > > > +#include > > > > +#include > > > > +#include > > > > + > > > > +#include > > > > + > > > > +#define VERSION 1 > > > > > > In kernel code does not need versions. > > > > > > > Could you elaborate on this? Should kernel version be used as a backward > > compatitbility marker instead? > > kernel versions should never be checked for in-kernel code, so I really > don't understand the question here sorry. > > For code that is in the kernel tree, having "versions" on them (as many > drivers used to, and now only a few do), makes no sense, especially with > the stable/lts trees getting fixes for them over time as well. > This version is rather an ABI version. The idea is to make sure, that any future ABI change is explicit and reflected in the version, so it can be easily noticed in case of kexec to a kernel with an older version. But I guess there are other ways to make sure, that the ABI contract is the preserved. > In short, there should not be a need for a "version" anywhere. > I see. Thank you. Stanislav > thanks, > > greg k-h