* [PATCH] maple_tree: shrink struct maple_tree from 24 to 16 bytes on LP64
@ 2023-08-21 22:51 Mateusz Guzik
2023-08-22 1:15 ` Matthew Wilcox
2023-08-22 14:09 ` Liam R. Howlett
0 siblings, 2 replies; 3+ messages in thread
From: Mateusz Guzik @ 2023-08-21 22:51 UTC (permalink / raw)
To: Liam.Howlett; +Cc: akpm, linux-kernel, linux-mm, maple-tree, Mateusz Guzik
by plugging a padding hole.
[sounds like an obvious thing to do, am I missing something?]
Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
---
include/linux/maple_tree.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
index 295548cca8b3..5bdd3ce34cb9 100644
--- a/include/linux/maple_tree.h
+++ b/include/linux/maple_tree.h
@@ -212,8 +212,8 @@ struct maple_tree {
spinlock_t ma_lock;
lockdep_map_p ma_external_lock;
};
- void __rcu *ma_root;
unsigned int ma_flags;
+ void __rcu *ma_root;
};
/**
--
2.39.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] maple_tree: shrink struct maple_tree from 24 to 16 bytes on LP64
2023-08-21 22:51 [PATCH] maple_tree: shrink struct maple_tree from 24 to 16 bytes on LP64 Mateusz Guzik
@ 2023-08-22 1:15 ` Matthew Wilcox
2023-08-22 14:09 ` Liam R. Howlett
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Wilcox @ 2023-08-22 1:15 UTC (permalink / raw)
To: Mateusz Guzik; +Cc: Liam.Howlett, akpm, linux-kernel, linux-mm, maple-tree
On Tue, Aug 22, 2023 at 12:51:45AM +0200, Mateusz Guzik wrote:
> by plugging a padding hole.
>
> [sounds like an obvious thing to do, am I missing something?]
That was how I originally had it. Not sure when/why it got messed up.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] maple_tree: shrink struct maple_tree from 24 to 16 bytes on LP64
2023-08-21 22:51 [PATCH] maple_tree: shrink struct maple_tree from 24 to 16 bytes on LP64 Mateusz Guzik
2023-08-22 1:15 ` Matthew Wilcox
@ 2023-08-22 14:09 ` Liam R. Howlett
1 sibling, 0 replies; 3+ messages in thread
From: Liam R. Howlett @ 2023-08-22 14:09 UTC (permalink / raw)
To: Mateusz Guzik; +Cc: akpm, linux-kernel, linux-mm, maple-tree
* Mateusz Guzik <mjguzik@gmail.com> [230821 18:52]:
> by plugging a padding hole.
>
> [sounds like an obvious thing to do, am I missing something?]
Thanks for the patch. There is no reason for the current ordering.
I've tested both 32 and 64 bit userspace testing to double check
everything still works.
>
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> include/linux/maple_tree.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
> index 295548cca8b3..5bdd3ce34cb9 100644
> --- a/include/linux/maple_tree.h
> +++ b/include/linux/maple_tree.h
> @@ -212,8 +212,8 @@ struct maple_tree {
> spinlock_t ma_lock;
> lockdep_map_p ma_external_lock;
> };
> - void __rcu *ma_root;
> unsigned int ma_flags;
> + void __rcu *ma_root;
> };
>
> /**
> --
> 2.39.2
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-22 14:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-21 22:51 [PATCH] maple_tree: shrink struct maple_tree from 24 to 16 bytes on LP64 Mateusz Guzik
2023-08-22 1:15 ` Matthew Wilcox
2023-08-22 14:09 ` Liam R. Howlett
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox