From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Mateusz Guzik <mjguzik@gmail.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, maple-tree@lists.infradead.org
Subject: Re: [PATCH] maple_tree: shrink struct maple_tree from 24 to 16 bytes on LP64
Date: Tue, 22 Aug 2023 10:09:46 -0400 [thread overview]
Message-ID: <20230822140946.kbmv43l4uhwwqwln@revolver> (raw)
In-Reply-To: <20230821225145.2169848-1-mjguzik@gmail.com>
* Mateusz Guzik <mjguzik@gmail.com> [230821 18:52]:
> by plugging a padding hole.
>
> [sounds like an obvious thing to do, am I missing something?]
Thanks for the patch. There is no reason for the current ordering.
I've tested both 32 and 64 bit userspace testing to double check
everything still works.
>
> Signed-off-by: Mateusz Guzik <mjguzik@gmail.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> include/linux/maple_tree.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/maple_tree.h b/include/linux/maple_tree.h
> index 295548cca8b3..5bdd3ce34cb9 100644
> --- a/include/linux/maple_tree.h
> +++ b/include/linux/maple_tree.h
> @@ -212,8 +212,8 @@ struct maple_tree {
> spinlock_t ma_lock;
> lockdep_map_p ma_external_lock;
> };
> - void __rcu *ma_root;
> unsigned int ma_flags;
> + void __rcu *ma_root;
> };
>
> /**
> --
> 2.39.2
>
>
prev parent reply other threads:[~2023-08-22 14:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 22:51 Mateusz Guzik
2023-08-22 1:15 ` Matthew Wilcox
2023-08-22 14:09 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230822140946.kbmv43l4uhwwqwln@revolver \
--to=liam.howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=mjguzik@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox