From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82F5DEE4996 for ; Tue, 22 Aug 2023 08:58:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B612D94000F; Tue, 22 Aug 2023 04:58:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B11A590000D; Tue, 22 Aug 2023 04:58:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D88694000F; Tue, 22 Aug 2023 04:58:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 8B84A90000D for ; Tue, 22 Aug 2023 04:58:40 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 5D2A5B186B for ; Tue, 22 Aug 2023 08:58:40 +0000 (UTC) X-FDA: 81151140000.04.D3B0913 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf05.hostedemail.com (Postfix) with ESMTP id 98EF610000A for ; Tue, 22 Aug 2023 08:58:38 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Y1dezFNn; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692694718; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ERob2TzfixW1rbjLjRpUEhngmMAPNQ8wi8LyErvvi84=; b=h0tICurrVFx8u7AEiC7WEhoq9xmhGomqgq+i2hSY54vpt+abEo8GdvN5aVzahYz2lsZYr/ 5Lxq7ePo04lJVbuZx46P3UPCsOf0jmHXadOYaRc0TMxoMgZzxIkDhrohTOor91yHVXB8Fw rmaFxSIlU8YUg/LoqAHyM7t+fq+hOqc= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Y1dezFNn; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf05.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692694718; a=rsa-sha256; cv=none; b=o8Rn7/M2FebS8/Jv/623PC3dFCCuHQZH7DG6/fVWsQdIeyrRl93LEaUJM/QGMpLGJkAhmc DsA082/+tRfLRGmMZeSKkarwo8ewhtC34tEeXc/cwTjWflMU+/0GIB1nn38rD32ONmJfFV Tj34g/v0+7JTE0nRCOh4EMVIlshNHoQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A3C6464FF7; Tue, 22 Aug 2023 08:58:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8B135C433C8; Tue, 22 Aug 2023 08:58:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692694717; bh=4qZ7RppNg9qYWoZJetV/MXqzmQCT9MKmJKzbdyaQ3Y0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Y1dezFNnX0NvdIqNeO5gHPMmW8rQdSDv9lYav1w373oqrjRLJ6n+XTYalCGcgVsAO F7dBkLXWJAPjSSlBid46Qkv3QP45lENIQAfwcH0liP1mMc3G0SVwS0ZhFmpES1YI27 DAnnsr6+uPhqE2kU0HMmrAKG99Z41a+iI6D6vFVnFQKISKOUpsFpyGVO/22t0C5BE9 kR+qlbBzNfITKy8VFOd85VicZRA+Xtk4LBB8k2zyVM87CSerzmnz1HFm/fpp6x97T0 NJPGvPiz+Bw5zZTEV8ik3X338CtqlWgZ2MusF1sCDKWKMuEdiAvnF/Q4VwH9EbQaGc NLrtIDF9gWaTw== From: Christian Brauner To: Hugh Dickins Cc: Christian Brauner , Andrew Morton , Oleksandr Tymoshenko , Carlos Maiolino , Jeff Layton , Chuck Lever , Jan Kara , Miklos Szeredi , Daniel Xu , Chris Down , Tejun Heo , Greg Kroah-Hartman , Matthew Wilcox , Christoph Hellwig , Pete Zaitcev , Helge Deller , Topi Miettinen , Yu Kuai , Franklin Mathieu , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: (subset) [PATCH vfs.tmpfs] tmpfs,xattr: GFP_KERNEL_ACCOUNT for simple xattrs Date: Tue, 22 Aug 2023 10:58:26 +0200 Message-Id: <20230822-anordnen-tracht-4dd042da0e09@brauner> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: <20230809-postkarten-zugute-3cde38456390@brauner> <20230809-leitgedanke-weltumsegelung-55042d9f7177@brauner> <20230810-notwehr-denkbar-3be0cc53a87a@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1511; i=brauner@kernel.org; h=from:subject:message-id; bh=4qZ7RppNg9qYWoZJetV/MXqzmQCT9MKmJKzbdyaQ3Y0=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaQ8qVhrdHjfzayJgX7KP7/31IqX3Dhux1QR6n1T8Kx56rSv b28rdZSyMIhxMciKKbI4tJuEyy3nqdhslKkBM4eVCWQIAxenAExkTQQjQ8+r5AQvRpV9j+P3qrxQ/7 t+xifBxZsW1B2Kje+LmaoVdpaRYc2jghl7vDbvv+Qc7daxWX92w2mnfRJ75wbePix3d3LvHj4A X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 98EF610000A X-Stat-Signature: 6tkrttcyk9et9qsn116kxukqwgo9k763 X-Rspam-User: X-HE-Tag: 1692694718-495144 X-HE-Meta: U2FsdGVkX18CjRLrZX+QeDNb5zOF6f6ajTr8yH5yTZvaMlizBu/Nw3tm/4Y6QoU0YIeK7d5v812UDEnN28vuIAwAyZa8aQvthxKpXuoWq4wsT+rgIIAFFeGNr3bto48LrCbM/1Czzy8CZIi1MrE+7TwiTtVZBw3IAKfB4v+fT42E9ixYozVhS4Cck8/jx/Ay7aKh2bLG56U8hRmFQUtBnIEyGsdgo+OeLn/CwlaUwciLFEaFxtvEuswtZ0poRYJE50qzhldS43WtloedCpO2GJHH8G+gqTU2zKjlWtPRgWLhNPCuO+G8J//UNRrLoRhepOzduhDF+eqe2K9nVfY9fUp4ZxeIVzevN+GdoirY5Rlp18N1l10dPdGMTpLlSxZOQD9oCeq5m6FfiOEC1Y+4GQTCoiPuIb+/4yx9l8sAjrKsawJ1vl1cG2ZPmFNbSNPIEIwLGPIz+HZ+F0TiSTievu2vOX26faaWzWla3bLlTjyIo39+TkFQk5CeJUQ881cymKZoIrBROh7niAd2LQLBhZr2JnuxXbQAzsK59hKgx0m3m8UGw19PdMrUiUEG4eveG+byYOQExJkuXKok0m42L2D4xvX5ozVFfZ+xPxg5YkqyIQK1zBNa5NBFKfiWQoY0BvFzhE56DgmiW/qhzWoOGICosVnQHMEhUFjjcq4dmg3eqIEhu+J0FnZZHBZfY21JkNI5YFGn1a/oN5HlUVOktCKsdN2fW0zsE4aghRRnxLW5YKAqIXX486ZnixY0y1zX0uSLO1R3I8P8Tlm/rOppp8VEplPZ+bDesFfalf0X7Re/z1nUm8p3gNLfnAbsoyESmpzWGklveHv1ReHD7yg8zjugOIWQL8ZHAnRe2WICk289W2fggQYbgowYEdmVZC8NZu8/a4OkUK843V1iDsSsWxQBzTM4AeF7i9SioUEbH979juCby7lbcx/Td9IbxgV4ikEF1jF/NCnetAIntbm H6q+ScSP 5dbLciB09+A2pLHlzzP1CYLJfvjNlEJMDUH5/KegD0h1K/B6o4tk2CWXH6vThw+D7+Bc4CjU6d6ZsBNFUs40X2ehNzBoGDRTCRJaL45A/y/nfw6hehpnnmAHX63ZG6CTZjw/HK8elFcKginny/zOYlaErSFGXFrSFTAi/ftqVmw0wfzlwCpPlaUkw2+pb33aNNuois9LW8xJgCX1Ya/JIaBXUi81iF1qzW578klY/QulpcDgQof1LYBm1kCS/59egggqEgORDXTpnBMO4dfkSEdoqzltra6VECVLYeq2pihsDdnxbcV3rgZZGBhEeZFI+0Z6m/sknpR4Q7QUZHGBf/GHjTYj9EQCiXHxFuZ+EFko6ARgNO7is+k20ML5tywLBuxamCetcmMVGavwcvFIFdq6cTPJ9GY82/vcsyFzgh2cjJ7I= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 21 Aug 2023 10:39:20 -0700, Hugh Dickins wrote: > It is particularly important for the userns mount case (when a sensible > nr_inodes maximum may not be enforced) that tmpfs user xattrs be subject > to memory cgroup limiting. Leave temporary buffer allocations as is, > but change the persistent simple xattr allocations from GFP_KERNEL to > GFP_KERNEL_ACCOUNT. This limits kernfs's cgroupfs too, but that's good. > > (I had intended to send this change earlier, but had been confused by > shmem_alloc_inode() using GFP_KERNEL, and thought a discussion would be > needed to change that too: no, I was forgetting the SLAB_ACCOUNT on that > kmem_cache, which implicitly adds __GFP_ACCOUNT to all its allocations.) > > [...] Applied to the vfs.tmpfs branch of the vfs/vfs.git tree. Patches in the vfs.tmpfs branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.tmpfs [1/1] tmpfs,xattr: GFP_KERNEL_ACCOUNT for simple xattrs https://git.kernel.org/vfs/vfs/c/572a3d1e5d3a