From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 168E4EE4996 for ; Mon, 21 Aug 2023 15:38:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9125D8D0001; Mon, 21 Aug 2023 11:38:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A4C86B0075; Mon, 21 Aug 2023 11:38:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 714BB8D0001; Mon, 21 Aug 2023 11:38:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5B5046B0074 for ; Mon, 21 Aug 2023 11:38:03 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2CDEA1C993C for ; Mon, 21 Aug 2023 15:38:03 +0000 (UTC) X-FDA: 81148517646.16.DC43E8D Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by imf01.hostedemail.com (Postfix) with ESMTP id B4E604002C for ; Mon, 21 Aug 2023 15:38:00 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="J/Wf7+iA"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692632281; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=CIPCzstNSSRocr734NDvuMWQt/eV1ZkWxqvVLeTMeWs=; b=DugHyTBCYItx70CEusMP7hg5B+DVSOLYytA6gaHVxOMDn/ctv98gefmHCBSCd/PYCNiqZo cYbF+4LU9z7xqFHpfnf/aJ92zeh3/mC/ocDFkBvZh0SYIqSxQ/xmSC6sxYgqhOzkhGbHBh dgSSCwDAB6YNFfwO3cbgto/vAERe2Ag= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="J/Wf7+iA"; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf01.hostedemail.com: domain of lkp@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692632281; a=rsa-sha256; cv=none; b=JBxyKIai3qimPdxpkXDDCFOtjVZApjVsA3xPzBr65ElTFv9mPFzLpJzzSO5YgxprdoS//p S3WKj7HqRDEAVoT4WCyuJBK2M9bt2uK7eyDXpX0RjbDTh/bG1hpVXIdrTlkrz9ev+hDxFq RDpLTbQFa2f6ZKpJfmN3iJHud1PqDVQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692632280; x=1724168280; h=date:from:to:cc:subject:message-id:mime-version; bh=7YIL7afJRiwZcQa2kOENWh7rvlFztE9aqcKdY2Sgwdg=; b=J/Wf7+iAvENPcN1EpuU+3EuXw8/K6ycJAyFrLTH1ME/vyCsZVaZZ908B 7iLrP3Aw99PC8YcVTB2dsmRylCAE7au9EoStHFHfd4njfZB/PLGUAr4Qu BtkTPHoDnudN48XTIWr/7Suete5BEisTKY+SYVpMRWq2UsuxZgnNnmgM4 PsCJ8axfyq0+ZONuDcgnutahk7bJGUDtwOTm/fgspF6kKReV9XWtP7ZxR mCYGaVkbjF87dwySC5bfKT5BYaWuyKxRJNJGJbtCkbcXLunw9CjiYKMzi 4fvxaPnWmK2jMbCmCoquLQMBs91uCvO69JGhLsBjHAm7Tp08Ehc4evym9 g==; X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="358608928" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="358608928" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Aug 2023 08:37:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10809"; a="850232686" X-IronPort-AV: E=Sophos;i="6.01,190,1684825200"; d="scan'208";a="850232686" Received: from lkp-server02.sh.intel.com (HELO 6809aa828f2a) ([10.239.97.151]) by fmsmga002.fm.intel.com with ESMTP; 21 Aug 2023 08:37:50 -0700 Received: from kbuild by 6809aa828f2a with local (Exim 4.96) (envelope-from ) id 1qY6y2-0000eG-1C; Mon, 21 Aug 2023 15:37:33 +0000 Date: Mon, 21 Aug 2023 23:36:03 +0800 From: kernel test robot To: "Darrick J. Wong" Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Christoph Hellwig , Dave Chinner , Jan Kara Subject: [linux-next:master 2069/11453] fs/gfs2/super.c:767: warning: Function parameter or member 'who' not described in 'gfs2_freeze_super' Message-ID: <202308212348.1TirdKeg-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Queue-Id: B4E604002C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 6wntngent9yuzuugeiy8beozi6hy3ohf X-HE-Tag: 1692632280-264234 X-HE-Meta: U2FsdGVkX1+qRxa42DSWcL22QwsTJR4wiHJtMuhhLx5HiEYTqDqHCmd/j13Cgw6aF5In7AhdwdPnLoGU1GRkSaiQev6bjEwvKXEidK+Xj4hWr61x8jfHYUCxsnDna0o+F7D3Kmr7JW3SLWLi4p8Rsv4cTaUs0WspeTSiO4g7v2PhDhxtVj0/pMURXrELDzU66vbvDx9erW2ji4NVBlK8sjHKxFdBfRKl7BgOsjUnQkZ1Iwl4yiUtaTlC+mqLymIPnHd5Rz2hnIlrwMHJhf8cHO1dSuK1++MCV2/mCEAe6YcsNmZtKeD5OF7jOvVTelg4G60HYecHlSP8jc5dGYty4CPiVx1ZH/iLX4psldlAHemWcTy0hGZkeBCIKYedCY5EQG7S0MNncqvgq4gCue8+FaZejzSCcRlyMUX6tGHlmFAirWCfdB81YQ0Ptt788RbT/90WMoyFZXSWhnKR9BQBFAW+TPJ1CarFj7X9V8KxAk+BY0UWseXvJ67gCskY8yOGp6jw0JCf02s3Vs0SYkZ9y0wZnkadS/+TBs2EeaIQ4M+Pvl+2C5/PRwUEZDADlQJQNzkw+yawbW9vR3nSEQZagd/nalFwsEwnm1Qc6kK/3rcwOgFk6ZqbIQy7Ae9DnHjpzHsRym/IJbU4+5YXVD3ZuU6KWa4GBqgXVJn0Y3+SqaUA0HNnVVKCNgUzrOYEGjYthZT01wOdwvgMlLlZVSkf0v+qKVRNce6EUPqjYQuGb0TyO7OUOZBpwmK8c/BiBAtG287VW1Kau2xzNVldOyYh7sRbXjM4oB7viue4SBHGDvZ5I7oarxgDhR0cIr9HHyJCih7jmh2JNPIT2kYriH6O5V6iD87DEdOWH433mIxgsVlaiBVf3XyTUES6bJOjVv6HJT8LelZD409upWq6QmJ2PgeWcE/ZzMroZt8cKG23HiBsVDHuvD4xDgWB2ZDobc+KLV2xBqM9h6Fvs/l97N0 EhZO9oCv dTFleUi62h+ebYV34gwU0GR8rdOVObAudUe4/U08UYPqWfkbJenxB9EEy46zfp6D6An8Eey9v75bXPLDMAAtHq1kDThro5aM8wGNnPhUMlHlvmd5SmPk/BOBQDDQhMgbEia2XvGMMDXzAeZS76T52CTavCJFjBk2Rci6ysXTNHhp9kJP8Is0dmUQD3BBYiusucBFwQSOanzD4X626GmuKkOtk6//yuHb8hVBxsN1KXygwFqMSnUpIVs3KOKliIU2pXu6GAwsn9SfDOs+uQzMJrvFVE18kH7d/gOKEpOXaA4p7jRcmPdBL30hwFSySkk+wBn5GYHMvg3fnkJ2qVpL1TXJjJ7x4jQFhGzZmHyCNYnJh9y+ouAZAuqGj7w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: 47d9bb711707d15b19fad18c8e2b4b027a264a3a commit: 880b9577855edddda1e732748e849c63199d489b [2069/11453] fs: distinguish between user initiated freeze and kernel initiated freeze config: alpha-randconfig-r011-20230821 (https://download.01.org/0day-ci/archive/20230821/202308212348.1TirdKeg-lkp@intel.com/config) compiler: alpha-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230821/202308212348.1TirdKeg-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308212348.1TirdKeg-lkp@intel.com/ All warnings (new ones prefixed by >>): >> fs/gfs2/super.c:767: warning: Function parameter or member 'who' not described in 'gfs2_freeze_super' >> fs/gfs2/super.c:822: warning: Function parameter or member 'who' not described in 'gfs2_thaw_super' vim +767 fs/gfs2/super.c 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 759 9e6e0a128bca0a Steven Whitehouse 2009-05-22 760 /** 097cca525adf10 Andreas Gruenbacher 2022-11-14 761 * gfs2_freeze_super - prevent further writes to the filesystem 9e6e0a128bca0a Steven Whitehouse 2009-05-22 762 * @sb: the VFS structure for the filesystem 9e6e0a128bca0a Steven Whitehouse 2009-05-22 763 * 9e6e0a128bca0a Steven Whitehouse 2009-05-22 764 */ 9e6e0a128bca0a Steven Whitehouse 2009-05-22 765 880b9577855edd Darrick J. Wong 2023-07-17 766 static int gfs2_freeze_super(struct super_block *sb, enum freeze_holder who) 9e6e0a128bca0a Steven Whitehouse 2009-05-22 @767 { 9e6e0a128bca0a Steven Whitehouse 2009-05-22 768 struct gfs2_sbd *sdp = sb->s_fs_info; ff132c5f93c06b Bob Peterson 2021-03-25 769 int error; 9e6e0a128bca0a Steven Whitehouse 2009-05-22 770 b77b4a4815a965 Andreas Gruenbacher 2022-11-14 771 if (!mutex_trylock(&sdp->sd_freeze_mutex)) b77b4a4815a965 Andreas Gruenbacher 2022-11-14 772 return -EBUSY; ff132c5f93c06b Bob Peterson 2021-03-25 773 error = -EBUSY; 5432af15f8772d Andreas Gruenbacher 2022-08-18 774 if (test_bit(SDF_FROZEN, &sdp->sd_flags)) 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 775 goto out; 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 776 60528afa78667b Bob Peterson 2019-11-14 777 for (;;) { b77b4a4815a965 Andreas Gruenbacher 2022-11-14 778 error = gfs2_freeze_locally(sdp); b77b4a4815a965 Andreas Gruenbacher 2022-11-14 779 if (error) { b77b4a4815a965 Andreas Gruenbacher 2022-11-14 780 fs_info(sdp, "GFS2: couldn't freeze filesystem: %d\n", b77b4a4815a965 Andreas Gruenbacher 2022-11-14 781 error); 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 782 goto out; 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 783 } 9e6e0a128bca0a Steven Whitehouse 2009-05-22 784 52b1cdcb7a84a4 Bob Peterson 2019-11-15 785 error = gfs2_lock_fs_check_clean(sdp); 9e6e0a128bca0a Steven Whitehouse 2009-05-22 786 if (!error) b77b4a4815a965 Andreas Gruenbacher 2022-11-14 787 break; /* success */ b77b4a4815a965 Andreas Gruenbacher 2022-11-14 788 b77b4a4815a965 Andreas Gruenbacher 2022-11-14 789 error = gfs2_do_thaw(sdp); b77b4a4815a965 Andreas Gruenbacher 2022-11-14 790 if (error) b77b4a4815a965 Andreas Gruenbacher 2022-11-14 791 goto out; 9e6e0a128bca0a Steven Whitehouse 2009-05-22 792 55317f5b00f0dc Bob Peterson 2019-04-29 793 if (error == -EBUSY) 9e6e0a128bca0a Steven Whitehouse 2009-05-22 794 fs_err(sdp, "waiting for recovery before freeze\n"); 52b1cdcb7a84a4 Bob Peterson 2019-11-15 795 else if (error == -EIO) { 52b1cdcb7a84a4 Bob Peterson 2019-11-15 796 fs_err(sdp, "Fatal IO error: cannot freeze gfs2 due " 52b1cdcb7a84a4 Bob Peterson 2019-11-15 797 "to recovery error.\n"); 52b1cdcb7a84a4 Bob Peterson 2019-11-15 798 goto out; 52b1cdcb7a84a4 Bob Peterson 2019-11-15 799 } else { 9e6e0a128bca0a Steven Whitehouse 2009-05-22 800 fs_err(sdp, "error freezing FS: %d\n", error); 52b1cdcb7a84a4 Bob Peterson 2019-11-15 801 } 9e6e0a128bca0a Steven Whitehouse 2009-05-22 802 fs_err(sdp, "retrying...\n"); 9e6e0a128bca0a Steven Whitehouse 2009-05-22 803 msleep(1000); 9e6e0a128bca0a Steven Whitehouse 2009-05-22 804 } b77b4a4815a965 Andreas Gruenbacher 2022-11-14 805 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 806 out: b77b4a4815a965 Andreas Gruenbacher 2022-11-14 807 if (!error) { b77b4a4815a965 Andreas Gruenbacher 2022-11-14 808 set_bit(SDF_FREEZE_INITIATOR, &sdp->sd_flags); 5432af15f8772d Andreas Gruenbacher 2022-08-18 809 set_bit(SDF_FROZEN, &sdp->sd_flags); b77b4a4815a965 Andreas Gruenbacher 2022-11-14 810 } 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 811 mutex_unlock(&sdp->sd_freeze_mutex); 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 812 return error; 9e6e0a128bca0a Steven Whitehouse 2009-05-22 813 } 9e6e0a128bca0a Steven Whitehouse 2009-05-22 814 9e6e0a128bca0a Steven Whitehouse 2009-05-22 815 /** 097cca525adf10 Andreas Gruenbacher 2022-11-14 816 * gfs2_thaw_super - reallow writes to the filesystem 9e6e0a128bca0a Steven Whitehouse 2009-05-22 817 * @sb: the VFS structure for the filesystem 9e6e0a128bca0a Steven Whitehouse 2009-05-22 818 * 9e6e0a128bca0a Steven Whitehouse 2009-05-22 819 */ 9e6e0a128bca0a Steven Whitehouse 2009-05-22 820 880b9577855edd Darrick J. Wong 2023-07-17 821 static int gfs2_thaw_super(struct super_block *sb, enum freeze_holder who) 9e6e0a128bca0a Steven Whitehouse 2009-05-22 @822 { d564053f074634 Steven Whitehouse 2013-01-11 823 struct gfs2_sbd *sdp = sb->s_fs_info; b77b4a4815a965 Andreas Gruenbacher 2022-11-14 824 int error; d564053f074634 Steven Whitehouse 2013-01-11 825 b77b4a4815a965 Andreas Gruenbacher 2022-11-14 826 if (!mutex_trylock(&sdp->sd_freeze_mutex)) b77b4a4815a965 Andreas Gruenbacher 2022-11-14 827 return -EBUSY; b77b4a4815a965 Andreas Gruenbacher 2022-11-14 828 error = -EINVAL; b77b4a4815a965 Andreas Gruenbacher 2022-11-14 829 if (!test_bit(SDF_FREEZE_INITIATOR, &sdp->sd_flags)) b77b4a4815a965 Andreas Gruenbacher 2022-11-14 830 goto out; b77b4a4815a965 Andreas Gruenbacher 2022-11-14 831 b77b4a4815a965 Andreas Gruenbacher 2022-11-14 832 gfs2_freeze_unlock(&sdp->sd_freeze_gh); b77b4a4815a965 Andreas Gruenbacher 2022-11-14 833 b77b4a4815a965 Andreas Gruenbacher 2022-11-14 834 error = gfs2_do_thaw(sdp); b77b4a4815a965 Andreas Gruenbacher 2022-11-14 835 b77b4a4815a965 Andreas Gruenbacher 2022-11-14 836 if (!error) { b77b4a4815a965 Andreas Gruenbacher 2022-11-14 837 clear_bit(SDF_FREEZE_INITIATOR, &sdp->sd_flags); 5432af15f8772d Andreas Gruenbacher 2022-08-18 838 clear_bit(SDF_FROZEN, &sdp->sd_flags); b77b4a4815a965 Andreas Gruenbacher 2022-11-14 839 } b77b4a4815a965 Andreas Gruenbacher 2022-11-14 840 out: 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 841 mutex_unlock(&sdp->sd_freeze_mutex); b77b4a4815a965 Andreas Gruenbacher 2022-11-14 842 return error; 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 843 } 2e60d7683c8d2e Benjamin Marzinski 2014-11-13 844 :::::: The code at line 767 was first introduced by commit :::::: 9e6e0a128bca0a151d8d3fbd9459b22fc21cfebb GFS2: Merge mount.c and ops_super.c into super.c :::::: TO: Steven Whitehouse :::::: CC: Steven Whitehouse -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki