* [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask [not found] <20230811115945.3423894-1-shikemeng@huaweicloud.com> @ 2023-08-11 11:59 ` Kemeng Shi 2023-08-11 4:28 ` Matthew Wilcox ` (2 more replies) [not found] ` <20230811115945.3423894-3-shikemeng@huaweicloud.com> 1 sibling, 3 replies; 6+ messages in thread From: Kemeng Shi @ 2023-08-11 11:59 UTC (permalink / raw) To: linux-mm, linux-kernel, akpm, baolin.wang, mgorman, david, willy Cc: shikemeng Function get_pfnblock_flags_mask just calls inline inner __get_pfnblock_flags_mask without any extra work. Just opencode __get_pfnblock_flags_mask in get_pfnblock_flags_mask and replace call to __get_pfnblock_flags_mask with call to get_pfnblock_flags_mask to remove unnecessary __get_pfnblock_flags_mask. Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> --- mm/page_alloc.c | 30 +++++++++++------------------- 1 file changed, 11 insertions(+), 19 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index e884d3fd0d06..6c2294ccc6cb 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -371,10 +371,16 @@ static inline int pfn_to_bitidx(const struct page *page, unsigned long pfn) return (pfn >> pageblock_order) * NR_PAGEBLOCK_BITS; } -static __always_inline -unsigned long __get_pfnblock_flags_mask(const struct page *page, - unsigned long pfn, - unsigned long mask) +/** + * get_pfnblock_flags_mask - Return the requested group of flags for the pageblock_nr_pages block of pages + * @page: The page within the block of interest + * @pfn: The target page frame number + * @mask: mask of bits that the caller is interested in + * + * Return: pageblock_bits flags + */ +unsigned long get_pfnblock_flags_mask(const struct page *page, + unsigned long pfn, unsigned long mask) { unsigned long *bitmap; unsigned long bitidx, word_bitidx; @@ -393,24 +399,10 @@ unsigned long __get_pfnblock_flags_mask(const struct page *page, return (word >> bitidx) & mask; } -/** - * get_pfnblock_flags_mask - Return the requested group of flags for the pageblock_nr_pages block of pages - * @page: The page within the block of interest - * @pfn: The target page frame number - * @mask: mask of bits that the caller is interested in - * - * Return: pageblock_bits flags - */ -unsigned long get_pfnblock_flags_mask(const struct page *page, - unsigned long pfn, unsigned long mask) -{ - return __get_pfnblock_flags_mask(page, pfn, mask); -} - static __always_inline int get_pfnblock_migratetype(const struct page *page, unsigned long pfn) { - return __get_pfnblock_flags_mask(page, pfn, MIGRATETYPE_MASK); + return get_pfnblock_flags_mask(page, pfn, MIGRATETYPE_MASK); } /** -- 2.30.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask 2023-08-11 11:59 ` [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask Kemeng Shi @ 2023-08-11 4:28 ` Matthew Wilcox 2023-08-21 12:20 ` Mel Gorman 2023-08-21 21:23 ` Johannes Weiner 2 siblings, 0 replies; 6+ messages in thread From: Matthew Wilcox @ 2023-08-11 4:28 UTC (permalink / raw) To: Kemeng Shi; +Cc: linux-mm, linux-kernel, akpm, baolin.wang, mgorman, david On Fri, Aug 11, 2023 at 07:59:44PM +0800, Kemeng Shi wrote: > Function get_pfnblock_flags_mask just calls inline inner > __get_pfnblock_flags_mask without any extra work. Just opencode > __get_pfnblock_flags_mask in get_pfnblock_flags_mask and replace call > to __get_pfnblock_flags_mask with call to get_pfnblock_flags_mask to > remove unnecessary __get_pfnblock_flags_mask. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org> This could have happened at any time after 535b81e20921 (and arguably should have happened as part of it) ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask 2023-08-11 11:59 ` [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask Kemeng Shi 2023-08-11 4:28 ` Matthew Wilcox @ 2023-08-21 12:20 ` Mel Gorman 2023-08-21 21:23 ` Johannes Weiner 2 siblings, 0 replies; 6+ messages in thread From: Mel Gorman @ 2023-08-21 12:20 UTC (permalink / raw) To: Kemeng Shi; +Cc: linux-mm, linux-kernel, akpm, baolin.wang, david, willy On Fri, Aug 11, 2023 at 07:59:44PM +0800, Kemeng Shi wrote: > Function get_pfnblock_flags_mask just calls inline inner > __get_pfnblock_flags_mask without any extra work. Just opencode > __get_pfnblock_flags_mask in get_pfnblock_flags_mask and replace call > to __get_pfnblock_flags_mask with call to get_pfnblock_flags_mask to > remove unnecessary __get_pfnblock_flags_mask. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Acked-by: Mel Gorman <mgorman@techsingularity.net> -- Mel Gorman SUSE Labs ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask 2023-08-11 11:59 ` [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask Kemeng Shi 2023-08-11 4:28 ` Matthew Wilcox 2023-08-21 12:20 ` Mel Gorman @ 2023-08-21 21:23 ` Johannes Weiner 2 siblings, 0 replies; 6+ messages in thread From: Johannes Weiner @ 2023-08-21 21:23 UTC (permalink / raw) To: Kemeng Shi Cc: linux-mm, linux-kernel, akpm, baolin.wang, mgorman, david, willy On Fri, Aug 11, 2023 at 07:59:44PM +0800, Kemeng Shi wrote: > Function get_pfnblock_flags_mask just calls inline inner > __get_pfnblock_flags_mask without any extra work. Just opencode > __get_pfnblock_flags_mask in get_pfnblock_flags_mask and replace call > to __get_pfnblock_flags_mask with call to get_pfnblock_flags_mask to > remove unnecessary __get_pfnblock_flags_mask. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20230811115945.3423894-3-shikemeng@huaweicloud.com>]
* Re: [PATCH 2/2] mm/page_alloc: use get_pfnblock_migratetype to avoid extra page_to_pfn [not found] ` <20230811115945.3423894-3-shikemeng@huaweicloud.com> @ 2023-08-21 12:21 ` Mel Gorman 2023-08-21 21:24 ` Johannes Weiner 1 sibling, 0 replies; 6+ messages in thread From: Mel Gorman @ 2023-08-21 12:21 UTC (permalink / raw) To: Kemeng Shi; +Cc: linux-mm, linux-kernel, akpm, baolin.wang, david, willy On Fri, Aug 11, 2023 at 07:59:45PM +0800, Kemeng Shi wrote: > We have get_pageblock_migratetype and get_pfnblock_migratetype to get > migratetype of page. get_pfnblock_migratetype accepts both page and pfn > from caller while get_pageblock_migratetype only accept page and get pfn > with page_to_pfn from page. > In case we already record pfn of page, we can simply call > get_pfnblock_migratetype to avoid a page_to_pfn. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Acked-by: Mel Gorman <mgorman@techsingularity.net> -- Mel Gorman SUSE Labs ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] mm/page_alloc: use get_pfnblock_migratetype to avoid extra page_to_pfn [not found] ` <20230811115945.3423894-3-shikemeng@huaweicloud.com> 2023-08-21 12:21 ` [PATCH 2/2] mm/page_alloc: use get_pfnblock_migratetype to avoid extra page_to_pfn Mel Gorman @ 2023-08-21 21:24 ` Johannes Weiner 1 sibling, 0 replies; 6+ messages in thread From: Johannes Weiner @ 2023-08-21 21:24 UTC (permalink / raw) To: Kemeng Shi Cc: linux-mm, linux-kernel, akpm, baolin.wang, mgorman, david, willy On Fri, Aug 11, 2023 at 07:59:45PM +0800, Kemeng Shi wrote: > We have get_pageblock_migratetype and get_pfnblock_migratetype to get > migratetype of page. get_pfnblock_migratetype accepts both page and pfn > from caller while get_pageblock_migratetype only accept page and get pfn > with page_to_pfn from page. > In case we already record pfn of page, we can simply call > get_pfnblock_migratetype to avoid a page_to_pfn. > > Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-08-21 21:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230811115945.3423894-1-shikemeng@huaweicloud.com>
2023-08-11 11:59 ` [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask Kemeng Shi
2023-08-11 4:28 ` Matthew Wilcox
2023-08-21 12:20 ` Mel Gorman
2023-08-21 21:23 ` Johannes Weiner
[not found] ` <20230811115945.3423894-3-shikemeng@huaweicloud.com>
2023-08-21 12:21 ` [PATCH 2/2] mm/page_alloc: use get_pfnblock_migratetype to avoid extra page_to_pfn Mel Gorman
2023-08-21 21:24 ` Johannes Weiner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox