From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20C38EE49A6 for ; Mon, 21 Aug 2023 21:24:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B2A00280007; Mon, 21 Aug 2023 17:24:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD895280005; Mon, 21 Aug 2023 17:24:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9A0DF280007; Mon, 21 Aug 2023 17:24:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 87595280005 for ; Mon, 21 Aug 2023 17:24:01 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 63FE51C9BF8 for ; Mon, 21 Aug 2023 21:24:01 +0000 (UTC) X-FDA: 81149389482.25.A95A023 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by imf06.hostedemail.com (Postfix) with ESMTP id 1DF8B180028 for ; Mon, 21 Aug 2023 21:23:58 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=j8Zr+W7Y; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692653039; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DP6IDsgCHUZqVeY6SUa+gx+l+qskomA4jh82+amtcws=; b=DIFREo60kRsiRuDFYEsx2GR3VeikJVz2oOUrmZ2HQ/8E62ysUFUYJoSN+gR808cOlBfLoI dvqHYwUv84X4+hDr1JxyJyNG/FYszO9bgms1+Hdv9E7rDgJ83t6R/YLUFzq0DYdFDBlHeC x+HzE4JGh3Nw0oJ16qisAnRtzGQi1s0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=cmpxchg-org.20221208.gappssmtp.com header.s=20221208 header.b=j8Zr+W7Y; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf06.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.222.173 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692653039; a=rsa-sha256; cv=none; b=u4ZlS75T77wWiXLR9TEUm6eb6voviVo3myzb/Vh5IHrmdlOaIX9IlS4tHA3l4PHGctNsWr lOH53+A3Ac2Tqz3wWgXZvMTnO7nbCnQBXiBRlQ9gpWmjXy/je/nYm7ERuf5eKAE1y+B/Ri e0p2TpV/BHCharYwaVI0Pfu6sw30d2w= Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-76db3361628so3171085a.0 for ; Mon, 21 Aug 2023 14:23:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20221208.gappssmtp.com; s=20221208; t=1692653038; x=1693257838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DP6IDsgCHUZqVeY6SUa+gx+l+qskomA4jh82+amtcws=; b=j8Zr+W7YMa40iJK+BLVYWT/YVZ3X1KKH0Hn4zfaXo2+6BHsjjVlIkDnVzDSvGQ+50m CgAlRlWvuZQIZcibXUYK/g1bHIvw5QiDW4meQvTHXWiGMvqiTG/YAu/iC0Ms+eyL/lWn s+Af7PHZQhuQE7RCT2aMCue8WuQSjPuLEZdz+6l8LajIpRI82ovsbwVl86h2Qth8/oMF uyOGz4IlHCw74e13AEutfbBNbL3l3lhV8e9QB+H5udwmCoZt35dWash+89oqxn389jYE ICp0amFGh06HhgeKEzHOHx6UqxH9ZoNxiGSNAS6lQBwfkVrgB+rMTobRZrHZW+2VbLie Nj/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692653038; x=1693257838; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DP6IDsgCHUZqVeY6SUa+gx+l+qskomA4jh82+amtcws=; b=EvYk204aZVNmkZC3xZ2V9kCPupnSWxpPKZ3b4lF8pM6ZairmEGEMkEe9Tcua36Gjla n9fg0HunmDN4N4BmemzfGUcCvN2qPQwTYrWqyhGWm8Vlu6Wm4syLpEVpSIwUM0l9YDF0 kfr0EF8Qut9KClnj020vKMmd1B3MOnjm0C4iwD4KsKS4U0ivfCoiRrAPlZ9QwZMtWUF0 EMAPlxIZAExOkbVnv3Y8uPNV7qi7Okt9WZC7wIDG30pN9xybQfJZW6vNABftl/GfG4eC sIoAScbveVoQyOgF44xicdwmU6YiiXUPM9ABDRzKCfRmj9Vv9QnYqR8NlU8H/cZj5zu9 MFyg== X-Gm-Message-State: AOJu0Yw7exMK2is8suiVrpc/JuQTmQQU1vYqM2dB2S+XC2b3gHmBhQUI aNiXBOUtr9uTo8XlVsZQp90JZQ== X-Google-Smtp-Source: AGHT+IHDpY9KDQrcZKpW6g0neLmQwOGB/c0MbsD5Cg/XSeQ9GXuPzIdBXl4oXKhBDR0jHEtnfIM1kQ== X-Received: by 2002:a0c:b452:0:b0:639:91ad:64d6 with SMTP id e18-20020a0cb452000000b0063991ad64d6mr7151887qvf.61.1692653038141; Mon, 21 Aug 2023 14:23:58 -0700 (PDT) Received: from localhost (2603-7000-0c01-2716-699c-6fe1-d2a8-6a30.res6.spectrum.com. [2603:7000:c01:2716:699c:6fe1:d2a8:6a30]) by smtp.gmail.com with ESMTPSA id x4-20020a0cb204000000b0063642bcc5e4sm3238893qvd.9.2023.08.21.14.23.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 14:23:57 -0700 (PDT) Date: Mon, 21 Aug 2023 17:23:57 -0400 From: Johannes Weiner To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, mgorman@techsingularity.net, david@redhat.com, willy@infradead.org Subject: Re: [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask Message-ID: <20230821212357.GD106501@cmpxchg.org> References: <20230811115945.3423894-1-shikemeng@huaweicloud.com> <20230811115945.3423894-2-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230811115945.3423894-2-shikemeng@huaweicloud.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 1DF8B180028 X-Stat-Signature: exw3bf83kxgpd7swaq7u7m6tydi4iwq5 X-Rspam-User: X-HE-Tag: 1692653038-662677 X-HE-Meta: U2FsdGVkX1/TccAQaPEYFgHLX6l54TwkkO4u1Q5/xmqw/SxzX+Zed/8FOEpcPaP9LGJG0kO2O5Hn6vAtNMDD9dqGdS+AHdHnS5pD7kmH5BD5ZkADCfBcS2AyBNqo8gM9sePFBGyEJNogOMU5JLikKhnvCIVyt4BTywDFyRvUxlFn122+5/iYE4z1P0qn1X3CekxYZrogiobu2uMfjLPfR/byMTcBtH8K2TqknoQmtZbOR7x2EjHUf4UP1ck7Ia/sjmP+FwdVFsZlSrHoOqfl23yGCQkDKagBaxBN61Fa3IL4/0RURtAOTAFQvJR76tU6H5Qsq5rdUBs+z48IUS4iIIba4SxsasBu/FLhvVVS6Y2LjWJxi8vb0jDFWr6RNwdAEnSe2RskVn3mQWC9pTqYS3eNZSSiX6W0aYRvJkjmL9GFTPVKNuWahKP94I+3i+wuexOlrwEzWp1oEq7qnX4A2gjb4U+KaTAC1ArlXeg5xUeIoaTU3BgIRewTEoYFtYkuH47FUxHhauquqSX5ukdr6JneLvH2v7Al5aSV9DNZOimULiKXJVtUj14Xsg6xEh3KeAm1GTD5XBORgBzqBx74Wxh3bhXrd7xNdxX432X43pUyTqzHxql88k4ZEmrVu2GPAhLiuodTqYi2yGnRyI/RIIu0SDQf0jUalWG8tzGF+VWPLZejYi21WDi8F+js/TiJKjx7UGWtVj6J93wVHRaRS7+8p0EuvwOLmF9NyFem3X7p38obIq9wHdnnGvAeZJmZ4X2qvveBnR9cjDfBde1pUFvQwjrcfUjcEnnnCcbL2rJnVxi5Dkj6FrNwFN+F8iORGMTgn/N99rfpUhac9EdbrfdIlW/7kb0FdmaQPAm/P+3VZCCRWRXv80Nnzxq9aVVcKDOyKJYfgstFd0d+2xcnuo54u9COwakzvHjDaks25AJpgEX20P8FWfDgBcL/hgp7VDKlBSzboslws/2jVl4 SCOfcQLd dVA14r2mQlxHhaep+D9ouU+eCVzX/70RaBwuuOBi+MIlpJo3ibBPD2tPeNQeeo3wiLa6laxz2RpabjoG0UuMzlLcxFveQ5qAohAoE6BWCcphlIHFxMDrp1L2eTj98ia6Aih9vTnQktn/hLvm/HXOklFF7MDIs0aRAk6qm6IJWFFnL/HRHibaQKsWKK+ClVHfDDPyLdZBYep/Wpg1UzSwyWY46r0Qcq1RCxj5w0GUrmEMyba9wKdEBhTovGX201CzYl5NAuW9dx1XOON7FfqzCj5k2NFr5/uzdgXxvwFg0QYYkCdtshlGjrzMd28crB9yVEqiPsdaWERwMHjjNZyNdeMsGQltgYWNWYEYyK2bUVu0jLncqTJg5V3rTGceBJz1sGqRCVBA8xN8x7qhh0kQPqrwn8fcrnnqgP7dSwS35Rgw5CN7qDS/DA3S4sXKtsbBI95xpLFHzAFL+BGWSMFujU4FwavVZHnp4Pik+8f81hPBOyU6bB3RGKeJ91JYFlTdmYy8rickedDM80Vrjpa4x+6pSpdo+fqoZcI/FroSFw/S6mmpjMXJ6/Gmt7A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000776, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 11, 2023 at 07:59:44PM +0800, Kemeng Shi wrote: > Function get_pfnblock_flags_mask just calls inline inner > __get_pfnblock_flags_mask without any extra work. Just opencode > __get_pfnblock_flags_mask in get_pfnblock_flags_mask and replace call > to __get_pfnblock_flags_mask with call to get_pfnblock_flags_mask to > remove unnecessary __get_pfnblock_flags_mask. > > Signed-off-by: Kemeng Shi Acked-by: Johannes Weiner