From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27561EE49A6 for ; Mon, 21 Aug 2023 17:57:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A67F8E0013; Mon, 21 Aug 2023 13:57:39 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9531F8E0002; Mon, 21 Aug 2023 13:57:39 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81C428E0013; Mon, 21 Aug 2023 13:57:39 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 72D108E0002 for ; Mon, 21 Aug 2023 13:57:39 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3FA8DB239A for ; Mon, 21 Aug 2023 17:57:39 +0000 (UTC) X-FDA: 81148869438.21.C7D6D97 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf07.hostedemail.com (Postfix) with ESMTP id 1728040012 for ; Mon, 21 Aug 2023 17:57:36 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GQZuukXe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zwrF1l6o; dmarc=none; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692640657; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gCIG0JsVp3QHiEtAiEKjNvHMosM+Qxtt2B4cFNpJCOI=; b=Id4V+apdq3awQ5lXAbrmQ/LzJy6MzSXBArllIJMBxDSON/g7c6UIRxe5HMJA2tBS6jxBYD NN+pEX/4zB3su9sKXh1OW/JtJIxNF88ABi1VAbxvZqxMb6sCfuYq3/IyFY6+9yWFamIcYL FgUu8ZIHU33DDxJYOqjec4Es7tk/BuE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=GQZuukXe; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=zwrF1l6o; dmarc=none; spf=pass (imf07.hostedemail.com: domain of jack@suse.cz designates 195.135.220.29 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692640657; a=rsa-sha256; cv=none; b=B7GOCPOJiH415uKPYpmD4TwVhUMBnGXgAtD0bnF317mTtschf0+x/xLv66tl7PLb4ZA0VU 7aQDqrHwfR1BQdWhHUWuZF+6HG53e3/S+uUJ/pRHwP8NB8KbLHAJ1ga+V6gOainXcaQbo3 TMuVPaLN3IXcKLtSMsg1tGqiE5k9Tjk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B45711F459; Mon, 21 Aug 2023 17:57:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1692640654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gCIG0JsVp3QHiEtAiEKjNvHMosM+Qxtt2B4cFNpJCOI=; b=GQZuukXeDNvRLCN8jLrQYJU2wQcy73fzQZ9trFI9HxSWJ39JQSkAOiUDqtYoHCfdDPSJqn OniSYqhVzxKXB1whQiMwjy8ggeHEXsSQVPaG/XZQd2n7+x0AUUVfcKGIcodEi711GDorBX uOUt1ttsDZEfmpq4ku+qHkO0o8RBrw8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1692640654; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gCIG0JsVp3QHiEtAiEKjNvHMosM+Qxtt2B4cFNpJCOI=; b=zwrF1l6ogiNiyD/7aPbLiQbbMsQk7qeLDXDSnyOiihtb8yNHkh/AlinTUiVt2Wx4t0PIuu p5KlQvLx6+rYqPDg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E63B13421; Mon, 21 Aug 2023 17:57:34 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 7XGqJo6l42QSYAAAMHmgww (envelope-from ); Mon, 21 Aug 2023 17:57:34 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 12C63A0774; Mon, 21 Aug 2023 19:57:34 +0200 (CEST) Date: Mon, 21 Aug 2023 19:57:34 +0200 From: Jan Kara To: Hugh Dickins Cc: Christian Brauner , Andrew Morton , Oleksandr Tymoshenko , Carlos Maiolino , Jeff Layton , Chuck Lever , Jan Kara , Miklos Szeredi , Daniel Xu , Chris Down , Tejun Heo , Greg Kroah-Hartman , Matthew Wilcox , Christoph Hellwig , Pete Zaitcev , Helge Deller , Topi Miettinen , Yu Kuai , Franklin Mathieu , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH vfs.tmpfs] tmpfs,xattr: GFP_KERNEL_ACCOUNT for simple xattrs Message-ID: <20230821175734.hkgxg7xixilhgvzp@quack3> References: <20230809-postkarten-zugute-3cde38456390@brauner> <20230809-leitgedanke-weltumsegelung-55042d9f7177@brauner> <20230810-notwehr-denkbar-3be0cc53a87a@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 1728040012 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 4nrhambb41zytfs1i38i5gapgnccxcg6 X-HE-Tag: 1692640656-89151 X-HE-Meta: U2FsdGVkX1+rnm36QAw3A4k3CXQ+hIslYs6JT7Dz8Nha0LDf9Lktm58UW0bX/3HFlLZgwJCg02hP7/aZl0GqBogbixZOomC2RD4SZuhAlSn4/FrNABy+tfXVVR6OhbKUZtGVJvUB9m7cph1AYTJIA2ylDaCPc+cj6AYbP2kl8XWrrJ1DsWtcv7tnpTUSYmVpDDK6iF35wnCdg+HOrqMlxwLKp4xJSts8S+cOYsMabbl1FSvTPZN8XW4q6r9z3zmYWUzQ7P9pA628agQrBwz+A3NNpAD4fW0GwJ8941Il760K4AAR+zExeknWWJhTRc1EhO5xrVE3qjaCbzkByzwxwSkpfk/I07vOj4YsvXWJQeNfuxzqT5raFe9pfEdflhyYEPEADpWoMIumXOyk2zNXxb2tFE7fClNfgX4zZ5G3Rrke5ht6OdRsNvRJLvT3ytwHZsRYrsuJiEm4r+4zYfQVKd7f6dnUiSCQgf0IrtebdSUOiggxavSu9DQxDqA32V1yLcyrxvJS/OrCqTYKfZ27CV6+uBhsc04PXi/56XunP7qRIoWN/Jvj0j5cPwxlRd5MsfXoWaCsMWqY6d6GWmbJ0Ly5rhwmF/kfYjM7TH9LqfcbbeAQF/W4NSGbsigHlYJJbS2lnJRpc/+u1xsS8SG3XnppTGJsml4USF+kM5Qy4mPOqhX4/vE03GPqwZMcioBsHEgMJyoGn8NAKE55J2wTHbAilIGZUe8FFnH40Vz8UTPS5KG2WoJZyR0jPXTnUBf17xWcJOWtFBkTAWgnoO5eNH5AqXVd10YO4DJbe2SR6LFNarjugJfUvOn0KuL9wji4w36A7hKbZXUNngL6XGcVkNnpf/xa3fPuDL+P+TkTYPu1hCpWhUD2HEFnsVkKHIup3OC59u80xwTI68JeE/d3ZLEXiNqfhLu3/qIkk0VrlfY++hx3pXgH8kC5gqt1e8SuehTQQuRtx0/3igqWBzX ht28VHIP PSAFYNdIWjT2x8c2DXduq4gQ6UCswHZPVYDCiXiQqzzkZ5NzCYK9ojXrTZUojX0UvCIBuAqjNOAtvCv4goKRLIo4u/RltRMLNlx+s5GuY/szSTBJr1RHgmYzJuSlWF/oJI4ibYIPCA5MnVWDCJ0IBTef0LDKXI8k5kYLdWdd61JQjAXWX4gRfWRSdusKYBBwPOhWd9LCcTDxfO8zioFSP9f28mVLckCWKjRjeBWNIqmo1wgXPvsgiqiMtyQRvszsL6bAhSDmj6V/BMz4/26N+xBqLgNHOAWu0/AMp5QX878gyaT9axzv8Kua1X4ZLt7eibA6ocSQcJ4hjgJMns4Acnqxc8h9+YDRScRwN X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 21-08-23 10:39:20, Hugh Dickins wrote: > It is particularly important for the userns mount case (when a sensible > nr_inodes maximum may not be enforced) that tmpfs user xattrs be subject > to memory cgroup limiting. Leave temporary buffer allocations as is, > but change the persistent simple xattr allocations from GFP_KERNEL to > GFP_KERNEL_ACCOUNT. This limits kernfs's cgroupfs too, but that's good. > > (I had intended to send this change earlier, but had been confused by > shmem_alloc_inode() using GFP_KERNEL, and thought a discussion would be > needed to change that too: no, I was forgetting the SLAB_ACCOUNT on that > kmem_cache, which implicitly adds __GFP_ACCOUNT to all its allocations.) > > Signed-off-by: Hugh Dickins So I've checked and also kernfs is affected by these changes. I guess that makes sense as well. So feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/xattr.c | 4 ++-- > mm/shmem.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/fs/xattr.c b/fs/xattr.c > index 2d607542281b..efd4736bc94b 100644 > --- a/fs/xattr.c > +++ b/fs/xattr.c > @@ -1093,7 +1093,7 @@ struct simple_xattr *simple_xattr_alloc(const void *value, size_t size) > if (len < sizeof(*new_xattr)) > return NULL; > > - new_xattr = kvmalloc(len, GFP_KERNEL); > + new_xattr = kvmalloc(len, GFP_KERNEL_ACCOUNT); > if (!new_xattr) > return NULL; > > @@ -1217,7 +1217,7 @@ struct simple_xattr *simple_xattr_set(struct simple_xattrs *xattrs, > if (!new_xattr) > return ERR_PTR(-ENOMEM); > > - new_xattr->name = kstrdup(name, GFP_KERNEL); > + new_xattr->name = kstrdup(name, GFP_KERNEL_ACCOUNT); > if (!new_xattr->name) { > simple_xattr_free(new_xattr); > return ERR_PTR(-ENOMEM); > diff --git a/mm/shmem.c b/mm/shmem.c > index b782edeb69aa..11298c797cdc 100644 > --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -3616,7 +3616,7 @@ static int shmem_initxattrs(struct inode *inode, > > len = strlen(xattr->name) + 1; > new_xattr->name = kmalloc(XATTR_SECURITY_PREFIX_LEN + len, > - GFP_KERNEL); > + GFP_KERNEL_ACCOUNT); > if (!new_xattr->name) { > kvfree(new_xattr); > break; > -- > 2.35.3 > -- Jan Kara SUSE Labs, CR