From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A8B0EE49AA for ; Mon, 21 Aug 2023 14:54:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1EB1F900004; Mon, 21 Aug 2023 10:54:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 19AE98E0006; Mon, 21 Aug 2023 10:54:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 06369900004; Mon, 21 Aug 2023 10:54:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EBD168E0006 for ; Mon, 21 Aug 2023 10:54:20 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B7547120C5D for ; Mon, 21 Aug 2023 14:54:20 +0000 (UTC) X-FDA: 81148407480.05.6475237 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id F2DC840010 for ; Mon, 21 Aug 2023 14:54:18 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ry1vjrSY; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692629659; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+PXhHZwB9klxCDXxl8eQk4cqGu674HE/aUbNVYGSltQ=; b=7fAyn4sBZj7x5AIb6eZve3myezjUGJVMgZTS8kt0s8pHf3pQ8gKYd0EYukHSbV0YoeFmRw TFmrILpQx1zAUS3MqUG5bmQNXsJ+88Q6ZjDkqix5eRGsFS2Crjn7BnMmAH5p69XsU6D46U KKIGd20skP/Tt19cPn9EmuM7P0dDyzA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692629659; a=rsa-sha256; cv=none; b=hEV0MxeAk78XRiISkEIRwEJ2U9VsDLg6LUqhQg2dmBQdfSDFh/Q+nakWnl2niNeZF+s0CW 4JnbuFvq9Zl/m6SPC7ureW4hcB35u+2g3CsrWjLBIhTQZeJbyiqvtEkPdS9Z9qQObdaWSA sSBH9n2Ah9Guif8ypts9lpsPCkRXXQc= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Ry1vjrSY; spf=pass (imf07.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 124A86125B; Mon, 21 Aug 2023 14:54:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1EEB6C433C9; Mon, 21 Aug 2023 14:54:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692629657; bh=XXk4gJYl5yxoJ2sva9Ggeq+caYpVLV0EPr+AedA8LNo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ry1vjrSYbat+DrNaJTNdYxqc8kp0Ft1J4x7PVUSo2JrI6QgKZWkP3Ga0jbriyqqj/ ieBXSM6HA3xGieSNUdpnwgpiw78B74VfiwlIZcyQORI3rUehrKT2Sxy3pddASr5KuB wLtXaflvI4LtbYj2u4clQ6cDuPjuEJLiChTB/jFsJn81EWzOQq2rQjAHXiJR/jgVLd +m9ftFi7qiCVOigKLZwNxlQqqw234ZOTtLFLMPqfubSOvOEMp1SBXJYYjOwN8UWg95 2iTqDRZ5wK0HhJxT1iUoQJ6aKT+ROaIN6bicw/ET7yz3cqWgKKzq5EOxXf6c26/Fcw fJqXaGSlzkaLw== Date: Mon, 21 Aug 2023 17:53:52 +0300 From: Mike Rapoport To: "Matthew Wilcox (Oracle)" Cc: Andrew Morton , linux-mm@kvack.org, linux-doc@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH 2/4] mm: Fix get_mctgt_type() kernel-doc Message-ID: <20230821145352.GC9849@kernel.org> References: <20230818200630.2719595-1-willy@infradead.org> <20230818200630.2719595-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230818200630.2719595-3-willy@infradead.org> X-Stat-Signature: cpzquzqfhbz6qoya5zr5qsyumht5mmw6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: F2DC840010 X-Rspam-User: X-HE-Tag: 1692629658-786070 X-HE-Meta: U2FsdGVkX1/HYmNBm4IuVb6gc/v32q1jl9/sU++Qg783EV9WoDCkcGfc5hefHn/brtPQ071s3iVOEQq0xS6w8vPKO4Rs3kcQ7Mt96/IyK9+ZKEuyHY650avkBoyPqdkERxwNeBif4E2/3/7wI8cbFyM6u/R1icTd7tww2m4/gxm+IR0mx70GnOX6EleJiwlY8iFywzd28255GDAiqMYcgXNvY3qERBhFS73lv7IE/lObjWGIc2hZEmaWAoz9pfgHKeiqB/5JnucApeDS45n48kKf/DDuy4ljKe5ZqvFCkvTgbKfDiwGyWZP3iG4l5iY5qclwgmxSWdDbGQsM/ZpbejQwQtPz/MQfc3KYTK/1cPmvWubs36oDx6Hs0qWJUaWqo5IabfvpmAnziaEeV9RrJih3FE6CqChdEBQi+aiyagLYegcTjMM8QHVj3zWfZixgZNjRZ/Sm9vveXq2d17Q8+z7WzAtw+NYPBYD3Zf0XdWFOfGkXfA1CWSzHrAZrsnMqNlLcuLHbh1EttCqN7C4xfrDJ8foIPggtrkbN1rbC+MoXUVI2JZAVm+O0hMSBQ5izfbcwv1TvR9Z7rf1kL1VHS5gatzp20sMmfnxKc18jA/UchzAQOXQ61I/K72Y7LyWyM7f3EnQyj9YcVYqhzONA9jwuCl4B2tDz1V8sOTPn4x/yKOQoVk+DxdkUySS6rX8Fn5OZzyFICivHcdFDNnnvHP5oYrPjlN8LyIhSmxzqpbpCQieVt+1ddf5cFuetXh8WzipMWTklTRF/kl7UlBl6Wd/lOajkR7PepbId591q9PxW+eSxKFHceycWbG+Ofhw86P4U5J6ohDja9iFh1ws3oLkoMOINI3HY57hp3DXyinCGpshz1Y0qfBMn8Asft/UXMen4n92g24ctnnhkF4v8V6zaWUlVM7gPY2wrznKik7DV3Ebl8jbxRSCZExsjYR0O6LzgGZdH90Wf3j8Nyq8 ilDudTOV nVaifNLEutxSfn5ltW/4n6+mvqODDLKyqSqzFzvHj1njm81+WcMYvcOkBU7suplC8d3e/BDJIueBkCj0D+023uFk9md2hn1xEtn8C+I4VxUTvTVEKHbDjIPQ3pKJ3kfJYmAb/M6i1vbmi6RMZ3fZtmwpaBA6rbRe8g80rBagyFLtrp1YiQON0uAHasTOC9yCkVlBSa55261d601w25A3RrNGdbZhTXNdyBJEQo+O/EJMURpNARBI85oS9vo0JmZGOOURNuebEQICz14GRO5fHggBHzA6N4/cvEcg5HZUTReowFGFzoN7q+XP5E9zRWizSp88xM6Rah1myA/Yn7b3aDEKxx6zlNbJ2Czukgk+BkF2LW46F5FNO+WW85TdQ2BjO4Zzcb3ro7CAuCI2NS3YXJ04h4SpdehnbYr/z5OPC9Q1ytoqHJXMZbjBwsCSBcQ3D9biMdDWpLfATuwo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 18, 2023 at 09:06:28PM +0100, Matthew Wilcox (Oracle) wrote: > Convert the return values to an ReST list and tidy up the wording while > I'm touching it. > > Signed-off-by: Matthew Wilcox (Oracle) Acked-by: Mike Rapoport (IBM) > --- > mm/memcontrol.c | 31 +++++++++++++------------------ > 1 file changed, 13 insertions(+), 18 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index e041ba827e59..cd8b3ae6b8d9 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -5850,25 +5850,20 @@ static int mem_cgroup_move_account(struct page *page, > * @ptent: the pte to be checked > * @target: the pointer the target page or swap ent will be stored(can be NULL) > * > - * Returns > - * 0(MC_TARGET_NONE): if the pte is not a target for move charge. > - * 1(MC_TARGET_PAGE): if the page corresponding to this pte is a target for > - * move charge. if @target is not NULL, the page is stored in target->page > - * with extra refcnt got(Callers should handle it). > - * 2(MC_TARGET_SWAP): if the swap entry corresponding to this pte is a > - * target for charge migration. if @target is not NULL, the entry is stored > - * in target->ent. > - * 3(MC_TARGET_DEVICE): like MC_TARGET_PAGE but page is device memory and > - * thus not on the lru. > - * For now we such page is charge like a regular page would be as for all > - * intent and purposes it is just special memory taking the place of a > - * regular page. > - * > - * See Documentations/vm/hmm.txt and include/linux/hmm.h > - * > - * Called with pte lock held. > + * Context: Called with pte lock held. > + * Return: > + * * MC_TARGET_NONE - If the pte is not a target for move charge. > + * * MC_TARGET_PAGE - If the page corresponding to this pte is a target for > + * move charge. If @target is not NULL, the page is stored in target->page > + * with extra refcnt got (Callers should handle it). > + * * MC_TARGET_SWAP - If the swap entry corresponding to this pte is a > + * target for charge migration. if @target is not NULL, the entry is stored > + * in target->ent. > + * * MC_TARGET_DEVICE - Like MC_TARGET_PAGE but page is device memory and > + * thus not on the lru. For now such page is charged like a regular page > + * would be as it is just special memory taking the place of a regular page. > + * See Documentations/vm/hmm.txt and include/linux/hmm.h > */ > - > static enum mc_target_type get_mctgt_type(struct vm_area_struct *vma, > unsigned long addr, pte_t ptent, union mc_target *target) > { > -- > 2.40.1 > -- Sincerely yours, Mike.