From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 994A7EE49AA for ; Mon, 21 Aug 2023 14:21:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32FBD8E000F; Mon, 21 Aug 2023 10:21:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E0538E0006; Mon, 21 Aug 2023 10:21:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A7D38E000F; Mon, 21 Aug 2023 10:21:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 089928E0006 for ; Mon, 21 Aug 2023 10:21:25 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D168C804E1 for ; Mon, 21 Aug 2023 14:21:24 +0000 (UTC) X-FDA: 81148324488.26.89EB438 Received: from mail.astralinux.ru (mail.astralinux.ru [217.74.38.119]) by imf01.hostedemail.com (Postfix) with ESMTP id C24A24001C for ; Mon, 21 Aug 2023 14:21:21 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of abelova@astralinux.ru designates 217.74.38.119 as permitted sender) smtp.mailfrom=abelova@astralinux.ru ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692627682; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=MVBdhKynnIBUxgLjV6QPvV+Rvclc62bs9Goz8coDZ9k=; b=Lb7VREwiiD6Y+1Y0oMuWIACRe0WXcU/UbQPp8Q7cYy/UhnnlGb47ziQvO6tOKcmnvEbogr 3urTYDkm64N/ylLwQaoA0W3Ympd/SlVLT1TEuQ0eBTRGcMREDzlESiSsY5Yacep9M9CM7c nLFVp/ny+msVWznNXQ5BGcqlZW3EnFE= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of abelova@astralinux.ru designates 217.74.38.119 as permitted sender) smtp.mailfrom=abelova@astralinux.ru ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692627682; a=rsa-sha256; cv=none; b=j6oGrJsjh7RNmoUo2LClSyntcbO+Gukr0su4JZ+h7ETYsn1oYDfpXtml3gorLjT5o+V26a kVTVCiyWNliqfh9zLOXtnBkTVbP7eWo7o48djJbkXccY2/ptv3tOqwmW4tHRR3wURrrJxm XYJVp6peatK5eZZIvdJRykY2YcPh7qY= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id 4332B1866B0F; Mon, 21 Aug 2023 17:21:17 +0300 (MSK) Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id nmMrT0FTAkwZ; Mon, 21 Aug 2023 17:21:16 +0300 (MSK) Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.astralinux.ru (Postfix) with ESMTP id D56661865CA5; Mon, 21 Aug 2023 17:21:16 +0300 (MSK) X-Virus-Scanned: amavisd-new at astralinux.ru Received: from mail.astralinux.ru ([127.0.0.1]) by localhost (rbta-msk-vsrv-mail01.astralinux.ru [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id EwXuEzTsToRB; Mon, 21 Aug 2023 17:21:16 +0300 (MSK) Received: from rbta-msk-lt-106062.astralinux.ru (unknown [10.177.13.132]) by mail.astralinux.ru (Postfix) with ESMTPSA id B6EF518668CE; Mon, 21 Aug 2023 17:21:14 +0300 (MSK) From: Anastasia Belova To: Johannes Weiner Cc: Anastasia Belova , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Vladimir Davydov , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, lvc-project@linuxtesting.org Subject: [PATCH] mm: memcomtrol: add warning in case of rtpn = NULL Date: Mon, 21 Aug 2023 17:20:51 +0300 Message-Id: <20230821142051.31889-1-abelova@astralinux.ru> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: C24A24001C X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: adsxpkcsgo8zsyuhcq8th1je3zy11ac5 X-HE-Tag: 1692627681-893586 X-HE-Meta: U2FsdGVkX19jLUVwUx2/a+b9psWxEjivb8rYyaTvdUazlGN1ckpINNv10EIMfApLsZ8/1T/D3MggtHZfATHbL0KsPtigWE/MxCY+k3wDC9nbMLFtEXafScBEwGs4Dyk5Ksx6gbcUStFhHa2Fl8KsmNoWv49CG6wJYxUFOZHmkn4FRXsiKUCcCs5WdmC00ATqU1VoBYbspjzXOAdK2awYpRbqAaRLU4abvT0DuA8JUyDpnFQr5yxYGje4j2ydjKneqY6hS1Gyb4KtM57VHHQpctzByM5cU89KojLDVkIBzebOQmgfrkGD1BnKsf0dhLJzNPqkBRdVEAJ9VJvq3pnK+Zrw4/gNhLhBcsCpjW8Q4rYzpcmPaRovkrHi9p1eP/0zhhribSRoZ/rsN7pSpYvEj63mcFZ+XCSsMwZciHMGAqqLfkjM1z2qJzjw47RxXxy1Iun1KHoejgMtsG9xbdoblvSIrH4HfZz9K41NBGPjHHQ3iKcc17+50VVVpFoaB7M5s5zECVL7TK74QdkMJci6sve4W3kaQiFSXUto7leFPJQAQQM5NPV/KJoUVAqfh0Z94b32cdsYDjUPsw6igcCyiLojl5HYx8BXgRT6OkIbkJ51Y9CIPUQ8B2xgjzG++2jeDmcXZvlcl06O4f6k0Ulp8Zb2uYFbhoDLUu33ZsLtn/h/hGZ7ImDIGCngMJPcBAmprcLsNEhxGKHJTwGZ6gtncJimBR9+Fbxk4ecoBKS6IqCyJozpQTp0iqbO4srABEsXU3ixPZ5ReFGIMbxLdZzhEQDztU4kwELafcIzQixoZco8K2s1MLEKoUedHNJQr0N7kS87cuHT3camPa4V/FX9h2YDslhtTMF23s3R13l/VI8Ps8UoKJXyYhiO0G16DwnYwG/DxT7ey1RwK8ocbJXMmfP23LhZog6NlARncP6bdjuqsTpGtpIAa1n/nSf89+j2vaXvmOT/v02N42ZxzRV 7jd9vQlm l8nL6RtuTf0gAwVqtWxJVAH3yvtVI8rrpcQi8PiyE+hf6EzTLQul1RSi+P5H+RHEvPp7v/Ex23JWLaXFZ7o9V2A6CxrnUOUhkFl6MG8OM4vAFYrac1F8eb5oeRG6E86pixmvjjtw8KoHPDJkO6rARgtwZb4Okwjc9OAgbTZk1RXW0vb9FebNZTv++EZohQ68aWPcFAdfEWePLfFq8m227WUW2kJD93QqN3XHyJ+3tH469Oz1g65qxANiY+thZ4sfXgamvBfiQObiZBeWjQ1f0n7PBxLoShNGoyTdpdWE4+WWfyWH8F9hE3xnQ9vyVMnXm4MSbDvoihMrCTqsAZWKQTnO9P3n/QYA/kf8oblrHSmmGc5E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: kzalloc_node may return NULL. So rtpn should be checked before dereference in mem_cgroup_init. Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 95a045f63d98 ("mm: memcontrol: consolidate memory controller initi= alization") Signed-off-by: Anastasia Belova --- mm/memcontrol.c | 1 + 1 file changed, 1 insertion(+) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index e8ca4bdcb03c..7998dbf3c7cd 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -7377,6 +7377,7 @@ static int __init mem_cgroup_init(void) struct mem_cgroup_tree_per_node *rtpn; =20 rtpn =3D kzalloc_node(sizeof(*rtpn), GFP_KERNEL, node); + WARN_ON(!rtpn); =20 rtpn->rb_root =3D RB_ROOT; rtpn->rb_rightmost =3D NULL; --=20 2.30.2