From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C49B7EE49A6 for ; Mon, 21 Aug 2023 12:20:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 28F998D000D; Mon, 21 Aug 2023 08:20:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 248BC8D000C; Mon, 21 Aug 2023 08:20:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0E0528D000D; Mon, 21 Aug 2023 08:20:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E7EAB8D000C for ; Mon, 21 Aug 2023 08:20:51 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BFC04120BCD for ; Mon, 21 Aug 2023 12:20:51 +0000 (UTC) X-FDA: 81148020702.13.03C53EA Received: from outbound-smtp01.blacknight.com (outbound-smtp01.blacknight.com [81.17.249.7]) by imf06.hostedemail.com (Postfix) with ESMTP id 0D04018002B for ; Mon, 21 Aug 2023 12:20:48 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.7 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692620449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sHeS+r4PLrfz908cD0ZmzQpvOOJGf2qgqJPjLQUBPl8=; b=Hp20RrTyzcLQLpLZBUufqnKHNEzM7ES0bnAvppfwZoJlRahiFrKNro3Xv2cuxXWBbv2Hr1 ObVf5sKS7ng26tcaNTNZHceEpBrtszUGmTpwq3ytjEC/9WMKOT3tSuMxB97zY/2FphtZ8V DSdrj02gKls33uoOgxvmA0rg2ZlKWeg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692620449; a=rsa-sha256; cv=none; b=v0uhwUCkKRFeI1rIJEY8VyHzQOvj02CSAmnL5lY7vVze8J3emHnCHW1FCwWNJPKJYc23BR r0WrkJ7CFGGZ0/GPdFrZH67EYH6NShSTCI12Ou7ISoEmYfDjSK1F2IzVojnGoBSK6ehRfH p+WyrJUW7tlu00qTuCuMTZvdTdxYvbM= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.7 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none Received: from mail.blacknight.com (pemlinmail06.blacknight.ie [81.17.255.152]) by outbound-smtp01.blacknight.com (Postfix) with ESMTPS id F3BAFC4BC7 for ; Mon, 21 Aug 2023 13:20:46 +0100 (IST) Received: (qmail 15072 invoked from network); 21 Aug 2023 12:20:46 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.20.191]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 21 Aug 2023 12:20:46 -0000 Date: Mon, 21 Aug 2023 13:20:42 +0100 From: Mel Gorman To: Kemeng Shi Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, david@redhat.com, willy@infradead.org Subject: Re: [PATCH 1/2] mm/page_alloc: remove unnecessary inner __get_pfnblock_flags_mask Message-ID: <20230821122042.4axbx7cg2nndvxaz@techsingularity.net> References: <20230811115945.3423894-1-shikemeng@huaweicloud.com> <20230811115945.3423894-2-shikemeng@huaweicloud.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230811115945.3423894-2-shikemeng@huaweicloud.com> X-Rspamd-Queue-Id: 0D04018002B X-Rspam-User: X-Stat-Signature: 55rsorzigeidz3ibg37y8kzk7khqr8kw X-Rspamd-Server: rspam03 X-HE-Tag: 1692620448-166685 X-HE-Meta: U2FsdGVkX1+lCoUQca+HeKTccl/mXETaTnXItWVmJxrJqHreovwCmGvWb6ibss2w1di9YvC9WSpj/Ll66I+TrWbxLvWPqn1sp0QJma6XgbghoLumcXyGU0a9WsvN8aN+3klH1VDALsj//Y8mUmRfxhNKB+SJ2UhISfUd9Lz69RvM3wjeXX3US/ryc764OHOpjMarvJozMzJlfrtXZfVRLuVp26R/SWYJ0WFoitfEp+sZ/hcBtZg6HSW5O2KuMucPkqPH7sFXABUd3OwoQwdg9MMXwsu23oMkNFVzSCEp4kg61Skc+R2CxY3ybf+3nPktYK30PaSdPSW2TNdvUV5We9u5aimSGQ5To7u8Nm5/nJlnKft7cjhqoZu4IPGc9HaTKxNY/giya+pqkVr+rSY2Zhg4UCG5AA4LE5nb/rChPydnjtVMuV8XjRtxNX4P27iTd4u1toFrH6nVO9PU7Z4DYCcA+YMSwPkkH9izYa9VLbZ3W9I8+fdgTggk3zPnQ7uV6NOke1bhcGHbGOPo8HvFtTlNx0wSocH8hCYyIBS1y09qQnARMuLaOs1Z7mdul4dzCYH6yRe11vf/1pi5h5nQi5nLpKxXhJyzcFH1K0IOTYwLUNgzM5PFKm9BfwWlLbWH/SjU0g6U6Xwjh7qwMDOVc/pYlN1O6/ESaW69f26BlcG9eg7NtBx5jtWsQiuuC2IK/2xML9lFYNwsJGpS1c4dSeIzKZsqMUx8zd3dwUwaLOyzbrt4N1LnI0SNlqvrEPJSVXsFQULymlvhnBOQcK/DiDVho5ZSRWRa0jM6k/RjEF9r2P5dsrV+/CnSjo0PiaW91SU9ixFiKHkjIMMXA2c3HoYiwR80gWvRABX4O7QlMqEiCl6EAhIgE3iD0cYSjxeFw25dwWssi5AefDuueB8F/cXocMk7sw3eMk0BIgS9x5iiqoj9DXTC12/K/9tK8uGYeLgQIYlhalkWgEdo2X2 jL6IibJW lWRf8vopoGLvgwIpEE0HZh04DO+Pv8DpFl7sPz0fiI2a88tzpPYLZbjKram7rVkaPY/TCjdEseZUyv/0uufnQdsWOAjRNv72qMAPEAnXkpr96BdsKir8+UWLIYbEdL7m2dYsl/U0Knts/ZbzD4Wy/dXWok0Z1TD+0PHburB16Am61qyDwlGwXzSc5mz+tH36xqudrkZucwZADtrZ6i7GP7yG8GTAQmUF8f9UiPmjpKECeWPOsKmF8NdQ8Bd7k1fzpVNc5TP5i0YQpCGD21p0TdR+Q0yj2JEC/6i+eaa1zTg11EMcWhXTPu9bnxFdynL3RjxK87QNLEPPNWuY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 11, 2023 at 07:59:44PM +0800, Kemeng Shi wrote: > Function get_pfnblock_flags_mask just calls inline inner > __get_pfnblock_flags_mask without any extra work. Just opencode > __get_pfnblock_flags_mask in get_pfnblock_flags_mask and replace call > to __get_pfnblock_flags_mask with call to get_pfnblock_flags_mask to > remove unnecessary __get_pfnblock_flags_mask. > > Signed-off-by: Kemeng Shi Acked-by: Mel Gorman -- Mel Gorman SUSE Labs