From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECD01EE49A5 for ; Mon, 21 Aug 2023 04:54:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0A206900003; Mon, 21 Aug 2023 00:54:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 02B128D0001; Mon, 21 Aug 2023 00:54:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DE806900003; Mon, 21 Aug 2023 00:54:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id CBC6D8D0001 for ; Mon, 21 Aug 2023 00:54:45 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9A77880122 for ; Mon, 21 Aug 2023 04:54:45 +0000 (UTC) X-FDA: 81146896530.15.BBF1AE9 Received: from invmail4.hynix.com (exvmail4.hynix.com [166.125.252.92]) by imf25.hostedemail.com (Postfix) with ESMTP id E942AA0009 for ; Mon, 21 Aug 2023 04:54:42 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692593683; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U1KhNt8sTYKdtzjbOT4KtAPL1Mx70Awi71g3n8NnAfk=; b=0IX5QOqzT30/kUfv6YhztGSzBcY1UhryMiCFZgkdhnaWQBwoh/tNFE1CbcxecEWCPYiYvz xKcSVWHI8bTYOqtMlxD6iiC1HzHqMLhABTW5qb3EY46/QEwMF/+GvYa78QzQMdEjwFL8ls 73o3XKGCbQtgBR9u2H89A2bx25uQp04= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf25.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692593683; a=rsa-sha256; cv=none; b=EwkGBuggNJhNidSHWt84oV3hBs/uT8wVZXpmMPAqA3XwbuXvmm5IYwCKxQ9JV8AiYkYHQ8 upeHtvZF4MRcgYfJAxs9zlgTwgAcRdgzaMmef4hYVGsHMj5rePA13OB9nnhkW86ltHStfa Ogy9Sg492ODnPrdlMDYUhZJ27xESAXo= X-AuditID: a67dfc5b-d85ff70000001748-91-64e2ee0f13f7 Date: Mon, 21 Aug 2023 13:51:36 +0900 From: Byungchul Park To: Matthew Wilcox Cc: linux-kernel@vger.kernel.org, kernel_team@skhynix.com, torvalds@linux-foundation.org, damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, will@kernel.org, tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org, sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com, johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu, david@fromorbit.com, amir73il@gmail.com, gregkh@linuxfoundation.org, kernel-team@lge.com, linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org, minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com, sj@kernel.org, jglisse@redhat.com, dennis@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, vbabka@suse.cz, ngupta@vflare.org, linux-block@vger.kernel.org, josef@toxicpanda.com, linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, jlayton@kernel.org, dan.j.williams@intel.com, hch@infradead.org, djwong@kernel.org, dri-devel@lists.freedesktop.org, rodrigosiqueiramelo@gmail.com, melissa.srw@gmail.com, hamohammed.sa@gmail.com, 42.hyeyoo@gmail.com, chris.p.wilson@intel.com, gwan-gyeong.mun@intel.com, max.byungchul.park@gmail.com, boqun.feng@gmail.com, longman@redhat.com, hdanton@sina.com, her0gyugyu@gmail.com Subject: Re: [RESEND PATCH v10 25/25] dept: Track the potential waits of PG_{locked,writeback} Message-ID: <20230821045136.GB73328@system.software.com> References: <20230821034637.34630-1-byungchul@sk.com> <20230821034637.34630-26-byungchul@sk.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUxTZxTH9zz39rm3nXXX6rJHWDbt4rZgJi9xyYkuy7LE7Vm2JSa6D7oP 0K030lDQFEUgMcFZFXmtJsCo3VJgK4gVtRDFabWAUpgOmCBWBDI6NkFaSMCi5c21c2Z+Ofnl /HN++X84IqfJIzGiIWOvbMrQGbVExauCy6ree2XSr0/4yxcPx4sSIPQonwfbWSeBnobTCJxN BzGM3/gU7s4GEMz/1s1BRVkPgqqRIQ6a2ocRuOu+I9A7uhz6QlMEOssKCRyqOUvg94kFDIPl JzCcdn0JNy3VGDzhBzxUjBM4WXEIR8YYhrCjXgBH3jrw11kFWBhJhM7hfgW4B9ZD5Y+DBK64 O3lob/Zj6P3FRmDY+VQBN9s7eOg5XqyAM5PVBCZmHRw4QlMC3PbYMZwzR0RHZpYU4C32YDjy 03kMffcuI7ia/wcGl7OfQFsogKHRVcbBXO0NBP6SoACHi8ICnDxYgqDwcDkP3YteBZgH34f5 Jzby0SbWFpjimLlxP3PP2nn2azVll6xDAjNfHRCY3bWPNdbFsZor45hVTYcUzFV/jDDX9AmB FQT7MJvs6hJYx/fzPBvtq8BbY3eqPtDLRkOWbIr/MEWVeid4it+zoM4eaJ7m8tCcqgApRSpt pI+8XvKcba3HhCjz0jpqu1jDR5lI71CfL8wVIFFcJb1LA01J0TUndahoqS03yiulFBqeKVVE WS0BvXs0FGGVqJGKEP178fF/wQraWTnKPzuOo76lcRx1clIsrV0So2tlpILVEfi3zqvSW9Rz wYujHiq1Kelg2IKf9VxNW+p8vAVJ1he01he01v+1dsTVI40hIytdZzBu3JCak2HI3vDt7nQX ivyl48DC181oumdbK5JEpF2mTnndr9codFmZOemtiIqcdpU69vGIXqPW63JyZdPuZNM+o5zZ imJFXvuaOml2v14j7dLtldNkeY9sep5iURmTh/Iv1qaVin+uuZYbszz+i13a5C3dQ1NHP37w 5Kn9K7tmDTemtWy+ntiwZfumYqOzqn+s5WffkvzyaBJrKekvfOlhsOz+/Vvw5uffxLy94t6l ys/WX+tdO+MVCs7P+Q8kb+VIua6w4eEPOy5f6DKMrZ0wJ2TP5O5M039icb9x3X5KuXjOo+Uz U3WJcZwpU/cPbz3LRJMDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA02SbUyTZxSGfZ73k2ad7zqMT4A/62LcWKYyJTkJC5kZCU+mW/bDuYVp7Ov6 ZjQU0FaZkJngAFFEBLdaqZ0psBTEbs5CHH5gmiKFClMUVMawGx2bYxbYwOIqBddmM/PPyZVz 57pzfhyR0QS5JNFQsEsxFchGLa9iVe9klL26dCqoX9PavBTqqtdA+MEBFuxnXDwMfHMagat9 H4aJ7my4MxdCMP/9dQaslgEEDWN3GWj3BRB0tnzGw+D4szAUnubBbznEQ1nTGR5u3I9iGD12 FMNp99vQV9uIwRO5x4J1gocT1jIcG79jiDhbBXCWroBgi02A6Fga+AO3Oej60s9B58grUH9y lIdLnX4WfB1BDIMX7DwEXI856PP1sjBQd5iDr6caebg/52TAGZ4W4KbHgeHb8ljb/tlFDnoO ezDs/+oshqEfLiK4fOBnDG7XbR66wiEMbW4LA4+auxEEayYFqKiOCHBiXw2CQxXHWLi+0MNB +Wg6zP9t59/IoF2haYaWt31CO+ccLL3aSOh5212Bll8eEajDvZu2taTSpksTmDbMhDnqbj3I U/fMUYFWTQ5hOnXtmkB7j8+zdHzIit9NyVG9rleMhiLFtDpTp8q9NXmK3RFV7xnpmGFK0SNV FUoQibSO2L0HhTiz0gpi/66JjTMvrSTDwxGmColiovQSCbW/Fl8zUq+KHLGXxPl5SUcis0e4 OKslIHcqwzFWiRqpGpHfFh7+FzxH/PXj7L9yKhlenMDxTkZKJs2LYnydEDvB5gzxcV4mvUg8 53pwLVLbnrJtT9m2/20HYlpRoqGgKF82GNNXmfNyiwsMe1Z9VJjvRrHPc+6N1nWgB4PZXiSJ SPuMWpcS1Gs4uchcnO9FRGS0ierkh2N6jVovF5copsJtpt1GxexFySKrXa5+631Fp5E+lncp eYqyQzE9SbGYkFSKlst+3ctrnasTgvXGYNSbkrRZ9lW2RAKWQE7apiUv7N346+jZ0kz6Re2W gPWPtdu3/tT/ecbxbDus78hMG/nxlGND5rLHuor+bSunTecq+z4sPN+vajCVrKshH/wyJvz5 3vadliyblIjSPxWLXFfu/eULZOW9SYpzZ9cv2LI8ge4BLWvOldNSGZNZ/gfo2omcdQMAAA== X-CFilter-Loop: Reflected X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E942AA0009 X-Stat-Signature: dpeohctojngtojk9gi5sok4duqxs491z X-Rspam-User: X-HE-Tag: 1692593682-740749 X-HE-Meta: U2FsdGVkX19kdZYUzV8UIpNntaVdUHhcxMWaWzeMUT70xfen2z+pmB4GaPyKejZdam+WdG5JINUvqmTJrq3bmUcLyU2MQC+taqhtXadYhDD66orC/6EK3w0Sxx3LVkIGWvJZPbv1G0qdMDIqbo69zX9D7fFb50ZCGbLSyo2KueG+/nC/9Cfh9KahhvIXGPaBBO+K9HY1w8DLvdnuIFT+Nk6F10UcJ/skem2mKGlqi0pz9FOHvzJ+oFiwHugSqhfMRNnAp3NlZxNrgcvrNoeeEsnXOFQ0tEdXbzt68cW4dN8ibDt4LbI4zMP37lWDz9hBkWNVU1YF6GC2C683BI/yP9vbWEgkvf1ZatXCLJXF99n9wKWgQ0ah0ljieFjYrGrYc6sc1UlQafeT4/0ZGuI4xWJ5WJGYMj7Aea92qfGnmwm6+DjNZA3b5py92PyTQnqacIRGxVS4T6FXFmPpOOoYACfaqEinNN5zq7cnzO47+9cGhUEJ07aELevjeXAeEdQNf5sMh4cM/97TafszBm2sIy3LDw4i6VLMROr3shMIUOMQqCcWHa7+Rv4YUbGwUoWDMTqO1Qk16TkUkl7pgTaxAOlmc7MZTLGDZfgGc86/OHGth5Kr/VwsV0/g4vIPNSpggcYvBerfJDRFqXTqhcBXRoTRTmNYRdBDTv1fa7gbrlTGl+hB8N4cxjyMYseBjoNxdsdnyZ3bxoQlzGaTeUB19kfMKom2EtaR0WMvJ9PQQrHA3rcclIRmtgMEB+xQgbKc4+oq3jMOt4ozzZoZWgM2YPh+fwtUqZCt+rszFmwiLaP6OdbR/RC0OP2sGryCO4COjcjEaX84eN6B9Uh/7V2auIIAod5UwEPuyNFsHWH/ssMUjmEMmm/YeApFfN6NOfo6Iax2JNrqBNBnbwMujO678aeOUm5yThGhc3rn665JOzXmjMinyU1DAvlLqQNy7pBIV8x9sn+Sr/IVHrwVmCA kopozTXm NiiiZolFBGj3SoP7TlNwhdtVcP0v2MN9fxgSQCPNFAGXjoulSAA+2lXV9kg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 21, 2023 at 05:25:41AM +0100, Matthew Wilcox wrote: > On Mon, Aug 21, 2023 at 12:46:37PM +0900, Byungchul Park wrote: > > @@ -377,44 +421,88 @@ static __always_inline int Page##uname(struct page *page) \ > > #define SETPAGEFLAG(uname, lname, policy) \ > > static __always_inline \ > > void folio_set_##lname(struct folio *folio) \ > > -{ set_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); } \ > > +{ \ > > + set_bit(PG_##lname, folio_flags(folio, FOLIO_##policy)); \ > > + dept_page_set_bit(&folio->page, PG_##lname); \ > > The PG_locked and PG_writeback bits only actually exist in the folio; > the ones in struct page are just legacy and never actually used. > Perhaps we could make the APIs more folio-based and less page-based? Yeah. I need to make it more folio-based. I will work on it. Thank you. > > static __always_inline void SetPage##uname(struct page *page) \ > > -{ set_bit(PG_##lname, &policy(page, 1)->flags); } > > +{ \ > > + set_bit(PG_##lname, &policy(page, 1)->flags); \ > > + dept_page_set_bit(page, PG_##lname); \ > > +} > > I don't think we ever call this for PG_writeback or PG_locked. If > I'm wrong, we can probably fix that ;-) Okay then, I will assume this will never be used. So are you asking me to get rid of this part, right? > > static __always_inline void __SetPage##uname(struct page *page) \ > > -{ __set_bit(PG_##lname, &policy(page, 1)->flags); } > > +{ \ > > + __set_bit(PG_##lname, &policy(page, 1)->flags); \ > > + dept_page_set_bit(page, PG_##lname); \ > > +} > > Umm. We do call __SetPageLocked() though ... I'll fix those up to > be __set_folio_locked(). Haha Okay. Lemme know when you get done on it. Thanks. Byungchul