From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15816EE49A4 for ; Sun, 20 Aug 2023 13:00:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6AD178D0006; Sun, 20 Aug 2023 09:00:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 65DFF8D0002; Sun, 20 Aug 2023 09:00:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 525498D0006; Sun, 20 Aug 2023 09:00:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 427D58D0002 for ; Sun, 20 Aug 2023 09:00:14 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 0D80B40A8C for ; Sun, 20 Aug 2023 13:00:14 +0000 (UTC) X-FDA: 81144491148.25.C8A3531 Received: from mail-lj1-f180.google.com (mail-lj1-f180.google.com [209.85.208.180]) by imf14.hostedemail.com (Postfix) with ESMTP id 0D123100021 for ; Sun, 20 Aug 2023 13:00:11 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=AgciMjmS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692536412; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HPSbgyhLc5Q7B4ZbRBJPVcxIZMDQI6ZiPnGnQ/TPqWo=; b=Gi9bCeexKQLtfMVL/WYFxbDZYrecR24Qv/jnCoNmX0JlYne+JGCxRIjhjKt1dKd0PwsI/z 1CL+K069ewCpy7CKMWZnfa0E5cXxzQxnwUrL/51DU0deShMtoAWot+nwFSPmxtfss5LgjT vGbFlCBbp57zN4GPScvyXoRePtIJwb4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=AgciMjmS; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf14.hostedemail.com: domain of mjguzik@gmail.com designates 209.85.208.180 as permitted sender) smtp.mailfrom=mjguzik@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692536412; a=rsa-sha256; cv=none; b=t7ogjgdeIafQa0ATupyGzztdf7Gaogjj5xaEb9CGhb8tkiw56+3ZPQbVh2UgXnb5swKq77 M7pBP4K0S7mnjyxWWzQkJYPjTXIhmDHUWFKoa9f7Pg7exUC/D+TQnHuKGIRe3sEFYn7De2 se3WV5qa+eHcaga2mUwi38kumDy+QlM= Received: by mail-lj1-f180.google.com with SMTP id 38308e7fff4ca-2bcb50e194dso8799841fa.3 for ; Sun, 20 Aug 2023 06:00:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692536410; x=1693141210; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=HPSbgyhLc5Q7B4ZbRBJPVcxIZMDQI6ZiPnGnQ/TPqWo=; b=AgciMjmSed47bauV5RemSXWwunpQAzO1Gx+83mn3oWeEd3+tRW89aaGP0dOBOoPG2N UQ1ZWl4JMGYcmhrZoN5VEj41OTx9KOW6uu0nZWW34/2fKMCYdvXa+7Ax8JCEKdEXMU11 iWw1QRcAe/HhZ1QCPbE3aFR50V11/R5sDqLfmBHAHxgDIQOL/P91/uyaMBaHqo1RQZGN a76sqjk9zqsUJxydGRcqM7i0/HJnq2AbDdgI/WQ3ATYwIQCIvaN4++cz2yxd93A9m1XV 0mkq7GlzBlsBcVSVDQXob8Xtei1vi7nz1SQM+mhmpQG6g6JVs2WH/TcoUAV7PW8pev6f poPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692536410; x=1693141210; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=HPSbgyhLc5Q7B4ZbRBJPVcxIZMDQI6ZiPnGnQ/TPqWo=; b=GR62mSbf9jmRvd7mdwLHnkB5/fbLpPR8d2Q1bHAKB99P1HLgZ+c7Z7lBZeiFpiGt25 4AddLBaF7X0LLUQZ2k6kS7lW+uUpeIRZBAIADxAD6dFte5hLb/RFIOD6DRyqGzJOvGiZ fvrty5BOtiC1MhzVeh11jW7L4/+onBCoiEMcV2EkKMRNSwBoKMpbRZ5P9HwJ8H2ybQmf UFftFy47AONDD/gRXMoUDDjhKmuanFYHkLKkbTvyKioXmAG/Hsw6UiWDVzNTizKCRDta up165nb8ayxzvTjPUkNNDY0APCOcj9dPBavkB3o8zeIscZ67GY+D+5RDTgQDc0MXDlyO +SKA== X-Gm-Message-State: AOJu0YzsFz/IFs2QbxqEuTl4PxTQtjwce5+p4i8IfexVdgDrkzY/qqSy gqRDXuXqjoALiy88BLn5m605elnXfUnvuQ== X-Google-Smtp-Source: AGHT+IHAM2G/YTBj7smE4cITzuV1oplz/ydV3jspEPYU8z45TQRqiN4V7vx6ePD2G3WrWv+QMzXh6w== X-Received: by 2002:a05:6512:3e19:b0:4f8:7513:8cac with SMTP id i25-20020a0565123e1900b004f875138cacmr3894582lfv.48.1692536409674; Sun, 20 Aug 2023 06:00:09 -0700 (PDT) Received: from f (cst-prg-27-89.cust.vodafone.cz. [46.135.27.89]) by smtp.gmail.com with ESMTPSA id n17-20020a056402061100b0052338f5b2a4sm4248953edv.86.2023.08.20.06.00.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 20 Aug 2023 06:00:09 -0700 (PDT) Date: Sun, 20 Aug 2023 15:00:04 +0200 From: Mateusz Guzik To: Linus Torvalds Cc: Matthew Wilcox , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] mm: remove unintentional voluntary preemption in get_mmap_lock_carefully Message-ID: <20230820130004.knx42tyeshps4vdg@f> References: <20230820104303.2083444-1-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 0D123100021 X-Stat-Signature: bi1ztd8iidmxzw7cdtjrg76hzsrpwnuf X-HE-Tag: 1692536411-785692 X-HE-Meta: U2FsdGVkX18/yn33HVz35AO1WdqHKJbAvz/AEf8kVBy6FoHM5FqY/RpbHeRibwkysnQ4Nyl2sZd/mnKKGMe5FN6tsHEdbCvdubOzOCSF4Du30E7EWDBGuKiIK4u6Ur/UepFt7VpKCjFQgSXGWiKDh9d2wD9Wg1c/nOF5dLSZfEEPAjTp7LW0SHsjM3IeaN1Nep7VF4SkUTxFwAvvHULAEqMNzVxg7yH9X3AcsZbrsEx4vyqp4Mx4/PcWfGSaIXAJ9UxBPvJnn1Pjc6N9uU2u+R0O/lbH35U4eK90oLOdlSHGvcXr51AkRbqxNDt+BVBr4BptE8D+WuIy8p8f8/a653XbgtjltkmPL+iCW9bbvRU0aj0Z0GAY51n+puezZ0VHvI+ENIcGu5ai/AONgPy1M07YeMciGdUJ9BZw8Wov76ir52wKbzXovbJ7aucVOIRhbiXFR4lOy4DlfFgFO6TYY1AF0afV4ECxKab0aMRJWmpB8WoiVyP9vNO2Zpt75eo3kp7j7jVfrSSFXdjI2oJY99xwEMxWaBTXwIR1HGIOmUMSLVboc7w8CM1EveskdjuUizJvjAyOSvJajEXp3UvBM8x5BA7ZXik3tmJU1hJMZUkZYG6nQ10WgKw1joHTAm1R7kKjGt0ovv9FKvOsk5mQOD7drp6F08nukRpKN3qWw5II7cjPfPNYFa41iELFKmu9Q1+QGZwX1mddFaFsf+XolqXG8BJvl4QmG6SlcBimT/Cnfvuxu2aqSTb+xIP9qNZhndLG0REG5t5Cnrm9V5q4vRr0oCuZKNl+CuQv8umEFGgeFJwChRTU0Ed9/8c6DgZ/pwcbKMr+x7QGRRBCfp5Yj8gA+jTrWVI/X5eGK+S3vGujzLibecIhYVMh7lS1J52jbogVxdvLq+ZJiQk9wfv9OXVpn5zrvwLyVl+7GT+M0i5jQ/sgutRPgjgLdVpW977hoQA0fVlv70KEniAdKJN zGd7pI7L +1Lg6kIHEqzradH/sZZ0PjYi+FcniuM0bxI8SBreG2k1rdU5KtFrhqprQA7uCfZUhueY1H/dCfY6KIqcnQQXZEWMGEKh6G0F0iPaAuQbFT4kOEfFlBYwbWYvxc6iq81Emab9T4ivPrJvvSg9YJ0CGqkBlsJxtvSQpDRMIif0+piKgisdBqmFbGdHQt76E8icVWs70GULDy7tkz2gh/K3ysqYa/bdM6CHnl94k5y3gX0LcLpczsys/nnK+dfUQbJfnySox9JN2auvoAotp0i5+QDenK+WDDKqqTtCi8QKCz3cKIb4hqUemov5SU/ieBz0g9QdBUyelgtaNI2aG8194jK2HM29TFCWGSucq0fN6wY2MQycGQgE2u0FmhF7F5HxAOajW3yhLtjb0lTihU+08qEy1sZXB/1j0Q9VU2QeBKC9A9JyLQOoIfEmkqVNA0uY6kszAiZoMrjnxEiAdh3rYrbmFBlDLMpMQnxBXufvIqTJNLkbZBjOaUlm7gA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 20, 2023 at 02:47:41PM +0200, Linus Torvalds wrote: > On Sun, 20 Aug 2023 at 14:41, Mateusz Guzik wrote: > > My first patch looked like this: > > Well, that's disgusting and strange. > > > - might_sleep(); > > +#if defined(CONFIG_DEBUG_ATOMIC_SLEEP) > > + __might_sleep(__FILE__, __LINE__); > > +#endif > > Why would you have that strange #ifdef? __might_sleep() just goes away > without that debug option anyway. > > But without that odd ifdef, I think it's fine. > Heh, I wrote the patch last night and I could swear it failed to compile without the ifdef. That said I think it looks more than disgusting and I'm happy to confirm it does build both ways. That said: mm: remove unintentional voluntary preemption in get_mmap_lock_carefully Should the trylock succeed (and thus blocking was avoided), the routine wants to ensure blocking was still legal to do. However, might_sleep() ends up calling __cond_resched() injecting a voluntary preemption point with the freshly acquired lock. __might_sleep() instead to only get the asserts. Found while checking off-CPU time during kernel build (like so: "offcputime-bpfcc -Ku"), sample backtrace: finish_task_switch.isra.0 __schedule __cond_resched lock_mm_and_find_vma do_user_addr_fault exc_page_fault asm_exc_page_fault - sh (4502) 10 Signed-off-by: Mateusz Guzik --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index 1ec1ef3418bf..d82316a8a48b 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -5259,7 +5259,7 @@ static inline bool get_mmap_lock_carefully(struct mm_struct *mm, struct pt_regs { /* Even if this succeeds, make it clear we *might* have slept */ if (likely(mmap_read_trylock(mm))) { - might_sleep(); + __might_sleep(__FILE__, __LINE__); return true; } -- 2.39.2