From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6533C71149 for ; Fri, 18 Aug 2023 13:35:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C2A5280035; Fri, 18 Aug 2023 09:35:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4721E940053; Fri, 18 Aug 2023 09:35:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 33A56280035; Fri, 18 Aug 2023 09:35:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 49180940053 for ; Fri, 18 Aug 2023 09:34:48 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 977861610DB for ; Fri, 18 Aug 2023 13:34:37 +0000 (UTC) X-FDA: 81137320194.09.DFC933F Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by imf30.hostedemail.com (Postfix) with ESMTP id 46E4B80013 for ; Fri, 18 Aug 2023 13:34:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=bootlin.com header.s=gm1 header.b=KBjw2bfW; spf=pass (imf30.hostedemail.com: domain of miquel.raynal@bootlin.com designates 217.70.183.201 as permitted sender) smtp.mailfrom=miquel.raynal@bootlin.com; dmarc=pass (policy=reject) header.from=bootlin.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692365676; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XUSBAmZKqea45tgmsPtCsKHT8kHVr/qm5VJCtBhaXkY=; b=WnHRFFEUfJjBAw4tKTIEd5MtuIMyRGitS+M8Kasp+uQOcv9mMCMRdjO1COVnq4PR3ATfnL tUpNb7v6ZsFOgv/vcKbzeVN52f2UhWMhP2BVm9ZlICn0CA2YnRlyOrz8BV1m9P17NnUoEg teTX7ddBTlHuZfvKYcILC7UUN58XKVQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692365676; a=rsa-sha256; cv=none; b=cMFgDVzPuHGyIwi30JBi2L2Be7N1BETa32iUcEsW7p6F3/06NGTpK20/7VbvMMRRtGDP+h pOhcUdE73AKOMQf3+mfDiuQ7MruKBCPJ5uLZYSQ6+oWx6QpAWkfyYNjTLnhFxrMj5p/BOi HJg5c1sNqBBATIYpw1rtw51Xw46GSfY= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=temperror ("DNS error when getting key") header.d=bootlin.com header.s=gm1 header.b=KBjw2bfW; spf=pass (imf30.hostedemail.com: domain of miquel.raynal@bootlin.com designates 217.70.183.201 as permitted sender) smtp.mailfrom=miquel.raynal@bootlin.com; dmarc=pass (policy=reject) header.from=bootlin.com Received: by mail.gandi.net (Postfix) with ESMTPSA id 4ED321BF207; Fri, 18 Aug 2023 13:33:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1692365601; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XUSBAmZKqea45tgmsPtCsKHT8kHVr/qm5VJCtBhaXkY=; b=KBjw2bfWLtCn+iB3ds2FAjC9N/sGBNzJgoiDzs08itibNfMqkiC4k+sLFk2/8ZE0jI5U3L h8CCo/srx3nVqLViQiowg7CzIE+4BUi4rVkHu4iLq+Wip1AIh9iZcbYj04/vmwhkfYpKVo LeNeUerfHw6PdDoMORqiNRWKnRAPpWzpigoNHtu3RzabYQ9837qrfhh1DgEsO1cgJm341u Zn3U1Fc6fSaAG9WiCs31tfUDPspokwxkrmaCD0Gsn9cQLp1owEg8QsLomGWpf4RPltZtLc KobaEVWkSgYBy/pjmBx0izRML9A9U7Y38huxxVmcOIX+SCz8MkxnKQxEDIyM/w== Date: Fri, 18 Aug 2023 15:33:19 +0200 From: Miquel Raynal To: Sricharan Ramabadhran Cc: Manivannan Sadhasivam , Dan Carpenter , , Md Sadre Alam , , , Linux Memory Management List Subject: Re: [linux-next:master 1937/6910] drivers/mtd/nand/raw/qcom_nandc.c:2941 qcom_op_cmd_mapping() error: uninitialized symbol 'ret'. Message-ID: <20230818153319.4f2ca354@xps-13> In-Reply-To: <4b8607e8-4df8-3b15-693f-7d7478caedac@quicinc.com> References: <7ad1160b-5f8c-47af-a1c5-51b34f656fab@kadam.mountain> <20230804184550.0cb12369@xps-13> <3604e2ed-8d30-4f7b-9e56-7af5b23b2ac5@kadam.mountain> <20230804190750.3367a044@xps-13> <20230805065510.GA18650@thinkpad> <908ee5e8-6213-5685-7094-8c4b1282015c@quicinc.com> <20230807211458.3de7c627@xps-13> <4b8607e8-4df8-3b15-693f-7d7478caedac@quicinc.com> Organization: Bootlin X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: miquel.raynal@bootlin.com X-Stat-Signature: dgxnq11sy79ei6wo51sioh8xiqicaia6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 46E4B80013 X-Rspam-User: X-HE-Tag: 1692365670-118488 X-HE-Meta: U2FsdGVkX1+fLRaHlMzZjzt3IRMYo3dYPbUdqXWULc0x+fhtTtMSbaGAJiz/WQ/ZV2//oYCXOAZTvQFYrBFOTs9anM4mmOE4CAnAakLGK4BCK5IrFpJBND37S+UPcEqHAO/5fIL7LH8JZ6tiFAxpnd6sLGoGvRta38G9CwCqeLX12qhYZBtCl+pqyaXblGr9LHnKYDsJt7v77rtmkC1a0nRwNN98w6nri8tD3czU+7RrCMeP+kZZjskdx9TJuPUjJckPBYS0onAgS3ntut00tCtfOiZazA/4RPn6OrLEJg0ZIMm+/eByK6O7wB59Yd8eul8urZR18In2G2NQDSZr9yf1lxRMqr7HmzT5f++iyO4D3MSyD5yEdni8R3NJzmhy5HVIvntOzP1LgtgMVdNcuERzKXV2KtLjzKfMq/Ej5+2i9SeJxhfyNvYFHFtW2cGJuy6Vb4+eDIDqypMXMmd6CAVvLTVQoAF7yTzpj5vQOIz0ZS8iHGcQIBRTb5yrbwC+1mCCEoUBFoMPm5hXGeyCXo1qfIiD/yqpPDIfvcjAAsJiqciWGmkjOL1xhwtU1ip9w3Uz08Be8nioiVSh2AuYC+kTeTzMn7ooYA7kWb1Aw41Yk+BbBgY8ag9gFnH+rszZX8/ixMcmB/Yigc6/Yj6p8LaVAFXR+6lYWq7SodQcxZB5kUpXUML+4KJ/Pj5yOpfV1L5cRzgG9goex9EjlPePT9Orv85kYK08yaBrdxA+Rmm+VX0f8pIY6egXmfltMUG5GUVVYPa7fQRkkytTMk8IYO32Ns1f9wx6s0jC9e++lXtZXg5b033kyrDWEjSg6ccxGSq42xr2R5at9fxI7nlgMcGgtHDUCDC6n79h0PYbZ1ZyS2jgL3bq/275uAWLusAzpKKBST59FIjEFcARZe5q80mUJ5lom1JSyqoWtF64x6+Zscjw26buGYV6VH4l6iRagwTuTd6+HjdPlLRjyaK TegRWi/b E16suVmLa5cIhpTzu/rLdXVexIqpu2UJ5zqgYvoGlybh0vS54rPRrRwZh+wxgLG3gUlgXnraoqFYtGPcBA5iKAXUegm6P2AY3WUba/0w1+GEvYQLtZspOrk0PLpt0m2vLXgLCpyprD/YZmpjv13UxCCKBdZQw+g0umeAhEZsySufrjm5qPS1zCm+c4yAEcWWR24+nvXRFEMbXopXmkQYUU4UPW/b8Rm4iHRZjSX5gC3nD/WYGc982pl2vcWYGD88XGxY2LgRl6WVSL9dtrky8fz/DR99rgNhTrTMm X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Sricharan, quic_srichara@quicinc.com wrote on Tue, 8 Aug 2023 10:46:14 +0530: > <..> >=20 > >> With this series applied on linux-next, started seeing the below > >> messages flooded on console while doing mtd r/w. > >> "xxx "Opcode not supported: 0" > >> > >> opcode '0' corresponds to NAND_CMD_READ0. This command inturn was > >> invoked from qcom_nandc.c driver from below places. For read/write_= page > >> driver does not use the exec ops. Hence these calls just ends up > >> being -ENOTSUPP and ignored. So removed their invocations. > >> If this is fine, can this be added to your series ? (will send > >> git-format patch to add to your cleanup series). So far, tested > >> mtd raw/block read/writes and all works fine. Will do further tests > >> as well. =20 > >=20 > > Unless I really don't understand the controller, this is non sense. > > nand_read_page_op() is precisely what allows your NAND to perform a > > read. Removing this call cannot work. > >=20 > > What you need is a proper ->exec_op() implementation, and repeating > > this becomes slightly annoying. > >=20 > > Look at your qcom_op_cmd_mapping, you don't even have a path for reads. > > I bet something along: > > CMD_READ0: > > ret =3D XXX_OPCODE_READ; > > break; > > will make it work. > >=20 > > Please fix the driver and test with nandbiterrs -i. If this test works, > > it is encouraging. Otherwise it is still broken. =20 >=20 > ok understand. Will fix this up. This is urgent now. The driver in -next is broken, shall I revert everything or will you test the above fix quickly? Thanks, Miqu=C3=A8l