From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10F0AEE4992 for ; Fri, 18 Aug 2023 19:24:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 57C35940071; Fri, 18 Aug 2023 15:24:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5054E940012; Fri, 18 Aug 2023 15:24:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3A811940071; Fri, 18 Aug 2023 15:24:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 274F3940012 for ; Fri, 18 Aug 2023 15:24:46 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E817FC112A for ; Fri, 18 Aug 2023 19:24:45 +0000 (UTC) X-FDA: 81138202530.26.CF157D9 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 33E3580022 for ; Fri, 18 Aug 2023 19:24:43 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=e+DlQi+f; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692386684; a=rsa-sha256; cv=none; b=ATc8DOnkAslfhbvo32Yrs09FUawoJpNqfccSjdcHzbHY4KVFC9VsaZ28TjeHyTL4IPmCMA tuRi/h6lWsMyKT3u7M8OVmT4DBXdVi0zaM9SoTNT+OI+PlBRNrNKg2thn4zS7EN5CZSloq 1eEvRtzVgTB1li14PLunYe69vd3WgRc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=e+DlQi+f; dmarc=none; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692386684; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=z27fpXbPfVGPgAxVc6YK1PJFVI13KS/wdUAk2vVtvmw=; b=5UOAUma5p0HBVlUj34LnZiTnSLy4vQm2fAjguWBud7KpUDyIsv1YDJX06cEAKPjng1zPrv vHbUcZ3F906BgOVXK7AQGfUPNTe+tdCE/8pK3o2kl3NnNNDTdA06nyXCDlwiVmgFoS/kWV QDvPUpLn6UwT3nPVb2w+jgbbPxmgePc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0459B6270C; Fri, 18 Aug 2023 19:24:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 271FAC433C7; Fri, 18 Aug 2023 19:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1692386682; bh=8ToUXkvhL/wbhnnT9iejKXHYhgs5FzE+x2IoT6wrvUA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=e+DlQi+fIQMqgYZNjLIPlJCjl/fM0554s0PCAM/zbRsaSPbfbROPlgQXJtRgNrjpT 1EkGKgdwksXLUclhy5cEaMnP88nOz+lwnEnCtuu7zGIR4inBV8FaA5WOl46IGS7euY gK3gdE0kfaQTvNp1mrLngNxELj3vU94TX2EhwK2s= Date: Fri, 18 Aug 2023 12:24:40 -0700 From: Andrew Morton To: Sidhartha Kumar Cc: Mike Kravetz , Matthew Wilcox , linux-kernel@vger.kernel.org, linux-mm@kvack.org, songmuchun@bytedance.com Subject: Re: [PATCH v6] mm/filemap: remove hugetlb special casing in filemap.c Message-Id: <20230818122440.e48c3ec75a594e67df13292c@linux-foundation.org> In-Reply-To: <71864148-6493-30fc-ada4-6bc242b6176f@oracle.com> References: <20230817181836.103744-1-sidhartha.kumar@oracle.com> <20230818110309.e9debd8b988cb8ca4a1019be@linux-foundation.org> <20230818183407.GA5850@monkey> <71864148-6493-30fc-ada4-6bc242b6176f@oracle.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 33E3580022 X-Stat-Signature: dwkuke64br3fgu6epaekhz54irdycti4 X-HE-Tag: 1692386683-834551 X-HE-Meta: U2FsdGVkX1+nSHfQYc2dHF3Z0hb13MZfDQxdC41x5J1o7wzmma1H+FU+D0nnCnfc0ua8lQ16jMFf9QY5G2+AVmuH74NsR96xLjq/HP8Iuxvtj5wMmvK5TX1BJJgF7FbFRZ6VdMhBZsH9ragWWPWERi0RhSokP+9q7Cx+yP4SH9DV3tVRp19v6vhvO5d12LLNigkqVrdaUDpJ/F4jAGdNPUXah23EwXFLpDp7X5LhE1Bs+H3vcLJ+IbpI1MsqZvob0OtLQPExA7obQxmRhDqLfuVVRCoLmWVo90wOAi/iN5AYaSUVhI2gFf2GkqO5yVuND9H0bBUxQa9uQc9FTPAWLeN4J+R2Q0I+VRrX+sT66yQM+EHqOjvgRARUX9mK1sDT2Malii0RAqstxWPv/F034+UiAMt/8JCP8AM69IlAM1Mq7HKsfzEfbD31XWpnH5i8v8FuriKmJKys/M/QLRinbLT90WTHaBJeVcnhx0m209jU5jBvZL4Y415iqMFM2Y3t3XUUeBnZB6A8Za55Y/ibY8lZupHsJX6refYxilrBiKchfEmJItFA90nmmWXgRAXgRJN2Bn8gjh2ERnQB+ozmHM7qkjsaTuIlNq/7NrLyYJypd12Qr+q0Otem0fmQ/Yw+OeIjEbyzwPE87gmyKsUihp+Q5o7RECo4K+NeYuG07fCRR7jCq4rUBf3ERW5UCOjlw0IGyeEceznU2SLmisLk4A72qNnL1W5U5kvD5MbXxN1VOEGo9+HjSmCVVAmkPcKP+zDYJcUdptjJ6pWDPqedNu/cAWY2NiHzVC2n55SS/jCORi6LAN17qhv9//68dd3W/pMD4hDVf++CS5W93cT+6/C6TCvDfm3lTUPsLZo6Zd4dUjR8cgZ6D/Dko/jiC8ECmLLZLTk+vQwPfaOiDB7W2vKSd9SM/z9RrtYdJ15z4D4W5IXzAkm4HdrNhBrOs5tXbtrtWyjXUcO8kvMevU8 SNV9Y6CA thoFX/EbJK/BjNHrTvpZENKgKZAJ4j+9PHdPGS5eDGlXSAucme/7DDFtt8Zt/jspdRoq1UNflOUmsAM2XSR6CL1UtAVP2ED3/Bi28JUdIYEXh6pbi6fwfIInwIENzDHDHjGw5y5FKiqaEmQ5+eUvybnP82j/zyBBa79ThN9e5v2OumBVM1u7gurPxU/Y6wZIszTF9RSc5TOTkcuLzkfrNZfpzHRd4ylJHLu1/wN5b8W/CXGEsMxIwvn8Uspqutq1Rh+j1LKREJB4RB+zlQsm61N0bomhGVfrWzeZ9d3DiS7CgkDED7rjpXQT/R6bA+Mmp4YrdQ8Wt2bMLbZcSMNP7Zw+cMbl51vmu8iK7 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 18 Aug 2023 11:54:24 -0700 Sidhartha Kumar wrote: > yes, the motivation for this patch came from the discussion about the > various places in mm where hugetlb is special cased and how there should > be an effort to unify these cases. As Matthew mentions, this series gets > rid of branches that would occur on every page cache lookup. Thanks. Could we please get all this spelled out in the changelog? Probably in a few days, give people time to review the patch itself.