From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA532C05052 for ; Fri, 18 Aug 2023 03:36:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54F9A940051; Thu, 17 Aug 2023 23:36:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FFA4940009; Thu, 17 Aug 2023 23:36:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C994940051; Thu, 17 Aug 2023 23:36:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 300B8940009 for ; Thu, 17 Aug 2023 23:36:55 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0665BA03B3 for ; Fri, 18 Aug 2023 03:36:55 +0000 (UTC) X-FDA: 81135813990.09.E7E69B8 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by imf11.hostedemail.com (Postfix) with ESMTP id E1FF440005 for ; Fri, 18 Aug 2023 03:36:52 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iY0rRZYb; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692329813; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JFgIwgGO3vrEGuZlY88Ca9pce87taBYsxOC16/ER5dE=; b=5uGO/PuGUkPBOiTkbSOWOO4NU/UEegNS3tXYpELTU74awqMR67vAI3vrR8q/jMoaZGcdpr AHUTJm8/uqYHF5XxTFH3U+A+GqP0W1VadDhr5SJYQSREeqMTnV3PcdVZX3SaM4MgK8kUxf NKrjkyE4pNqvtrpXYdEKF5XqL/lROvw= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=iY0rRZYb; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf11.hostedemail.com: domain of lkp@intel.com designates 134.134.136.20 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692329813; a=rsa-sha256; cv=none; b=Fq5/E5B/r6pEn3JOfuEbC86vRClngb9DkYpvry9+sPIA3DKaWyQLs4JuMAAoUern9d05pF EXqXohw/YWgRmEqkK2axcliNGtZv/6iFbywldczy/kXYfOQpUjdNCrxGp3rzD5cSQ+N0Q2 DedhQL62q+BjVHryXePoO2q0vEGtAMY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692329812; x=1723865812; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=e6mQbkZhJ+crlMj97hR9Gkzu8n2w0+M+4yl1/MdMkHQ=; b=iY0rRZYbKFv3g7vA/PpFO7krHmQhteU3rKPiw+J9EPhq59ToLm3xeQJf v58KKByFCzycgH7u4pFx4zRHlvZujyQHsLqHwfJkzXCN9q4v8q7D/a8N2 b8M0Du66WjDmy7nqRKIeHgbz/Hz1Vh50XNB9dsJfLkpwgFBVey7rqdI1e az8mAMUkoUkDoFch2H1NRc7WbSRI8RdvbRvL5aEJ9L8KBq194NZslxUTQ YmvfHmMxpvXrsbXPZsLXoX6cqpoxuRu3ZrxZMXehuDjw1XH5s38d5lJLp nBSuwotv7rWJtN+7mLapA+6QhPfVow4rAwK69rzhQZzh7m+XZ4PJeMfiz A==; X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="363161779" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208";a="363161779" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2023 20:36:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10805"; a="800312178" X-IronPort-AV: E=Sophos;i="6.01,181,1684825200"; d="scan'208";a="800312178" Received: from lkp-server02.sh.intel.com (HELO a9caf1a0cf30) ([10.239.97.151]) by fmsmga008.fm.intel.com with ESMTP; 17 Aug 2023 20:36:44 -0700 Received: from kbuild by a9caf1a0cf30 with local (Exim 4.96) (envelope-from ) id 1qWqI0-00024a-0n; Fri, 18 Aug 2023 03:36:44 +0000 Date: Fri, 18 Aug 2023 11:36:38 +0800 From: kernel test robot To: Nhat Pham , akpm@linux-foundation.org Cc: oe-kbuild-all@lists.linux.dev, hannes@cmpxchg.org, kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, yosryahmed@google.com Subject: Re: [PATCH v2] workingset: ensure memcg is valid for recency check Message-ID: <202308181130.VIAl2viu-lkp@intel.com> References: <20230817190126.3155299-1-nphamcs@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230817190126.3155299-1-nphamcs@gmail.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E1FF440005 X-Stat-Signature: 5s4uh1smuqerd976ddqtdng6yuw7eazp X-Rspam-User: X-HE-Tag: 1692329812-718177 X-HE-Meta: U2FsdGVkX183+PyElLSj4mwgDkbKGrGAI8oniIhkj6ynrfs+ejMOGhUAZfcD3jvcK4NNt+0jrcrxcs88U1z5qTAzbQF42uzuOkm5jxQemRV6IpCNX/SxNY/1sUd8pICX0Nbjxs9p77rOmKi7N79F/vqSwtv+xWfK/JRzBBSCvqCqJ3YSelEtm4LGGjYw20rWbAW74G/OlG8g2v2xWu4P/auPx12wDEU9L/zmi/uSKRE5+r8NLIsx0+eSbZu/k8r1yprZH3IoB6tYyXi9VUUVQzsNBGCqjY6jrQdsM/deOH/mmOVHM/UGcFF876Kl2jm8iRaadztPjNEBH84A6VIuwtRlbOoyfs3CXqbpbnk3K+BsEtVc6dCeqfCwCPY7imAHzorQsYZm/Y9STW/0xz1W4Ik+mFxZC7hoOfeR8/hkm51UX6jiN0M5WT3CQcpxZSWH+M6h8wNXp1RS1Zyg5S8zwfPU4q3gZP0MnViMVHfz5LS7R0CBMsdamo4w33Sb67trLGWdOVw5IozK3pMkGQm5pCz7r0iEX+3uIs/f7ivRji/oFsfZVt0/AcLThkJZIcoo/mgCAueOj1c3/Rc2bJ8VWjOExAD90KRZX6M7ZDa9364cvRn9zalJrRf/Z2mq/EpkN1V5+9022sKB7TenJDJgsmlSensGH+096GGtkUg8PJejwnnsDt0AMX3Qo46bpfISHHf35pO6guHPfgjUK+S4xDDotLirCSGUqZRB/dYlYUfFtI2I43PRlTc/g6t6pBjj/dxxluTcoD1MSGbKulZGQ2rLoXIOPjslAOqQnTJqrTGh1m28BIrGlRmgIOpWrf6vuX4lIquGhsUC+IQmaWPEg2t6URd6EP4igZA7Xiz27bH5cAEo/lUvysFDMLnQptsMLtpbFLa0Q6XCRhiVg9FGPOqPs2gCOY/rQ7v0adl93k6aRB90/+BJXg+V6m4AQaRM8aEOLv40eu7J1T13Gpq yBPabTBq /zRz3y4LFW+dlVpPbkfueZSG6xgKuDztX12eJ2Vvi8pAjzWwkHDTqcF15d8BslKE9gsBSFskvGArImIvH6kwkopwSFY94AVnGN/NekYE2spv65x+oDOyVZjmtuHAcL8WdfoeI2uFKLjgMDxpNcRaeTqQ1Aao+6/9Q3kB/t3iObOycp1gDG/T1Uo9tdu1/j5VjtaBWcMiNFzJnEotIiDcN1xavFGQpD1Vd1DkBcqnfwuNejTUROQ+SeTr1ueBuJxF1/MpgWAEO/8/VIEnoRu7ZmmQVS+6OZTi7LrVZiBKHdp0Wc/dNSkAlIQYsoZVWVPu99P6Don5oj/napAcw0T32A/DVjpGDgVx61cF3Pn5gp7zJJCFlOOQpubPcQZ/zklLSCfkQoLDlgyEQqdI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Nhat, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.5-rc6 next-20230817] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Nhat-Pham/workingset-ensure-memcg-is-valid-for-recency-check/20230818-030311 base: linus/master patch link: https://lore.kernel.org/r/20230817190126.3155299-1-nphamcs%40gmail.com patch subject: [PATCH v2] workingset: ensure memcg is valid for recency check config: x86_64-buildonly-randconfig-r003-20230818 (https://download.01.org/0day-ci/archive/20230818/202308181130.VIAl2viu-lkp@intel.com/config) compiler: gcc-9 (Debian 9.3.0-22) 9.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230818/202308181130.VIAl2viu-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308181130.VIAl2viu-lkp@intel.com/ All errors (new ones prefixed by >>): mm/workingset.c: In function 'unpack_shadow': >> mm/workingset.c:245:32: error: dereferencing pointer to incomplete type 'struct mem_cgroup' 245 | if (memcg && css_tryget(&memcg->css)) | ^~ vim +245 mm/workingset.c 208 209 /* 210 * Unpacks the stored fields of a shadow entry into the given pointers. 211 * 212 * The memcg pointer is only populated if the memcg recorded in the shadow 213 * entry is valid. In this case, a reference to the memcg will be acquired, 214 * and a corresponding mem_cgroup_put() will be needed when we no longer 215 * need the memcg. 216 */ 217 static void unpack_shadow(void *shadow, struct mem_cgroup **memcgp, 218 pg_data_t **pgdat, unsigned long *evictionp, bool *workingsetp) 219 { 220 unsigned long entry = xa_to_value(shadow); 221 struct mem_cgroup *memcg; 222 int memcgid, nid; 223 bool workingset; 224 225 workingset = entry & ((1UL << WORKINGSET_SHIFT) - 1); 226 entry >>= WORKINGSET_SHIFT; 227 nid = entry & ((1UL << NODES_SHIFT) - 1); 228 entry >>= NODES_SHIFT; 229 memcgid = entry & ((1UL << MEM_CGROUP_ID_SHIFT) - 1); 230 entry >>= MEM_CGROUP_ID_SHIFT; 231 232 /* 233 * Look up the memcg associated with the stored ID. It might 234 * have been deleted since the folio's eviction. 235 * 236 * Note that in rare events the ID could have been recycled 237 * for a new cgroup that refaults a shared folio. This is 238 * impossible to tell from the available data. However, this 239 * should be a rare and limited disturbance, and activations 240 * are always speculative anyway. Ultimately, it's the aging 241 * algorithm's job to shake out the minimum access frequency 242 * for the active cache. 243 */ 244 memcg = mem_cgroup_from_id(memcgid); > 245 if (memcg && css_tryget(&memcg->css)) 246 *memcgp = memcg; 247 else 248 *memcgp = NULL; 249 250 *pgdat = NODE_DATA(nid); 251 *evictionp = entry; 252 *workingsetp = workingset; 253 } 254 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki