From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9438EE4980 for ; Fri, 18 Aug 2023 17:33:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 12DEE940066; Fri, 18 Aug 2023 13:33:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DDC9940012; Fri, 18 Aug 2023 13:33:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE7AA940066; Fri, 18 Aug 2023 13:33:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E1ED3940012 for ; Fri, 18 Aug 2023 13:33:31 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id BB51116077C for ; Fri, 18 Aug 2023 17:33:31 +0000 (UTC) X-FDA: 81137922222.30.7F52F16 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf15.hostedemail.com (Postfix) with ESMTP id D4D7CA000D for ; Fri, 18 Aug 2023 17:33:28 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SmQZg12z; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692380008; a=rsa-sha256; cv=none; b=yMHLV3zonnq90Qrs0SYNI3rih5aqJD08xz4VTdnSzp8t4+VuRSmNFoJgER6BwhPmumWIwd NuCYRyi+y/K+8hIsAul1FdYzdu/cLOi08F8yD+I/dmNOcxbUVp6VF+KL0NoCqTkE8nVckh npXPCHWi/z1YYZ8HGE4O9yLRm7pRO9w= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SmQZg12z; spf=pass (imf15.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.177 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692380008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9LqROe/xq3VxxB2qIfe85nYrLgNe52o6xYWxNbvcSzw=; b=wO1nKu2tCWQIOofoRQbzN+mIDnXdUAddkLDn4B9ZX2UwOf3Gzm1T98FxUzu8vd7cdJ1p/U RY+wcE8KNDe49xHojIbxWhXiapOUS7855wqXBJLq9Bg9/bCMYAUeKLnQuoOEk6lo+HRJ24 0oKQlzXAkD6EZIOv6Wxj6XGjK2om8L0= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1bc63ef9959so9665815ad.2 for ; Fri, 18 Aug 2023 10:33:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1692380008; x=1692984808; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=9LqROe/xq3VxxB2qIfe85nYrLgNe52o6xYWxNbvcSzw=; b=SmQZg12z/hBsunEu7RHOuUKrqiDUOk0W+yPuT9G37hg+RkAfxXMwjDRJq8KSr6aXtL uBJQbBcikFT6uhkVNj6XWwIgHdkJ7/wUe8TxcW57HsezTr67A9qMyrnPSQbBr9Y1L3jo eMCa6nZ5xloAE7/UdJ/VVe9hwgROpMLKku6/A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692380008; x=1692984808; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9LqROe/xq3VxxB2qIfe85nYrLgNe52o6xYWxNbvcSzw=; b=UA0kwnXFLwTXphoWsrBvyOX8+CP9dxxR3W/78BvjE8OcmFuoN5Q3qe7zADvQmcBXVo ZMWig7V6DCMQ2wdlUQgnmnD/RPl3dAt8cJH0bg6ct8Wt1v91RZO8wCXHpGSqosc3YPb5 S6APxYFLfu5ICzPKr0C1eOqG0alD441BSZs546D0Fpd6AM3hXN8C/m2FzaEm3cqJKPfi fhwn5Q3Ofi4nVucrHz/xXChrkWt1BTIl4kbzP3WaIe7eqKk0f5zbFHCCrm5pE9DuZICB Z4RxcAwvZCSPI78iGNtc6Ck4xxCMUmtD6kZ5Lpt51YGEgmTfUiKk/pmn3R1SMm7plKlG FpsA== X-Gm-Message-State: AOJu0YwI/Fr84xeg7cIRMan6a9/06xaNz8I3oCmmMjSAnqnAw9uZAf4W 5sH0ZAenic/bNuQNtuLe4iWg5w== X-Google-Smtp-Source: AGHT+IG7+VZxTbILfrSZv34tOHbnZPnsXjg6L4Mnlt+0JSwNWtlbPKrNujxb5jWd0t+KLFeCAP/iQw== X-Received: by 2002:a17:902:b198:b0:1bc:48dc:d881 with SMTP id s24-20020a170902b19800b001bc48dcd881mr3193969plr.8.1692380007700; Fri, 18 Aug 2023 10:33:27 -0700 (PDT) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id 10-20020a170902c14a00b001b8953365aesm2029761plj.22.2023.08.18.10.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 10:33:27 -0700 (PDT) Date: Fri, 18 Aug 2023 10:33:26 -0700 From: Kees Cook To: "Eric W. Biederman" Cc: syzbot , anton@tuxera.com, brauner@kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-ntfs-dev@lists.sourceforge.net, syzkaller-bugs@googlegroups.com, viro@zeniv.linux.org.uk Subject: Re: [syzbot] [ntfs?] WARNING in do_open_execat Message-ID: <202308181030.0DA3FD14@keescook> References: <000000000000c74d44060334d476@google.com> <87o7j471v8.fsf@email.froward.int.ebiederm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o7j471v8.fsf@email.froward.int.ebiederm.org> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: D4D7CA000D X-Stat-Signature: duwof4czssc46711wi47kbpnbggw34n4 X-Rspam-User: X-HE-Tag: 1692380008-977097 X-HE-Meta: U2FsdGVkX1/3NfGWhTbVWCUZkmSQ2A9w5b0gKM1pWJgWsp/BjDncb+DYh8lk/G0ZeogozK3h2iS65wgCbqcnkgUmmuYFwSC7rVf4eEDbioOnELxYi/Bsnq7+FCshsW5n4Muk6GhkBYZyfYYwttRtqQys07EWGOAkLFcF6lU2F0UcjVX6A15ihbWu3BFcTjRdLtQM6N621ebIdycTuWw5w0nkC5VVZIdazixPXZ7f7rbAnC/uDiEqjrDI/cq+hdvfWEB9nM6/JkgXfhB16iPAy6ygfmc70r4BCqbQ6lbnl7buV/mrFAkt2nAa7Opw23wJYkMDAexF9sPTIaAid0UrOEBRr7GDXMfxQCrXIyOG51XFecVPdt7Xo5P2T9f14HunYLvTuG5aZXX21YufmyJfVWX99E7CQ2USrcufUWmKJSyAIhHcbjLPdHQ/cStfbsAL0ZvlmzSEQJ6BwnDoUKv32sUp6ACBt/PmJ4oeBF8ePalqzHU14MVA9gVNzyJ7sub9oEkwBrvXEq+hVq+qlUGz9zGsT6nmO3oJ6/xl6KG+YzPwd3fiZXa4SY6Chq6WieQ0AC+1cV/iMnrPhX7lgP29SHrFkVOYX9caGF5nulWOCi2/LgKeSjMNoKowaMj//wTtfZckA2ssyLSuEFpVUmexjOfsbPEcwFGirgclnaCKx3zvfcueAcvfWPh+pYC2ZUDUaJVXU9gK08BipCArPZtNB3XDW7sGgzNPSUKXUHAy+CL9doVnpaAhO8IKh6IcCGwyU8IFJxGyf4fvu2ZKUDD9wI12fJgmLqpGeXKX8ffbzI1rL0OvdlNFNnZ1P6vY8jExl04f5meoIe8byMn3mZLzNUnKLoU93c2vVnE8n0fFF/zne//1VebmJCNAf9o2socIZFxKxNg/jEzpgVE3dhDZxv34IYb4oIKX7ZL+Z3tv9+kbkSYCjez6Yuwb0Yq1TOqDdFI4OywDSAcg6dUtcY6 MC36IgiP z7b44Vk99RE3kTdjjbDEiXvkAVXqOQbLuB/Ejb4CcFnvLa3h7wd/ZA7nrNwirW25H3ZTaPtHLtYMTZGrYZLKWZI/eBYjiZdgZ05qfpMusKCgSpq0qBWwbKf3aOSqGPpk3DIzqtfWdvNQoSv6dIWxsDCHdRFjFvT/EbLTUmhxL5pD1BcejuFkfpbnWOv594ps/BdmsUbIlq+zLU6ialL5o2D7AAtrzPyfS2ka4DePzHHK+YSohwrOlRUhxG0xfI2TTaBvajw1e+D6IO9efqOy0cXGGqcNy+w5HAxqVjL5VJDeXBkwmvVH06rhqKFjXjl33Beqjtma9WU8LOG8k8IVFc7V0kdDmBwiKJrSZ8AbxAyAR5ZD+tKErDHBfZO9wtSkt/jHs0R+nLxE0rnRtU5MpTvVzP9u8WwN72K9bl4GjpyzrNF7BmJlJgwMC/YHllaYXcqHLi3CtM6wJ2Z+lYWXqtA+kBBgeGBhpTOhVahM2kMEkL+t8ENSnzVHngl42QkD972lNTlxZyPT7RhTFGm4YuSdVmTpQ/UrFHO7J232tfrhKYvU1I+/qdwel3rWjK+slMWZLDjFIRVSRtQxLfA6kZFSRd8YLvC7df/yM6PfRrG7WvNQmzAibrX57zk4t+ZCkDNK4aiE0uu65DhIWksFobF5kPHFkRRD1jCkkfMz/AIaM2ACy1wqZyh4PPb6i7iiMmpCvXbMriBtwn6X8Gqil6RGOaNnsPajNXsZnsdjwEpLAp7ps68PIfu9dVMZSZP68iMnepro46c4MTW7pKS3iXcx2UVrPFmW89lehksLeDDaVxFa3IXrMs0+zkRuRVfT77daPtejKLO7iOeiRjWkEP+1HO0OflE3rdDn9IhiY+4yHXSpok14VcvKU8pXtpOVXg8LzGpiMzcEA8xT7lTHrXnic1EfvKLwLckOcG1vGnA3smqpfmCNwwBJV8LgIsKHbJXF/2Lx65CB4F5BthxTvVtI8Cw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Aug 18, 2023 at 11:26:51AM -0500, Eric W. Biederman wrote: > syzbot writes: > > > Hello, > > > > syzbot found the following issue on: > > Not an issue. > Nothing to do with ntfs. > > The code is working as designed and intended. > > syzbot generated a malformed exec and the kernel made it > well formed and warned about it. > > Human beings who run syzbot please mark this as not an issue in your > system. The directions don't have a way to say that the code is working > as expected and designed. WARN and BUG should not be reachable from userspace, so if this can be tripped we should take a closer look and likely fix it... > > HEAD commit: 16931859a650 Merge tag 'nfsd-6.5-4' of git://git.kernel.or.. > > git tree: upstream > > console+strace: https://syzkaller.appspot.com/x/log.txt?x=13e2673da80000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=aa796b6080b04102 > > dashboard link: https://syzkaller.appspot.com/bug?extid=6ec38f7a8db3b3fb1002 > > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=17cdbc65a80000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=1262d8cfa80000 > > > > Downloadable assets: > > disk image: https://storage.googleapis.com/syzbot-assets/eecc010800b4/disk-16931859.raw.xz > > vmlinux: https://storage.googleapis.com/syzbot-assets/f45ae06377a7/vmlinux-16931859.xz > > kernel image: https://storage.googleapis.com/syzbot-assets/68891896edba/bzImage-16931859.xz > > mounted in repro: https://storage.googleapis.com/syzbot-assets/4b6ab78b223a/mount_0.gz > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > Reported-by: syzbot+6ec38f7a8db3b3fb1002@syzkaller.appspotmail.com > > > > ntfs: volume version 3.1. > > process 'syz-executor300' launched './file1' with NULL argv: empty string added > > ------------[ cut here ]------------ > > WARNING: CPU: 0 PID: 5020 at fs/exec.c:933 do_open_execat+0x18f/0x3f0 fs/exec.c:933 This is a double-check I left in place, since it shouldn't have been reachable: /* * may_open() has already checked for this, so it should be * impossible to trip now. But we need to be extra cautious * and check again at the very end too. */ err = -EACCES; if (WARN_ON_ONCE(!S_ISREG(file_inode(file)->i_mode) || path_noexec(&file->f_path))) goto exit; So yes, let's figure this out... -- Kees Cook