From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35E2CC3DA61 for ; Thu, 17 Aug 2023 17:07:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A273B940043; Thu, 17 Aug 2023 13:07:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D68F940009; Thu, 17 Aug 2023 13:07:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8C6CB940043; Thu, 17 Aug 2023 13:07:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7E21A940009 for ; Thu, 17 Aug 2023 13:07:09 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E990B161004 for ; Thu, 17 Aug 2023 17:07:08 +0000 (UTC) X-FDA: 81134226936.24.E7A0F84 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) by imf07.hostedemail.com (Postfix) with ESMTP id DD85040028 for ; Thu, 17 Aug 2023 17:07:06 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=cPbrT9R7; spf=pass (imf07.hostedemail.com: domain of 3uVPeZAgKCAg0pismmtjowwotm.kwutqv25-uus3iks.wzo@flex--shakeelb.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3uVPeZAgKCAg0pismmtjowwotm.kwutqv25-uus3iks.wzo@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692292026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QnA3zPm2q98qby0UoFFaFMSu7nPrN723bBGGT2+DgLs=; b=AENNsUs9fST77QT9syIRBW2GiMbhBhFmLPyhQIxWCCCYfEI2PXUU+OfsvM2RLVNHYwp15d DllLOv50jRD0St+WupNmO/ZLhXpAp9kg65YY3kBVLk8oU/JsYhKR1ro0iXYM3LJMPJO1z2 +FAXik/XV/v+EdAQosXrl//uWAd8Q68= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692292026; a=rsa-sha256; cv=none; b=SUrd2gPk4UyfQIuD7xfsfWeaN/3pPCdnNnRjJdZE2UWffnL4mF2RH8iGPF7IE+r+Etv61a ghl8ip6CqVkyXw7iFEMounHGmR+QFCLSCly4EL2cHg7kzr/wYR9+tpBe0i78pPOIj5iBve azvUXWi5ARakLwN2lhSpbdwAF5479wU= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=cPbrT9R7; spf=pass (imf07.hostedemail.com: domain of 3uVPeZAgKCAg0pismmtjowwotm.kwutqv25-uus3iks.wzo@flex--shakeelb.bounces.google.com designates 209.85.214.201 as permitted sender) smtp.mailfrom=3uVPeZAgKCAg0pismmtjowwotm.kwutqv25-uus3iks.wzo@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-1bbdced15f3so263725ad.2 for ; Thu, 17 Aug 2023 10:07:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692292025; x=1692896825; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=QnA3zPm2q98qby0UoFFaFMSu7nPrN723bBGGT2+DgLs=; b=cPbrT9R7dbSgZyIYn0MoABD+dW9CzgzB0c2szdO9q2gaQezgEccSgLaZARJUxDii3N z2xVLOsuI32LBrHAJjco19jtnJttDM9z5VTOcV4d0KghDeGC/LeT+LQNnXzLb5hXhfac epcWSxrBvzEcCnO1xidylUFN1IPNUinKwyDkLHxFBALc+nXRm8rKZcufVEx5nlkyrSzw 8mIVqtIoFXayBbkUJNL8QSXTjk3u5fdN6MtfgO9MUf2uBhJ0JgHKIRfXe6BEmApaJufR vKiuZpi7tq+ULrqeuRVyaDWvIZTtmJqvL2nsHH8hLJF84cIrJNlcfxBv7IXZxOuZxpUV SCiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692292025; x=1692896825; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QnA3zPm2q98qby0UoFFaFMSu7nPrN723bBGGT2+DgLs=; b=ZxhZpTbhMRptQhR+zUiQZHmB17rHDp1maEK363YVahU2C5PWOFnmb59hY2DE2qO4M6 C4C6Y1Qa01nHsQZhRnTg1Z1PMkziZsVcb8jIlnDUoLfkyza/4KPx0s2pFC3g3Xgv3Mzy vwroijtFtyw8owhN2sdY1XE7O8CF/SrZ3QDw72VyZ2naVDBu88ouM89yJtbixPLd2/Fz FETxqE6LcdHYLRbIw8GKxU7QikrKggugNcHMIDUrBTTEi0NJ4zO5dxg3xzgKNPow6zfs g0OBpA1LpOuPKUCellGnQHMdP94TJNlziExEFNGhilsxvLtGCADmumSm52kd0hIkhd0T O+WQ== X-Gm-Message-State: AOJu0YxC71NT+nXqy/n0HnhuZ/wg+qrSN5t2LFFE/iA2FdWyWkCI/p8s S7PGhBF/e8yX3JMeNJwCXIRhbTQTKL9aUQ== X-Google-Smtp-Source: AGHT+IEwMltNFPnv+TWY5AbM/L2SSVB4Cwu+aXXJkg5TrmecyH0tcs+CbpYVLgXJ5E30Hfo3VlYRap3agDlaNA== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a17:903:64e:b0:1b8:d44:32aa with SMTP id kh14-20020a170903064e00b001b80d4432aamr3467plb.1.1692292025414; Thu, 17 Aug 2023 10:07:05 -0700 (PDT) Date: Thu, 17 Aug 2023 17:07:02 +0000 In-Reply-To: Mime-Version: 1.0 References: Message-ID: <20230817170702.mwem4nsy2ka4gj7n@google.com> Subject: Re: [PATCH v2] selftests: cgroup: fix test_kmem_memcg_deletion kernel mem check From: Shakeel Butt To: Lucas Karpinski Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Tejun Heo , Zefan Li , Shuah Khan , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Stat-Signature: j7t3iyyhzai3cd7gka1gx1qq786uan9b X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DD85040028 X-Rspam-User: X-HE-Tag: 1692292026-952613 X-HE-Meta: U2FsdGVkX1/iHDUzZrr6Fv0M6RB+YhVxkTkXVjQFMNaHP6qIsQcXy3AzjKF09734eU6yG3iD8dqjfjNev3DA9HFVQp9bg6hmjiXUiIG1h7vT8y1hFQz79R1x1Ic/OtGiSs9HmX4yw/wymisCmhwzMeJBPOiBWsGgCBhCdY6bY0IleAbv7Pmu6ZUxgAGbSG7VPuIaQFXP7LS6qn4pClPUtmDpoPo7MbnqOLoI55wSP0otJUOL2j0S0a/P6j+uyvsFtfGI+roVHEX5N1Wpadz675BlpatI3Rupo1DS9yLu3MasWIPiqtL6q/q5toadq0f2jibr4YwoBCFFn2S1WqjlhMPDBgETJLOMAwUekQsCjVdgyFHFg67tNpvJRO6KeVORAqcJdKnpkXoCJWddpk50eYzQ/nlnKdm+GRmiKge1qW48WDhSy9uKhXuZQLaectfkCQTwNj9Je77rjUSCjjJ2GRzK1z3IsC4k7Ix/1WDJVL20QeHwJMeU3Lvjzu3nCoiu35lhbwMNzjUINUk+EL7VPGScxbSmeTvKicug5ajEdA/DacMDN6VezC1O1nboa2BXZAPP+cVm0oX0J4Nje2LZKJRFuLr0tUWbdm9axFttnFruw0kx9C+n3hCoX4cPqPWghzbF+5MU7ehTQw08rLbJsfeFhVWqIz7lJ0OtLiTwQ/Cv4t0JYAMaBZ6sDQwzf5ZHC0Lv48YVsI1Pw6t1gfTC2kQPJOD5AL7byq/mownqOig/W8LeZl/0qa8TngM5BadCfE3kKbYkMCUHhMRod5p8NH48zKpCcCx3uuYBj0inQOLYDEBD4zp9iwyEucMKdogisMQqZsQy2z2DC72B5flvCzaPcD9nzuOt5w8QqAS2qtE1x42hOT2SNL+D5P9znU9yf9ZTz//nwok0yrz5Qpx8yD7yCsdtZD68v3m9QfXhGuk4IZHNIBmHjMDqJ+5gRWIG5iPaBmKrgmNowqUUBM+ NfXiFW/2 O+1ep9qwj2zRrmKocGyQNijPQSOmEcwbv+PKjzs+eiQ5RR8/y/YUFyurXDl/tUUN7GU9b1ActxTNiRJL6RsZhiXtYjxIv7qSM0YdM7aposdwtvkCjf/lHEQmUv7EWb0sX/59Z/mPDitX+c0pbi1/bxde6jqO2Dt0pK8y5LrQ2d08aErIi68poR3KfsphN9CkC1+enSiTMwmqB90myBdl0zAtbChjLr2ebC0R5p2hbmvD2pjKh0Gp7K/e0VjYXSW2Pco5KG08VegH3XDU9tNY7iItq0WRtrxAa8KoHXpbCrqWh96DF8+zMGdC+13tH92sXQQdh9N2s9rC0YfnEhJvZCoCCF4Fsfj/+8qqHFX+7yhu13jlpsP7oUpAahGYD27Q3myt9ZWrOWMWATv68zTMPAG+aesl7gNtH5Lb0UNwL9zqu0HTSVmWDz9aqG5XNZBz+VhW6TguriN7gdXP9UvygndeFagYb5sMzwdW41ZzmzokvEyz1zao0gZjelBl65GiW7XQdtV2rEDEcGGrYlK1Iw6qOwKzpNZxyYAhVuJ1CugJVdzn7C5fhHOK+QS1BvFDOCS+Xogl4WqxytNGbkI4tFjhLuY8e6I4Kc8+o/4dMGBFhEo7xZTT71HtkvnVinArze9O/hX4+AAFvn83QKADvk0+PBoJyH7ywFwSBfpDLhei+uGSMLUkrnzf+sV8L9b7A8dKG7/YmUIurJPfCg14bVPB5l+p49rZoS274aMnS0ZcTiCs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.023568, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Aug 17, 2023 at 08:47:26AM -0400, Lucas Karpinski wrote: > The combination of using slab, anon, file, kernel_stack, and percpu is > not accurate for total kernel memory utilization. Checking kernel within > memory.stat provides a more accurate measurement. > > Signed-off-by: Lucas Karpinski > --- > v1: https://lore.kernel.org/all/eex2vdlg4ow2j5bybmav73nbfzuspkk4zobnk7svua4jaypqb5@7ie6e4mci43t/ > > tools/testing/selftests/cgroup/test_kmem.c | 25 +++++----------------- > 1 file changed, 5 insertions(+), 20 deletions(-) > > diff --git a/tools/testing/selftests/cgroup/test_kmem.c b/tools/testing/selftests/cgroup/test_kmem.c > index ed2e50bb1e76..3ef979ee0edf 100644 > --- a/tools/testing/selftests/cgroup/test_kmem.c > +++ b/tools/testing/selftests/cgroup/test_kmem.c > @@ -166,7 +166,7 @@ static int cg_run_in_subcgroups(const char *parent, > */ > static int test_kmem_memcg_deletion(const char *root) > { > - long current, slab, anon, file, kernel_stack, pagetables, percpu, sock, sum; > + long current, kernel; > int ret = KSFT_FAIL; > char *parent; > > @@ -184,30 +184,15 @@ static int test_kmem_memcg_deletion(const char *root) > goto cleanup; > > current = cg_read_long(parent, "memory.current"); > - slab = cg_read_key_long(parent, "memory.stat", "slab "); > - anon = cg_read_key_long(parent, "memory.stat", "anon "); > - file = cg_read_key_long(parent, "memory.stat", "file "); > - kernel_stack = cg_read_key_long(parent, "memory.stat", "kernel_stack "); > - pagetables = cg_read_key_long(parent, "memory.stat", "pagetables "); > - percpu = cg_read_key_long(parent, "memory.stat", "percpu "); > - sock = cg_read_key_long(parent, "memory.stat", "sock "); > - if (current < 0 || slab < 0 || anon < 0 || file < 0 || > - kernel_stack < 0 || pagetables < 0 || percpu < 0 || sock < 0) > + kernel = cg_read_key_long(parent, "memory.stat", "kernel "); > + if (current < 0 || kernel < 0) > goto cleanup; > > - sum = slab + anon + file + kernel_stack + pagetables + percpu + sock; > - if (abs(sum - current) < MAX_VMSTAT_ERROR) { > + if (abs(kernel - current) < MAX_VMSTAT_ERROR) { I don't think this is what you want. Since slab, kernel_stack, pagetables and percpu are included in the kmem stats, you just want to replace those with kmem. Basically keep the anon, file and sock stats.