From: Shakeel Butt <shakeelb@google.com>
To: Lucas Karpinski <lkarpins@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Roman Gushchin <roman.gushchin@linux.dev>,
Muchun Song <muchun.song@linux.dev>, Tejun Heo <tj@kernel.org>,
Zefan Li <lizefan.x@bytedance.com>,
Shuah Khan <shuah@kernel.org>,
cgroups@vger.kernel.org, linux-mm@kvack.org,
linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: cgroup: fix test_kmem_memcg_deletion kernel mem check
Date: Thu, 17 Aug 2023 17:07:02 +0000 [thread overview]
Message-ID: <20230817170702.mwem4nsy2ka4gj7n@google.com> (raw)
In-Reply-To: <jnyjalhg43mdnn6su2a2kmwzqasdyjsfdvipim2i2hvqo7w6y2@st57sbo4bkxf>
On Thu, Aug 17, 2023 at 08:47:26AM -0400, Lucas Karpinski wrote:
> The combination of using slab, anon, file, kernel_stack, and percpu is
> not accurate for total kernel memory utilization. Checking kernel within
> memory.stat provides a more accurate measurement.
>
> Signed-off-by: Lucas Karpinski <lkarpins@redhat.com>
> ---
> v1: https://lore.kernel.org/all/eex2vdlg4ow2j5bybmav73nbfzuspkk4zobnk7svua4jaypqb5@7ie6e4mci43t/
>
> tools/testing/selftests/cgroup/test_kmem.c | 25 +++++-----------------
> 1 file changed, 5 insertions(+), 20 deletions(-)
>
> diff --git a/tools/testing/selftests/cgroup/test_kmem.c b/tools/testing/selftests/cgroup/test_kmem.c
> index ed2e50bb1e76..3ef979ee0edf 100644
> --- a/tools/testing/selftests/cgroup/test_kmem.c
> +++ b/tools/testing/selftests/cgroup/test_kmem.c
> @@ -166,7 +166,7 @@ static int cg_run_in_subcgroups(const char *parent,
> */
> static int test_kmem_memcg_deletion(const char *root)
> {
> - long current, slab, anon, file, kernel_stack, pagetables, percpu, sock, sum;
> + long current, kernel;
> int ret = KSFT_FAIL;
> char *parent;
>
> @@ -184,30 +184,15 @@ static int test_kmem_memcg_deletion(const char *root)
> goto cleanup;
>
> current = cg_read_long(parent, "memory.current");
> - slab = cg_read_key_long(parent, "memory.stat", "slab ");
> - anon = cg_read_key_long(parent, "memory.stat", "anon ");
> - file = cg_read_key_long(parent, "memory.stat", "file ");
> - kernel_stack = cg_read_key_long(parent, "memory.stat", "kernel_stack ");
> - pagetables = cg_read_key_long(parent, "memory.stat", "pagetables ");
> - percpu = cg_read_key_long(parent, "memory.stat", "percpu ");
> - sock = cg_read_key_long(parent, "memory.stat", "sock ");
> - if (current < 0 || slab < 0 || anon < 0 || file < 0 ||
> - kernel_stack < 0 || pagetables < 0 || percpu < 0 || sock < 0)
> + kernel = cg_read_key_long(parent, "memory.stat", "kernel ");
> + if (current < 0 || kernel < 0)
> goto cleanup;
>
> - sum = slab + anon + file + kernel_stack + pagetables + percpu + sock;
> - if (abs(sum - current) < MAX_VMSTAT_ERROR) {
> + if (abs(kernel - current) < MAX_VMSTAT_ERROR) {
I don't think this is what you want. Since slab, kernel_stack,
pagetables and percpu are included in the kmem stats, you just want to
replace those with kmem. Basically keep the anon, file and sock stats.
next prev parent reply other threads:[~2023-08-17 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-17 12:47 Lucas Karpinski
2023-08-17 17:07 ` Shakeel Butt [this message]
2023-08-17 18:11 ` Lucas Karpinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230817170702.mwem4nsy2ka4gj7n@google.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lizefan.x@bytedance.com \
--cc=lkarpins@redhat.com \
--cc=mhocko@kernel.org \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=shuah@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox