From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A081C3DA61 for ; Thu, 17 Aug 2023 17:06:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9D8E2940042; Thu, 17 Aug 2023 13:06:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 987A5940009; Thu, 17 Aug 2023 13:06:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 84F69940042; Thu, 17 Aug 2023 13:06:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 751F4940009 for ; Thu, 17 Aug 2023 13:06:12 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 191A5A10B7 for ; Thu, 17 Aug 2023 17:06:12 +0000 (UTC) X-FDA: 81134224584.12.54020AE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id 0CB2A40023 for ; Thu, 17 Aug 2023 17:06:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=coIcBhTX; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of lee@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=lee@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692291970; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HbRFUMlb2rgwmHyyQNJIvmPwMGTV3QpLv69mVMpVTKQ=; b=cJDiWmoXBCSO2Py8GBagE356Ycjp7VNcUgxai0nuls1gKy8FpxdSGDGbLX1g3abErbkv4/ 8fi6EVaqOunzgIOgytcQjMaET4QCQzw1PBkiEIKo64crnLQoH9PO8vZRGsDoDB5/iDqnkW WTbEAmezUc+QyBrGk3xdP5HEHdlK/uM= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=coIcBhTX; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf27.hostedemail.com: domain of lee@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=lee@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692291970; a=rsa-sha256; cv=none; b=Eu7i26sxrE7vvZAYrxNLVcdPZs7937rvliU4Dn6CaIpysp0jz51RXGCvdxQ5Lk2DklRX2W mlSxuW5kXKWAGbWBsUwUgDhyzZxahEiH7Ty6AKvBfKtFHGb8gITKvh7Nah2uGQLgfV+EmB 48GVnYUmcOBVXkRWh5U238yGbU4EJIQ= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0FC6860EA7; Thu, 17 Aug 2023 17:06:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6040DC433C8; Thu, 17 Aug 2023 17:06:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1692291968; bh=sen9TQXr/zKZqojODsbJSwqZD2qAsaFDcJAkfDcxUFY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=coIcBhTXB6fCF/db+6zSqXqQ5KtIv+w4xBb8LlQozLmN1p48zaz+RgUf1Lpw/mTEV JuRaHCKOCpd3juvxvi6hA73rd6+5ZHeL+z/ksusZhcNWu4u3WEw1VK48/XsN9fDDTF lDdUWpScIi1IXyt6dDHmCmGxdRz303r/UAXM+3Y212v1mAip0pd4sI9KK2ggEliBsh PE5EKt2uXZu7Ji54RN965mF6m3iX8i1tq+LHBRPVjtR7c9pqQFO+a/hSCYDUt8pJcH TGhQEZAF9H8YtX/FW3wabvPvSxHsByWtmh+0NCiKmuGDPJ75QLEMMygHjgL8yW0HCY k7DMmCLIbdXuw== Date: Thu, 17 Aug 2023 18:06:02 +0100 From: Lee Jones To: kernel test robot Cc: Artur Weber , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Daniel Thompson Subject: Re: [linux-next:master 4727/8441] drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is false Message-ID: <20230817170602.GJ986605@google.com> References: <202308091728.NEJhgUPP-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202308091728.NEJhgUPP-lkp@intel.com> X-Rspam-User: X-Stat-Signature: z67zin6irzm7aysin5wfa4dsff8wrb5w X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 0CB2A40023 X-HE-Tag: 1692291969-704570 X-HE-Meta: U2FsdGVkX1+3Fbq5lNcwZ80AUgmPokbD3GXhmWMmzrxkTWx0/7ngki7ouznXurbGsNxBHu/7xX5QbnFzao0LhZq5cxKlgTDNAo7tD55fKWufQ3IN82c7ABPQyqmHcdR/TqYcCB3DbzkKJOJgKyMUdMO9diTR4l9RFygis23z8KLAnXRrsRkgwAikKUAL/ATgnnNSFqxat9yEFrvZ0+Gazt5cyvY9g1LOM1OQDZPXaysNc7j8kUsysaZKqLFvRP0TC8IVtp6ESL/vdfzcTBVcSeGIjCmNrvTyXRDHkHJCdzfzx+4m1Fd7Fq01kEnxy75GbDCJmTQBopVZ6kCi7ozzIZmri5CNTrgYatQp6sCPl+CIrQxWVYB/0uISGssU3aqeEadS41Jz2qSH8DWDphpPfepIZc8HTCsW8U2QOh2Hl1DadaIw7OGePeaXQAEvatVS5TG04qseT5r1B43p6/Q019Y5VYsSNhaJfxGfr+On1cGrkauBNZ73HyvJpfRPmXmzLW6PQnOrw0lSJHGlgn82Bc0GBIa1rQ8hPLf5ODw+96RHyXKm8GOy9aDiXLiqF2+bWOXCV2ZpgK01kis9DmG/RlNIzmwZIb2oKhOxxcz+INyHR9oQcel9L8BRau/v8tB4f8zFpLtxMRpvJ/FFUodkTn0gMC9gyLTHAQFJ7736sT24MAAdCO7Bwd5D4QkMUaknQ2+CVbGvNqdZl67rEEmhtM9xW9wI5m5VrnJ/sZHkiiAbTUJJFzmpJEhJAWvlPpOcRcKJHurR9E24nfb2nFH7TaAtaBSafk3BWzCbs/BnezrhyMRuvH8C50uQPzYQhr2qMu3ZaUhHU/umB49vEkpE/9BwKdCNVlsbNtYbu66BkxI0mwnO3vl5kWA/jz8NpRSliXtDwBRYD3Uffum/bjEib4wGVH12if3S3Yhh6RHBQr+gj9ZbZOucWmqUrGf0DuVdtK9IKcqbRCOgp0gUsg4 gVkkny6F g08rGpDMMJEAaxLgwrFlaocMJkIHPb8k3ICdTtjMDthSNzfZbyKkngZyk/ra4kHET8qN6YZuyYSIG/sIH1nkrt2ASAedaCbaes+Kyvj0sSCsVfX3zDjXdTwwYjr+Lwhxz1Obu3yTs6JjdFeAQGygumqwS8wO2o6m662Rcr4wUaqKg6Pkow3kgngPSZ38ScfFsu47E0BypiwBC/Fh/XSDuy2HAQZ8JLvnEoRcBLwXEg0WSixp1Fn8nbxEYPgIUwb1qES/bMzJqlQJvlAl7WPUAH2VlKfYnLbmnZyIMgYiBZN6e/E/nGSrMKQ96biFVamUOApcKj2KY7Jne4Xy+cygDLOvlySj7fTORAJBhdNl+YbpJ5Z7Knlri0nvrQrX7x5VgOIepiNDl4cHVZDshqa+0fZlnKpRPsWHni05gU1WJgyClvvW5qKe6OZhb5Hz2HO/g+Vg1snHjlQiSJTUN1dPZT5WeKzs2K38hiJ42lu6HNx7qS705F0zyGUUSiU3DOLDDzSEHcjwY/DbyIR1ETpE/Octx33KPoHtQGN6rg85ehwaNYgAGyes4cf66PiyLEQxfcfgh1uN7zXf6KX5jx1+FwS/d6zt13mqecmc3c8Y8w2JW7RKg6QZndo+sLkLJ5la9RIqVpeNDDKcP3yk= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Arthur, Please submit a follow-up patch or I'll have to revert it. Thanks. On Wed, 09 Aug 2023, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > head: 21ef7b1e17d039053edaeaf41142423810572741 > commit: 5145531be5fbad0e914d1dc1cbd392d7b756abaa [4727/8441] backlight: lp855x: Catch errors when changing brightness > config: x86_64-buildonly-randconfig-r002-20230808 (https://download.01.org/0day-ci/archive/20230809/202308091728.NEJhgUPP-lkp@intel.com/config) > compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) > reproduce: (https://download.01.org/0day-ci/archive/20230809/202308091728.NEJhgUPP-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202308091728.NEJhgUPP-lkp@intel.com/ > > All warnings (new ones prefixed by >>): > > >> drivers/video/backlight/lp855x_bl.c:252:7: warning: variable 'ret' is used uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > else if (lp->mode == REGISTER_BASED) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/compiler.h:55:28: note: expanded from macro 'if' > #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/compiler.h:57:30: note: expanded from macro '__trace_if_var' > #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > drivers/video/backlight/lp855x_bl.c:256:9: note: uninitialized use occurs here > return ret; > ^~~ > drivers/video/backlight/lp855x_bl.c:252:7: note: remove the 'if' if its condition is always true > else if (lp->mode == REGISTER_BASED) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > include/linux/compiler.h:55:23: note: expanded from macro 'if' > #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) > ^ > drivers/video/backlight/lp855x_bl.c:244:9: note: initialize the variable 'ret' to silence this warning > int ret; > ^ > = 0 > 1 warning generated. > > > vim +252 drivers/video/backlight/lp855x_bl.c > > 8cc9764c9c7d01 Kim, Milo 2012-12-17 239 > 7be865ab8634d4 Kim, Milo 2012-03-23 240 static int lp855x_bl_update_status(struct backlight_device *bl) > 7be865ab8634d4 Kim, Milo 2012-03-23 241 { > 7be865ab8634d4 Kim, Milo 2012-03-23 242 struct lp855x *lp = bl_get_data(bl); > 61c1c6147f69d8 Sean Paul 2015-05-11 243 int brightness = bl->props.brightness; > 5145531be5fbad Artur Weber 2023-07-14 244 int ret; > 7be865ab8634d4 Kim, Milo 2012-03-23 245 > 9f0a511f4a227c Shingo Nakao 2013-07-02 246 if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) > 61c1c6147f69d8 Sean Paul 2015-05-11 247 brightness = 0; > 7be865ab8634d4 Kim, Milo 2012-03-23 248 > 61c1c6147f69d8 Sean Paul 2015-05-11 249 if (lp->mode == PWM_BASED) > 5145531be5fbad Artur Weber 2023-07-14 250 ret = lp855x_pwm_ctrl(lp, brightness, > 5145531be5fbad Artur Weber 2023-07-14 251 bl->props.max_brightness); > 61c1c6147f69d8 Sean Paul 2015-05-11 @252 else if (lp->mode == REGISTER_BASED) > 5145531be5fbad Artur Weber 2023-07-14 253 ret = lp855x_write_byte(lp, lp->cfg->reg_brightness, > 5145531be5fbad Artur Weber 2023-07-14 254 (u8)brightness); > 7be865ab8634d4 Kim, Milo 2012-03-23 255 > 5145531be5fbad Artur Weber 2023-07-14 256 return ret; > 7be865ab8634d4 Kim, Milo 2012-03-23 257 } > 7be865ab8634d4 Kim, Milo 2012-03-23 258 > > :::::: The code at line 252 was first introduced by commit > :::::: 61c1c6147f69d8dea31fd133d2ec0b1594c9a3eb backlight: lp855x: Don't clear level on suspend/blank > > :::::: TO: Sean Paul > :::::: CC: Lee Jones > > -- > 0-DAY CI Kernel Test Service > https://github.com/intel/lkp-tests/wiki -- Lee Jones [李琼斯]