From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5183CC2FC14 for ; Thu, 17 Aug 2023 07:07:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C169F6B0071; Thu, 17 Aug 2023 03:07:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC4176B0075; Thu, 17 Aug 2023 03:07:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A8BF5280009; Thu, 17 Aug 2023 03:07:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 955E96B0071 for ; Thu, 17 Aug 2023 03:07:49 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 67C4712064F for ; Thu, 17 Aug 2023 07:07:49 +0000 (UTC) X-FDA: 81132716658.24.8D9EF9A Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by imf06.hostedemail.com (Postfix) with ESMTP id 54201180023 for ; Thu, 17 Aug 2023 07:07:47 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ow10WsaA; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of vivek.kasireddy@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692256067; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OFWxI1i+p4efvmikRdB46knSq10ZwkVaViiQ0SsvQMA=; b=T4qJX4+w7h13iX1kEzLiFR3g5ps4GYMAXLUtYpy/onqAle7cnCCnAwuuLUv6q7GBcTXNt5 Q3ppAktaSqg93BpdSVUOqbSd4MV9RPJ4reGaj6ZY0XeXQWtm+k1Gsc/AwqYVZj+Cc9GvLw xS+/loVvbnFkfOQmU6Hh6W0GFymm8FI= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=Ow10WsaA; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf06.hostedemail.com: domain of vivek.kasireddy@intel.com designates 134.134.136.126 as permitted sender) smtp.mailfrom=vivek.kasireddy@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692256067; a=rsa-sha256; cv=none; b=QsZHsQoNjn2JL76zrMFMdVyzIdklAAn/S6kdkTXYw4LlYxW4qcKGI+gfoDSHH59tLeGV9Q IreUYoM3YbH9ezf6EaZIC6Tqkp8Lmaw5HDTGY7lfx4+3L3p7WDmMEohYm6zcv7h/zjqXH9 DJ0dICsbERevVof5Qjs6tmvlpTXEI9g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692256067; x=1723792067; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=U5Op4CjhDDAHfKtiDzpe6+9a1b7R8CllBxVTE/TesJE=; b=Ow10WsaAr3GnKbaTZ0ND9nz1OQbudngHp8FBnaKGGSlKZ+qKF5o1iCav m56gV3Bd/XWa9K1wjTxAh1N2RigMrlTOVLuCoru3sVmIhct2nhQpOmUwy tRuKCFkPrci1f3oh2EkVzUrD5OuHOHKyeIrF9ikB7kHrZN6Y2qZ6yPZpR 0RLAzSg3OfgsoMPb7XjrtY4PxCEBlIGSMVGqT/Q1bT0CnBKd4c8DetOjg YkCvP3asWxMGTP5ElYpeTG0nmSxnj1cYCqvVUivMGqhTi0RDAW9WRlWpr gd1n6ItFRuVKgdgS70QbvJ1gVVFaGag891DeSCQCdcp5g9/KbkBOM9VWN w==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="357697948" X-IronPort-AV: E=Sophos;i="6.01,179,1684825200"; d="scan'208";a="357697948" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2023 00:07:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="799913426" X-IronPort-AV: E=Sophos;i="6.01,179,1684825200"; d="scan'208";a="799913426" Received: from vkasired-desk2.fm.intel.com ([10.105.128.127]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2023 00:07:41 -0700 From: Vivek Kasireddy To: dri-devel@lists.freedesktop.org, linux-mm@kvack.org Cc: Vivek Kasireddy , David Hildenbrand , Daniel Vetter , Mike Kravetz , Hugh Dickins , Peter Xu , Jason Gunthorpe , Gerd Hoffmann , Dongwon Kim , Junxiao Chang Subject: [PATCH v3 1/2] udmabuf: Use vmf_insert_pfn and VM_PFNMAP for handling mmap Date: Wed, 16 Aug 2023 23:46:22 -0700 Message-Id: <20230817064623.3424348-2-vivek.kasireddy@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230817064623.3424348-1-vivek.kasireddy@intel.com> References: <20230817064623.3424348-1-vivek.kasireddy@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 54201180023 X-Stat-Signature: ucei3en8wc75txiowdbeb9cxhh5uozki X-Rspam-User: X-HE-Tag: 1692256067-779800 X-HE-Meta: U2FsdGVkX1/74jXow5Ojjg3XRUgmvQC4Qun8lM/l7LNz7GOTSvHoTad1dD7vqVoq5kfmLcwrcbx3fTJLSa/yFHiUYFpo5RhlWaXTpb2XGgQWYLIXb6qdk5aQEQvxCcf3ytxcEp5AyGafK0+K2+2MPTg4PeQM6AejeANTp5NFh2IYs35SGZpppVl52P8IvLmveSOeKpyc+GJoyuiI+F9fyjReYYEc3yU4QKiUsOn0V+uX8UjDxHmXzJsxn2MGvF+XMIgICpSSFdeIaQn0djezCYdid/JeLY4JYYDC27MEhyl2R6iVJgnyR/xMBpJQDLtiAzRn9gn6UDWg7HM3T6SmjsTMyh8El6Wm66n2mGb5RlmJnoxQkkknYz7KUuJqcOEOACuvJdRjhR+hhU6LPumdfc6vd7wGVddcM4rNlms8dYT4bmAh/ukYL+rHGP2omJEhk4OVteHgLbzznBvDL3W5wmC9z+Mbx0rSwHEc9lMyUzSmz+YhCviWYt9GlEMI3+J1Wa6UNcvjGUKBA7ZvxgF4txd8icnuI14hlJ7ARgIWMKQKnQvwFZWs4e0CzzrD7YMVM7Y5DDmjZQlWazbgP1ToiG8CfPlUxbcJURttSvh9I4gBpmlRo4waIBBLLLQSVGgar1pin1DP7nh1kY08xe3igrgO8m8KiVIXUqiyf3DIP1c7rhOG6hW8XXm7DDJwOV/MSEuLgQNxJ0qs5WECCVeBI5qhC21wPbz2fyZ7NjnCAZXLwyoG7kdMX9RGJ1ln38C5x/brdJf0Qi26h41+BlEfJnAa5GMm+WjDzi+cC+e68Ynbg/8zIFDGBGKB3nMPGv8uucnqkC3hrRXGPAkP/kia425Wt8z80Tq+VYymjWPRUFS8/gJnnlxtvQXg4I2ihr6ggE/M2adrST+1CaFLUVpW8P4Kuef8arst9s3zT5CJeOBhfuwIwn/nqIc9TZirZt2cdxOwUOwiuJuiDvq8OkT rlz2tFcJ nICRNtp3Ia47/++GiNRV1LY9idhF11RtzvGOt4l2YMlm3jscRFgZ/eZVOWzoUvDndT50rNnwt0G1YPfb5+YDr58+EeDiRC0ODBkKh0Lv5npLbdVLOFv1apKXWVsO5484PYeoYxCQupjg1k9EbMPJCh69qxdmGoK9aB7ZqIiY9jnC7zCN2ktJtchh5+bDKnHiXQjAj9wUeAaEMyXYPxCldNycyKvG4EUWB8JHSh7iQkkG2D5At9yyxdVWkOFAYCm5TlDcTDgKLaV9R0rncWdY1HI9ytulPbHO6c8VPbuiirzrBT74= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Add VM_PFNMAP to vm_flags in the mmap handler to ensure that the mappings would be managed without using struct page. And, in the vm_fault handler, use vmf_insert_pfn to share the page's pfn to userspace instead of directly sharing the page (via struct page *). Cc: David Hildenbrand Cc: Daniel Vetter Cc: Mike Kravetz Cc: Hugh Dickins Cc: Peter Xu Cc: Jason Gunthorpe Cc: Gerd Hoffmann Cc: Dongwon Kim Cc: Junxiao Chang Suggested-by: David Hildenbrand Acked-by: David Hildenbrand Signed-off-by: Vivek Kasireddy --- drivers/dma-buf/udmabuf.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/dma-buf/udmabuf.c b/drivers/dma-buf/udmabuf.c index c40645999648..820c993c8659 100644 --- a/drivers/dma-buf/udmabuf.c +++ b/drivers/dma-buf/udmabuf.c @@ -35,12 +35,13 @@ static vm_fault_t udmabuf_vm_fault(struct vm_fault *vmf) struct vm_area_struct *vma = vmf->vma; struct udmabuf *ubuf = vma->vm_private_data; pgoff_t pgoff = vmf->pgoff; + unsigned long pfn; if (pgoff >= ubuf->pagecount) return VM_FAULT_SIGBUS; - vmf->page = ubuf->pages[pgoff]; - get_page(vmf->page); - return 0; + + pfn = page_to_pfn(ubuf->pages[pgoff]); + return vmf_insert_pfn(vma, vmf->address, pfn); } static const struct vm_operations_struct udmabuf_vm_ops = { @@ -56,6 +57,7 @@ static int mmap_udmabuf(struct dma_buf *buf, struct vm_area_struct *vma) vma->vm_ops = &udmabuf_vm_ops; vma->vm_private_data = ubuf; + vm_flags_set(vma, VM_PFNMAP | VM_DONTEXPAND | VM_DONTDUMP); return 0; } -- 2.39.2