From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08E3C001E0 for ; Wed, 16 Aug 2023 13:58:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 48BBC8D003B; Wed, 16 Aug 2023 09:58:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 43C248D0001; Wed, 16 Aug 2023 09:58:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 303A68D003B; Wed, 16 Aug 2023 09:58:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 211EF8D0001 for ; Wed, 16 Aug 2023 09:58:09 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B938B80F47 for ; Wed, 16 Aug 2023 13:58:08 +0000 (UTC) X-FDA: 81130121856.16.B738680 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by imf29.hostedemail.com (Postfix) with ESMTP id 2766F120035 for ; Wed, 16 Aug 2023 13:58:04 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OzawAi5t; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of lkp@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692194285; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=i/x7UTAwehbYu58bQ7ub5YF+/E442CCf2s4pS/MlVlI=; b=VHE05roYDqqVf/0GkMWR85e1MTIwC7qUJF3KjryfcvUm451cCNc5XhadGiX7x0HFAz4V1d jBrw2qe8YxQQvwfe9c+DGVfL+lUw+MTLin/DAyQSZ9GX6LWJJHb4wbTzz53d7eAH8voOCX Smi6N66L6UNSVehSXKjKUDILqoSUWRw= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=OzawAi5t; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf29.hostedemail.com: domain of lkp@intel.com designates 192.55.52.151 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692194285; a=rsa-sha256; cv=none; b=A1j3vYB4TFrNVv73cQGnj+t7OaOt6JA41eSq/4JVmhI0mjQWwogKfnZverw8evUJ7/fKOl wM0yN20BnscqRAnN+haIV8k/xruSOHu/82ETQLtVy2DGluieP7v+/zatL51D1fXiPdulEL NOP+Aa99xpi0yIMzN4BYFY7Gjtq1rxQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692194285; x=1723730285; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=DUczewNPllC94OPCnns3pO2+rMVMgE13ohRtdkbEVoM=; b=OzawAi5tz8Zn/OojgViAezld1iGAZVHtVnajYq2XmadJofqchn2u6UIM 6I4UptHZowkipFrPMVlhFleRdzJxt6YAKEMcuHj7ko939aPmwa9j07dbZ NYlU6eylqyHl/qp6/o0DD7NPysDTzcHWojfsVwRZ9FoVeJqQpAQPJgacq WpfVTQdB14grGtxI7On29JyvgvU38THsneVfVcmoK0Vtix/HefK0EviJk oDeXrqbf5qbD4uO7VQq9ozUDs8hcI4biDe5Q9wOuHR/8uPKLi9755f6fG fcWq6T8FfM3dadxQQukZoEemuK+67dvDDOEqiirvTZWZKqUBZDRF5T/tr g==; X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="352863247" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="352863247" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Aug 2023 06:58:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10803"; a="857828332" X-IronPort-AV: E=Sophos;i="6.01,177,1684825200"; d="scan'208";a="857828332" Received: from lkp-server02.sh.intel.com (HELO a9caf1a0cf30) ([10.239.97.151]) by orsmga004.jf.intel.com with ESMTP; 16 Aug 2023 06:57:56 -0700 Received: from kbuild by a9caf1a0cf30 with local (Exim 4.96) (envelope-from ) id 1qWH23-0000M5-18; Wed, 16 Aug 2023 13:57:55 +0000 Date: Wed, 16 Aug 2023 21:57:03 +0800 From: kernel test robot To: Qi Zheng , akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev, joel@joelfernandes.org, christian.koenig@amd.com Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, dri-devel@lists.freedesktop.org, linux-fsdevel@vger.kernel.org, Qi Zheng , Muchun Song Subject: Re: [PATCH 1/5] mm: move some shrinker-related function declarations to mm/internal.h Message-ID: <202308162105.y9XrlTA7-lkp@intel.com> References: <20230816083419.41088-2-zhengqi.arch@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230816083419.41088-2-zhengqi.arch@bytedance.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2766F120035 X-Stat-Signature: xbn5m54o1ro43kkyc5pca4g53conz1t8 X-Rspam-User: X-HE-Tag: 1692194284-460217 X-HE-Meta: U2FsdGVkX1+QVpKZCOFRyQiHDRbsj8EnU8nBzT1PhpBVjMIuFNwGP59HAKRSuD48Yw9aVHuRW2QS2u0sgYlGUz948cD4ifQ233SfYxKUp+qnOnDZ1cGTofPqkQv0iL21nbZKGmPRpvdhnGysnePHn0Zpu4M3JAjhPSbco5HU3c7T75bM9mw2vLF+g5jmWt0oPZQMRSssbxDvm6uwliJlZrmCzv0ndqD5qeZbNno/AGG8VGCR6i9W6Wr0d/WGVOhxh91TawmuEEiGRMPA3TjkRqGDxCcAW+PrU2nQqt/w6zpi9stx9zZvV8gonvOV8QBCgYjrzy8PYPoguabHbyzV1EfqQL1qP+IfrA8aqeQXYHi5jEmK84SukLCJHdapqyHTGaaVYz6PdxWiV5soONl5hKVWmy3bwJncCCZNQGaTVvgGbiv0JWhbDe1AD0x1OgDHtAsqV4TSBBxCh9/wsf2FPCO8yTM8YIy/Tu2A0VVKF91SB6DabkbEZUdQZoxut5baHVdVYeznIr/L41pIY0bTzyQR+BrRXXAnqvYhvhOV7nLu4V2SmKOME67AmgfesTN9lnJeJq9Oik1ly1NoFWMbQCsJKnnvVYudvyczMJibBVYNPoRk5NXj2xJQnnD+twRK6x1Clf4rooADobTEfDMvLsAsllIylMDV0eDMfz193s7yue4Zd+ebsBPP8j5YMCEHZx/+JmMcTnACyJle1dppebalNfXJEZi3wVy6bQh01L+2e8yW27q+xK7UMqXW47ei8MkinQFqCqoCQsuBuMwA9wV7arREeha7E3RLSgZB1l4ciu9A3LTrP86XR+akrB4skxK5Hjs1SFsAn90KpuUlYSMKjmOAtecEu1pzVZy60p3cRgIJ6ABvQPHTGNSJNvF2lPfjcV7ulQ8VULu2OrhtRXkwz2VMiNEKqJU+TJcdsQIvcCJwDwjjoX32R4xplKkBR3OHDmuSrIdb5UlPtTU ECaj1qAz nIYS0JzLgEna/y+JwT6LrL+8lgC+tR8s7WHcW0Lp6WhZtlRcdXQZcGmek2zE0m/VcmyVR9TW5cwC53WCW6HuAz5G6lJviW4y/S7J0ML1D/QvMM8xms8F3HUyDioEOyxmX78Hu1hhQak9+aoTshbUW21T8P8ndF6eIE5uNRA847b4V1LR5PIiwE5XubNW2fMGbiXcVJ4kBm0wBtMKZuuN3f7IsxcLGp70b6eSyb+QYPVzcVKOshonR3kB/QWvEexQJSGe9PBaziYBdjnCdcXeJnIHwVIdXjen5gu0ZVRqNNfWaWozGD2/UpOJkWagVtW2jVVoMvGl0vl1YB5VfjsXuDVIeQYJ4hNE475OiO+CgeBree9Uz9w4iggyZe+s1tXlWv5uGH6P/FMlZ8tUYZkGuUmTKk6Yv6K1XCPgHWYTUTSVsCh8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Qi, kernel test robot noticed the following build warnings: [auto build test WARNING on brauner-vfs/vfs.all] [also build test WARNING on linus/master v6.5-rc6 next-20230816] [cannot apply to akpm-mm/mm-everything drm-misc/drm-misc-next vfs-idmapping/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Qi-Zheng/mm-move-some-shrinker-related-function-declarations-to-mm-internal-h/20230816-163833 base: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all patch link: https://lore.kernel.org/r/20230816083419.41088-2-zhengqi.arch%40bytedance.com patch subject: [PATCH 1/5] mm: move some shrinker-related function declarations to mm/internal.h config: m68k-randconfig-r013-20230816 (https://download.01.org/0day-ci/archive/20230816/202308162105.y9XrlTA7-lkp@intel.com/config) compiler: m68k-linux-gcc (GCC) 12.3.0 reproduce: (https://download.01.org/0day-ci/archive/20230816/202308162105.y9XrlTA7-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202308162105.y9XrlTA7-lkp@intel.com/ All warnings (new ones prefixed by >>): >> mm/shrinker_debug.c:174:5: warning: no previous prototype for 'shrinker_debugfs_add' [-Wmissing-prototypes] 174 | int shrinker_debugfs_add(struct shrinker *shrinker) | ^~~~~~~~~~~~~~~~~~~~ >> mm/shrinker_debug.c:249:16: warning: no previous prototype for 'shrinker_debugfs_detach' [-Wmissing-prototypes] 249 | struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, | ^~~~~~~~~~~~~~~~~~~~~~~ >> mm/shrinker_debug.c:265:6: warning: no previous prototype for 'shrinker_debugfs_remove' [-Wmissing-prototypes] 265 | void shrinker_debugfs_remove(struct dentry *debugfs_entry, int debugfs_id) | ^~~~~~~~~~~~~~~~~~~~~~~ vim +/shrinker_debugfs_add +174 mm/shrinker_debug.c bbf535fd6f06b9 Roman Gushchin 2022-05-31 173 5035ebc644aec9 Roman Gushchin 2022-05-31 @174 int shrinker_debugfs_add(struct shrinker *shrinker) 5035ebc644aec9 Roman Gushchin 2022-05-31 175 { 5035ebc644aec9 Roman Gushchin 2022-05-31 176 struct dentry *entry; e33c267ab70de4 Roman Gushchin 2022-05-31 177 char buf[128]; 5035ebc644aec9 Roman Gushchin 2022-05-31 178 int id; 5035ebc644aec9 Roman Gushchin 2022-05-31 179 47a7c01c3efc65 Qi Zheng 2023-06-09 180 lockdep_assert_held(&shrinker_rwsem); 5035ebc644aec9 Roman Gushchin 2022-05-31 181 5035ebc644aec9 Roman Gushchin 2022-05-31 182 /* debugfs isn't initialized yet, add debugfs entries later. */ 5035ebc644aec9 Roman Gushchin 2022-05-31 183 if (!shrinker_debugfs_root) 5035ebc644aec9 Roman Gushchin 2022-05-31 184 return 0; 5035ebc644aec9 Roman Gushchin 2022-05-31 185 5035ebc644aec9 Roman Gushchin 2022-05-31 186 id = ida_alloc(&shrinker_debugfs_ida, GFP_KERNEL); 5035ebc644aec9 Roman Gushchin 2022-05-31 187 if (id < 0) 5035ebc644aec9 Roman Gushchin 2022-05-31 188 return id; 5035ebc644aec9 Roman Gushchin 2022-05-31 189 shrinker->debugfs_id = id; 5035ebc644aec9 Roman Gushchin 2022-05-31 190 e33c267ab70de4 Roman Gushchin 2022-05-31 191 snprintf(buf, sizeof(buf), "%s-%d", shrinker->name, id); 5035ebc644aec9 Roman Gushchin 2022-05-31 192 5035ebc644aec9 Roman Gushchin 2022-05-31 193 /* create debugfs entry */ 5035ebc644aec9 Roman Gushchin 2022-05-31 194 entry = debugfs_create_dir(buf, shrinker_debugfs_root); 5035ebc644aec9 Roman Gushchin 2022-05-31 195 if (IS_ERR(entry)) { 5035ebc644aec9 Roman Gushchin 2022-05-31 196 ida_free(&shrinker_debugfs_ida, id); 5035ebc644aec9 Roman Gushchin 2022-05-31 197 return PTR_ERR(entry); 5035ebc644aec9 Roman Gushchin 2022-05-31 198 } 5035ebc644aec9 Roman Gushchin 2022-05-31 199 shrinker->debugfs_entry = entry; 5035ebc644aec9 Roman Gushchin 2022-05-31 200 2124f79de6a909 John Keeping 2023-04-18 201 debugfs_create_file("count", 0440, entry, shrinker, 5035ebc644aec9 Roman Gushchin 2022-05-31 202 &shrinker_debugfs_count_fops); 2124f79de6a909 John Keeping 2023-04-18 203 debugfs_create_file("scan", 0220, entry, shrinker, bbf535fd6f06b9 Roman Gushchin 2022-05-31 204 &shrinker_debugfs_scan_fops); 5035ebc644aec9 Roman Gushchin 2022-05-31 205 return 0; 5035ebc644aec9 Roman Gushchin 2022-05-31 206 } 5035ebc644aec9 Roman Gushchin 2022-05-31 207 e33c267ab70de4 Roman Gushchin 2022-05-31 208 int shrinker_debugfs_rename(struct shrinker *shrinker, const char *fmt, ...) e33c267ab70de4 Roman Gushchin 2022-05-31 209 { e33c267ab70de4 Roman Gushchin 2022-05-31 210 struct dentry *entry; e33c267ab70de4 Roman Gushchin 2022-05-31 211 char buf[128]; e33c267ab70de4 Roman Gushchin 2022-05-31 212 const char *new, *old; e33c267ab70de4 Roman Gushchin 2022-05-31 213 va_list ap; e33c267ab70de4 Roman Gushchin 2022-05-31 214 int ret = 0; e33c267ab70de4 Roman Gushchin 2022-05-31 215 e33c267ab70de4 Roman Gushchin 2022-05-31 216 va_start(ap, fmt); e33c267ab70de4 Roman Gushchin 2022-05-31 217 new = kvasprintf_const(GFP_KERNEL, fmt, ap); e33c267ab70de4 Roman Gushchin 2022-05-31 218 va_end(ap); e33c267ab70de4 Roman Gushchin 2022-05-31 219 e33c267ab70de4 Roman Gushchin 2022-05-31 220 if (!new) e33c267ab70de4 Roman Gushchin 2022-05-31 221 return -ENOMEM; e33c267ab70de4 Roman Gushchin 2022-05-31 222 47a7c01c3efc65 Qi Zheng 2023-06-09 223 down_write(&shrinker_rwsem); e33c267ab70de4 Roman Gushchin 2022-05-31 224 e33c267ab70de4 Roman Gushchin 2022-05-31 225 old = shrinker->name; e33c267ab70de4 Roman Gushchin 2022-05-31 226 shrinker->name = new; e33c267ab70de4 Roman Gushchin 2022-05-31 227 e33c267ab70de4 Roman Gushchin 2022-05-31 228 if (shrinker->debugfs_entry) { e33c267ab70de4 Roman Gushchin 2022-05-31 229 snprintf(buf, sizeof(buf), "%s-%d", shrinker->name, e33c267ab70de4 Roman Gushchin 2022-05-31 230 shrinker->debugfs_id); e33c267ab70de4 Roman Gushchin 2022-05-31 231 e33c267ab70de4 Roman Gushchin 2022-05-31 232 entry = debugfs_rename(shrinker_debugfs_root, e33c267ab70de4 Roman Gushchin 2022-05-31 233 shrinker->debugfs_entry, e33c267ab70de4 Roman Gushchin 2022-05-31 234 shrinker_debugfs_root, buf); e33c267ab70de4 Roman Gushchin 2022-05-31 235 if (IS_ERR(entry)) e33c267ab70de4 Roman Gushchin 2022-05-31 236 ret = PTR_ERR(entry); e33c267ab70de4 Roman Gushchin 2022-05-31 237 else e33c267ab70de4 Roman Gushchin 2022-05-31 238 shrinker->debugfs_entry = entry; e33c267ab70de4 Roman Gushchin 2022-05-31 239 } e33c267ab70de4 Roman Gushchin 2022-05-31 240 47a7c01c3efc65 Qi Zheng 2023-06-09 241 up_write(&shrinker_rwsem); e33c267ab70de4 Roman Gushchin 2022-05-31 242 e33c267ab70de4 Roman Gushchin 2022-05-31 243 kfree_const(old); e33c267ab70de4 Roman Gushchin 2022-05-31 244 e33c267ab70de4 Roman Gushchin 2022-05-31 245 return ret; e33c267ab70de4 Roman Gushchin 2022-05-31 246 } e33c267ab70de4 Roman Gushchin 2022-05-31 247 EXPORT_SYMBOL(shrinker_debugfs_rename); e33c267ab70de4 Roman Gushchin 2022-05-31 248 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 @249 struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 250 int *debugfs_id) 5035ebc644aec9 Roman Gushchin 2022-05-31 251 { badc28d4924bfe Qi Zheng 2023-02-02 252 struct dentry *entry = shrinker->debugfs_entry; badc28d4924bfe Qi Zheng 2023-02-02 253 47a7c01c3efc65 Qi Zheng 2023-06-09 254 lockdep_assert_held(&shrinker_rwsem); 5035ebc644aec9 Roman Gushchin 2022-05-31 255 e33c267ab70de4 Roman Gushchin 2022-05-31 256 kfree_const(shrinker->name); 14773bfa70e67f Tetsuo Handa 2022-07-20 257 shrinker->name = NULL; e33c267ab70de4 Roman Gushchin 2022-05-31 258 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 259 *debugfs_id = entry ? shrinker->debugfs_id : -1; badc28d4924bfe Qi Zheng 2023-02-02 260 shrinker->debugfs_entry = NULL; badc28d4924bfe Qi Zheng 2023-02-02 261 badc28d4924bfe Qi Zheng 2023-02-02 262 return entry; 5035ebc644aec9 Roman Gushchin 2022-05-31 263 } 5035ebc644aec9 Roman Gushchin 2022-05-31 264 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 @265 void shrinker_debugfs_remove(struct dentry *debugfs_entry, int debugfs_id) 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 266 { 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 267 debugfs_remove_recursive(debugfs_entry); 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 268 ida_free(&shrinker_debugfs_ida, debugfs_id); 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 269 } 26e239b37ebdfd Joan Bruguera Micó 2023-05-03 270 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki