From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC6FC0015E for ; Tue, 15 Aug 2023 15:56:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E55E94001F; Tue, 15 Aug 2023 11:56:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36E8B8D0001; Tue, 15 Aug 2023 11:56:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20F4694001F; Tue, 15 Aug 2023 11:56:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0EB9E8D0001 for ; Tue, 15 Aug 2023 11:56:34 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D5D54402BE for ; Tue, 15 Aug 2023 15:56:33 +0000 (UTC) X-FDA: 81126791466.18.A27D5B0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf13.hostedemail.com (Postfix) with ESMTP id 2592D2000F for ; Tue, 15 Aug 2023 15:56:31 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of andre.przywara@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=andre.przywara@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1692114992; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YlNSoMP2FgHmsuhuEnPfHxeLnh4batQSjqhc3RkeaO4=; b=WQprD0fH/PCluWe6onVgJUlD+jbp/3/7f7oHVJHRsHxxFEQnv3+0HGKZjbh2qFtbaOUqWl mALO5YhEafxl4pIaoDBPg4JzKbfUNoXI9FlDZd+09upMWT0tZ26pZKI2EAdHyL2W4chlOG sSYBfqTpcpvsAvTrDaiArhuPfQnOQKM= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf13.hostedemail.com: domain of andre.przywara@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=andre.przywara@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1692114992; a=rsa-sha256; cv=none; b=Tw/H35BXt5vPLhGQMxJQ9HFfGS3df9J5DVBp/XSteJXOVnE7tDNh0fXeGZJ4627N76Vvbk QRMLhkjzmWL7c9vYdN6ldv2aAGZJBy/rqL8qubE+9OPfITKRQskyPmLvrVT9j29s3rscdQ da9TahuN8ReNntX6pT1+O7x8ViPw1is= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A37C11FB; Tue, 15 Aug 2023 08:57:13 -0700 (PDT) Received: from donnerap.arm.com (donnerap.manchester.arm.com [10.32.100.58]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0B2773F6C4; Tue, 15 Aug 2023 08:56:29 -0700 (PDT) From: Andre Przywara To: Shuah Khan , Nhat Pham , Johannes Weiner Cc: linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] selftests: cachestat: properly link in librt Date: Tue, 15 Aug 2023 16:56:10 +0100 Message-Id: <20230815155612.2535947-2-andre.przywara@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230815155612.2535947-1-andre.przywara@arm.com> References: <20230815155612.2535947-1-andre.przywara@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 2592D2000F X-Stat-Signature: nfe6trbppbq4mtn4gr7fqnzpp7c5gong X-Rspam-User: X-HE-Tag: 1692114991-913463 X-HE-Meta: U2FsdGVkX1+7DdLkiTBZX23YdzDXSRFdLJS8swTvEd/iHpgr3bPxC1QdIoD/2wp3A/5H/cVvY1QJhv2cc+8FiBTvI6qLcgBrL2XcYWvcHvMtG+0NCF+qRs4sxFgpqYtRVrnzbrdIjCqi8PpHUqhVpvBJrYagxVngixz7Q0uStRkSMHRNF7D3eHvpX+Lca519jFLusekrbJr5x9ocGs5TruPn49x+EYwBExpCwZFbTG4xaDJw3U7IKaZNad+k/XQvfgbsJGJTIftT33feNs4FnSPdM6fpKtj4S3QEvDHBvJ0/gz84V+KlYHQioJHC82xszViQ5K8Ldxj2QOGruqREqz8sAF19z7RRXcnjgKR1qrmZjruhYTjdP0X+tg/D+WkGd6QECYnYTMhApaLBgEhsVYBGfJxo4435uN4ABn7rKF758PiplUeqfDjXKb47YSoDLFj+bKGGHatW/O8RybKyMNK1vKUZY5H7gsiWueXzYIMhm8ekNdXoFd13tO1PcHbw4OVWl0+IsyvrlWbZApKkeHOSJELxPMdgkyyMLFcybo2hjMDkydYfcr96JKdMtpZi9Xfxionr6KYIX1kRSo2H9u2A+FQEMg91UMKQr0h/qtaMkaeDFMpNG1SFYACoNUeeo/ihn8n+DV1h0bIKs6QhdtbeUynbheseFMqoGFAVfMRvUeKWWB1kCHt9EtibppunAiuG0hYDkn8byG/v69so4hYZKJzPj9V8f4tsndKEjyJVMoU5fkHOBtyMSoIT1eWlooVqHeoKniPlcocY8/WLhYRlpzIxpunupbDcocmYW0IDnq0J3mSk6MHOUWlFcDtz9NbQmaiMzWMSn2YMfQtUe0CGBme37ucSLL3zisX3FaUYipQITMx7FKSmD4rtKn0hmBHVfiwgyr95GVUcz1+TkAW8fQUquE/tAnfQQ5b/qV7B2YWQygTcHwIZJb8O8K02MSQASTz33s7pD/8M/3t hE2kj9kR pwlvdWUF17z9AZzo797WxiqFzEPG082kKUkRC4u1ymfUBwZtJhcOKr3seiFPchGu5souRWUPYkK7DCNe4/K2Nw3052lRRSuIzkPPF+i1Y5qNRgz5bFrveV91M/vr+jAKOaR2LJXlLqqQ1Tr22vdzMH8HjVQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Libraries should be listed last on the compiler's command line, so that the linker can look for and find still unresolved symbols. The librt library, required for the shm_* functions, was announced using CFLAGS, which puts the library *before* the source files, and fails compilation on my system: ====================== gcc -isystem /src/linux-selftests/usr/include -Wall -lrt test_cachestat.c -o /src/linux-selftests/kselftest/cachestat/test_cachestat /usr/bin/ld: /tmp/cceQWO3u.o: in function `test_cachestat_shmem': test_cachestat.c:(.text+0x890): undefined reference to `shm_open' /usr/bin/ld: test_cachestat.c:(.text+0x99c): undefined reference to `shm_unlink' collect2: error: ld returned 1 exit status make[4]: *** [../lib.mk:181: /src/linux-selftests/kselftest/cachestat/test_cachestat] Error 1 ====================== Announce the library using the LDLIBS variable, which ensures the proper ordering on the command line. Signed-off-by: Andre Przywara --- tools/testing/selftests/cachestat/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/cachestat/Makefile b/tools/testing/selftests/cachestat/Makefile index fca73aaa7d141..778b54ebb0364 100644 --- a/tools/testing/selftests/cachestat/Makefile +++ b/tools/testing/selftests/cachestat/Makefile @@ -3,6 +3,6 @@ TEST_GEN_PROGS := test_cachestat CFLAGS += $(KHDR_INCLUDES) CFLAGS += -Wall -CFLAGS += -lrt +LDLIBS += -lrt include ../lib.mk -- 2.25.1